IRC Archive for channel #xwiki on 13 June 2008

xwikibot - (13/06/2008 13:40): Community.CodeStyle was modified by xwiki:XWiki.ThomasMortagne - http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle
sdumitriu - (13/06/2008 14:22): news
xwikibot - (13/06/2008 14:22): Last 5 pages modified:
xwikibot - (13/06/2008 14:22):   * IRC.xwikiArchive20080613 - http://dev.xwiki.org/xwiki/bin/view/IRC/xwikiArchive20080613, by XWiki.XWikiGuest
xwikibot - (13/06/2008 14:22):   * Community.CodeStyle - http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle, by xwiki:XWiki.ThomasMortagne
xwikibot - (13/06/2008 14:22):   * IRC.xwikiArchive20080612 - http://dev.xwiki.org/xwiki/bin/view/IRC/xwikiArchive20080612, by XWiki.XWikiGuest
xwikibot - (13/06/2008 14:22):   * XWiki.poora - http://www.xwiki.org/xwiki/bin/view/XWiki/poora, by XWiki.poora (Created user)
xwikibot - (13/06/2008 14:22):   * XWiki.JacobMiller - http://www.xwiki.org/xwiki/bin/view/XWiki/JacobMiller, by XWiki.JacobMiller (Created user)
sdumitriu - (13/06/2008 14:22): news
xwikibot - (13/06/2008 14:22): Last 5 pages modified:
xwikibot - (13/06/2008 14:22):   * IRC.xwikiArchive20080613 - http://dev.xwiki.org/xwiki/bin/view/IRC/xwikiArchive20080613, by XWiki.XWikiGuest
xwikibot - (13/06/2008 14:22):   * Community.CodeStyle - http://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle, by xwiki:XWiki.ThomasMortagne
xwikibot - (13/06/2008 14:22):   * IRC.xwikiArchive20080612 - http://dev.xwiki.org/xwiki/bin/view/IRC/xwikiArchive20080612, by XWiki.XWikiGuest
xwikibot - (13/06/2008 14:22):   * XWiki.poora - http://www.xwiki.org/xwiki/bin/view/XWiki/poora, by XWiki.poora (Created user)
xwikibot - (13/06/2008 14:22):   * XWiki.JacobMiller - http://www.xwiki.org/xwiki/bin/view/XWiki/JacobMiller, by XWiki.JacobMiller (Created user)
xwikibot - (13/06/2008 14:53): Design.ImproveWikiAdministration was modified by xwiki:XWiki.jvdrean (Put layout drafts as attachments) - http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministration
xwikibot - (13/06/2008 14:54): Design.ImproveWikiAdministration was modified by xwiki:XWiki.jvdrean (Fixed typos) - http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministration
vmassol_ - (13/06/2008 15:45): guys we don't have any core plugins located in xwiki-platform-plugins right now?
sdumitriu - (13/06/2008 15:45): I don't agree with the notion of "core plugins"
vmassol_ - (13/06/2008 15:46): yes I don't agree either
vmassol_ - (13/06/2008 15:46): they're not plugins
vmassol_ - (13/06/2008 15:46): they're core components
vmassol_ - (13/06/2008 15:46): but
vmassol_ - (13/06/2008 15:46): so solution is:
vmassol_ - (13/06/2008 15:47): 1) move code into a package in xwiki-core/ (and later create a component proper in a different module)
vmassol_ - (13/06/2008 15:47): 2) keep the mailsender plugin but make it use the code from xwiki-core/ (and later from the component proper)
vmassol_ - (13/06/2008 15:47): ok?
sdumitriu - (13/06/2008 15:48): Yes
sdumitriu - (13/06/2008 15:48): I just sent some emails regarding this
vmassol_ - (13/06/2008 16:43): jvdrean: did you just break all xwiki translations? :)
vmassol_ - (13/06/2008 16:43): (except French and English)
jvdrean - (13/06/2008 17:06): yes but I'm about to migrate the other translations as well
jvdrean - (13/06/2008 17:07): vmassol : sales are asking for this features for ages
vmassol_ - (13/06/2008 17:07): jvdrean: I agree about that
vmassol_ - (13/06/2008 17:08): it's not just sales
vmassol_ - (13/06/2008 17:08): but lots of users too
vmassol_ - (13/06/2008 17:08): I was just worried about the other translations 
vmassol_ - (13/06/2008 17:08): and about the missing tests too
jvdrean - (13/06/2008 17:08): yep I've seen the email
jvdrean - (13/06/2008 17:09): you're right to ping me about tests, I was not going to write some for this
vmassol_ - (13/06/2008 17:09): since you didn't mention that you were working on it in your commit mail or in jira I thought I would make sure.... ;)
vmassol_ - (13/06/2008 17:09): hehe
vmassol_ - (13/06/2008 17:09): so good I did it ;)
jvdrean - (13/06/2008 17:09): since the real addition stands in one condition in one velocity if
vmassol_ - (13/06/2008 17:10): it's quite easy
vmassol_ - (13/06/2008 17:10): and we already have tests for this
vmassol_ - (13/06/2008 17:10): I mean for user mgmt
vmassol_ - (13/06/2008 17:16): cool found bugs in our seleinum tests, fixing them now
vmassol_ - (13/06/2008 17:18): this was a bit vicious
vmassol_ - (13/06/2008 17:18): we didn't notice them before because we were starting a new browser for every single test
vmassol_ - (13/06/2008 17:24): quite a few other errors to fix...
vmassol_ - (13/06/2008 17:24): like someone set getSelenium().setSpeed("1000"); but never reset it back
vmassol_ - (13/06/2008 17:25): so all tests after are all very very very slow
sdumitriu - (13/06/2008 17:30): We should remove all setSpeed calls
sdumitriu - (13/06/2008 17:30): And replace with proper condition wait
vmassol_ - (13/06/2008 17:34): yep definitely
vmassol_ - (13/06/2008 17:35): I'm trying that now
vmassol_ - (13/06/2008 17:35): that's not the only problems, lots of others tests failing for soe other reasons
vmassol_ - (13/06/2008 17:35): anyway doing them one by one, it's long
sdumitriu - (13/06/2008 17:38): vmassol_: When can I rename testEmptyDocumentContentIsAllowed? If I do that, will you need to merge things?
vmassol_ - (13/06/2008 17:38): go for it
sdumitriu - (13/06/2008 17:38): (I'm catching op un yesterday's mails)
vmassol_ - (13/06/2008 17:38): (sdumitriu )
vmassol_ - (13/06/2008 17:39): sdumitriu: one question for you
vmassol_ - (13/06/2008 17:39): on the RMUI
vmassol_ - (13/06/2008 17:39): if I click on a rights box
vmassol_ - (13/06/2008 17:40): I don't have to wait before I navigate away do I?
vmassol_ - (13/06/2008 17:40): right new there's a setSpeed for this
vmassol_ - (13/06/2008 17:40): s/new/now
sdumitriu - (13/06/2008 17:41): No, you don't
sdumitriu - (13/06/2008 17:42): But you should wait to ensure that the platform had time to make the change
sdumitriu - (13/06/2008 17:42): Otherwise you could make a new request before the rights have been updated
vmassol_ - (13/06/2008 17:43): ok anyway I saw that there's no verification that it has been done
jvdrean - (13/06/2008 18:10): vmassol_: sdumitriu : to test the "admin has a nice UI to edit user passwords" issue I have to edit the profile of another user, is it a bad practice to use a user created during the RegisterTest#testRegisterJohnSmith() ?
sdumitriu - (13/06/2008 18:11): Yes...
vmassol_ - (13/06/2008 18:11): jvdrean: yes we should avoid that as much as possible 
sdumitriu - (13/06/2008 18:11): You depend on an execution order
vmassol_ - (13/06/2008 18:11): sdumitriu: which isn't bad for functional tests
vmassol_ - (13/06/2008 18:11): but better not to tie this constraint if we can do without
vmassol_ - (13/06/2008 18:13): hmmm
vmassol_ - (13/06/2008 18:13): the other option
vmassol_ - (13/06/2008 18:13): is to have a global set up
vmassol_ - (13/06/2008 18:14): in which we create a few things we need globally for all tests that want to use them
vmassol_ - (13/06/2008 18:14): but I don't think we need this at this stage
vmassol_ - (13/06/2008 18:14): your use case will slow down our tests by 3-4 seconds more
vmassol_ - (13/06/2008 18:14): but I feel this is acceptable for now
vmassol_ - (13/06/2008 18:15): wdyt?
sdumitriu - (13/06/2008 18:15): You can just enter the right URL
sdumitriu - (13/06/2008 18:16): open("/bin/objectadd/XWiki/TestUser?classname=XWiki.XWikiUser&XWiki.XWikiUser_password=pass")
sdumitriu - (13/06/2008 18:16): Or something like that
sdumitriu - (13/06/2008 18:18): You don't need to actually go through the UI and fill in all the fields
sdumitriu - (13/06/2008 18:22): (the actual classname is XWiki.XWikiUsers)
jvdrean - (13/06/2008 18:24): I'll use the URL way since RegisterTest are not even listed in AllTests
vmassol_ - (13/06/2008 18:27): jvdrean: looks like a bug
vmassol_ - (13/06/2008 18:27): I'll add it
vmassol_ - (13/06/2008 18:27): thanks
jvdrean - (13/06/2008 18:27): I'm looking at the history to see if this has been commented
jvdrean - (13/06/2008 18:27): (the removal)
jvdrean - (13/06/2008 18:29): UsersGroupsRightsManagementTest test user creation too
sdumitriu - (13/06/2008 18:29): Probably someone forgot to register them
vmassol_ - (13/06/2008 18:30): yes I don't like that we have 2 different UIs for registering users
vmassol_ - (13/06/2008 18:46): sdumitriu: to nitpick, it would be better to use a private static final String DEFAULT_HOME_PAGE rather than override a member field
sdumitriu - (13/06/2008 18:47): Why?
sdumitriu - (13/06/2008 18:47): I thought of that, but don't see an advantage
sdumitriu - (13/06/2008 18:47): Oh, wait
sdumitriu - (13/06/2008 18:47): I just saw one :p
vmassol_ - (13/06/2008 18:47): :)
sdumitriu - (13/06/2008 18:52): I gotta go now
sdumitriu - (13/06/2008 18:52): Bye