IRC Archive for channel #xwiki on 20 June 2008

sdumitriu - (20/06/2008 21:40): vmassol: Ping
vmassol - (20/06/2008 21:52): sdumitriu: give me 5 minutes, putting the kids to bed
sdumitriu - (20/06/2008 21:52): K
vmassol - (20/06/2008 22:01): sdumitriu: back
sdumitriu - (20/06/2008 22:01): I can't build trunks
sdumitriu - (20/06/2008 22:01): Do you know anything about this?
vmassol - (20/06/2008 22:02): nope haven't tried building today
vmassol - (20/06/2008 22:02): I can try
vmassol - (20/06/2008 22:07): sdumitriu: re testDataIsPreservedAfterLogin
vmassol - (20/06/2008 22:07): I don't understand the last assert about "Welcome to your wiki"
sdumitriu - (20/06/2008 22:07): Tests that the parent was saved, too
sdumitriu - (20/06/2008 22:07): Not so sure it is a good assertion
vmassol - (20/06/2008 22:08): btw for the part under +        // Preserve the initial state
vmassol - (20/06/2008 22:08): maybe you need a try finally block
vmassol - (20/06/2008 22:08): or nothing at all
vmassol - (20/06/2008 22:09): which is probably better since each test should set its own working conditions
vmassol - (20/06/2008 22:09): I prefer the strategy of not resetting state at the end but instead each test should verify the state is good for the test
vmassol - (20/06/2008 22:09): wdyt?
sdumitriu - (20/06/2008 22:10): Yep
vmassol - (20/06/2008 22:10): also instead of  getSelenium().waitForCondition you should use waitForCondition()
vmassol - (20/06/2008 22:11): I haven't reviewed the new filter you've added... too much code for me to review ;)
vmassol - (20/06/2008 22:11): sounds good though
sdumitriu - (20/06/2008 22:43): vmassol: Did you manage to build?
vmassol - (20/06/2008 22:43): thanks for reminding me... I had just svned up... started the build now
vmassol - (20/06/2008 22:52): sdumitriu: fails here too
vmassol - (20/06/2008 22:52): ah waut
vmassol - (20/06/2008 22:52): that's because of some local changes I have
vmassol - (20/06/2008 22:52): let me fix them
vmassol - (20/06/2008 22:56): sdumitriu: now I get lots of failing tests in core
vmassol - (20/06/2008 22:57): is that what you have too?
sdumitriu - (20/06/2008 22:57): Yes
vmassol - (20/06/2008 22:57): rebuiling tools to see if it helps
vmassol - (20/06/2008 22:57): since I remember thomas moved stuff there 
vmassol - (20/06/2008 22:58): and maybe C didn't build it today
vmassol - (20/06/2008 22:58): yes C seems to have lots and lots of problems
vmassol - (20/06/2008 22:58): Raff was on it but apparently he hasn't found a fix
sdumitriu - (20/06/2008 22:59): Yes, rebuilding tools seems to fixed part of the problem
sdumitriu - (20/06/2008 22:59): (just did that here, too)
sdumitriu - (20/06/2008 22:59): But now I get a test failure in Rendering - Integration Tests
sdumitriu - (20/06/2008 22:59): testGetAvailableSyntaxes
vmassol - (20/06/2008 23:00): ah that would be me, let me verify that
vmassol - (20/06/2008 23:00): right my gault
vmassol - (20/06/2008 23:00): fixing that now
vmassol - (20/06/2008 23:02): ah no that's something thomas did too
vmassol - (20/06/2008 23:02): I need to understand what he did
vmassol - (20/06/2008 23:05): actually not it's my fault... got a strange error in the ide
vmassol - (20/06/2008 23:05): fixed
vmassol - (20/06/2008 23:05): sdumitriu: fixed
vmassol - (20/06/2008 23:05): sorry about taht