IRC Archive for channel #xwiki on 27 August 2008

art - (27/08/2008 00:00): thats great thanks, will look further
cypromis - (27/08/2008 00:05): hmm I should mail that to devel I guess
vmassol - (27/08/2008 00:05): yep (whatever "that" is :))
xwikibot - (27/08/2008 05:44): XWiki.perumal_9884166233 was modified by XWiki.perumal_9884166233 (Created user) - http://www.xwiki.org/xwiki/bin/view/XWiki/perumal_9884166233
xwikibot - (27/08/2008 09:14): XWiki.selvakarthik was modified by XWiki.selvakarthik (Created user) - http://www.xwiki.org/xwiki/bin/view/XWiki/selvakarthik
xwikibot - (27/08/2008 11:35): XWiki.XWikiServerCode was modified by XWiki.jvdrean (Added object) - http://www.xwiki.org/xwiki/bin/view/XWiki/XWikiServerCode
xwikibot - (27/08/2008 11:35): XWiki.XWikiServerCode was modified by XWiki.jvdrean - http://www.xwiki.org/xwiki/bin/view/XWiki/XWikiServerCode
xwikibot - (27/08/2008 11:35): XWiki.XWikiServerCode was modified by XWiki.jvdrean - http://www.xwiki.org/xwiki/bin/view/XWiki/XWikiServerCode
gpaul44 - (27/08/2008 13:45): vmassol: there are some Test classes that doesn
gpaul44 - (27/08/2008 13:46): vmassol: doesn't have setUp
gpaul44 - (27/08/2008 13:46): but in rest the api is up to date
gpaul44 - (27/08/2008 13:46): do I add that ?
vmassol - (27/08/2008 13:46): hi gpaul44 
vmassol - (27/08/2008 13:46): not sure what you mean
gpaul44 - (27/08/2008 13:46): there is a method called setUp()
gpaul44 - (27/08/2008 13:46): in most of the Test classes
sdumitriu - (27/08/2008 13:46): gpaul44: It's not mandatory to have that method
vmassol - (27/08/2008 13:47): yes I know that.. hehe... you should read JUnit in Action ;)
gpaul44 - (27/08/2008 13:47):     @Override
gpaul44 - (27/08/2008 13:47):     protected void setUp() throws Exception
gpaul44 - (27/08/2008 13:47):     {
gpaul44 - (27/08/2008 13:47):         super.setUp();
gpaul44 - (27/08/2008 13:47):         loginAsAdmin();
gpaul44 - (27/08/2008 13:47):     }
gpaul44 - (27/08/2008 13:47): the think is that there are some test classes
gpaul44 - (27/08/2008 13:47): that don't have it
vmassol - (27/08/2008 13:47): gpaul44: do you have an example for what you call "missing"?
vmassol - (27/08/2008 13:47): yes but the question is: should they have it?
gpaul44 - (27/08/2008 13:47): public class WatchListTest extends AbstractXWikiTestCase
gpaul44 - (27/08/2008 13:47): {
gpaul44 - (27/08/2008 13:47):     public static Test suite()
gpaul44 - (27/08/2008 13:47):     {
gpaul44 - (27/08/2008 13:47):         XWikiTestSuite suite = new XWikiTestSuite("Verify the watchlist feature of XWiki");
gpaul44 - (27/08/2008 13:47):         suite.addTestSuite(WatchListTest.class, AlbatrossSkinExecutor.class);
gpaul44 - (27/08/2008 13:47):         return suite;
vmassol - (27/08/2008 13:47): and I'll need to see an example
gpaul44 - (27/08/2008 13:47):     }
gpaul44 - (27/08/2008 13:47):     protected void tearDown()
gpaul44 - (27/08/2008 13:47):     {
gpaul44 - (27/08/2008 13:47):         // Restore XWiki.WatchListManager from the trash since it's been deleted by the tests below.
gpaul44 - (27/08/2008 13:47):         open("XWiki", "WatchListManager");
gpaul44 - (27/08/2008 13:47):         if (isElementPresent("link=Restore")) {
gpaul44 - (27/08/2008 13:48):             clickLinkWithLocator("link=Restore");
gpaul44 - (27/08/2008 13:48):             assertTextPresent("Watchlist for Administrator");
gpaul44 - (27/08/2008 13:48):         }
gpaul44 - (27/08/2008 13:48):     }
vmassol - (27/08/2008 13:48): gpaul44: please don't paste in irc
gpaul44 - (27/08/2008 13:48): for example
gpaul44 - (27/08/2008 13:48): that was the question: should I add it ?
vmassol - (27/08/2008 13:48): gpaul44: sorry you're not clear
sdumitriu - (27/08/2008 13:48): If the test works, no
gpaul44 - (27/08/2008 13:48): oh...ok
sdumitriu - (27/08/2008 13:48): setUp is something you can use if you need initialize stuff
vmassol - (27/08/2008 13:48): is it because there's no loginAsAdmin?
vmassol - (27/08/2008 13:49): (that you want to add a setup)
sdumitriu - (27/08/2008 13:49): If the test suite doesn't need to do anything, then you don't need to override setUp
gpaul44 - (27/08/2008 13:49): ok...
vmassol - (27/08/2008 13:49): gpaul44: to make it clear let us know what you want to do in the setup?
vmassol - (27/08/2008 13:50): s/?//
vmassol - (27/08/2008 13:50): does the test require to be logged as admin for it to work? Is that your point?
gpaul44 - (27/08/2008 13:52): the think is this: for example: DocExtraTest doesn't have the setUp() method, they do loginAsAdmin(), but in the first test, they wokr, but this is creating a dependency between them
gpaul44 - (27/08/2008 13:53): what if the first test isn't executed as the first one
gpaul44 - (27/08/2008 13:53): for such classes to override the setUp(), and call loginAsAdmin() in setUp() instead
vmassol - (27/08/2008 13:54): let me check DocExtraTest
vmassol - (27/08/2008 13:55): gpaul44: I would put the question differently. Is the loginAsAdmin() required for the tests in DocExtraTest?
vmassol - (27/08/2008 13:56): hmm by default the wiki requires for a user to be logged in I think
vmassol - (27/08/2008 13:56): so the answer is yes although it doesn't have to be the admin user
gpaul44 - (27/08/2008 13:57): ok
vmassol - (27/08/2008 13:58): so yes you're right I think
vmassol - (27/08/2008 13:58): for DocExtraTest
gpaul44 - (27/08/2008 13:59): ok
vmassol - (27/08/2008 13:59): would be nice to imprvoe the test frameowkr by offerinf a loginAsNormalUser() in addition to the loginAsAdmin()
vmassol - (27/08/2008 13:59): and refactor the tests to use loginAsNormalUser() when no admin rights should be required
gpaul44 - (27/08/2008 13:59): that would request improving it by adding createNormalUseR()
vmassol - (27/08/2008 14:03): gpaul44: it would be created under the hood automatically
vmassol - (27/08/2008 14:03): but yes
vmassol - (27/08/2008 14:04): we'd need some checks as for loginAsAdmin() for good performance (and not recreate user and relogin every time)
vmassol - (27/08/2008 14:05): we could also create some wrapping Test suites for automatically logging in the user as admin or as a normal user but that requires a bit more knowledge of junit so we can do this later on
gpaul44 - (27/08/2008 14:06): vmassol:loginAsAdmin() doesn't log in every time, it does first check if the admin is already logged in, if it isn;t logged in, then will login
vmassol - (27/08/2008 14:07): I know I wrote it and that's what I was saying
vmassol - (27/08/2008 14:07): :)
vmassol - (27/08/2008 14:07): re the wrapping test suite this is what I meant: http://rafb.net/p/6Tq5kR99.html
gpaul44 - (27/08/2008 14:07): is there a guest user by default for xwiki enterprise: I could use it
gpaul44 - (27/08/2008 14:07): ?
vmassol - (27/08/2008 14:08): no
vmassol - (27/08/2008 14:08): there isn't
vmassol - (27/08/2008 14:08): well there is but it's not a user
gpaul44 - (27/08/2008 14:08): oh...ok
vmassol - (27/08/2008 14:08): it's when you're not logged in
daning - (27/08/2008 14:08): vmassol: When I use mvn eclipse:eclipse to build a project for eclipse for xwiki-rendering, got a error "can't get xwiki-core-bridge". Any suggestion?
vmassol - (27/08/2008 14:08): daning: yes, ask sergiu :) or use m2eclipse
vmassol - (27/08/2008 14:09): more seriously
vmassol - (27/08/2008 14:09): I think you didn't build it
vmassol - (27/08/2008 14:09): did you?
daning - (27/08/2008 14:09): vmassol:  I use mvn install . same error.
vmassol - (27/08/2008 14:10): daning: did you build  xwiki-core-bridge?
daning - (27/08/2008 14:10): vmassol: no.
vmassol - (27/08/2008 14:10): then build it :)
vmassol - (27/08/2008 14:10): it'll work
daning - (27/08/2008 14:10): vmassol: OK.
vmassol - (27/08/2008 14:10): hudson is probably not building it for some reason
jvdrean - (27/08/2008 14:14): about problems with xwik-core-bridge, hudson is supposed to discover core modules from core-parent
jvdrean - (27/08/2008 14:15): but it seems that hudson is not able to svn co since this morning
jvdrean - (27/08/2008 14:15): ERROR: svn: timed out waiting for server
vmassol - (27/08/2008 14:16): jvdrean: ok that explains it. You're working on fixing it right?
jvdrean - (27/08/2008 14:17): vmassol: looks like a network problem, I'm not able to ping svn.xwiki.org from maven.xwiki.org
daning - (27/08/2008 14:32): vmassol: Where can I see the xwiki syntax 2.0 specification?
vmassol - (27/08/2008 14:32): daning: otp
vmassol - (27/08/2008 14:33): look in dev.xwiki.org, drafts
daning - (27/08/2008 14:49): vmassol: [[label>Space.ExistingPage>_target]] convert to html is <a href="/xwiki/bin/view/Space/ExistingPage" rel="_target">label</a> or
daning - (27/08/2008 14:49): <a href="/xwiki/bin/view/Space/ExistingPage" rel="__target">label</a>
daning - (27/08/2008 14:49): one "_" for target or two "_"?
sdumitriu - (27/08/2008 14:50): Two
sdumitriu - (27/08/2008 14:51): Actually, it depends
sdumitriu - (27/08/2008 14:51): It adds one _ before the text you use as the target
sdumitriu - (27/08/2008 14:52): There are two sometimes because _blank, _top and others are special target names
sdumitriu - (27/08/2008 14:52): But the user can put a target without a trailing _, in which case the generated HTML will have only one _
daning - (27/08/2008 14:53): sdumitriu: got it. Thanks.
jvdrean - (27/08/2008 15:57): mflorea : xwiki-web-wysiwyg build is failing on the CI, see : http://hudson.xwiki.org/job/xwiki-platform-web-trunk/85/com.xpn.xwiki.platform$xwiki-web-wysiwyg/console any idea why ?
mflorea - (27/08/2008 16:00): :| it builds fine on my machine. Maybe this is the problem
mflorea - (27/08/2008 16:00): [WARNING] repository metadata for: 'snapshot com.totsp.gwt:maven-googlewebtoolkit2-plugin:1.5.3-SNAPSHOT' could not be retrieved from repository: gwt-maven due to an error: Error transferring file
mflorea - (27/08/2008 16:01): jvdrean: ping
jvdrean - (27/08/2008 16:03): mflorea: xwiki-web will be rebuilt in a few minutes, we'll see if the error persist
mflorea - (27/08/2008 16:03): ok
gpaul44 - (27/08/2008 16:22): vmassol: a few days ago I've said that I would update the api for the selenium tests...here it is:http://pastebin.com/m1801370c
gpaul44 - (27/08/2008 16:22): vmassol_:a few days ago I've said that I would update the api for the selenium tests...here it is:http://pastebin.com/m1801370c
vmassol_ - (27/08/2008 17:10): sdumitriu: see http://www.icegreen.com/greenmail/ :)
sdumitriu - (27/08/2008 17:10): Cool
vmassol_ - (27/08/2008 17:12): this will make it real easy to use in our Selenium tests
daning - (27/08/2008 18:10): vmassol_: Hi.
vmassol_ - (27/08/2008 18:10): daning: hi
daning - (27/08/2008 18:11): vmassol_: When I use HTMLCleaner, I meet a error.
daning - (27/08/2008 18:11): vmassol_: Can't cast from Text to jdom 's Document
daning - (27/08/2008 18:12): vmassol_: the input is <ul> <ul><li>test</li></ul></ul>.
daning - (27/08/2008 18:12): vmassol_: There is a space between the first two <ul>
vmassol_ - (27/08/2008 18:12): daning: ok I'll try your test input. I need to finish something first. Unless you have a patch already?
vmassol_ - (27/08/2008 18:13): I know the pb
vmassol_ - (27/08/2008 18:13): I think
daning - (27/08/2008 18:13): in the 121 line of ListCleaningFilter.java
vmassol_ - (27/08/2008 18:13): I should check for the cast I'm doin
vmassol_ - (27/08/2008 18:13): doing
vmassol_ - (27/08/2008 18:40): daning: looking into it now
daning - (27/08/2008 18:40): vmassol_: OK.
vmassol_ - (27/08/2008 19:14): daning: fixed, thanks for reporting the issue!
daning - (27/08/2008 19:14): vmassol_: ;)
daning - (27/08/2008 19:14): vmassol_: Have to go to bed.
daning - (27/08/2008 19:14): vmassol_: Bye.
vmassol_ - (27/08/2008 19:17): bye
xwikibot - (27/08/2008 19:27): Design.OfficeConverter was modified by xwiki:XWiki.daning - http://dev.xwiki.org/xwiki/bin/view/Design/OfficeConverter
xwikibot - (27/08/2008 20:26): Main.ReleaseNotes was modified by XWiki.jvdrean - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotes
trifon_ - (27/08/2008 22:07): hi
lucaa - (27/08/2008 22:16): hi