Wiki source code of IRC Archive for channel #xwiki on 20 November 2008
Last modified by Vincent Massol on 2012/10/18 18:30
Show last authors
| author | version | line-number | content |
|---|---|---|---|
| 1 | xwikibot - (20/11/2008 08:49): Design.JcrStore was modified by xwiki:XWiki.amelentev - http://dev.xwiki.org/xwiki/bin/view/Design/JcrStore | ||
| 2 | vmassol - (20/11/2008 09:42): hi everyone | ||
| 3 | vmassol - (20/11/2008 09:44): can someone confirm to me that the try/catch is not needed in this code (XWiki.java around line 1350): http://rafb.net/p/daKk2k46.html | ||
| 4 | vmassol - (20/11/2008 09:44): jvdrean, jvelociter, thomasmortagne : any idea? | ||
| 5 | thomasmortagne - (20/11/2008 09:44): looking | ||
| 6 | vmassol - (20/11/2008 09:45): ok found XWIKI-2091 from sergiu | ||
| 7 | vmassol - (20/11/2008 09:45): checking it | ||
| 8 | vmassol - (20/11/2008 09:46): (svn annotations in eclipse are very nice) | ||
| 9 | thomasmortagne - (20/11/2008 09:46): it should not be necessary even there is a reason for this it looks weird... | ||
| 10 | vmassol - (20/11/2008 09:46): but IMO the setFullName should be improved instead of doing a catch all | ||
| 11 | thomasmortagne - (20/11/2008 09:47): yes | ||
| 12 | jvdrean - (20/11/2008 10:15): vmassol: I don't get why we need to deprecate doc.getRenderedContent(String) since the document is holding is syntaxId | ||
| 13 | vmassol - (20/11/2008 10:17): jvdrean: good question. The reason is that getRenderedContent is not in its right location | ||
| 14 | vmassol - (20/11/2008 10:18): let me look at the code again... | ||
| 15 | vmassol - (20/11/2008 10:19): ah yes I remember now | ||
| 16 | vmassol - (20/11/2008 10:19): here's the reason: | ||
| 17 | asyd - (20/11/2008 10:19): hello there | ||
| 18 | vmassol - (20/11/2008 10:19): we still have getRenderedContent(Context) that is NOT deprecated | ||
| 19 | jvdrean - (20/11/2008 10:19): asyd: hello | ||
| 20 | vmassol - (20/11/2008 10:19): it's going to render the document text using the document syntax | ||
| 21 | vmassol - (20/11/2008 10:20): the pb is that getRenderedContent(text) is not in its right place | ||
| 22 | vmassol - (20/11/2008 10:20): since it renders ANY text | ||
| 23 | jvdrean - (20/11/2008 10:20): oh, right | ||
| 24 | vmassol - (20/11/2008 10:20): it's not related to the document | ||
| 25 | vmassol - (20/11/2008 10:20): so the right thing to do is to move it | ||
| 26 | vmassol - (20/11/2008 10:20): but I was working on something else and didn't take the time to do that... | ||
| 27 | vmassol - (20/11/2008 10:21): (at first it could be moved in XWiki I guess) | ||
| 28 | xwikibot - (20/11/2008 10:33): XWiki.Dudito was modified by XWiki.Dudito (Created user) - http://www.xwiki.org/xwiki/bin/view/XWiki/Dudito | ||
| 29 | amelentev - (20/11/2008 11:15): Hi. Link from http://www.xwiki.org/xwiki/bin/view/Panels/SyntaxHelp is incorrect (left click works (js openHelp()), but middle is not:)). And I don't have rights to fix it. | ||
| 30 | xwikibot - (20/11/2008 11:24): FAQ.HowtorestrictattachmentformatsForexampleonlyimagesformats was modified by XWiki.yo - http://www.xwiki.org/xwiki/bin/view/FAQ/HowtorestrictattachmentformatsForexampleonlyimagesformats | ||
| 31 | xwikibot - (20/11/2008 11:27): XWiki.Elek was modified by XWiki.Elek (Created user) - http://www.xwiki.org/xwiki/bin/view/XWiki/Elek | ||
| 32 | vmassol - (20/11/2008 11:28): amelentev: checking.. | ||
| 33 | vmassol - (20/11/2008 11:29): amelentev: I don't understand what's not working (apart from the styling issue de to xpage=plain)? | ||
| 34 | vmassol - (20/11/2008 11:29): what do you mean by "middle"? | ||
| 35 | vmassol - (20/11/2008 11:30): and what should be done? | ||
| 36 | vmassol - (20/11/2008 11:30): (I'm on a mac so the notion of middle click is strange for me ;)) | ||
| 37 | amelentev - (20/11/2008 11:31): right click -> open in new tab | ||
| 38 | amelentev - (20/11/2008 11:31): a href is incorrect | ||
| 39 | amelentev - (20/11/2008 11:32): some users often middle click for read it later | ||
| 40 | amelentev - (20/11/2008 11:33): status bar show wrong url also | ||
| 41 | amelentev - (20/11/2008 11:34): http://www.xwiki.com/xwiki/bin/view/Doc/XWikiSyntax?xpage=plain | ||
| 42 | lucaa - (20/11/2008 11:38): hi xwikiers gang, hi vmassol. I seem to have a problem with the xhtml parser, look at failing test: http://pastebin.com/m5173eaff | ||
| 43 | vmassol - (20/11/2008 11:38): lucaa: checking | ||
| 44 | lucaa - (20/11/2008 11:39): sorry, wrong wrong test. But it'll fail anyway | ||
| 45 | lucaa - (20/11/2008 11:39): wait | ||
| 46 | lucaa - (20/11/2008 11:40): this is it: http://pastebin.com/m309c94dd , the "right" failing test | ||
| 47 | vmassol - (20/11/2008 11:41): lucaa: what's failing? | ||
| 48 | lucaa - (20/11/2008 11:42): it's outputting a[[b>>Main.WebHome]]c instead of a[[//b//b>>Main.WebHome]]c | ||
| 49 | lucaa - (20/11/2008 11:42): is smth wrong on my side? | ||
| 50 | vmassol - (20/11/2008 11:42): no looks good, can you create a jira for it and I'll work on it? | ||
| 51 | lucaa - (20/11/2008 11:43): sure. | ||
| 52 | lucaa - (20/11/2008 12:07): done, vmassol. You prefer I assign it to you? | ||
| 53 | vmassol - (20/11/2008 12:09): lucaa: I'll do it thanks | ||
| 54 | xwikibot - (20/11/2008 12:37): Main.ReleaseNotes was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotes | ||
| 55 | xwikibot - (20/11/2008 12:38): Main.ReleaseNotes was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotes | ||
| 56 | xwikibot - (20/11/2008 13:12): Design.JcrStore was modified by xwiki:XWiki.amelentev - http://dev.xwiki.org/xwiki/bin/view/Design/JcrStore | ||
| 57 | xwikibot - (20/11/2008 13:24): Main.ReleaseNotesXWikiEnterprise17M3 was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17M3 | ||
| 58 | xwikibot - (20/11/2008 13:28): Main.ReleaseNotesXWikiEnterprise17M3 was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17M3 | ||
| 59 | xwikibot - (20/11/2008 13:28): Main.ReleaseNotesXWikiEnterprise17M3 was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17M3 | ||
| 60 | xwikibot - (20/11/2008 13:29): Main.ReleaseNotesXWikiEnterprise17M3 was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17M3 | ||
| 61 | xwikibot - (20/11/2008 13:30): Main.ReleaseNotesXWikiEnterprise17M3 was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17M3 | ||
| 62 | xwikibot - (20/11/2008 13:30): Main.ReleaseNotesXWikiEnterprise17M3 was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17M3 | ||
| 63 | xwikibot - (20/11/2008 13:30): Main.ReleaseNotesXWikiEnterprise17M3 was modified by XWiki.ThomasMortagne - http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise17M3 | ||
| 64 | vmassol - (20/11/2008 13:39): lucaa: ok I've found the problem. Will commit in a few minutes | ||
| 65 | vmassol - (20/11/2008 13:39): thomasmortagne: can I commit on trunk for RC1? | ||
| 66 | vmassol - (20/11/2008 13:39): (for core) | ||
| 67 | thomasmortagne - (20/11/2008 13:40): no yet I have a problem with core release | ||
| 68 | lucaa - (20/11/2008 13:40): vmassol: cool | ||
| 69 | lucaa - (20/11/2008 13:40): thanks | ||
| 70 | vmassol - (20/11/2008 13:40): thomasmortagne: ok ping me when I can commit | ||
| 71 | thomasmortagne - (20/11/2008 13:40): mvn install work well but release:prepare return me a java.lang.ClassNotFoundException: | ||
| 72 | thomasmortagne - (20/11/2008 13:41): releas:perform a mean | ||
| 73 | thomasmortagne - (20/11/2008 13:55): vmassol: you can commit now | ||
| 74 | vmassol - (20/11/2008 13:56): thomasmortagne: thanks | ||
| 75 | vmassol - (20/11/2008 13:56): however I've a new problem while fixing anca's issue.... | ||
| 76 | vmassol - (20/11/2008 13:56): s/a new/created a new/ | ||
| 77 | vmassol - (20/11/2008 13:56): so I need more time ;) | ||
| 78 | thomasmortagne - (20/11/2008 13:56): :) |
