Wiki source code of IRC Archive for channel #xwiki on 20 February 2012
Last modified by Vincent Massol on 2012/10/18 19:22
Show last authors
| author | version | line-number | content |
|---|---|---|---|
| 1 | 00:16 <SvenDowideit> has quit | ||
| 2 | 00:16 <SvenDowideit> has joined #xwiki | ||
| 3 | 00:29 <jvdrean> has joined #xwiki | ||
| 4 | 00:34 <jvdrean> has quit | ||
| 5 | 00:35 <jvdrean> has joined #xwiki | ||
| 6 | 00:35 <jvdrean> has quit | ||
| 7 | 00:36 <SvenDowideit> has quit | ||
| 8 | 00:41 <SvenDowideit> has joined #xwiki | ||
| 9 | 00:44 <SvenDowideit> has quit | ||
| 10 | 00:45 <SvenDowideit> has joined #xwiki | ||
| 11 | 01:40 <rrodriguez> has quit | ||
| 12 | 02:35 <cjd> has quit | ||
| 13 | 02:38 <Guest83825> has joined #xwiki | ||
| 14 | 02:38 <Guest83825> has quit | ||
| 15 | 03:02 <DrLou> has quit | ||
| 16 | 03:19 <cjd> has joined #xwiki | ||
| 17 | 04:10 <cjd> has quit | ||
| 18 | 04:48 <npm> has quit | ||
| 19 | 04:48 <npm> has joined #xwiki | ||
| 20 | 04:52 <DrLou> has joined #xwiki | ||
| 21 | 04:53 <DrLou> has quit | ||
| 22 | 05:39 <cjd> has joined #xwiki | ||
| 23 | 05:58 <Denis> has quit | ||
| 24 | 05:58 <Denis> has joined #xwiki | ||
| 25 | 07:21 <rrodriguez> has joined #xwiki | ||
| 26 | 07:42 <mflorea> has joined #xwiki | ||
| 27 | 08:10 <vmassol> has joined #xwiki | ||
| 28 | 08:45 <rrodriguez> has quit | ||
| 29 | 08:53 <sburjan`> has quit | ||
| 30 | 08:53 <sburjan`> has joined #xwiki | ||
| 31 | 09:20 <tmortagne> has joined #xwiki | ||
| 32 | 09:41 <sdumitriu> has quit | ||
| 33 | 09:47 <+tmortagne> vmassol: Hi | ||
| 34 | 09:47 <+tmortagne> any idea what could cause http://ci.xwiki.org/job/xwiki-enterprise-test-extension/org.xwiki.enterprise$xwiki-enterprise-test-extension/362/testReport/org.apache.maven.surefire.junit4/JUnit4Provider/org_xwiki_test_ui_AllTests/ this error is new to me | ||
| 35 | 09:47 <+tmortagne> Caused by: java.lang.RuntimeException: Unsupported browser name [] | ||
| 36 | 09:47 <+tmortagne> is browser need to be set somewhere now and has been forgotten here ? | ||
| 37 | 09:57 <vmassol> tmortagne: good morning, checking | ||
| 38 | 10:00 <vmassol> hmm this means that the browsername passed is a white space, need to find out why | ||
| 39 | 10:04 <jvdrean> has joined #xwiki | ||
| 40 | 10:04 <gdelhumeau> has joined #xwiki | ||
| 41 | 10:11 <CIA-120> tmortagne master * r07c42ad https://github.com/xwiki/xwiki-platform/commit/07c42ad5234cd5b4c3fd99672bb169b341f2776f / (9 files in 3 dirs): XWIKI-7549: Install state of an extension located in a subfolder of the ... | ||
| 42 | 10:11 <CIA-120> tmortagne stable-3.5.x * r835401c https://github.com/xwiki/xwiki-platform/commit/835401c5168d1de2a36da1a96ea305970dfbd4be / (9 files in 3 dirs): XWIKI-7549: Install state of an extension located in a subfolder of the ... | ||
| 43 | 10:12 <vmassol> tmortagne: I'm debugging it | ||
| 44 | 10:12 <sburjan> has joined #xwiki | ||
| 45 | 10:13 <+tmortagne> vmassol: ok | ||
| 46 | 10:13 <vmassol> if ${browser} isn't defined I'm not sure what's used, I'm checking that | ||
| 47 | 10:14 <vmassol> my code does: private static final String BROWSER_NAME_SYSTEM_PROPERTY = System.getProperty("browser", "*firefox"); | ||
| 48 | 10:14 <+sburjan> it defaults to FF | ||
| 49 | 10:14 <vmassol> but I think the problem is that the "browser" prop is defined | ||
| 50 | 10:14 <vmassol> sburjan: nope | ||
| 51 | 10:14 <+sburjan> doesn't work defaulting to ff ? | ||
| 52 | 10:14 <vmassol> sburjan: you're confusing what we want to have and what's happening I think :) | ||
| 53 | 10:15 <+sburjan> I never tested if defaulting to FF actually works ;) | ||
| 54 | 10:16 <vmassol> acutally I don't even need to debug, the answer is obvious, it's an empty string or whitespace | ||
| 55 | 10:16 <vmassol> I'll change the code | ||
| 56 | 10:17 <Enygma`> has joined #xwiki | ||
| 57 | 10:18 <vmassol> hmm actually the correct solution is to define the profiles | ||
| 58 | 10:18 <vmassol> I'll do that | ||
| 59 | 10:18 <+sburjan> did we have some problems with this on jenkins ? | ||
| 60 | 10:18 <vmassol> and we need to find a wayt o share those profiles somehow | ||
| 61 | 10:18 <+tmortagne> sburjan: (09:49:54 AM) tmortagne: any idea what could cause http://ci.xwiki.org/job/xwiki-enterprise-test-extension/org.xwiki.enterprise$xwiki-enterprise-test-extension/362/testReport/org.apache.maven.surefire.junit4/JUnit4Provider/org_xwiki_test_ui_AllTests/ this error is new to me | ||
| 62 | 10:19 <+sburjan> ok. didn't saw what you wrote .. I was in the bus | ||
| 63 | 10:20 <CIA-120> Vincent Massol master * r6e1489e https://github.com/xwiki/xwiki-enterprise/commit/6e1489eaf86dbbae6743f1ad8a8368a00522a05b / xwiki-enterprise-test/xwiki-enterprise-test-extension/pom.xml : [Misc] Adding missing profiles which meant the browser system property wasn't defined ... | ||
| 64 | 10:22 <florinciu> has joined #xwiki | ||
| 65 | 10:22 <+sburjan> Rookie question, but how come this profiles are't/can't be inherited for a parent pom ? | ||
| 66 | 10:22 <vmassol> ask google! | ||
| 67 | 10:23 <vmassol> :) | ||
| 68 | 10:23 <vmassol> or better, ask the maven guys | ||
| 69 | 10:23 <+sburjan> afaik we already do inheritance | ||
| 70 | 10:23 <+sburjan> for other stuff | ||
| 71 | 10:23 <vmassol> they probably had a good reason | ||
| 72 | 10:23 <vmassol> actually I think it's even documented | ||
| 73 | 10:23 <florinciu> has quit | ||
| 74 | 10:24 <vmassol> guy today is 3.5 final release day | ||
| 75 | 10:24 <vmassol> s/guy/guys/ | ||
| 76 | 10:24 <florinciu> has joined #xwiki | ||
| 77 | 10:24 <vmassol> mflorea: you're releasing today? | ||
| 78 | 10:25 <florinciu> has left #xwiki | ||
| 79 | 10:25 <+mflorea> vmassol: sure, but there is one blocker XWIKI-7549 | ||
| 80 | 10:25 <vmassol> AFAICS all tests are passing for 3.5, right? | ||
| 81 | 10:25 <+mflorea> yes | ||
| 82 | 10:26 <florinciu> has joined #xwiki | ||
| 83 | 10:27 <vmassol> mflorea: this one has been fixed by thomas | ||
| 84 | 10:27 <vmassol> hope it's been tested enough though.... | ||
| 85 | 10:28 <+sburjan> is he bot stuck ? | ||
| 86 | 10:28 <+sburjan> XWIKI-7549 | ||
| 87 | 10:28 <+mflorea> oh, I don't know why I saw it as open.. anyway, this means we're good. I want to commit some tests to AppWithinMinute that I have locally for some time, and then I'll proceed with the release | ||
| 88 | 10:28 <vmassol> jira.xwiki.org/browse/XWIKI-7549 | ||
| 89 | 10:33 <djdirks> is now known as <joris> | ||
| 90 | 10:35 <+sburjan> yes vmassol, you are right. Profiles are not inherited. Period | ||
| 91 | 10:35 <vmassol> I'm fixing that now | ||
| 92 | 10:36 <+sburjan> curious how ;) | ||
| 93 | 10:45 <+florinciu> Hi | ||
| 94 | 10:45 <+florinciu> Is there a known performance issue with the activity stream on 3.4? | ||
| 95 | 10:45 <vmassol> hi florinciu | ||
| 96 | 10:45 <vmassol> yes there is | ||
| 97 | 10:45 <+florinciu> is there a fix for it? | ||
| 98 | 10:46 <+florinciu> I'm trying to pitch XWiki as a collaboration tool in my team..the loading time of the home page doesn't help :( | ||
| 99 | 10:46 <vmassol> http://jira.xwiki.org/browse/XWIKI-7520 | ||
| 100 | 10:47 <vmassol> indeed this is a good point | ||
| 101 | 10:47 <vmassol> we need to decide if we roll back this commit from jerome for 3.5 final | ||
| 102 | 10:47 <vmassol> I had asked jerome to look at it before 3.5 final but he hasn't apparenerly :( | ||
| 103 | 10:47 <vmassol> I'll ping him now | ||
| 104 | 10:48 <vmassol> IMO we should rollback | ||
| 105 | 10:52 <+florinciu> ok I see. thanks for the info | ||
| 106 | 10:52 <+florinciu> I guess I'll remove the AS from the homepage and try to put something else in place | ||
| 107 | 10:55 <vmassol> mflorea, tmortagne, others: what do we do? Do we need a vote? I don't think so since this is an importabt regression introduced and a lazy commit and according to our bylaws we can ask to revert any change not explicitly voted for | ||
| 108 | 10:55 <vmassol> first, do you agree that we should remove it for 3.5 final? | ||
| 109 | 10:56 <vmassol> s/remove/rollback/ | ||
| 110 | 10:57 <evalica> has joined #xwiki | ||
| 111 | 10:57 <+mflorea> reading issue description to understand the problem.. | ||
| 112 | 10:57 <+tmortagne> vmassol: reading | ||
| 113 | 11:01 <+tmortagne> the speed difference is indeed impressive... | ||
| 114 | 11:01 <vmassol> has quit | ||
| 115 | 11:02 <+sburjan> and this happens only on MySQL ? because I don't see perf issues on hsqldb build | ||
| 116 | 11:02 <vmassol> has joined #xwiki | ||
| 117 | 11:02 <+tmortagne> but removing something in 3.5 that has been introduced in 3.2 is a bit tough | ||
| 118 | 11:02 <+tmortagne> now I agree that we don't have much time for 3.5 | ||
| 119 | 11:02 <vmassol> well there isn't much choice | ||
| 120 | 11:02 <vmassol> on one hand you have a non working software | ||
| 121 | 11:02 <vmassol> OTOH you remove one not so large feature | ||
| 122 | 11:03 <+tmortagne> I did not really seen what was feature was yet :) | ||
| 123 | 11:03 <+tmortagne> ok to remove it for me | ||
| 124 | 11:04 <vmassol> FTR I've left a message on jerome's voicemail too | ||
| 125 | 11:09 <vmassol> ok I've spoken with jerome | ||
| 126 | 11:09 <+florinciu> sburjan: yes. I also saw the issue only on my production machine and not when I first tested with hsqldb. maybe the issue is not that severe on the test distribution. | ||
| 127 | 11:09 <vmassol> he's ok to rollback too | ||
| 128 | 11:09 <vmassol> what we could do is: | ||
| 129 | 11:09 <vmassol> - rollback for 3.5 final | ||
| 130 | 11:09 <vmassol> - put it back in 3.5.1 if someones fixes the issue | ||
| 131 | 11:09 <vmassol> - ofc we need to document this in the RN for 3.5 since it means we remove an exsiting feature | ||
| 132 | 11:10 <+sburjan> does this break backward compatibility ? | ||
| 133 | 11:10 <+tmortagne> probably, removing something always break backward compatibility | ||
| 134 | 11:10 <vmassol> it's not used by us directly though | ||
| 135 | 11:11 <vmassol> (at least jerome doesn't think so) | ||
| 136 | 11:11 <vmassol> jerome had an external need when he added it | ||
| 137 | 11:13 <CIA-120> Vincent Massol master * r0956a6a https://github.com/xwiki/xwiki-enterprise/commit/0956a6aafc278b7ae54d171399d8479aff9319a6 / (7 files in 7 dirs): [Misc] Put browser profile definitions in the test top level POM but continue defining default browser in children POM since profiles aren't inherited in Maven - http://git.io/XG8zTQ | ||
| 138 | 11:13 <vmassol> sburjan: check that commit | ||
| 139 | 11:14 <+sburjan> checking .. are you sure it works ? | ||
| 140 | 11:14 <lucaa> has joined #xwiki | ||
| 141 | 11:14 <vmassol> sburjan: if you can test it too that would be good, it seems to work for me | ||
| 142 | 11:14 <+sburjan> I will test after I finish with M1 and final. | ||
| 143 | 11:16 <+sburjan> afaik we already had this in xwiki-enterprise-test/pom.xml and didn't worked, you had to specify the profiles in ui-tests and selenium-tests. what triggers now the inheritance ? | ||
| 144 | 11:16 <vmassol> there's no inheritance | ||
| 145 | 11:16 <vmassol> profiles are not inherited perdio | ||
| 146 | 11:16 <vmassol> :) | ||
| 147 | 11:16 <+sburjan> oh, you felt the ff profile definition there | ||
| 148 | 11:16 <+sburjan> *left | ||
| 149 | 11:17 <+sburjan> ok, I understand | ||
| 150 | 11:17 <vmassol> but you can trigger parent profiles when building children poms | ||
| 151 | 11:17 <+sburjan> may I ask how ? | ||
| 152 | 11:18 <vmassol> errr | ||
| 153 | 11:18 <vmassol> by using profiles | ||
| 154 | 11:19 <+sburjan> i know that, but if there is no inheritance, and no profile defined for chrome in ui-tests, how can I trigger it from the parent pom. This is what I don't understand | ||
| 155 | 11:19 <vmassol> using profiles | ||
| 156 | 11:19 <vmassol> stadnard maven | ||
| 157 | 11:19 <vmassol> -P<myprofiles> | ||
| 158 | 11:19 <vmassol> how else would you trigger a prpofile? | ||
| 159 | 11:20 <vmassol> I think you should read up on profiles | ||
| 160 | 11:20 <+sburjan> ok. | ||
| 161 | 11:20 <vmassol> this is good read: http://maven.apache.org/guides/introduction/introduction-to-profiles.html | ||
| 162 | 11:20 <vmassol> (note that I already explained this to you when I saw you IRL last time ;)) | ||
| 163 | 11:21 <+sburjan> yes, and made sense since we declared our profiles in the ui-tests pom :) | ||
| 164 | 11:22 <+sburjan> I'll have to read the URL you gave me, maybe I can understand | ||
| 165 | 11:22 <vmassol> mflorea: so wdyt about XWIKI-7520 | ||
| 166 | 11:23 <vmassol> BTW we have 2 subchoices for rolling it back: full rollback or only partial: "I found this came from http://jira.xwiki.org/browse/XWIKI-6839 and that by removing the <map> mapping from activitystream.hbm.xml the previous speed was recovered." | ||
| 167 | 11:23 <vmassol> we could do the partial rollback and explain how to put the feature back in the Rlease notes | ||
| 168 | 11:24 <vmassol> (by adding some lines to activitystream.hbm.xml) | ||
| 169 | 11:24 <vmassol> partial = just remove the <map> from activitystream.hbm.xml | ||
| 170 | 11:27 <vmassol> ok I'm going to perform the partial rollback now on both master and 3.5 branch + create a new issue to put it back | ||
| 171 | 11:27 <vmassol> shout quickly if you don't agree | ||
| 172 | 11:27 <vmassol> :) | ||
| 173 | 11:34 <CIA-120> Ecaterina Moraru (Valica) stable-3.5.x * r77d68eb https://github.com/xwiki/xwiki-platform/commit/77d68ebd5d1446184269dee37ddf56e4c643cbc6 / xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-client/src/main/resources/org/xwiki/gwt/wysiwyg/public/stylesheets/toolbar.css : XWIKI-7532 - UI Issue on WYSIWYG Editor when editing Application Class ... | ||
| 174 | 11:36 <vmassol> evalica and everyone: please don't commit on 3.5 without discussing it | ||
| 175 | 11:36 <vmassol> today is release day | ||
| 176 | 11:36 <vmassol> since otherwise it means your changes won't be tested | ||
| 177 | 11:36 <+mflorea> vmassol: I'm fine with partial rollback. I agree with Jerome this is a nice feature and we should find the real problem | ||
| 178 | 11:37 <vmassol> and this introduces the risk of introducing a regression/problem | ||
| 179 | 11:37 <vmassol> mflorea: ok doing it | ||
| 180 | 11:37 <+mflorea> vmassol: evalica discussed it with me | ||
| 181 | 11:38 <vmassol> please discuss here then | ||
| 182 | 11:38 <vmassol> :) | ||
| 183 | 11:45 <+evalica> vmassol: it was a cherry pick | ||
| 184 | 11:47 <CIA-120> Vincent Massol master * r63db8fd https://github.com/xwiki/xwiki-platform/commit/63db8fd7b7f4f46b6bd7a7aea8074ab3e6539051 / xwiki-platform-core/xwiki-platform-activitystream/src/main/resources/activitystream.hbm.xml : XWIKI-7520: Activity Stream performance regression - http://git.io/C_SX1A | ||
| 185 | 11:48 <CIA-120> Vincent Massol stable-3.5.x * rcb7343a https://github.com/xwiki/xwiki-platform/commit/cb7343a3d20129e783ac40b14049c8a056827135 / xwiki-platform-core/xwiki-platform-activitystream/src/main/resources/activitystream.hbm.xml : XWIKI-7520: Activity Stream performance regression - http://git.io/TkdwzQ | ||
| 186 | 11:50 <vmassol> sburjan: would be great if you could test with this change in your build | ||
| 187 | 11:50 <vmassol> (test 3.5 I mean) | ||
| 188 | 11:52 <+sburjan> I guess I have to test on a MySQL build, right ? | ||
| 189 | 11:52 <vmassol> why? | ||
| 190 | 11:52 <vmassol> you do test on various DBs right? | ||
| 191 | 11:53 <vmassol> it's always important to test on various DBs | ||
| 192 | 11:53 <+sburjan> I can't test in 2 days 4 browsers and 3 db's | ||
| 193 | 11:53 <+sburjan> I haven't got the time to test on other db's | ||
| 194 | 11:54 <+sburjan> but I did not see any perf issue on AS using hsqldb | ||
| 195 | 11:54 <+sburjan> this is why I am asking if I need a mysql install to compare the difference | ||
| 196 | 11:57 <vmassol> the perf issue should be on all DBs | ||
| 197 | 11:57 <vmassol> see http://jira.xwiki.org/browse/XWIKI-7520 | ||
| 198 | 11:58 <vmassol> sburjan: you could check on oracle | ||
| 199 | 11:58 <vmassol> since on oracle it takes a lot of time | ||
| 200 | 11:58 <vmassol> maybe the difference is more visible | ||
| 201 | 11:58 <vmassol> so ideally you should compare home page load with 3.5M1 and 3.5SNAPSHOT (after my change has been built) and compare | ||
| 202 | 11:58 <+sburjan> ok. I'll check M1 vs final .. and see if there is any diference when using activity entries="5" | ||
| 203 | 11:59 <vmassol> make sure you have some activity in the stream first | ||
| 204 | 11:59 <vmassol> don't change the home page | ||
| 205 | 11:59 <+sburjan> ofc | ||
| 206 | 11:59 <vmassol> just make some activity in the wiki | ||
| 207 | 11:59 <+sburjan> ok | ||
| 208 | 11:59 <vmassol> mflorea: I'd like to add the note in the RN for 3.5. Could you prepare the 3.5 RN page or let me know how I should prepare it | ||
| 209 | 12:02 <+sburjan> which is the best way to see if the build containing your commit has been built ? because each commit triggers a new build, right ? | ||
| 210 | 12:02 <vmassol> yes | ||
| 211 | 12:02 <vmassol> you can see it in jeknins | ||
| 212 | 12:03 <vmassol> for ex: http://ci.xwiki.org/job/xwiki-platform-3.5/9/ | ||
| 213 | 12:03 <vmassol> see "changes" | ||
| 214 | 12:03 <vmassol> http://ci.xwiki.org/job/xwiki-platform-3.5/9/changes#detail0 | ||
| 215 | 12:03 <vmassol> hmm http://ci.xwiki.org/job/xwiki-manager-test-selenium/1330/console is stuck again | ||
| 216 | 12:04 <vmassol> mflorea: btw are jenkins jobs triggered when there are changes to 3.5 branch? | ||
| 217 | 12:05 <+sburjan> ok, so it is still building with tmortagne 's fix of EM .. yours must be in the queue | ||
| 218 | 12:05 <vmassol> yes except I don't see it in the queue | ||
| 219 | 12:05 <vmassol> I'll force it | ||
| 220 | 12:05 <+sburjan> me neither .. and I'm confused :| | ||
| 221 | 12:06 <vmassol> seems github did a push though: http://ci.xwiki.org/view/Platform/job/xwiki-platform-3.5/GitHubPollLog/? | ||
| 222 | 12:06 <vmassol> (but not for my commit It hink) | ||
| 223 | 12:06 <vmassol> ok I've added a build in the queue for platform 3.5 | ||
| 224 | 12:07 <+mflorea> vmassol: it should trigger. We discussed about this Friday. It's strange because I'm pretty sure it used to be triggered by other commits. | ||
| 225 | 12:08 <vmassol> yes that's why I'm asking because on Friday it didn't trigger | ||
| 226 | 12:08 <+mflorea> but how is it possible that Thomas' commit triggered a build and yours not.. | ||
| 227 | 12:09 <+mflorea> or maybe tmortagne forced the build too | ||
| 228 | 12:09 <vmassol> well it just says: "Started on 20 f?vr. 2012 11:34:15" | ||
| 229 | 12:09 <vmassol> http://ci.xwiki.org/view/Platform/job/xwiki-platform-3.5/GitHubPollLog/? | ||
| 230 | 12:09 <vmassol> check on master | ||
| 231 | 12:09 <vmassol> checking | ||
| 232 | 12:09 <vmassol> hmm | ||
| 233 | 12:09 <vmassol> http://ci.xwiki.org/view/Platform/job/xwiki-platform/GitHubPollLog/? | ||
| 234 | 12:09 <vmassol> a lot more information | ||
| 235 | 12:11 <+mflorea> indeed | ||
| 236 | 12:12 <vmassol> going for lunch, bbl | ||
| 237 | 12:13 <+mflorea> xwiki-platform and xwiki-platform-3.5 have the same config, expect the git branch, master vs. stable-3.5.x so it should work fine for all commits | ||
| 238 | 12:14 <CIA-120> tmortagne stable-3.5.x * r94999c5 https://github.com/xwiki/xwiki-platform/commit/94999c54e59425ab3a3d08676e5c6b013d3362eb / (2 files in 2 dirs): XWIKI-7547: Version parsing error when loading core Extension at startup ... | ||
| 239 | 12:14 <CIA-120> tmortagne master * r419d191 https://github.com/xwiki/xwiki-platform/commit/419d1914964867155f4ef8cb15c134ced56d7a36 / (2 files in 2 dirs): XWIKI-7547: Version parsing error when loading core Extension at startup - http://git.io/mV8QPg | ||
| 240 | 12:15 <+tmortagne> I did not forced any build today | ||
| 241 | 12:16 <+tmortagne> mflorea: I would like to fix XWIKI-7544 before 3.5, the fix itself should be easy but what's long is to setup what I need to test it | ||
| 242 | 12:17 <+mflorea> tmortagne: np, I have to commit some functional tests for awm | ||
| 243 | 12:18 <+mflorea> so I'm not starting the release right away | ||
| 244 | 12:24 <mflorea> has quit | ||
| 245 | 12:29 <CIA-120> Eduard Moraru feature-annotations-merged-with-comments * r13f9fff https://github.com/xwiki/xwiki-platform/commit/13f9ffff5a3711115f985c7f6fdc21d78ac5a553 / (4 files in 3 dirs): XWIKI-7540: Merge Annotations with Comments. ... | ||
| 246 | 12:45 <CIA-120> tmortagne master * r793bf2f https://github.com/xwiki/xwiki-platform/commit/793bf2fb2b014547cf87f9b45de20642ec68219b / xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-api/src/main/java/org/xwiki/extension/version/internal/DefaultVersion.java : XWIKI-7547: Version parsing error when loading core Extension at startup ... | ||
| 247 | 12:45 <CIA-120> tmortagne stable-3.5.x * r5f7d7e2 https://github.com/xwiki/xwiki-platform/commit/5f7d7e214f7d1acabfb72060b4b7b964e782f248 / : XWIKI-7547: Version parsing error when loading core Extension at startup ... | ||
| 248 | 12:48 <jvdrean> has quit | ||
| 249 | 13:00 <+sburjan> I think I found a blocker | ||
| 250 | 13:04 <jvdrean> has joined #xwiki | ||
| 251 | 13:05 <+sburjan> when I create a space using the default space dashboard, the creator of the document is blank | ||
| 252 | 13:06 <+sburjan> I will report it as a blocker | ||
| 253 | 13:18 <+tmortagne> sburjan: yep it's not very nice, should be the context user | ||
| 254 | 13:18 <+sburjan> reported it | ||
| 255 | 13:19 <+sburjan> I wonder how I didn't catch this on 3.4 .. because 3.4 is also affected | ||
| 256 | 13:22 <+tmortagne> ok | ||
| 257 | 13:37 <mflorea> has joined #xwiki | ||
| 258 | 13:48 <+mflorea> tmortagne: enterprise build stuck when installing xwiki-enterprise-installer-debian-common . http://ci.xwiki.org/job/xwiki-enterprise/8594/console | ||
| 259 | 13:48 <DrLou_> has joined #xwiki | ||
| 260 | 13:49 <+tmortagne> mflorea: ok that's weird since it's not doing much, will look at it | ||
| 261 | 13:50 <+mflorea> the build was triggered by vmassol's commit, I think, but that commits was related to functional tests so I don't see how it could affect xwiki-enterprise-installer-debian-common | ||
| 262 | 13:51 <+tmortagne> yep and maven-install plugin is just supposed to put the file in the local repository | ||
| 263 | 13:51 <+tmortagne> i don't see how it could get stuck whatever the project | ||
| 264 | 13:59 <gdelhumeau> has quit | ||
| 265 | 14:14 <gdelhumeau> has joined #xwiki | ||
| 266 | 14:27 <+sburjan> there is something odd on maven, because I don't see any newer snapshots for 3.5 | ||
| 267 | 14:27 <+sburjan> http://maven.xwiki.org/snapshots/org/xwiki/enterprise/xwiki-enterprise-jetty-hsqldb/3.5-SNAPSHOT/ | ||
| 268 | 14:27 <+sburjan> the last one is from 16 February .. am I in the wrong place ? | ||
| 269 | 14:28 <+tmortagne> maybe none has been built by jenkins since | ||
| 270 | 14:29 <+tmortagne> http://ci.xwiki.org/view/Enterprise/job/xwiki-enterprise-3.5/ | ||
| 271 | 14:29 <+tmortagne> sburjan: | ||
| 272 | 14:29 <+tmortagne> last built Feb 16 | ||
| 273 | 14:29 <+tmortagne> one is pending | ||
| 274 | 14:29 <+tmortagne> should start as soon as platform is done | ||
| 275 | 14:29 <+sburjan> interesting.. I thought a commit in platform will trigger a build of enterprise too | ||
| 276 | 14:30 <+tmortagne> it is | ||
| 277 | 14:30 <+tmortagne> but enterprise will not build if any of its dependencies is building | ||
| 278 | 14:30 <+tmortagne> so it was probably stuck waiting for several builds of platform | ||
| 279 | 14:31 <+sburjan> i see | ||
| 280 | 14:39 <+Enygma`> hi Denis | ||
| 281 | 14:39 <+Enygma`> I need to implement a DB migration and I was wondering if you have 2 minutes to explain a bit how the DB versions work and how should I use them | ||
| 282 | 14:40 <vmassol> would be great to have some docs on this maybe… :) | ||
| 283 | 14:44 <+Denis> Enygma`: Hi, feel free to ask, there has been a vote: http://markmail.org/thread/c4itpnnul32v7zf5 | ||
| 284 | 14:49 <+Enygma`> Denis: so I should specify the XWikiDBVersion for 4.0 to 40000, right? | ||
| 285 | 14:49 <+Denis> vmassol: well, documentation is always good, it is a matter of time and the security module will be a priority in comparison; I have commented in the javadoc as much as possible, and there is a very complete example with the id migration I have recently commit (maybe a little complex however). | ||
| 286 | 14:49 <+Enygma`> and if someone else needs to do a DB migration too, the next version for 4.0 would be 40.001 | ||
| 287 | 14:50 <+Denis> right | ||
| 288 | 14:50 <+Denis> 40000 is taken alread | ||
| 289 | 14:50 <+Denis> y | ||
| 290 | 14:50 <+Denis> 40000 is the id migration | ||
| 291 | 14:50 <vmassol> Denis: it depends how many times you want to answer questions about it :) | ||
| 292 | 14:51 <+Denis> vmassol: there should not be much, since the early begin, there have been less than ten migrations | ||
| 293 | 14:51 <vmassol> it's already costing you more than if it were documented... | ||
| 294 | 14:51 <vmassol> anyway :) | ||
| 295 | 14:52 <vmassol> since you spent so much time on it I think you should think about docuetnign it | ||
| 296 | 14:52 <vmassol> actually it coul dhave been nice to make a separate module for it | ||
| 297 | 14:52 <+Denis> I would, if I could, as I said, the new security component is first on my list | ||
| 298 | 14:52 <+Enygma`> Denis: and what about shouldExecute(XWikiDBVersion startupVersion) ? From what I understand, I need to check the given startupVersion to see if the DB is at the version that I want it to be before my migration is applied, right? | ||
| 299 | 14:52 <vmassol> I don't know how much links with oldcore we have | ||
| 300 | 14:52 <vmassol> I thought migration was first | ||
| 301 | 14:52 <vmassol> ont he list | ||
| 302 | 14:53 <vmassol> since you've done it before | ||
| 303 | 14:53 <+Denis> Enygma`: no, do not implement if you need a simple migration | ||
| 304 | 14:53 <vmassol> right now it's in oldcore, does it mena it's throwaway code? | ||
| 305 | 14:53 <+Denis> vmassol: but the security module need much more explanation | ||
| 306 | 14:53 <vmassol> I think the only link should be the storage | ||
| 307 | 14:54 <vmassol> so it should be pretty well compartimented and could be reusable even when we change the storage quite easily | ||
| 308 | 14:54 <vmassol> but you'll have a cyclic dep | ||
| 309 | 14:54 <vmassol> .... | ||
| 310 | 14:54 <vmassol> ATM | ||
| 311 | 14:55 <vmassol> the prereq is probably a storage module | ||
| 312 | 14:55 <+Enygma`> Denis: ah, getVersion() specifies on which DB version my migration needs to be applied, and not what is the new version defined by the changes of my migration. | ||
| 313 | 14:56 <+Denis> Enygma`: getVersion() give the new version you are migrating the DB to | ||
| 314 | 14:56 <+Denis> migration are applied in order appropriatly | ||
| 315 | 14:58 <+Denis> shouldExecute could be use to remove your migration from the list of needed migration in special case; it has been used for migration that fix migration, and that are only needed when the initial migration has been used in buggy state | ||
| 316 | 14:58 <+Denis> hope you never need it ! | ||
| 317 | 14:59 <+Enygma`> Denis: hm... ok, I think I`ve got it :) | ||
| 318 | 14:59 <+Enygma`> thanks | ||
| 319 | 15:00 <+Denis> vmassol: there is some weird issue in the migration system due to the multiplicity of the stores, and the link between them | ||
| 320 | 15:00 <+Denis> currently the migration system see the store as a whole, and is dependant of the kind of store | ||
| 321 | 15:01 <+Denis> this is not good when we mix different kind of store (hibernate, filesystem,...) | ||
| 322 | 15:02 <+Denis> so, there is more to do in that field, and my migration system is currently good from an hibernate POV (most of the migration we have done up to now) | ||
| 323 | 15:02 <vmassol> ok... | ||
| 324 | 15:02 <+Denis> I have not fully review it, from what it was before | ||
| 325 | 15:02 <+Denis> just improvement currently, and more component sugar | ||
| 326 | 15:03 <+Denis> while, the security component is more a full rewrite and expected to last longer | ||
| 327 | 15:03 <vmassol> it's going to be in oldcore too? | ||
| 328 | 15:03 <+Denis> no, it's fully independant and use a bridge, read the mail ! | ||
| 329 | 15:04 <vmassol> (yeah I need to read that mail...) | ||
| 330 | 15:05 <+sburjan> this seems stuck: http://ci.xwiki.org/job/xwiki-platform-3.5/12/ | ||
| 331 | 15:08 <CIA-120> Marius Dumitru Florea master * r14fd395 https://github.com/xwiki/xwiki-platform/commit/14fd395e58dfbf3b0d05bbd94086afc856fd366a / xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateAction.java : XWIKI-7558: Creating a space using Space Dashboard Template will result in a page with blank creator ... | ||
| 332 | 15:08 <CIA-120> Marius Dumitru Florea master * rae09194 https://github.com/xwiki/xwiki-platform/commit/ae09194f83b9fe1f75778e0a2501a6cc37c4b060 / (3 files): [misc] Preview class fields with custom display before they are added/saved to the class ... | ||
| 333 | 15:08 <CIA-120> Marius Dumitru Florea stable-3.5.x * r24b18c7 https://github.com/xwiki/xwiki-platform/commit/24b18c7c64805d237eaa1fcf11824eb1e21d6fa7 / xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CreateAction.java : XWIKI-7558: Creating a space using Space Dashboard Template will result in a page with blank creator ... | ||
| 334 | 15:08 <CIA-120> Marius Dumitru Florea stable-3.5.x * rdbc1a79 https://github.com/xwiki/xwiki-platform/commit/dbc1a79a39ad6257eab01ee661f34c2c62946876 / (3 files): [misc] Preview class fields with custom display before they are added/saved to the class ... | ||
| 335 | 15:13 <florinciu> has quit | ||
| 336 | 15:14 <CIA-120> Marius Dumitru Florea stable-3.5.x * r007ccfa https://github.com/xwiki/xwiki-enterprise/commit/007ccfa6898367700d7afd35bb5ffddc72925160 / (6 files in 2 dirs): Add functional tests for Date field (AppWithinMinutes/ClassEditor) ... | ||
| 337 | 15:14 <CIA-120> Marius Dumitru Florea master * r5da298e https://github.com/xwiki/xwiki-enterprise/commit/5da298eb139155829e6acaf97a7815c4a38efba5 / (6 files in 2 dirs): Add functional tests for Date field (AppWithinMinutes/ClassEditor) - http://git.io/5JZBkg | ||
| 338 | 15:58 <jvelo> has joined #xwiki | ||
| 339 | 16:01 <CIA-120> tmortagne stable-3.5.x * r136d113 https://github.com/xwiki/xwiki-platform/commit/136d113cea46c2f35fe358f713d72c114fe36e7a / (5 files in 5 dirs): XWIKI-7544: Add support for standard proxy settings in Extension Manager(cherry picked from commit afba250409f3d185289d9526c07629b44c9fca19) - http://git.io/jTMb6g | ||
| 340 | 16:02 <CIA-120> tmortagne master * rd481874 https://github.com/xwiki/xwiki-platform/commit/d48187411b3a4fdd141eb2435bacf69bb7f7044a / (5 files in 5 dirs): XWIKI-7544: Add support for standard proxy settings in Extension Manager - http://git.io/OyWH2Q | ||
| 341 | 16:09 <+mflorea> vmassol: you should comment on XWIKI-7555 I remember you forced the current behavior intentionaly, by adding an object of EditModeClass to Main.WebHome | ||
| 342 | 16:11 <vmassol> mflorea: yep it's intentional | ||
| 343 | 16:11 <vmassol> I almost commtned on it this morning | ||
| 344 | 16:13 <vmassol> mflorea: why is there a need for EditModeClass in home? | ||
| 345 | 16:13 <vmassol> it only does an include | ||
| 346 | 16:14 <vmassol> maybe it's a leftover | ||
| 347 | 16:16 <+mflorea> to force edit mode instead of inline. If you don't have this object then getDefaultEditMode detects the include macro and defaults to inline if the included macro doesn't have a EditModeClass object (like in this case I think) | ||
| 348 | 16:16 <+mflorea> s/included macro/included document | ||
| 349 | 16:16 <vmassol> ok | ||
| 350 | 16:18 <+mflorea> yep, I just tested, if you remove it then it goes to inline mode | ||
| 351 | 16:24 <+sburjan> I see an odd behavior. If a Admin finishes editing a Page Rights page, and after that a normal user edits it, the user will still see the document being locked by the Admin. How is the current implementation, how xwiki know that Admin has left that page ? | ||
| 352 | 16:24 <+sburjan> so it can unlock the page | ||
| 353 | 16:24 <+tmortagne> sburjan: a lock is saved in the database for a document when someone start editing it | ||
| 354 | 16:25 <+tmortagne> the lock is removed when saving or canceling | ||
| 355 | 16:25 <+tmortagne> when you edit XWiki check if there is a lock saved for the document | ||
| 356 | 16:25 <+tmortagne> also if you don't save or cancel the lock is lost after some time | ||
| 357 | 16:25 <+tmortagne> don't remember exactly how much time | ||
| 358 | 16:26 <+sburjan> ok.. | ||
| 359 | 16:26 <+tmortagne> probably something like 30 min | ||
| 360 | 16:26 <+sburjan> still not very nice IMO | ||
| 361 | 16:27 <+tmortagne> sure but it's not that easy to avoid collisions without some complex system | ||
| 362 | 16:27 <vmassol> tmortagne: sburjan means something else | ||
| 363 | 16:28 <vmassol> sburjan: can you explain what you mean by "If a Admin finishes editing a Page Rights page, " | ||
| 364 | 16:30 <+sburjan> use case: vmassol denies comment rights for user sburjan on a page. tmortagne comes and wants to deny view page for the _same_ page as vmassol denies comment rights. tmortagne will see the page locked, even if vmassol has set the permission, and navigated away from the page | ||
| 365 | 16:30 <vmassol> "vmassol denies comment rights for user sburjan on a page. " how? | ||
| 366 | 16:30 <+tmortagne> the issue if that the rights UI does not "finish" anything | ||
| 367 | 16:30 <+tmortagne> so it never remove the lock explicitely | ||
| 368 | 16:31 <vmassol> yep | ||
| 369 | 16:31 <+sburjan> go to page, Edit Rights | ||
| 370 | 16:31 <+sburjan> Edit -> Access Rights | ||
| 371 | 16:31 <+tmortagne> one of the reason why I never liked this save when you click thing | ||
| 372 | 16:31 <vmassol> and this is a bug for me | ||
| 373 | 16:31 <vmassol> it's a major pita and generates unnecessary revs | ||
| 374 | 16:32 <+sburjan> I think this is a very old behavior I guess, right from the start, right ? | ||
| 375 | 16:32 <vmassol> no | ||
| 376 | 16:33 <+sburjan> but there is not much to do about it .. except putting a save button on the right edit page, I don't know. Should I report it ? | ||
| 377 | 16:33 <vmassol> you can report it indeed, there might already be an issue though | ||
| 378 | 16:33 <+tmortagne> pretty sure there is something about it already | ||
| 379 | 16:34 <+tmortagne> no this particular use case but about the way right UI is working in general | ||
| 380 | 16:34 <vmassol> but it's a good reminder of something we could work on in 4.X | ||
| 381 | 16:34 <vmassol> since it's about usability | ||
| 382 | 16:34 <vmassol> it wouldn't do any harm in reporting it again IMO | ||
| 383 | 16:35 <+sburjan> ok, reporting again. I also found a really critical issue Andreas is working on .. so I won't report it again | ||
| 384 | 16:43 <+sburjan> done | ||
| 385 | 16:44 <jvelo> has quit | ||
| 386 | 16:45 <+sburjan> vmassol: downloading latest snapshot to check AS slowness | ||
| 387 | 16:46 <vmassol> ok | ||
| 388 | 16:47 <+sburjan> gonna run in parallel a 3.5M1 and latest 3.5 SNAPSHOT on oracle .. let's hope I see a speed difference | ||
| 389 | 16:55 <+mflorea> guys, any pending commits for 3.5? | ||
| 390 | 16:55 <vmassol> not from me | ||
| 391 | 16:55 <+mflorea> tmortagne? | ||
| 392 | 16:55 <+tmortagne> mflorea: nothing blocker | ||
| 393 | 16:55 <+mflorea> ok, I'll wait for CI to finish building 3.5 and start the release | ||
| 394 | 16:56 <vmassol> cool, let's hope sburjan finds a speed difference | ||
| 395 | 16:56 <+mflorea> I'll repare the release notes in the mean time | ||
| 396 | 16:56 <+sburjan> just give me 5 minutes, unpacking zip's | ||
| 397 | 16:56 <+mflorea> s/repare/prepare | ||
| 398 | 17:02 <nIMBVS> has joined #xwiki | ||
| 399 | 17:03 <nIMBVS> hi. after enabling filesystem store for attachments and using it for some time, some of my attachments stopped working | ||
| 400 | 17:04 <nIMBVS> I didn't find a pattern for them not working anymore... | ||
| 401 | 17:04 <vmassol> a good question for cjd if he's avail… ;) | ||
| 402 | 17:05 <+sburjan> ok, I have at least one odd issue. I am not able to start xwiki with custom port on windows | ||
| 403 | 17:05 <+sburjan> let me investigate | ||
| 404 | 17:06 <nIMBVS> but when I access the attachments I get "Error. The attachment does not exist" | ||
| 405 | 17:06 <nIMBVS> but I can find the file on the filesystem. it's there... | ||
| 406 | 17:06 <+mflorea> guys, do we move http://jira.xwiki.org/browse/XWIKI-7513 to 4.0M1? | ||
| 407 | 17:06 <+mflorea> it is marked as blocker | ||
| 408 | 17:06 <nIMBVS> nothing in catalina.out | ||
| 409 | 17:07 <nIMBVS> can you advise how to enable some logging for attachments? | ||
| 410 | 17:10 <+sburjan> vmassol: I have a question. I am not using the default xwiki database name, and it seems it doesn't start if the db name isn't xwiki. Do we have somewhere hardcoded xwiki database for oracle ? I am running XE, not XEM | ||
| 411 | 17:13 <vmassol> you must use xwiki | ||
| 412 | 17:13 <vmassol> and on oracle db == user | ||
| 413 | 17:14 <vmassol> use the default db name and you'll be fine | ||
| 414 | 17:14 <+sburjan> yes.. but I didn't knew we had a restriction on db name ... don't like it | ||
| 415 | 17:14 <vmassol> change it | ||
| 416 | 17:14 <vmassol> fix it | ||
| 417 | 17:14 <+sburjan> I wanted to have both running in parallel ... so I can measure timings | ||
| 418 | 17:15 <vmassol> that's bad | ||
| 419 | 17:15 <vmassol> it's really the worse of things to do | ||
| 420 | 17:15 <vmassol> running in // will defniitely mess up your times | ||
| 421 | 17:15 <vmassol> very bad | ||
| 422 | 17:15 <vmassol> just time it one after another | ||
| 423 | 17:15 <+sburjan> okay.. so all for the best running them separately | ||
| 424 | 17:15 <+mflorea> ok, I'll move XWIKI-7513 to 4.0M1 since there is a workaround provided in the comments | ||
| 425 | 17:21 <vmassol> mflorea: hmm | ||
| 426 | 17:21 <vmassol> just seen about 7513 | ||
| 427 | 17:21 <+tmortagne> issue with XWIKI-7513 is that it's a regression | ||
| 428 | 17:21 <vmassol> it's a blocker | ||
| 429 | 17:21 <vmassol> and a regression | ||
| 430 | 17:22 <vmassol> I don't see how we could release without it | ||
| 431 | 17:22 <+tmortagne> we released 3.4 | ||
| 432 | 17:22 <vmassol> because we didn't notice it | ||
| 433 | 17:22 <vmassol> which means 3.4 is a broken release | ||
| 434 | 17:22 <vmassol> I don't see this as good :) | ||
| 435 | 17:22 <vmassol> 3.5 is supposed to be the last release | ||
| 436 | 17:23 <vmassol> of the 3.x cycle | ||
| 437 | 17:23 <vmassol> it would be better if it worked | ||
| 438 | 17:24 <vmassol> are we using REST upload of attachments in XE? | ||
| 439 | 17:25 <vmassol> this is caused by the move to restlet 2.0 right? | ||
| 440 | 17:25 <+tmortagne> in XE we always set the mime type when dealing with REST whatever we do | ||
| 441 | 17:25 <+sburjan> vmassol: yes, I see some slowness on 3.5M1 .. just by importing the xar which already fills a lot of AS data | ||
| 442 | 17:25 <+tmortagne> yes | ||
| 443 | 17:25 <+tmortagne> I think | ||
| 444 | 17:25 <vmassol> seems jerome is pretty unlucky in his commits ;) | ||
| 445 | 17:25 <+mflorea> :) | ||
| 446 | 17:26 <+tmortagne> yea | ||
| 447 | 17:26 <vmassol> if I remember well we arleady rolled back once the move to restlet 2.0 | ||
| 448 | 17:26 <+tmortagne> yes | ||
| 449 | 17:26 <+tmortagne> but now it's going to be harder | ||
| 450 | 17:26 <+sburjan> just pray I don't see the same slowness on SNAPSHOT too.. this would make unlucky too. Installing firebug so I can measure times more accurately | ||
| 451 | 17:27 <+tmortagne> (and IMO we should not revert for this) | ||
| 452 | 17:28 <vmassol> yes reverting seems a bit too excessive here | ||
| 453 | 17:28 <vmassol> if we set the mime type internally then no feature of XE is broken then | ||
| 454 | 17:28 <vmassol> it's only external code which might be broken | ||
| 455 | 17:28 <+mflorea> maybe setting the content type is a best practice | ||
| 456 | 17:29 <+tmortagne> and kind of crappy code since it's not that nice to upload something without indicating the mime type | ||
| 457 | 17:29 <vmassol> yes maybe in which case we wouldn't have a rgression | ||
| 458 | 17:29 <+mflorea> i.e. maybe the behavior or restlet 2.0 is intentional | ||
| 459 | 17:29 <+tmortagne> but restlet guys did not answer to my message so i don't know if it's on purpose on not | ||
| 460 | 17:30 <+tmortagne> it does not look intentional in the code, at least there is nothing explaining it's ok it behave like this | ||
| 461 | 17:30 <vmassol> I'm with jerome | ||
| 462 | 17:31 <+tmortagne> it get the mime type and compare it without really expecting null it seems |
