IRC Archive for channel #xwiki on 22 September 2014

Last modified by Vincent Massol on 2014/09/22 23:39

<cjd> has quit
00:25 <cjd> has joined #xwiki
00:25 <sdumitriu2> has quit
00:27 <sdumitriu2> has joined #xwiki
00:55 <lucaa> has quit
00:56 <sdumitriu2> has joined #xwiki
01:10 <unfed_> has joined #xwiki
01:10 <unfed_> Not sure if anyone's listening on a Sunday.  But if you are I could use some help with attachment sizes.
01:11 <unfed_> I've changes xwiki.cfg to store attachments in the filesystem and confirmed they're going there.
01:11 <unfed_> I've also changed the Maximum Upload Size to a really big number in the objects editor
01:12 <unfed_> But I'm still getting a red bar at the bottom of the page when I upload a big file, small files work
01:12 <unfed_> Anyone know somewhere else I can look?  Or at least a way to get more info on the error; there's nothing in the log files that seem to relate to this.
04:10 <polx> has quit
04:29 <polx> has joined #xwiki
07:15 <cjd> unfed_: check the xwiki logs (eg: catalina.out) for errors
07:16 <msmeria> has joined #xwiki
07:27 <DarkKnightCZ> has joined #xwiki
07:36 <andreeapopescu> has joined #xwiki
07:37 <sdumitriu2> has joined #xwiki
07:48 <cjd> has quit
07:48 <sdumitriu2> has quit
07:50 <sdumitriu2> has joined #xwiki
08:04 <gdelhumeau> has joined #xwiki
08:04 <sdumitriu2> has quit
08:05 <sdumitriu2> has joined #xwiki
08:25 <DarkKnightCZ> has quit
08:25 <DarkKnightCZ> has joined #xwiki
08:48 <cjd> has joined #xwiki
08:52 <tmortagne> has joined #xwiki
08:53 <polx> has quit
08:53 <sdumitriu2> has quit
08:54 <tmortagne> [WARN] Upgrading myxwiki.org to 6.2 in about 2h
08:55 <sdumitriu2> has joined #xwiki
09:09 <vmassol> has joined #xwiki
09:09 <woshilapin> has joined #xwiki
09:26 <mflorea> has joined #xwiki
09:33 <lucaa> has joined #xwiki
10:03 <vmassol> good morning
10:03 <vmassol> let's not forget that we need to fix the build!
10:03 <vmassol> :)
10:16 <vmassol> looking at http://ci.xwiki.org/job/xwiki-enterprise-test-extension-6.2.x/41/org.xwiki.enterprise$xwiki-enterprise-test-extension/testReport/org.xwiki.test.ui.repository/RepositoryTest/testAddExtension/
10:17 <vmassol> the screenshot clearly shows that seleniulm is on a white page
10:17 <vmassol> http://ci.xwiki.org/job/xwiki-enterprise-test-extension-6.2.x/ws/xwiki-enterprise-test/xwiki-enterprise-test-extension/target/screenshots/RepositoryTest-testAddExtension.png
10:17 <tmortagne> [WARN] Upgrading myxwiki.org to 6.2 in about 1h
10:18 <vmassol> seems it''s caused by Edy's change
10:32 <DarkKnightCZ> has left #xwiki
10:34 <tekzilla> has joined #xwiki
10:34 <sdumitriu2> has quit
10:35 <sdumitriu2> has joined #xwiki
10:56 <tmortagne> [WARN] Restarting myxwiki.org as 6.2 in 5min
10:58 <sdumitriu2> has joined #xwiki
11:01 <Denis1> has joined #xwiki
11:01 <Denis1> is now known as <Denis>
11:02 <sdumitriu2> has quit
11:04 <sdumitriu2> has joined #xwiki
11:05 <polx> has joined #xwiki
11:12 <tmortagne>   p, li { white-space: pre-wrap; }  [WARN] Restarting myxwiki.org as 6.2
11:17 <Pbas> has quit
11:31 <evalica> has joined #xwiki
11:34 <Enygma`> has joined #xwiki
11:44 <Enygma`1> has joined #xwiki
11:44 <Enygma`> has quit
11:45 <sdumitriu2> has joined #xwiki
11:46 <ClemensR> has joined #xwiki
11:53 <DarkKnightCZ> has joined #xwiki
11:53 <vmassol> Enygma`1: ping
11:54 <vmassol> (could you check your skype please)
11:57 <sdumitriu2> has quit
11:59 <sdumitriu2> has joined #xwiki
12:10 <Enygma`1> starting to look at http://ci.xwiki.org/job/xwiki-enterprise-test-extension/63/org.xwiki.enterprise$xwiki-enterprise-test-extension/testReport/org.xwiki.test.ui.repository/RepositoryTest/testAddExtension/
12:10 <vmassol> ok thanks
12:10 <Enygma`1> is now known as <Enygma>
12:11 <Enygma> is now known as <Guest62013>
12:12 <cjd> heh I thought for a second you'd finally managed to register Enigma w/o the ` mark :)
12:12 <Guest62013> is now known as <Enygma`>
12:13 <Enygma`> was taken before I joined freenode
12:14 <Enygma`> is now known as <Enygam>
12:14 <Enygam> is now known as <Enygma`>
12:15 <cjd> it the person never joins or auths up for 6 months, you can beg the #freenode people to release it
12:15 <Enygma`> I get "Nickname is temporarily unavailable" if I try to use that nickname
12:16 <Enygma`> but indeed, I should look that up at some point
12:16 <Enygma`> maybe I can snatch it
12:20 <vmassol> gdelhumeau and everyone: when we find/fix important issues I think we should put then in an {{error}} block on the RN of 6.2 WDYT?
12:21 <vmassol> gdelhumeau: I wonder if XWIK-11081 doesn't qualify for that
12:21 <vmassol> XWIKI-11081
12:21 <Enygma`> vmassol: maybe we should have a section in release notes, right after the description, with issues detected on this release
12:21 <Enygma`> and list the jira issues that affect that release
12:21 <vmassol> Enygma`: yes that's the idea
12:21 <vmassol> we've been doing this unofficially for a long time now
12:22 <vmassol> I'd say only critical+ issue
12:22 <vmassol> *issues
12:22 <Denis> +1
12:23 <Enygma`> +1 to add this practice and to update our release notes template
12:25 <gdelhumeau> vmassol: I agree. I update the RN
12:26 <vmassol> k
12:44 <cjd> xar plugin only works on oracle jvm?
12:45 <tmortagne> cjd: if it does it's a bug IMO
12:46 <cjd> The following artifacts could not be resolved: jdk.tools:jdk.tools:jar:1.7
12:47 <tmortagne> not sure what this has to do with the JVM used
12:47 <cjd> I might be wrong but an old memory of some kind of jar packer which is only distributed with oracle jdk comes up
12:48 <cjd> let me try defining JAVA_HOME first though since that's missing
12:49 <sdumitriu2> has quit
12:50 <sdumitriu2> has joined #xwiki
12:51 <cjd> find /usr/lib/jvm/java-7-openjdk-amd64/ -name 'tools.jar'
12:51 <cjd> turns up nothing
12:55 <cjd> ahh ok, I had the jre but it was in the jdk directory
12:58 <ClemensR> has left #xwiki
12:59 <Enygma`> I`m using openjdk for development, and am having no problems.
12:59 <sdumitriu2> has quit
13:01 <Enygma`> vmassol: as I was saying on skype, I`ve recently pushed a modification to our PageObjects and have put inside the constructor of BasePage a call to BaseElement.waitUntilPageJSIsLoaded(). See https://github.com/xwiki/xwiki-platform/commit/9c503afb3d2171d2ca2a34a9c13f0033363794bc
13:01 <KermitTheFragger> has joined #xwiki
13:01 <vmassol> yes I know
13:01 <vmassol> and it's breaking some stuff apparently
13:01 <sdumitriu2> has joined #xwiki
13:02 <vmassol> at least for the extension tests
13:02 <Enygma`> now I have to fix a lot of previous tests that are first calling the cosntructor and only after are changing the URL
13:02 <Enygma`> with my change, the logic needs to be the other way around
13:02 <Enygma`> does that sound OK as a logic to follow?
13:02 <Enygma`> this is an example of "bad" practice:
13:02 <Enygma`>     public static AdministrationSectionPage gotoPage(String section)
13:02 <Enygma`>         AdministrationSectionPage page = new AdministrationSectionPage(section);
13:02 <Enygma`>         page.getDriver().get(page.getURL());
13:02 <vmassol> don't know
13:03 <Enygma`> however, this case is also special
13:03 <vmassol> you can be sure that people are going to continue making mistakes I think
13:03 <Enygma`> because it is using a parameter in the constructor
13:03 <vmassol> gtg for lunch now
13:03 <Enygma`> ok
13:03 <Enygma`> I`ll continue fixing tests
13:03 <Enygma`> and hope people will follow along, otherwise they will get failing tests :P
13:04 <vmassol> it's better to not fail by design :)
13:04 <vmassol> ie have a design that doesn't lead to potential failures
13:04 <Enygma`> well, it is kind of wrong IMO to instantiate the PO if you are not on that page yet
13:05 <Enygma`> on the other side, it's also kind of wrong to have failing constructors as well :/
13:06 <Denis> has quit
13:06 <Enygma`> the "best" way is to only *manually* use the call to waitUntilPageJSIsLoaded() when needed... but that will *guarantee* that people will forget to use it every time and we`ll still have flickers because of that
13:06 <Enygma`> since we need it in a lot of places and it`s not always obvious
13:07 <Enygma`> and then we have this test that does something without JavaScript http://ci.xwiki.org/job/xwiki-enterprise-test-ui/org.xwiki.enterprise$xwiki-enterprise-test-ui/59/testReport/junit/org.xwiki.test.ui/CommentAsGuestTest/testPostCommentAsGuestNoJs/ which spoils the fun
13:08 <Enygma`> getUtil().gotoPage(getTestClassName(), getTestMethodName(), "view", "xpage=xpart&vm=commentsinline.vm");
13:08 <Enygma`>         CommentsTab commentsTab = new CommentsTab();
13:08 <Enygma`> the problem here is that CommentsTab extens ViewPage, when instead it should extend BaseElement or something
13:08 <Enygma`> since it's not a page, it`s just an element in a page.
13:31 <Denis> has joined #xwiki
13:49 <Pbas> has joined #xwiki
13:50 <ClemensR> has joined #xwiki
13:51 <sdumitriu2> has joined #xwiki
14:19 <polx> has quit
14:22 <polx> has joined #xwiki
14:59 <andreeapopescu> has left #xwiki
15:07 <msmeria> has quit
15:20 <DarkKnightCZ> has quit
15:28 <tmortagne> has quit
15:29 <tmortagne> has joined #xwiki
15:31 <sdumitriu2> has quit
15:32 <sdumitriu2> has joined #xwiki
15:36 <tmortagne1> has joined #xwiki
15:37 <tmortagne> has quit
15:37 <cjd> mm is it normal that a scheduler job is not active when the document is imported ?
15:37 <cjd> I exported an active scheduler job and then import it and it doesn't seem to be triggering
16:00 <sdumitriu2> has quit
16:00 <OSIMasson> has joined #xwiki
16:02 <sdumitriu2> has joined #xwiki
16:03 <sdumitriu2> has quit
16:05 <sdumitriu2> has joined #xwiki
16:07 <sdumitriu2> has quit
16:09 <sdumitriu2> has joined #xwiki
16:18 <lucaa> has quit
16:18 <sdumitriu2> has quit
16:19 <sdumitriu2> has joined #xwiki
16:29 <Enygma`> vmassol: here's what I got while trying to run tests from a maven command line what I had an XWiki instance started in the background: http://hastebin.com/nujunowuni.vhdl
16:29 <sdumitriu2> has quit
16:30 <KermitTheFragger> has quit
16:31 <Enygma`> looks like a race condition
16:31 <vmassol> where?
16:32 <vmassol> looks ok to me
16:32 <vmassol> hmm you're right
16:32 <vmassol> this lines is happening too soon:
16:32 <vmassol> 17:23:28.727 [main] INFO  o.x.test.integration.XWikiExecutor - Server is answering to [http://localhost:8080/xwiki/bin/get/Main/]... cool
16:33 <Enygma`> yep, before the stop script does its job
16:33 <Enygma`> and I see there up to 3 threads : main, 1 and 2
16:33 <vmassol> but I don't understand why
16:33 <momomomomo> has joined #xwiki
16:33 <vmassol> I see 2 threads which is normal
16:34 <Enygma`> [main] [Thread-1] [Thread-2]
16:34 <vmassol> ok indeed I see why it can fail
16:34 <Enygma`> though from the logs, 2 seems to be a rename of 1
16:35 <vmassol> makes sense
16:35 <vmassol> XWikiExecutor runs start_xwiki.sh in a separate thread
16:35 <Enygma`> right
16:35 <vmassol> and waits by pinging
16:35 <vmassol> so it can reply before start_xwiki.sh stops the -existing instance
16:36 <vmassol> we should instead wait till the timeout
16:36 <vmassol> or till it finishes (exit code)
16:36 <Enygma`> can I do this to reuse my running instance? -Dxwiki.test.verifyRunningXWikiAtStart=false
16:37 <vmassol> yes
16:37 <vmassol> it needs to be true
16:37 <vmassol>         if (VERIFY_RUNNING_XWIKI_AT_START.equals("true")) {
16:37 <vmassol>     public static final String VERIFY_RUNNING_XWIKI_AT_START =
16:37 <vmassol> it's set to false in our pom
16:38 <vmassol> creating jira
16:40 <Enygma`> ah, I have to set it to true :)
16:41 <vmassol> XWIKI-11086
16:41 <Enygma`> cool
16:51 <Enygma`> vmassol: I seem to be reproducing http://ci.xwiki.org/job/xwiki-platform-6.2.x/lastBuild/org.xwiki.platform$xwiki-platform-activeinstalls-client-api/testReport/org.xwiki.activeinstalls.internal.client/DefaultPingSenderIntegrationTest/sendPingThroughProxy/ locally on master
16:52 <Enygma`> even if on ci I see no problem reported for xwiki-platform
16:52 <Enygma`> and I have no port 80 opened
16:53 <momomomomo> has quit
17:03 <gdelhumeau> I have to go
17:03 <gdelhumeau> has quit
17:04 <vmassol> Enygma`: ok I think I know how to fix it (XWIKI-11086), working on it
17:05 <momomomomo> has joined #xwiki
17:09 <lucaa> has joined #xwiki
17:09 <ClemensR> has left #xwiki
17:10 <benoitc_> is now known as <benoitc>
17:10 <benoitc> has quit
17:16 <sdumitriu1> vmassol: Did you get a chance to look at that code?
17:22 <vmassol> sdumitriu: sorry but no
17:22 <vmassol> and my work stack is pretty large right now, at least for a few days
17:22 <vmassol> (bugs to fix)
17:22 <vmassol> (important ones)
17:48 <mflorea> has quit
17:59 <woshilapin> has quit
18:00 <cjd> has quit
18:10 <tekzilla> has quit
18:12 <tekzilla> has joined #xwiki
18:16 <tekzilla> has quit
18:17 <tekzilla> has joined #xwiki
18:24 <evalica> has quit
18:28 <Enygma`> has quit
18:32 <momomomomo> has quit
18:33 <tmortagne1> has quit
18:36 <momomomomo> has joined #xwiki
18:43 <polx> has quit
18:55 <momomomomo> has quit
18:56 <momomomomo> has joined #xwiki
19:00 <lucaa> has quit
19:07 <polx> has joined #xwiki
19:43 <polx> has quit
19:45 <polx> has joined #xwiki
19:51 <polx> has quit
20:09 <mflorea> has joined #xwiki
20:14 <tmortagne> has joined #xwiki
20:14 <tmortagne> has left #xwiki
20:41 <polx> has joined #xwiki
20:43 <polx> has quit
20:55 <momomomomo> has quit
21:00 <polx> has joined #xwiki
21:10 <polx_> has joined #xwiki
21:11 <polx> has quit
21:11 <polx_> is now known as <polx>
21:12 <Denis> has quit
21:23 <mflorea> has quit
21:29 <Denis> has joined #xwiki
21:42 <mflorea> has joined #xwiki
22:20 <drapo> has joined #xwiki
22:27 <drapo> has quit
22:29 <vmassol> has quit
22:44 <abusenius> has joined #xwiki
23:07 <Denis> has quit
23:18 <mflorea> has quit
23:39 <abusenius> has quit
Tags:
   

Get Connected