IRC Archive for channel #xwiki on 22 October 2014

Last modified by Vincent Massol on 2014/10/22 23:59

<xwikibot> has joined #xwiki
12:21 <vmassol> guys, one thing I noticed yesterday on dev.xwiki.org when I upgraded
12:21 <vmassol> I had to modify the home page
12:21 <vmassol> it was using:
12:21 <vmassol> #includeInContext("Community.WebHome")
12:21 <vmassol> and the icons were broken
12:22 <vmassol> the page was in syntax 1.0
12:22 <vmassol> so it seems we have some regression somewhere
12:22 <tmortagne> evalica: ok with you if I release idea application ? I would like to update my wiki with the fix you did but asking in case there is other things you want to fix before
12:22 <vmassol> between 5.4.3 and 6.2.2
12:22 <vmassol> I moved the page to syntax 2.1 and used {{display reference="Community.WebHome"/}}
12:22 <vmassol> will try to reproduce later on
12:36 <Lyes> has quit
13:09 <DarkKnightCZ> has quit
13:10 <DarkKnightCZ> has joined #xwiki
13:14 <gdelhumeau> Enygma`: I have fixed the failing test (http://jira.xwiki.org/browse/XWIKI-11306)
13:21 <evalica> has quit
13:25 <evalica> has joined #xwiki
13:25 <evalica> tmortagne: you can release it, I don't know if there are multiple issues on Flamingo, let me look 3 secons
13:29 <evalica> tmortagne: give 30 min pls for idea
13:35 <vmassol1> has joined #xwiki
13:38 <vmassol> has quit
13:40 <Lyes> has joined #xwiki
13:49 <vmassol1> restarting xwiki.org
13:54 <vmassol> wiki.org is back
13:58 <Lyes> has quit
14:12 <tmortagne> evalica: ok
14:35 <woshilapin> has quit
14:36 <Enygma`> gdelhumeau: cool. Would be interesting if we could extend the dom to add a deprecation console.log message to devs depending on the meta tags :)
14:37 <woshilapin> has joined #xwiki
14:43 <andreeapopescu> has quit
14:49 <Lyes> has joined #xwiki
15:18 <DarkKnightCZ> has quit
15:33 <OSIMasson> has joined #xwiki
15:37 <Lyes> has quit
15:38 <Lyes> has joined #xwiki
15:42 <msmeria1> has quit
15:48 <Lyes> has quit
15:54 <Lyes> has joined #xwiki
15:59 <Lyes> has quit
16:01 <Lyes> has joined #xwiki
16:07 <Lyes> has quit
16:09 <Lyes> has joined #xwiki
16:09 <gdelhumeau> mflorea: tmortagne: Enygma`: I am wondering if I can change thet way xwiki.getSkinFile generates an URL
16:09 <gdelhumeau> all the details are there: http://jira.xwiki.org/browse/XWIKI-11300?focusedCommentId=83263&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-83263
16:09 <gdelhumeau> do you have an opinion?
16:11 <tmortagne> I did not knew skin action was supporting http://extensions.xwiki.org/xwiki/bin/skin/xwiki/XWikiOrgCode/Skin/style.css syntax
16:11 <vmassol> it doesn't
16:11 <tmortagne> so it's not only about getSkinFile then
16:11 <vmassol> that's what gdelhumeau is proposing AFAIK
16:11 <vmassol> (in option 4)
16:12 <tmortagne> gdelhumeau: what is the proposal exactly ?
16:12 <Slashman> has joined #xwiki
16:13 <gdelhumeau> add the wiki in the URL, just before the space
16:13 <gdelhumeau> like this: /skin/wiki/space/page
16:13 <tmortagne> so modify skin action behavior and url factory ?
16:13 <gdelhumeau> instead of /skin/space/page
16:13 <gdelhumeau> yes
16:13 <gdelhumeau> could be  dangerous thought
16:13 <tmortagne> yes it could
16:13 <vmassol> personally I don't like it too much since we're supposed to find the wiki either in the domain or in the /wiki/<wiki>/ path
16:14 <tmortagne> hwo would you make the difference between http://extensions.xwiki.org/xwiki/bin/skin/xwiki/XWikiOrgCode/Skin/style.css and http://extensions.xwiki.org/xwiki/bin/skin/XWikiOrgCode/Skin/style.css
16:14 <gdelhumeau> I won't
16:14 <tmortagne> or do you propose to always have he wiki part in the URL ?
16:14 <gdelhumeau> yes
16:15 <tmortagne> so breaking any existing URL that did not go trough URL factory (but I guess we can justify it)
16:15 <gdelhumeau> exactly
16:16 <gdelhumeau> it has sense only when path-based mode is disabled BTW
16:16 <tmortagne> now without talking about browser security and stuff like this I don't like too much the logic of a URL like http://extensions.xwiki.org/xwiki/bin/skin/extensions/XWikiOrgCode/Skin/style.css
16:16 <gdelhumeau> with path-based, we would have the wiki twice
16:16 <vmassol> even in domain base the wiki is also twie
16:16 <vmassol> twice
16:17 <tmortagne> gdelhumeau: do you mean that in your proposal skin action does not behave the same if path based is enabled ?
16:17 <gdelhumeau> actually I don't like the logic of an url doing:  http://www.xwiki.org/xwiki/bin/skin/XWikiOrgCode/Skin/style.css?colorTheme=extension:ColorThemes.MyColorTheme
16:17 <gdelhumeau> no no, I don't mean that
16:17 <gdelhumeau> I only mean that it would look less good in path-based
16:18 <tmortagne> it's not really worst
16:18 <tmortagne> you have the wiki twice in both cases
16:18 <tmortagne> which is the thing I don't like too much
16:18 <gdelhumeau> but do you think the URL I have pasted just before is good?
16:18 <tmortagne> so all that is just for fonts, right ?
16:19 <gdelhumeau> yes tmortagne...
16:19 <tmortagne> any idea why browsers have this security about fonts only ?
16:20 <gdelhumeau> and AJAX calls too
16:20 <gdelhumeau> for AJAX it make sense
16:20 <tmortagne> yes for AJAX I can understand
16:20 <gdelhumeau> but for fonts... I don't know
16:21 <gdelhumeau> http://schock.net/articles/2013/07/03/hosting-web-fonts-on-a-cdn-youre-going-to-need-some-cors/
16:22 <tmortagne> gdelhumeau: I don't have anything against http://www.xwiki.org/xwiki/bin/skin/XWikiOrgCode/Skin/style.css?colorTheme=extension:ColorThemes.MyColorTheme
16:22 <gdelhumeau> ok
16:23 <tmortagne> the URL is pretty clear
16:23 <tmortagne> you want the skin located on main wiki with a custom color theme
16:23 <tmortagne> and that's the URL for the main wiki
16:23 <gdelhumeau> so the other fix is 2) via the webjar action or via a servlet filter
16:24 <tmortagne> not sure I see what http://www.xwiki.org/xwiki/bin/skin/XWikiOrgCode/Skin/style.css?colorTheme=extension:ColorThemes.MyColorTheme has to do with a webjar
16:28 <Enygma`> gdelhumeau: so in the previous skin, we were able to use in a subwiki a skin defined in the main wiki, because we were not using fonts? And now with flamingo, we need fonts to display icons and hence the problem?
16:29 <OSIMasson> has quit
16:33 <vmassol> yes
16:33 <vmassol> (Enygma`)
16:33 <vmassol> fonts have cross-domain protection apparently
16:33 <mflorea> gdelhumeau: you could load the font from the "target" wiki, so you need to pass the target wiki in the URL
16:34 <mflorea> i.e. in the css you have in the main wiki, compute the font URL dynamically, based on a request parameter that specified the target wiki
16:35 <mflorea> this way you load the css from the main wiki but the font is loaded through the subwiki that is specified in the URL
16:36 <gdelhumeau> the font is loaded by a bootstrap class
16:36 <gdelhumeau> but I can override it
16:36 <mflorea> you specify the font URL don't you?
16:36 <gdelhumeau> in a variable
16:37 <gdelhumeau> in a LESS variable
16:37 <gdelhumeau> and then the skin is cached
16:39 <Lyes> has quit
16:40 <mflorea> ok, but if you can overwrite it then you just need a (1) a way to pass the "target" wiki on the URL and (2) build the font URL using the specified wiki. One issue I see is that the font is loaded from webjar and you cannot specify the wiki when you get the webjar URL
16:41 <Lyes> has joined #xwiki
16:41 <mflorea> now, the CSS that loads the font is in the main wiki skin document or is it in the file system?
16:43 <mflorea> I mean, is the font loaded directly by XWikiOrgCode.Skin or does it load another css which then loads the font. In other words, the @font-face rule is in XWikiOrgCode.Skin or in the file system?
16:43 <mflorea> if it is in the file system then you may be able to load that css from the file system through the subwiki
16:44 <mflorea> i.e. the subwiki loads the skin from the main wiki (xwiki:XWikiOrgCode.Skin) but the skin from the main wiki loads the fiile system resources by going through the subwiki (which is specified on the URL)
16:52 <Lyes> has quit
16:54 <Lyes> has joined #xwiki
16:59 <gdelhumeau> mflorea: it is from style.css of XWikiOrgCode.Skin
16:59 <gdelhumeau> because it is customized
17:02 <silverdrop> has quit
17:18 <vmassol> hmmm searchsuggest is not displaying correctly on the main wiki: http://www.xwiki.org/xwiki/bin/view/Main/WebHome
17:18 <vmassol> see https://www.evernote.com/shard/s119/sh/1097ded6-c00c-4637-ae27-041175d06c1c/1f025a4e73b156c038db0a9235cee38c
17:18 <OSIMasson> has joined #xwiki
17:18 <silverdrop> has joined #xwiki
17:18 <vmassol> I wonder why
17:23 <gdelhumeau> mflorea: I think your solution is complicated, and we will have to do it at each bootstrap upgrade, or for any font loaded this way
17:24 <mflorea> gdelhumeau: do you have to overwrite the font-face in XWikiOrgCode.Skin?
17:24 <gdelhumeau> I don't understand
17:24 <mflorea> why do you load the font directly in XWikiOrgCode.Skin?
17:25 <gdelhumeau> it does not. It does: $services.lesscss.compileSkinFile('style.less.vm')
17:25 <gdelhumeau> which load the font
17:26 <gdelhumeau> it returns a CSS code, and that CSS code loads the font
17:26 <gdelhumeau> so for the browser, it is  XWikiOrgCode.Skin which loads the font
17:32 <vmassol> mflorea: would you know how to debug the problem of searchsuggest on http://extensions.xwiki.org/xwiki/bin/view/Main/WebHome ?
17:32 <mflorea> what problem?
17:32 <vmassol> try it
17:32 <vmassol> it doesn't open for me
17:32 <vmassol> just some white horizontal bar
17:33 <mflorea> yes, it never worked since we have the search code on the main wiki
17:33 <vmassol> it does work for test.xwiki.org though
17:33 <vmassol> the searhc code is on e.x.o too
17:33 <vmassol> there are 2 subwikis which have the search code: exo and test
17:39 <xwikibot> has joined #xwiki
17:43 <mflorea> vmassol: check if there are any search suggest sources configured. I cannot checked right now because xwiki.org is unresponsive
17:44 <vmassol> yeah ok, I'll check once it restarts or becomes responsive , thanks
17:45 <vmassol> mflorea: looks ok: http://extensions.xwiki.org/xwiki/bin/edit/XWiki/SearchSuggestConfig?editor=object
17:45 <vmassol> 14 sources
17:46 <vmassol> btw
17:46 <vmassol> objects 14 and 15 looks the same
17:46 <vmassol> platform.search.suggestSourceWikis
17:46 <vmassol> ah no
17:46 <vmassol> one is for lucene and the other for solr
17:46 <vmassol> they just have the same name
17:59 <tmortagne> has quit
18:00 <mflorea> vmassol: http://extensions.xwiki.org/xwiki/bin/skin/resources/uicomponents/search/searchSuggest.js?minify=false
18:00 <mflorea> var sources = [];
18:00 <mflorea> no sources for some reason
18:00 <cjd> has quit
18:01 <mflorea> the real version http://extensions.xwiki.org/xwiki/resources/uicomponents/search/searchSuggest.js
18:01 <mflorea> #set ($searchSuggestConfig = $xwiki.getDocument('XWiki.SearchSuggestConfig'))
18:01 <mflorea> #foreach ($source in $searchSuggestConfig.getObjects('XWiki.SearchSuggestSourceClass'))
18:04 <mflorea> vmassol: http://extensions.xwiki.org/xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Search
18:04 <mflorea> database search is selected
18:04 <mflorea> and it's the only option
18:04 <mflorea> so something is missing
18:04 <vmassol> indeed
18:05 <mflorea> well, search application is installed, but not the solr/lucene apps
18:05 <Lyes> has quit
18:06 <vmassol> ok thanks I'll add them and create a jira issue
18:07 <vmassol> hmm
18:07 <vmassol> Solr searh app is installed
18:08 <vmassol> hmhm no
18:08 <vmassol> something is strange
18:08 <vmassol> checking something
18:09 <mflorea> I don't see it
18:09 <vmassol> http://extensions.xwiki.org/xwiki/bin/view/Extension/Solr+Search+Application
18:09 <mflorea> and afaik, we decided to use the search from the main wiki so it's kind of normal that solr is not installed on subwikis
18:09 <vmassol> latest version is 6.1
18:09 <vmassol> strange
18:09 <vmassol> mflorea: no
18:09 <vmassol> that's true except for 3 wikis:
18:09 <vmassol> exo, test and design
18:10 <mflorea> ok
18:10 <mflorea> indeed, solr search app extension page is not up to date
18:10 <vmassol> checking id
18:11 <vmassol> id is ok
18:11 <vmassol> now it's ok, very strange
18:11 <vmassol> I don't understand why the scheduler job didn't update it
18:13 <vmassol> works now, thanks for your help mflorea
18:13 <mflorea> np
18:15 <vmassol> created http://jira.xwiki.org/browse/XWIKI-11312
18:20 <woshilapin> has quit
18:20 <vmassol> has quit
18:24 <evalica> has quit
18:26 <Enygma`> has quit
18:29 <gdelhumeau> has quit
18:44 <KermitTheFragger> has quit
19:02 <lucaa> has quit
19:03 <Slashman> has quit
19:10 <OSIMasson> has quit
19:12 <mflorea> has quit
19:31 <vmassol> has joined #xwiki
19:37 <OSIMasson> has joined #xwiki
20:09 <OSIMasson> has quit
20:09 <OSIMasson> has joined #xwiki
20:15 <OSIMasson> has quit
20:22 <abusenius> has joined #xwiki
21:14 <lucaa> has joined #xwiki
21:27 <silverdrop> has quit
21:37 <vmassol> has quit
22:52 <lucaa> has quit
23:59 <lucaa> has joined #xwiki

Get Connected