IRC Archive for channel #xwiki on 03 August 2015

Last modified by Vincent Massol on 2015/08/03 23:50

<abusenius> has quit
03:44 <spawn57> has quit
06:56 <mflorea> has joined #xwiki
08:03 <mflorea> has quit
08:09 <DarkKnightCZ> has joined #xwiki
08:48 <DarkKnightCZ> has quit
08:51 <KermitTheFragger> has joined #xwiki
08:57 <tmortagne> has joined #xwiki
09:05 <Slashman> has joined #xwiki
09:18 <mflorea> has joined #xwiki
09:37 <woshilapin> has joined #xwiki
09:39 <vmassol> has joined #xwiki
09:44 <vmassol> good morning
09:57 <woshilapin> has quit
10:08 <vmassol> fyi this morning I'll test Edy's change for the script permission
10:14 <vmassol> I guess we should remove the jobs related to the script permissiosn from jenkins
10:14 <vmassol> and the branch
10:16 <tmortagne> if it's merged then yes we should get rid of them
10:17 <vmassol> checking if it works first
11:03 <vmassol> cool the new script right seems to be work fine :)
11:04 <vmassol> (I hope there are not too many side effects)
11:04 <vmassol> removing branch + jobs
11:09 <vmassol> done
11:10 <vmassol> hmmm I really don't see how this can happen: http://ci.xwiki.org/job/xwiki-rendering-testrelease/12/console
11:10 <vmassol> restarting the job
11:12 <vmassol> hmm same here, I don't see what has changed: http://ci.xwiki.org/job/xwiki-commons_Sonar/362/#showFailuresLink
11:19 <vmassol> mflorea: is this a false positive: http://ci.xwiki.org/job/xwiki-platform/org.xwiki.platform$xwiki-platform-wysiwyg-test-tests/1663/testReport/org.xwiki.wysiwyg.test.ui/EditWYSIWYGTest/testUndoRepeatedPaste/ ? Seems we have quite a few on the wysiwyg
11:20 <mflorea> age 5, it may be a real problem
11:20 <vmassol> we have the same error on the 6.4 branch
11:20 <vmassol> http://ci.xwiki.org/job/xwiki-platform-6.4.x/org.xwiki.platform$xwiki-platform-wysiwyg-test-tests/276/testReport/org.xwiki.wysiwyg.test.ui/EditWYSIWYGTest/testUndoRepeatedPaste/
11:21 <mflorea> I don't remember seeing this test fail in the past
11:21 <vmassol> we don't have it on the 7.1.x branch though
11:22 <mflorea> hmm, it failed for 13 times, then it passed 2 times, and then 6 failues
11:22 <mflorea> s/2/3 times
11:22 <vmassol> a false positive that fails often then :)
11:23 <mflorea> something must have triggered the repeated failures, I don't remember seeing this test failed before
11:24 <mflorea> deserves some investigation
11:24 <vmassol> 11 test failures for test-ui that's a lot: http://ci.xwiki.org/job/xwiki-enterprise-test-ui/lastBuild/testReport/
11:25 <vmassol> I'll check http://ci.xwiki.org/job/xwiki-enterprise-test-ui/lastBuild/org.xwiki.enterprise$xwiki-enterprise-test-ui/testReport/org.xwiki.test.ui/CreatePageTest/testCreatePageFromTemplate/
11:26 <vmassol> ok easy to fix
11:26 <vmassol> the issue for this one is the breadcrumb
11:27 <vmassol> the test is looking for "Wiki Home" in the breadcrumb
11:27 <vmassol> fixing
11:28 <vmassol> actually the test needs to be rewritten a bit I think since it sets parents
11:28 <vmassol> hmm we need to review all tests that sets parents actually
12:11 <vmassol> guys I propose to move the CreatePageTest func test currently located in enteprrise-test-ui to platform admin func test module since it's about "Tests page creation using a Template Provider and a Template." ok for you?
12:12 <vmassol> (tmortagne, mflorea)
12:12 <vmassol> if you're ok I'll do that after lunch
12:13 <mflorea> fine with me
12:13 <tmortagne> ok
12:14 <vmassol> k
12:14 <vmassol> hmm Guillaume has not added tests for the breadcrumbs…
12:15 <vmassol> he's actually caused some false positive….
12:15 <vmassol> (in his changes for BreadcrumbsTest
12:16 <vmassol> bbl
12:18 <martinus__> has joined #xwiki
12:18 <martinus__> hi cjd are you around ?
12:18 <ol-ow2> has joined #xwiki
12:18 <martinus__> or maybe tmortagne
12:19 <martinus__> we are trying to install totem app in a child wiki , as Admin, and we get 'Programming right is required to install extension' ?
12:20 <martinus__> this one http://extensions.xwiki.org/xwiki/bin/view/Extension/TotemApplication
12:20 <tmortagne> martinus__: it means you are trying to install a JAR, which require PR
12:20 <tmortagne> totem app itself is a XAR but it depends on several jars as far as I can see
12:21 <martinus__> tmortagne, what we don't understand is we are using the Admin user which is expected to have PR ?
12:21 <tmortagne> so will need someone who have programming right to install those (or only the dependencies)
12:21 <tmortagne> is this main wiki Admin user ?
12:21 <martinus__> yes
12:22 <tmortagne> you should probably check its rights (it's not because you are admin that you have PR)
12:23 <tmortagne> you could also check in a page to use something that require PR like groovy
12:23 <martinus__> let me verify that; as a side note, we are able to install the extension in the main wiki with that same Admin user
12:23 <tmortagne> are you really sure you are using the same user ?
12:23 <martinus__> that's the question
12:23 <martinus__> lets verify this :)
12:24 <tmortagne> just click on the user profile and you'll see
12:24 <tmortagne> seems to be you are using the subwiki Admin user
12:24 <martinus__> clicking the profile redirects to the main wiki user's profile (no to the subwiki user profile)
12:25 <tmortagne> installing from main wiki or subwiki does not make any difference for EM since it's always running in a background thread which have main wiki in its context
12:26 <tmortagne> do you have more detail in the error ? some stack trace in the extension log with the actual user reference
12:26 <martinus__> yes we have
12:27 <tmortagne> another possibility is that the author of the Extension UI page in the subwiki does not have PR
12:27 <tmortagne> both context user and context author need PR (as otherwise anyone could install anything just by waiting for the right current user)
12:28 <martinus__> tmortagne, http://pastebin.com/pg6um72K
12:29 <tmortagne> mflorea: any idea what is the current page when install/continue is executed from EM UI ?
12:30 <mflorea> XWiki.AddExtensions probably
12:31 <tmortagne> martinus__: if you are 100% sure the current user is right then it probably means the wiki page user to start the install does not have a PR user
12:32 <mflorea> i.e. the document that displays the EM administration section
12:32 <martinus__> tmortagne, bingo. The Xwiki.AddExtensions : wrong author.
12:33 <martinus__> thanks mflorea
12:33 <mflorea> you're welcome
13:14 <woshilapin> has joined #xwiki
14:03 <martinus__> has quit
14:42 <vmassol> hi devs, just sent a proposal for locating func tests that don't need wiki pages (i.e tests that test the skin)
14:42 <vmassol> I've brainstormed it with tmortagne so I know he's ok
14:42 <vmassol> mflorea: I'd like to have your quick opinion since I'm about to start implementing it for moving some exsiting func tests (and fix them at the same time)
14:43 <mflorea> let me check
14:43 <vmassol> thx
14:54 <mflorea> vmassol: answered
14:54 <vmassol> thx
15:07 <mflorea> vmassol, tmortagne: I'll add $services.model.createDocumentReference($name, $spaceReference). Anything against it? It's quite useful because I often need to resolve the local space reference and then create the document ref from the doc name and the space ref
15:08 <vmassol> so it would be a shortcut for createEntityReference($name, 'DOCUMENT', $spaceReference) ?
15:08 <tmortagne> we have this for other type of references in the script service as well as in DocumentReference itself so it makes sense yes
15:08 <tmortagne> vmassol: it's not exactly the same thing since you don't get exactly the same object
15:09 <vmassol> yeah you get a DocumentReference
15:09 <vmassol> (istead of an EntityReference)
15:09 <vmassol> ok for me
15:09 <mflorea> vmassol: yes, the problem with createEntityRef is that the result is not typed and I need a DocRef to pass to various methods
15:09 <vmassol> initially I wanted this SS api to be small and simple but I guess over time it'll become the same as the java api :)
15:09 <tmortagne> mflorea: note that it should not be a problem with the DocumentReference converter
15:10 <tmortagne> but anyway it makes sense
15:10 <tmortagne> (converters are not about String, you can convert anything to anything)
15:10 <mflorea> tmortagne: are you sure it will convert an EntityReference with type=DOCUMENT to a DocumentReference ?
15:11 <mflorea> let me check
15:11 <tmortagne> https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-model/src/main/java/org/xwiki/model/internal/reference/converter/DocumentReferenceConverter.java
15:11 <tmortagne> when it's a EntityReference it resolve it
15:11 <mflorea> cool
15:11 <tmortagne> so it should cover your use case
15:11 <mflorea> it should yes, let me try
15:12 <tmortagne> makes me think I should modify it to use the same resolver than XWiki#getDocument
15:57 <Slashman> has quit
17:17 <vmassol> good that I'm testing page/space creation, finding bugs...
17:18 <KermitTheFragger> has quit
17:20 <vmassol> actually it's not a bug apparently since it's also there in 7.1.1
17:20 <vmassol> the issue is that http://localhost:8080/xwiki/bin/create/SomeSpace/SomePage?tocreate=space doesn't show the space creation UI
17:20 <vmassol> it directly edits the passed doc (SomeSpace.SpacePage)
17:20 <vmassol> any idea why we would want this?
17:21 <vmassol> should I raise a big?
17:21 <vmassol> *bug
17:31 <vmassol> no idea tmortagne or mflorea?
17:32 <tmortagne> I don't know this action very well
17:32 <vmassol> me neither  :)
17:32 <vmassol> it looks strange that create space would just edit the current document
17:33 <tmortagne> I think CreateAction lead you to edit when the document already exist, assuming to made a mistake when you used create action
17:33 <tmortagne> s/to made/you made.
17:33 <vmassol> it's the opposite
17:34 <vmassol> if you're on a page that exists create action will correctly ask you for the space name
17:34 <vmassol> it's when you're on a non existent page that create action just edits it
17:34 <vmassol> without asking the space
17:34 <mflorea> has quit
17:34 <mflorea1> has joined #xwiki
17:34 <tmortagne> and it works without tocreate=space ?
17:35 <vmassol> ok I get the logic (I think)
17:35 <vmassol> except that it's wrongly implemented
17:35 <mflorea> has joined #xwiki
17:35 <vmassol> basicalyl the create action assume you want to create the current page if it doesn't exist
17:36 <vmassol> and if it exists it asks you for the which page/space to create
17:36 <vmassol> but when the page doesn't exist, tocreate=space will not create the space
17:36 <vmassol> it'll create the page passed in the url
17:37 <vmassol> (instead of a WebHome)
17:37 <vmassol> thus ignoring tocreate=space in practice
17:42 <vmassol> hmm I need to understand why I get this ui: https://www.evernote.com/l/AHcMlM-IwNJGQIf0y7q_X-irSRQee8M-bwM
17:48 <woshilap1n> has joined #xwiki
17:50 <woshilapin> has quit
17:59 <mflorea> has quit
18:21 <vmassol> has quit
18:28 <vmassol> has joined #xwiki
18:30 <ol-ow2> has quit
18:31 <tmortagne> has quit
18:38 <vmassol> has quit
18:48 <vmassol> has joined #xwiki
19:16 <woshilap1n> has quit
19:28 <Slashman> has joined #xwiki
20:03 <abusenius> has joined #xwiki
20:08 <Slashman> has quit
21:19 <woshilapin> has joined #xwiki
23:25 <xwikiorg_guest_7> has joined #xwiki
23:26 <woshilapin> has quit
23:26 <xwikiorg_guest_7> A space is created when select create a page in xwiki 7.2
23:26 <xwikiorg_guest_7> Is it a bug??
23:30 <cjd> hmm in <= 7.1 if you create a page in a space which does not exist, the space comes to exist
23:30 <cjd> but in >= 7.2, spaces and pages are the same thing
23:31 <xwikiorg_guest_7> in 7.2 only if I select the option of terminal page thge
23:31 <xwikiorg_guest_7> page is created inside the space
23:31 <cjd> terminal page should cause a page to be created rather than a (nested) space
23:32 <xwikiorg_guest_7> for example if I have a space named support and If I create a page in it
23:32 <xwikiorg_guest_7> it comes as support.testpage
23:32 <xwikiorg_guest_7> instead of support/testpage
23:33 <cjd> in the URL for the web browser ?
23:33 <xwikiorg_guest_7> like the structure
23:33 <xwikiorg_guest_7> support.testpage is a space and it has its own webhome
23:34 <cjd> with "terminal page" unchecked, that's expected behavior
23:34 <xwikiorg_guest_7> okay
23:34 <cjd> with "terminal page" checked, that's a bug
23:34 <xwikiorg_guest_7> then what is the point of having documents inside the page?
23:34 <xwikiorg_guest_7> *space
23:35 <cjd> additional extensibility
23:35 <cjd> Already a wiki page can have objects, attachments, comments, etc
23:35 <cjd> now it can also have pages
23:37 <cjd> For your usage, you might think of it as future proofing - a project, customer or other entity referenced by one of your pages now might become so complex that you need to have multiple pages about different aspects of it in the future
23:38 <xwikiorg_guest_7> it would be nice if there are nested spaces
23:38 <xwikiorg_guest_7> also in addition to this
23:38 <xwikiorg_guest_7> so it gives more extensibility
23:39 <cjd> technically this is nested spaces
23:39 <cjd> but it's presented to the user as nested pages
23:39 <xwikiorg_guest_7> okay
23:40 <xwikiorg_guest_7> it is rather confusing since documentation is not very clear
23:41 <xwikiorg_guest_7> please  update the space references so it will be easier for all
23:41 <cjd> This is an ongoing problem but what can help with this is people like yourself writing what you learn on the xwiki.org wiki
23:41 <xwikiorg_guest_7> yes for sure
23:41 <xwikiorg_guest_7> thanks @cjd
23:42 <cjd> sure thing
23:50 <xwikiorg_guest_7> has quit
Tags:
   

Get Connected