IRC Archive for channel #xwiki on 27 August 2015

Last modified by Vincent Massol on 2015/08/27 23:01

<Chuguniy> has quit
00:52 <vmassol> cjd: zipexplorer plugin should work again now (for non-nested spaces)
00:52 <cjd> thanks
00:52 <vmassol> backward compat restored!
00:52 <vmassol> thanks for noticing this issue!
00:53 <cjd> that's a place where it's rather important
00:53 <vmassol> fix was a bit complex...
00:53 <vmassol> I probably introduced several bugs in the process :)
00:53 <cjd> we could drop a whole lot of API functions over-night without anyone noticing, dropping that == people notice...
00:54 <vmassol> going to bed now!
00:54 <vmassol> nn
00:54 <cjd> gn
00:54 <vmassol> has quit
01:19 <abusenius_> has quit
01:40 <Trefex> has quit
02:05 <Chuguniy> has joined #xwiki
04:33 <cpe> has quit
04:34 <cpe> has joined #xwiki
05:33 <_cjd> has joined #xwiki
05:36 <mflorea> has joined #xwiki
05:37 <cjd> has quit
07:24 <msmeria> has joined #xwiki
07:59 <sorinello> has joined #xwiki
08:21 <_cjd> has quit
08:42 <Ramona1> has joined #xwiki
08:55 <vmassol> has joined #xwiki
09:09 <gsmeria> has joined #xwiki
09:15 <_cjd> has joined #xwiki
09:21 <vmassol> good morning
09:21 <_cjd> gm
09:22 <vmassol> just sent a postpone release mail
09:22 <vmassol> as I don't see how we can release today 7.2M3
09:22 <vmassol> hi _cjd
09:28 <mflorea> has quit
09:32 <vmassol> taking http://jira.xwiki.org/browse/XWIKI-12406
09:33 <tmortagne> has joined #xwiki
09:35 <martin-h> has quit
09:36 <martin-h> has joined #xwiki
09:48 <Enygma`> has joined #xwiki
09:49 <mflorea> has joined #xwiki
09:52 <Slashman> has joined #xwiki
10:07 <gdelhumeau> has joined #xwiki
10:19 <ClemensR> has joined #xwiki
10:22 <Pbas> has quit
10:35 <vmassol> has quit
10:38 <Pbas> has joined #xwiki
10:38 <vmassol> has joined #xwiki
10:42 <evalica> has joined #xwiki
11:21 <Enygma`> gdelhumeau: have you seen  http://jira.xwiki.org/browse/XWIKI-12427?focusedCommentId=87531&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-87531 ?
11:21 <gdelhumeau> yes looking at it
11:24 <Enygma`> http://localhost:8080/xwiki/bin/skin/skins/colibri/style.css seems to resolve fine
11:24 <Enygma`> but the ?skin=colibri parameter messes it up
11:34 <gdelhumeau> Enygma`: it's strange
11:34 <gdelhumeau> the LESS compiler is not supposed to be used in colibri/style.css
11:38 <Trefex> has joined #xwiki
11:42 <Enygma`> gdelhumeau:  as I`ve mentioned in the comment, the style.css is resolved to flamingo/style.css which calls the LESS compiler... but the LESS compiled then gets executed in the colibri skin folder and it fails
11:43 <gdelhumeau> indeed
11:43 <Enygma`> I`ll dig deeper then
11:43 <Enygma`> thought you might know something about it
11:44 <gdelhumeau> it seems it comes from the skin action
11:44 <tmortagne> has quit
11:51 <Slashman> has quit
11:58 <tmortagne> has joined #xwiki
11:59 <gdelhumeau> Enygma`: strange beheviour in SkinAction line 230
11:59 <gdelhumeau> the second argument of getSkinFilePath
12:00 <gdelhumeau> hhm or maybe the doc is not the good one
12:01 <Enygma`> I`m a bit in that direction too
12:01 <Enygma`> the usage doc.getSpace() and doc.getName() needs to be cleaned out pretty much everywhere in SkinAction
12:01 <Enygma`> going to lunch now
12:01 <Enygma`> bbl
12:01 <gdelhumeau> in my opinion the doc is not the good one ine SkinAction line 94
12:02 <gdelhumeau> doc: "skins.colibri.style\.css" says my debugger
12:05 <Slashman> has joined #xwiki
12:10 <gdelhumeau> it seems the SkinsResourceReferenceResolver is not used
12:14 <gdelhumeau> so for me it comes from XWiki#initializeResourceFromURL()
12:17 <vmassol> it's normal that SkinsResourceReferenceResolver is not used, it's not supposed to
12:18 <vmassol> AFAIR it's only used in the RoutingFilter
12:18 <vmassol> (in step 3)
12:19 <gdelhumeau> ok I'm in step 2
12:20 <vmassol> msmeria: thanks for updating the FAQ tutorial! :)
12:21 <msmeria> vmassol: you're welcome
12:38 <gdelhumeau> in any case vmassol, it seem XWiki#initializeResourceFromURL() is broken
12:38 <vmassol> what breakage?
12:39 <gdelhumeau> because the entity reference returned is not a skinresource reference
12:39 <vmassol> it's not supposed to be
12:39 <vmassol> "Extract the Entity Resource from the URL"
12:39 <vmassol> this is only for entity resources
12:40 <gdelhumeau> well it returns "type = [entity], parameters = [[skin] = [[colibri]], [colorTheme] = [[xwiki:ColorThemes.Azure]]], reference = [Document xwiki:skins.colibri.style\.css], action = [skin], locale = [<null>]" for the url http://localhost:8080/xwiki/bin/skin/skins/colibri/style.css?skin=colibri&colorTheme=xwiki%3AColorThemes.Azure
12:40 <gdelhumeau> which is obviously wrong
12:40 <vmassol> then the problem is not initializeResourceFromURL()
12:40 <vmassol> which is correct
12:40 <vmassol> it's something happening before that
12:41 <vmassol> does step 3 go inside the "if"?
12:41 <vmassol> (of RoutinfFilter)
12:41 <vmassol> we're talking about static resources right?
12:41 <gdelhumeau> wdym
12:41 <vmassol> see step 3
12:42 <gdelhumeau> it's a file containing velocity code in a fs skin
12:42 <vmassol> ok so not a static resource
12:42 <vmassol> so nothing to do with SkinsResourceReference
12:42 <vmassol> "Represents a reference to a static filesystem skin resource.
12:42 <gdelhumeau> we don't go in the step 3
12:43 <vmassol> skin action is different from the skins action
12:43 <vmassol> so normally there should be no handler
12:43 <vmassol> and it should go in step 4 inside the "if"
12:44 <gdelhumeau> yes it does
12:44 <vmassol> and thus it's normal that it reaches initializeResourceFromURL
12:44 <vmassol> as an Entity Resource
12:44 <vmassol> because xwiki considers "skin" action to be entities
12:45 <vmassol> ("bin" means entity)
12:45 <vmassol> so what's not working?
12:46 <gdelhumeau> In skinAction#render()
12:46 <gdelhumeau> line 94
12:46 <vmassol> you said above "which is obviously wrong" WDYM?
12:46 <gdelhumeau> XWikiDocument doc = context.getDoc();
12:46 <gdelhumeau> returns "skins.colibri.style\.css"
12:46 <vmassol> yes and?
12:47 <vmassol> oh I see
12:47 <vmassol> I think
12:47 <vmassol> you mean that it's considered as a nested space
12:48 <gdelhumeau> doc.getName() returns "style\.css"
12:48 <vmassol> that's correct
12:48 <gdelhumeau> and it should have been "colibri" previously I think
12:48 <vmassol> but the space part isn't It hink
12:48 <vmassol> ah yes
12:48 <vmassol> ok
12:48 <gdelhumeau> mut then maybe Enygma` is right, we should not rely on this
12:48 <vmassol> I know the reason actually
12:48 <gdelhumeau> *but
12:48 <vmassol> this is the same problem as for the zipexplorer plugin
12:49 <vmassol> cuased by http://jira.xwiki.org/browse/XWIKI-12169
12:50 <vmassol> so basically this is not a supported format
12:50 <vmassol> anymore
12:50 <vmassol> what was happening before
12:50 <vmassol> is that the actions were reparsing the url
12:50 <vmassol> and they could support url formats that extended the normal entity URL format
12:50 <vmassol> so they coud hack it
12:50 <vmassol> this is not true anymore
12:51 <vmassol> commenting in the issue
12:54 <vmassol> commented
12:54 <vmassol> is it clear?
12:55 <vmassol> wait
12:55 <vmassol> changing comment since my proposal is actually a hack which isn't good
12:56 <vmassol> done
12:56 <vmassol> we really need to flesh out all Actions that were extending the Entity URL format
12:57 <gdelhumeau> ok I see
12:58 <vmassol> I can take that issue if someone takes the javascript api one :)
13:00 <vmassol> lunch for now
13:07 <gdelhumeau> I'm ok to  take the javascript one
13:17 <gdelhumeau> We should refactor the whole Javscript API at some point
13:17 <gdelhumeau> because we have some that uses prototype, some that use jquery, some that use AMD
13:17 <gdelhumeau> this is not consistent anymore
14:08 <_cjd> has quit
14:08 <_cjd> has joined #xwiki
14:16 <Enygma`> vmassol: so are you taking XWIKI-12427 ?
14:16 <vmassol> yes I've assigned myself to it Enygma`
14:16 <vmassol> is it ok?
14:16 <Enygma`> ah, right, did not refresh
14:17 <vmassol> maybe guillaume and you could work together on the js api thing since
14:17 <Enygma`> sure, since I was going at it by fixing the way the document reference is handled, but you seem to know more about it and what`s going on in the background
14:17 <vmassol> 1) it's complex
14:17 <vmassol> 2) we need something for next Monday and Guillaume is off tomorrow...
14:17 <vmassol> Enygma`: yeah I caused the issue and it's in a domain I've worked on...
14:24 <Enygma`> ok, cool. I`ll try to help on the JS side, though I`m not sure at what level we want to take it.
14:24 <vmassol> yes that's the hard part, to decide what to do
14:24 <vmassol> :)
15:01 <Ramona1> has quit
15:01 <Ramona1> has joined #xwiki
15:02 <msmeria> has quit
15:03 <tmortagne> Enygma`: re what to do on JS API the priority is to add nested support to existing API, for example several things are broken just because what XWiki.currentDocument.getURL return is wrong
15:04 <Enygma`> ok
15:05 <gdelhumeau> I propose to continue the work done by vmassol on http://jira.xwiki.org/browse/XWIKI-12205
15:05 <gdelhumeau> changing the constructor of XWiki.Document, but I think we can do it more simple
15:18 <Enygma`> we probably need to look on the number of arguments in the constructor to see if it's the old (backwards compatible) signature or if it's the new one (using references)
15:20 <gdelhumeau> I just look at the type of the first one
15:20 <gdelhumeau> either the first one is a string or a reference
15:21 <gdelhumeau> if it's a reference, the other arguments are ignored
15:22 <Ramona1> has quit
15:28 <vmassol> guys I'm looking at SkinAction#renderFileFromObjectField() and I see that velocity is only executed if the xproperty name ends with css or js. So does it mean velocity is not executed if the xproperty name is something like edit.vm? What am I missing?
15:29 <Enygma`> templates are handled by TemplateManager
15:29 <Enygma`> SkinAction only handles resources
15:29 <vmassol> so what does SkinAction#renderFileFromObjectField()  do ? :)
15:30 <vmassol> ok I understand what you mean
15:30 <Enygma`> renders files... defined in Skin Objects in Skin Documents...
15:30 <Enygma`> requested through the "skin" action
15:30 <vmassol> so indeed if thexproperty is named edit.vm it won't have velocity applied in this case
15:30 <Enygma`> because we don`t ask for templates through the skin action
15:30 <vmassol> yep
15:30 <vmassol> thanks
15:31 <Enygma`> sure
15:31 <Enygma`> I just learned about this stuff too :P
15:31 <vmassol> :)
15:31 <vmassol> it's now documented at http://platform.xwiki.org/xwiki/bin/view/DevGuide/Standard+URL+Format#HAction:skin btw
15:32 <Enygma`> :)
15:33 <Enygma`> I noticed that for filesystem resources only, .less files are also rendered
15:35 <vmassol> hmm that's not what I see
15:35 <vmassol> if (isCssMimeType(mimetype) || isJavascriptMimeType(mimetype) || isLessCssFile(filename)) {
15:35 <Enygma`> isLessCssFile(filename) ?
15:35 <vmassol> so css and js also have velocity executed
15:36 <Enygma`> well, yes, .css, .js and .less.vm
15:36 <vmassol> indeed isLessCssFile is a misnamer
15:36 <Enygma`> but the .less.vm is only for filesystem resources, not document resources
15:36 <vmassol>     return filename.toLowerCase().endsWith(".less.vm");
15:40 <gdelhumeau> entityResource.js is loaded after xwiki.js
15:40 <gdelhumeau> so it seems I cannot use XWiki.Model in xwiki.js, can I?
15:41 <sorinello> has quit
15:44 <OSIMasson> has left #xwiki
15:45 <OSIMasson> has joined #xwiki
15:50 <_cjd> is now known as <cjd>
16:09 <gdelhumeau> ok I can put entityReferences before xwiki.js without breaking anything
16:22 <gsmeria> has quit
16:35 <OSIMasson> has quit
16:36 <tmortagne> has quit
16:37 <OSIMasson> has joined #xwiki
16:41 <vmassol> wtf…. I call http://localhost:8080/xwiki/bin/skin/skins/colibri/style.css?skin=colibri&colorTheme=xwiki%3AFlamingoThemes.Charcoal locally
16:41 <vmassol> and I get in my console:
16:42 <vmassol> 2015-08-27 16:39:20,857 [http://localhost:8080/xwiki/bin/skin/skins/flamingo/style.css?skin=XWiki.DefaultSkin&colorTheme=playground%3AFlamingoThemes.Charcoal] WARN  o.h.u.JDBCExceptionReporter    - SQL Error: -4850, SQLState: 3F000
16:42 <vmassol> notice the "playground" wiki!
16:45 <OSIMasson> has quit
16:46 <sorinello> has joined #xwiki
16:48 <vmassol> mflorea: is there an issue for changing the home page to use the document tree macro instead? You're in charge of this right?
16:48 <vmassol> I'm replying to a mail and wanted to link to that issue
16:50 <mflorea> http://jira.xwiki.org/browse/XE-1497
16:50 <vmassol> ah yes thanks
16:50 <vmassol> missing label
16:50 <vmassol> adding
16:50 <vmassol> that's why I couldn't find it
16:51 <mflorea> now, replacing the spaces macro is not the only change needed, we need to update the test on that page too, Main.Welcome
16:51 <mflorea> s/test/text
16:51 <Enygma`> vmassol: do`t know where you got that playground from... maybe bad copy/paste, configured a different color theme, etc..
16:52 <vmassol> Enygma`: I rebuilt from sources this morning :)
16:52 <Enygma`> when we have such nice snapshots? :)
16:52 <vmassol> I always rebuild
16:53 <vmassol> (just enterprise here)
16:53 <vmassol> still a mystery to me where it's coming from...
16:53 <vmassol> anyway I think I've fixed the issue, going to commit
16:53 <Enygma`> cool
16:53 <vmassol> just triple-checking
16:53 <vmassol> (re skin action)
16:53 <vmassol> with a one-liner ;)
16:54 <vmassol> (but took me several hours to write this one line!)
16:57 <Enygma`> classic development scenario :)
16:57 <vmassol> ah grrrr
16:57 <vmassol> I wanted to test writing a new skin a nested space but if I cannot add xobjects in a nested space doc then it's going to be tough :)
16:58 <vmassol> ok I'll assume I fixed that without testing for now while waiting for your fix :)
17:12 <Enygma`> gdelhumeau: ideally, we`d need to make entityReference.js an AMD module
17:12 <gdelhumeau> indeed
17:12 <gdelhumeau> for now, I am affraid of breaking things
17:13 <Enygma`> yes, because we have code using it in the global scope
17:18 <gdelhumeau> Enygma`: could you have a look to this commit?
17:19 <mflorea> has quit
17:26 <Enygma`> looking...
17:27 <OSIMasson> has joined #xwiki
17:37 <Trefex> has quit
18:20 <evalica> has quit
18:21 <Enygma`> I`m off
18:21 <Enygma`> have a nice evening
18:21 <Enygma`> has quit
18:39 <cjd> has quit
18:44 <vmassol> 6 issues left for M3
18:45 <vmassol> + the CI which is failing a lot
18:45 <vmassol> we're late for Monday since we probably need one full day to fix the CI...
18:59 <ClemensR> has quit
19:10 <Slashman> hello, is this intended that most of the official xwiki website are using http only? also jira.xwiki.org can be accessed via https, but the default url is using http
19:28 <OSIMasson> has quit
19:32 <gdelhumeau> has quit
20:04 <tekzilla> has joined #xwiki
20:30 <abusenius_> has joined #xwiki
20:31 <Ramona1> has joined #xwiki
20:32 <Chuguniy> has quit
20:51 <OSIMasson> has joined #xwiki
20:56 <OSIMasson> has left #xwiki
21:04 <Ramona1> has quit
21:30 <cjd> has joined #xwiki
22:11 <MasterPiece> has joined #xwiki
22:23 <vmassol> has quit
22:31 <mflorea> has joined #xwiki
22:51 <Slashman> has quit
23:01 <mflorea> has quit
Tags:
   

Get Connected