IRC Archive for channel #xwiki on 29 September 2016

Last modified by Vincent Massol on 2016/09/29 23:43

<xwikibot> has joined #xwiki
13:11 <vmassol> oh
13:11 <vmassol> the bot is back
13:11 <vmassol> so the restart was enough apaprently… weird
13:11 <vmassol> !search "bot is awesome"
13:11 <vmassol> haha
13:11 <vmassol> :)
13:18 <msmeria1> has joined #xwiki
13:21 <msmeria> has quit
13:25 <acotiuga> has quit
13:26 <acotiuga> has joined #xwiki
13:29 <vmassol> evalica: might be better to use your username on xwiki.org when you make changes
13:29 <vmassol> (hard to know that chocolade is you :))
13:29 <evalica> I am using the normal user for the playground - and sometimes I forget :)
13:29 <vmassol> :)
13:30 <evalica> there are 2 more "milestone" occurence on the Practices page
13:30 <vmassol> I know
13:30 <evalica> :)
13:30 <vmassol> they're there oin purpose
13:30 <vmassol> *on
13:30 <evalica> k :)
13:37 <edvorg> has joined #xwiki
13:38 <acotiuga> has quit
13:38 <acotiuga> has joined #xwiki
13:41 <edvorg> has quit
13:55 <tmortagne> has joined #xwiki
14:04 <msmeria> has joined #xwiki
14:07 <msmeria1> has quit
14:21 <D-Spair> has quit
14:27 <D-Spair> has joined #xwiki
14:50 <msmeria1> has joined #xwiki
14:52 <msmeria> has quit
15:06 <msmeria1> has quit
15:50 <acotiuga> has quit
16:21 <vmassol> tmortagne: I'm about to fix http://jira.xwiki.org/browse/XWIKI-13706?focusedCommentId=92784&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-92784 Please let me know if you had any special reason to remove this feature. Thanks
16:24 <vmassol> gdelhumeau: wrong since at https://github.com/xwiki/xwiki-platform/compare/692f0c526d4e...d11237796e93#diff-969e866750907f414b75a9e8b2ded49bR43
16:25 <vmassol> gdelhumeau: it's a complex change for 7.4.x
16:25 <vmassol> hope you're sure of yourself :)
16:25 <vmassol> gdelhumeau: and https://github.com/xwiki/xwiki-platform/compare/692f0c526d4e...d11237796e93#diff-969e866750907f414b75a9e8b2ded49bR135 doesn't look good
16:26 <vmassol> (doesn't seem a good practice at all to me)
16:31 <vmassol> tmortagne: committing, I'll revert if need be
16:36 <vmassol> nice timing for the BFD Denis :)
16:37 <vmassol> we fixed a lot of blockers/critical today!
16:37 <Denis> indeed, nice timing
16:38 <gdelhumeau> hmm indeed, sorry for the since
16:39 <vmassol> the since is a detail. I'm more worried about the risk for 7.4.x and even 8.2.x
16:39 <vmassol> (and the ugly try/catch needs to be reviewed too)
16:42 <tmortagne> vmassol: don't remember
16:42 <vmassol> ok then my change should be good then
16:43 <gdelhumeau> I've removed the try/catch
16:44 <vmassol> be careful because if the guy had put it
16:44 <vmassol> like forgetting to check for null somrwhere
16:44 <vmassol> (gdelhumeau)
16:44 <gdelhumeau> yes, I'm checking the object
16:45 <DarkKnightCZ> has quit
16:45 <vmassol> k, so you think it's a safe change?
16:45 <vmassol> otherwise be prepared to re-release 7.4.6, 8.2.2, 8.3 and 8.4 :)
16:46 <vmassol> (I'm always worried when introducing new urls)
16:46 <vmassol> (new action in this case)
16:47 <vmassol> (new urls used by old code)
16:47 <vmassol> (new url used by new code is not a problem)
16:51 <DarkKnightCZ> has joined #xwiki
16:52 <gdelhumeau> if you prefer I revert the backporting
17:00 <DarkKnightCZ> has quit
17:01 <gdelhumeau> vmassol: see last commit. if yoy like it, I backport it
17:02 <vmassol> gdelhumeau: I don't prefer anything. You're the owner of it and I haven't analyzed it enough to know th erisk it represnets. I'm just asking you since I see quite a lot of code, code not done by an experienced xwiki dev, and for a fix that is not a blocker for LTS IMO. I'll let you take the decision
17:29 <gdelhumeau> When I read the code, and when I test it (with different users on diffent wikis), it seems quite safe
17:29 <gdelhumeau> However, side effects always come from places we never think about
17:30 <gdelhumeau> so, as you said, since it's not a blocker, I can let it for 8.4 only and let community/professional testers comfort this fix
17:34 <vmassol> yes a good strategy is to have it on master, wait a bit to make sure it's ok and then backport if need be
17:34 <vmassol> (unless you're sure of yourself)
17:54 <mflorea> has quit
17:54 <DarkKnightCZ> has quit
18:24 <gdelhumeau> has quit
18:46 <tmortagne> has quit
18:48 <evalica> has quit
18:51 <Enygma`> has quit
19:05 <vmassol> hmm
19:05 <vmassol> ah yes
19:05 <vmassol> forget it
19:06 <vmassol> :)
19:06 <vmassol> still trying to figure out hte prolem...
19:08 <vmassol> seems we have a problem on our ci
19:08 <vmassol> [ERROR] Failed to execute goal on project xwiki-platform-rendering-macro-context: Could not resolve dependencies for project org.xwiki.platform:xwiki-platform-rendering-macro-context:jar:8.4-SNAPSHOT: The following artifacts could not be resolved: org.xwiki.rendering:xwiki-rendering-syntax-event:jar:8.4-SNAPSHOT, org.xwiki.rendering:xwiki-rendering-test:jar:8.4-SNAPSHOT
19:08 <vmassol> (when I execute locally)
19:09 <vmassol> hmm that should work fine
19:09 <vmassol> I see that the CI has built it
19:09 <vmassol> http://ci.xwiki.org/job/xwiki-rendering/org.xwiki.rendering$xwiki-rendering-syntax-event/910/console
19:10 <vmassol> forcing with )U
19:10 <vmassol> -U
19:10 <vmassol> same problem
19:10 <vmassol> checking maven repo
19:11 <vmassol> hmm seems ok : http://maven.xwiki.org/snapshots/org/xwiki/rendering/xwiki-rendering-syntax-event/8.4-SNAPSHOT/
19:12 <vmassol> what.????
19:12 <vmassol> http://nexus.xwiki.org/nexus/content/groups/public-snapshots/org/xwiki/rendering/ is empty for me
19:13 <vmassol> so it seems we have a nexus problem
19:13 <vmassol> checking nexus logs
19:13 <vmassol> found it
19:13 <vmassol> java.lang.IllegalStateException: java.io.IOException: No space left on device
20:20 <DarkKnightCZ> has joined #xwiki
20:29 <Slashman> has quit
20:54 <edvorg> has joined #xwiki
20:56 <mflorea> has joined #xwiki
21:46 <blabla2[m]> has quit
21:47 <Trefex_> has joined #xwiki
21:48 <edvorg> has quit
21:50 <Trefex> has quit
21:50 <chaas_> has quit
21:51 <chaas> has joined #xwiki
21:56 <edvorg> has joined #xwiki
22:03 <vmassol1> has joined #xwiki
22:03 <vmassol> has quit
22:21 <vmassol1> has quit
22:21 <edvorg> has quit
22:42 <daemoen> has quit
22:44 <daemoen> has joined #xwiki
22:45 <aloisdg[m]> has joined #xwiki
22:48 <vmassol> has joined #xwiki
23:04 <blabla2[m]> has joined #xwiki
23:05 <edvorg> has joined #xwiki
23:05 <edvorg> has quit
23:11 <vmassol> has quit
23:16 <mflorea> has quit
23:17 <vmassol> has joined #xwiki
23:40 <edvorg> has joined #xwiki
23:43 <edvorg> has quit
Tags:
   

Get Connected