IRC Archive for channel #xwiki on 20 April 2017

Last modified by Vincent Massol on 2017/04/20 23:22

<slayerjain> has joined #xwiki
06:15 <mflorea> has joined #xwiki
07:13 <mflorea> has quit
07:19 <sammy1997> has joined #xwiki
07:19 <sammy1997> has quit
08:12 <Aranjedeath> has quit
08:23 <acotiuga> has joined #xwiki
08:58 <mflorea> has joined #xwiki
09:46 <vmassol> SotoX3: the URL spec doesn't say to use dashes for spaces, it says to use %20
09:47 <vmassol> so xwiki just uses spaces and URL gets encoded as it should to %20, abiding by the spec
09:47 <vmassol> now you can do whatever you wish in front of xwiki and perform rewriting if you wish
09:48 <vmassol> for ex with the rewritefilter, see http://platform.xwiki.org/xwiki/bin/view/Main/ShortURLs#HUrlRewriteFilter
09:48 <msmeria> has joined #xwiki
10:00 <faichelbaum> has joined #xwiki
10:09 <vmassol> good morning eveyrone
10:10 <vmassol> today for the test day, I'm moving the HTML export test to platform
10:22 <floflobel> has joined #xwiki
10:23 <Slashman> has joined #xwiki
10:27 <evalica> has joined #xwiki
11:16 <vmassol> gdelhumeau: question for you, could you point me to the place in the code where we pass the pages to export to the ExportAction (when exporting at the level of a page)?
11:16 <gdelhumeau> for a war export for example ?
11:17 <vmassol> sorry
11:17 <vmassol> I meant HTML export or XAR export
11:17 <vmassol> you implemented some new UI to be able to export children too
11:18 <gdelhumeau> https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/src/main/webapp/resources/uicomponents/exporter/exporter.js
11:18 <vmassol> ok thanks
11:19 <vmassol> gdelhumeau: where's the call to the "export" action?
11:19 <gdelhumeau> https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/src/main/webapp/resources/uicomponents/exporter/exporter.js#L208
11:19 <vmassol> hmm is it: url.initFromURL(button.attr('href')); ?
11:20 <vmassol> ok so you copy the current URL and modify the params for this url?
11:20 <vmassol> ok I get it
11:20 <vmassol> thanks
11:20 <gdelhumeau> yes indeed
11:20 <vmassol> so you pass individual "pages" params
11:21 <vmassol> and not using any regex
11:21 <vmassol> ah no
11:21 <vmassol> you do for children
11:21 <gdelhumeau> depends if you select a page without expanding it
11:21 <vmassol>                 var spaceReference = new XWiki.EntityReference('%', XWiki.EntityType.DOCUMENT, pageReference.parent);
11:21 <vmassol> ok
11:21 <gdelhumeau> so it select the children than the JS export does not know at this point
11:21 <gdelhumeau> so it select the children that the JS export does not know at this point
11:21 <vmassol> ok got it
11:21 <vmassol> thx again
11:54 <floflobel> hi, i have a warn for initialize authservice org.xwiki.contrib.ldap.XWikiLDAPAuthServiceImpl (https://paste.fedoraproject.org/paste/Z3g8x-KnTasTJTG339OfrV5M1UNdIGYhyRLivL9gydE=). I try to execute an ldapsearch manually and it's works.
12:05 <vmassol> guys, I think it would be good to merge http://jira.xwiki.org/browse/XWIKI-13991# in 8.4.x for 8.4.5, WDYT?
12:05 <vmassol> tmortagne, gdelhumeau, Enygma, mflorea : WDYT?
12:06 <gdelhumeau> I think it's our rule actually :)
12:12 <Enygma`> vmassol: sounds good
12:14 <vmassol> gdelhumeau: it's more a question of risk
12:14 <vmassol> ok I'll merge it
12:14 <vmassol> I was not sure about the ratio risk vs benefit
12:14 <vmassol> it's not really a bug
12:14 <vmassol> it's more an improvement
12:15 <Enygma`> AFAICS, it`s about resending prepared mails that have not been sent, on a server restart
12:15 <vmassol> yes
12:15 <vmassol> (it was just never implemented)
12:15 <Enygma`> sounds like a moderate-low risk to me
12:15 <Enygma`> bbl, lunch.
12:15 <vmassol> well imagine that you have 1000 such emails
12:15 <vmassol> (a newsletter for ex)
12:15 <vmassol> then it'll stop your xwiki startup by the time it takes to resend them all
12:16 <vmassol> (not the full resend, the preparing part)
12:16 <vmassol> (the resend is async but not the prepare)
12:16 <gdelhumeau> that what postfix does BTW
12:16 <vmassol> so imagine your xwiki crashes
12:16 <vmassol> you restart it
12:17 <vmassol> and noboyd will be able to use it till the mails have been reprepared for resend
12:17 <vmassol> so you can have a downtime that could be long in some cases
12:17 <vmassol> what we/I need to implement is to make the full resend in a thread but it's not done yetr
12:17 <vmassol> *yet
12:18 <vmassol> what I don't know is the time it take to reprepzre 1000 mails for ex
12:18 <vmassol> it could be 5 seconds or it could be 5mn
12:18 <vmassol> I think it's closer to 5 s
12:18 <gdelhumeau> I see... with the thread, I would have said yes
12:18 <vmassol> it consists in reading the mails from the FS for each mail + doing a single DB query
12:19 <vmassol> so should be not too long to read 1000 files from the FS probaby
12:19 <vmassol> the thing is that I don't really know )
12:19 <vmassol> :)
12:20 <vmassol> I proably won't have the time to work on ths before 9.3 final
12:20 <vmassol> which is Monday....
12:21 <vmassol> evalica: you're the next RM btw for Monday :)
12:22 <vmassol> we really need to start understanding (retrospective) why we're not able to release on a given date when we're on a 3 weeks release basis. It shouldn't be that hard. This week we have one day off ok but we should have been able to release Tuesday
12:23 <vmassol> so we need to analyse what's blocking us from doing that and see if we can remove roadblocks, change process, etc
12:23 <vmassol> if we had one week more, I'm pretty sure the issue would have been exactly the same
12:23 <vmassol> (even worse potentially)
12:36 <vmassol> Enygma: re setting the date in the RN, it's the following line in the plan "Set the Release date + Release flag in the Release Notes for version 9.3-rc-1 by editing with the object editor."
12:36 <vmassol> (at http://dev.xwiki.org/xwiki/bin/view/ReleasePlans/ReleasePlan93RC1 )
12:37 <vmassol> this is just a FYI
12:37 <vmassol> it still says "no" in the LT :)
12:37 <vmassol> for " Released?"
13:08 <evalica> vmassol: thanks for letting me know about the release
13:19 <Enygma`> vmassol: I`ve probably confused it with the release plan, since they both require a date.
13:19 <vmassol> yep
13:19 <vmassol> np
13:51 <tillo> has quit
13:51 <tillo|> has quit
13:56 <vmassol> evalica: I really like http://design.xwiki.org/xwiki/bin/download/Proposal/KoelSkin/V1_2.png
13:56 <vmassol> :)
13:57 <vmassol> simplicity FTW!
13:57 <gdelhumeau> FTW? really?
13:58 <vmassol> yes simplicity is important
13:58 <gdelhumeau> indeed indeed
13:58 <vmassol> it's the single tihng we're lacking
13:58 <vmassol> :)
13:58 <vmassol> I can envision users have less trouble when they start with this skin
13:59 <gdelhumeau> don't you mean rule the world?
13:59 <gdelhumeau> or really http://www.urbandictionary.com/define.php?term=Fuck%20The%20World%20%5B%5BFTW%5D%5D ?
13:59 <vmassol> ah no FTW = For the Win :)
13:59 <gdelhumeau> ahahah
13:59 <gdelhumeau> I have a bad mind :p
13:59 <vmassol> you do! :)
14:02 <gdelhumeau> +1, this looks great
14:02 <gdelhumeau> I'm glad not to have right panels and not using full width
14:02 <gdelhumeau> but it's look more to a website than a "wiki"
14:02 <evalica> :) I'm glad you like it - I was experimenting yesterday with the whole labeled actions thing
14:04 <vmassol> wikis don't need to look ugly! :)
14:04 <evalica> with the note that is more of a KB skin
14:04 <gdelhumeau> I think you liked having xwiki using the whole width vmassol
14:05 <vmassol> yes I still do
14:06 <vmassol> that's a detail and it could be a config option
14:07 <gdelhumeau> So you prefer using the whole width while saying it's ugly :)
14:07 <vmassol> but even with not full width it still looks like a wiki
14:07 <vmassol> - edit button
14:07 <vmassol> - extra  tabs at bottom
14:07 <vmassol> - links between pages
14:07 <vmassol> - revisions
14:07 <vmassol> etc
14:08 <vmassol> but a nice looking wiki :)
14:08 <gdelhumeau> anyway I prefer that version too
14:08 <vmassol> lunch time, bbiab
14:13 <gdelhumeau> vmassol: ping on skype
14:47 <evalica> has quit
14:57 <mflorea> tmortagne: have you seen this before:
14:57 <mflorea> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce (enforce-valid-poms) on project parent-commons: The parameters 'rules' for goal org.apache.maven.plugins:maven-enforcer-plugin:1.3.1:enforce are missing or invalid -> [Help 1]
14:57 <mflorea> I'm trying to release a new contrib parent pom for v6.2.5 (to use it for CKEditor)
14:58 <tmortagne> mflorea: what branch did you use to create yours from ?
14:58 <mflorea> master
14:58 <tmortagne> that's a big difference
14:59 <tmortagne> you should probably create it from 6.4.x instead
14:59 <tmortagne> there is little differences between branches
14:59 <tmortagne> for example in 6.4.x it's not revapi which is used butCLIRR
14:59 <tmortagne> for example in 6.4.x it's not revapi which is used but CLIRR
15:00 <mflorea> I don't see any mention of revapi in the parent-commons pom
15:00 <tmortagne> in the documentation
15:00 <tmortagne> for this example
15:01 <tmortagne> a better example is the release plugin which is not set in master but forced to a recent version in 6.4.x
15:01 <mflorea> ok
15:02 <tmortagne> before the release plugin in 6.4.x is way too old
15:02 <mflorea> I'll recreate the branch then
15:02 <mflorea> starting from 6.4
15:02 <tmortagne> s/before/because/
15:02 <mflorea> thanks
15:02 <tmortagne> you should have less surprises
15:02 <mflorea> I hope so :)
15:02 <tmortagne> also why do you use compons as parent ?
15:02 <evalica> has joined #xwiki
15:03 <tmortagne> since you have a XAR in your project you should use platform as parent
15:03 <tmortagne> among other things is register XAR extension/plugin
15:06 <tmortagne> s/compons/commons/
15:09 <mflorea> I'll switch to parent-platform
15:39 <mflorea> vmassol: can I specify some maven parameter from the Jenkins file? For instance, I'd like to specify -Dwebdriver.firefox.bin because I need a newer version of FF for my functional tests
15:51 <slayerjain> has quit
15:54 <vmassol> mflorea: sorry was otp
15:54 <mflorea> np
15:54 <vmassol> let me check
15:55 <vmassol> so the answer is no,  but I'll add it now
15:55 <vmassol> (it's easy)
15:59 <mflorea> that would great, thanks
16:00 <vmassol> mflorea: should be ok now (haven't tested it)
16:01 <vmassol> properties = '-Dparam1=value1 -Dparam2value2'
16:01 <mflorea> I'll test it, thanks!
16:01 <vmassol> you can use it directly since our CI uses the latest version of this groovy script (uses version on master by default)
16:08 <acotiuga> has left #xwiki
16:28 <msmeria> has quit
16:43 <gdelhumeau> evalica: Hi :) If you agree I want to merge https://github.com/xwiki-contrib/application-blog/pull/1/files
16:47 <evalica> gdelhumeau: it's fine - yes
16:51 <gdelhumeau> thx!
17:17 <OSIMasson1> has joined #xwiki
17:37 <mflorea> vmassol: do you know if I can tell the packager plugin to exclude some artifacts? I checked the code and it doesn't seem to be possible. I can add more deps but I can't exclude.
17:38 <mflorea> I'm asking in case you did this before
17:38 <vmassol> mflorea: well the packager is supposed to bring the bare minimum
17:38 <vmassol> ie things that are needed for all tests
17:38 <vmassol> so if it brings too much there's a problem
17:39 <vmassol> I don't remember any exclude
17:39 <vmassol> I don't remember any exclude possibility ATM
17:39 <tmortagne> it also add all dependencies of the project, I guess that's what Marius wants to exclude ?
17:39 <tmortagne> it also add all dependencies of the test project, I guess that's what Marius wants to exclude ?
17:39 <vmassol> if the deps are in the project they're needed
17:39 <mflorea> in my case it brings a dep from the parent pom. Maven doesn't support excluding such deps so I though maybe I can tell the packager to not include it
17:40 <tmortagne> vmassol: they could be needed for the test but not the instance
17:40 <vmassol> they're "test" scope in that case
17:40 <vmassol> ah
17:40 <vmassol> I'm talking about func tests
17:41 <vmassol> maybe marius is using it elsewhere
17:41 <vmassol> outside of func tests I mean
17:42 <mflorea> my use case it more complex. xwiki-platform-core 6.2.5 enforces this dep https://github.com/xwiki/xwiki-platform/blob/xwiki-platform-6.2.5/xwiki-platform-core/pom.xml#L41 (bad practice)  and I want to use a more recent version. The problem is that xwiki-commons-test-component has been moved to xwiki-commons-tool-test-component, so I can't just declare a dep on xwiki-commons-tool-test-component because I'll get both.
17:43 <mflorea> I need to exclude xwiki-commons-test-component:6.2.5 and include instead xwiki-commons-tool-test-component:9.3-rc-1
17:43 <tmortagne> I see ResolutionScope.RUNTIME in package mojo so that should be ok indeed
17:44 <tmortagne> mflorea: try redefining  xwiki-commons-test-component with scope test
17:44 <tmortagne> from what I need if it's scope test it should not be selected by packager plugin
17:44 <mflorea> it has already scope test in xwiki-platform-core pom 6.2.5
17:44 <tmortagne> indeed
17:44 <mflorea> https://github.com/xwiki/xwiki-platform/blob/xwiki-platform-6.2.5/xwiki-platform-core/pom.xml#L46
17:44 <tmortagne> that's weird then
17:45 <vmassol> <exclusions> should be supported too normally
17:45 <mflorea> ok, so you're saying that scope=test shouldn't end up in the war
17:45 <mflorea> the war build by the packager plugin
17:45 <tmortagne> not in the current code but maybe it's wrong in 6.2.5
17:46 <tmortagne> vmassol: exclusions is for excluding dependencies of dependencies
17:46 <tmortagne> you can't use that for the parent
17:46 <mflorea> I'm using a recent version of packager, not 6.2.5
17:47 <tmortagne> checking dependency resolution
17:47 <tmortagne> hmm actually no test is selected by ResolutionScope.RUNTIME I think
17:47 <tmortagne> checking
17:48 <vmassol> it's a bug if it is since tests stuff shouldn't end up in the WAR
17:48 <mflorea> indeed, xwiki-commons-test-component is not in the war, but I have its dependencies, so it must be something else
17:48 <tmortagne> hmm according to the javadoc ResolutionScope.RUNTIME is only compile and runtime
17:48 <mflorea> let me dig a bit and I'll get back to you
17:48 <tmortagne> ok
17:49 <tmortagne> maybe they come from somewhere else
17:54 <vmassol> moving to http://jira.xwiki.org/browse/XWIKI-14217
17:56 <mflorea> I think I was mislead by the dep tree. xwiki-commons-test-component appears with scope test but some of its deps like xwiki-commons-component-api appear with scope runtime. The dep tree shows the shortest path to a dep. There must be other module that need xwiki-commons-component-api but the path is longer. Unfortunately for me, because the path is shorter the version used is 6.2.5 instead of 9.3RC1
17:56 <mflorea> but I think I can do something about it
18:01 <tmortagne> mflorea: your setup looks very complex
18:01 <tmortagne> you should probably do the opposite and use a recent parent but declare old dependencies
18:01 <tmortagne> might make build a lot simpler
18:03 <mflorea> I think I will get into similar problems because the parent has dep management so I will get more recent versions for transitive deps which may break APIs
18:04 <mflorea> but I could try
18:06 <tmortagne> depends on the dependencies
18:06 <tmortagne> transitive dependencies of core extension don't really matter
18:07 <tmortagne> so it's about transistive dependencies of other stuff but you probably don't have that many
18:07 <tmortagne> (core or already installed extensions)
18:15 <evalica> has quit
18:16 <evalica> has joined #xwiki
18:16 <evalica> has quit
18:21 <mflorea> has quit
18:40 <slayerjain> has joined #xwiki
18:42 <vmassol> btw mflorea  when we start xwiki we have:
18:42 <vmassol> "2017-04-20 18:42:00,336 [coreLoadExecutor-6-thread-1] WARN  o.a.s.c.SolrResourceLoader     - Solr loaded a deprecated plugin/analysis class [solr.SynonymFilterFactory]. Please consult documentation how to replace it accordingly. "
18:42 <vmassol> do we have a jira issue for fixing this?
18:42 <vmassol> (this is on a clean jetty/hsqldb)
19:26 <woshilapin> has quit
19:31 <woshilapin> has joined #xwiki
19:32 <OSIMasson1> has quit
19:35 <floflobel> has quit
19:46 <OSIMasson1> has joined #xwiki
20:04 <Slashman> has quit
20:12 <evalica> has joined #xwiki
20:17 <evalica> has quit
20:22 <evalica> has joined #xwiki
20:25 <ClemensR> has joined #xwiki
20:26 <ClemensR> has left #xwiki
20:26 <evalica> has quit
20:28 <tillo> has joined #xwiki
20:29 <tillo_> has joined #xwiki
20:37 <ClemensR> has joined #xwiki
20:55 <mflorea> has joined #xwiki
21:00 <OSIMasson1> has quit
21:54 <tillo-> has joined #xwiki
21:56 <tillo|> has joined #xwiki
21:57 <tillo> has quit
21:57 <tillo-> is now known as <tillo>
21:57 <tillo|> is now known as <7GHAAUJH2>
21:58 <tillo_> has quit
22:08 <mflorea> has quit
22:16 <Aranjedeath> has joined #xwiki
22:18 <tillo> has quit
22:18 <7GHAAUJH2> has quit
22:41 <slayerjain> has quit
22:49 <simfir> has quit
22:50 <simfir> has joined #xwiki
23:07 <ClemensR> has quit
23:19 <OSIMasson1> has joined #xwiki
23:22 <Aranjedeath> has quit
Tags:
   

Get Connected