IRC Archive for channel #xwiki

Last modified by Vincent Massol on 2012/10/18 19:18

01:13 <npm> has joined #xwiki
01:17 <npm__> has quit
01:55 <florinciu1> has quit
03:03 <abusenius> has quit
03:03 <abusenius> has joined #xwiki
03:17 <abusenius> has quit
03:17 <abusenius> has joined #xwiki
03:37 <abusenius> has quit
04:26 <DrLou> has quit
05:47 <venkatesh> has joined #xwiki
06:18 <sdumitriu> has quit
07:35 <rrodriguez> has quit
07:51 <vmassol> has joined #xwiki
07:52 <mflorea> has joined #xwiki
07:55 <gsauthier> has quit
07:55 <gsauthier> has joined #xwiki
08:25 <tmortagne> has joined #xwiki
09:00 <sburjan> has joined #xwiki
09:07 <jstoldt> has quit
09:19 <vmassol> good morning
09:20 <vmassol> mflorea: re the release I still need to move the enterprise/ build to use the commons pom. I believe this is the last step for the commons/rendering move
09:20 <vmassol> I'm working on this now, should be pretty quick
09:21 <+mflorea> vmassol: ok, we still have failing test. what worries me is that we have many flickering tests in ui-tests..
09:26 <rrodriguez> has joined #xwiki
09:45 <+mflorea> jvelociter: have you seen this$xwiki-enterprise-test-webstandards/428/testReport/org.xwiki.test.webstandards.framework/DefaultValidationTest/Validating_XHTML_validity_for__space_Sandbox__page_WebHome_executed_with_credentials_Admin_admin/ ?
09:45 <+mflorea> it complains about the search suggest icon.
10:07 <arkub> has joined #xwiki
10:08 <vmassol> jvelociter: is in 2.6?
10:09 <vmassol> I thought you said you updated it to 2.6.2
10:09 <vmassol> ?
10:11 <+tmortagne> vmassol: what's weird is that import page indicate 2.6.2 and footer 2.6
10:11 <vmassol> yep
10:11 <vmassol> hence my question to jvelociter
10:11 <+mflorea> tmortagne: as stated here velocity macro has only 2 parameters, output and filter. Is that right? I don't understand why {{velocity wiki="false"}} has a different output than {{velocity}}. AFAIK "wiki" is a parameter for the html macro, so IMO it should either be ignored or documented.
10:11 <+tmortagne> and theversion numvber is supposed to come from the same place in both
10:12 <+tmortagne> mflorea: no it's not right, it also have everything from except language
10:13 <+sburjan> good morning
10:13 <+tmortagne> mflorea: i don't see wht wiki parameter is not valid
10:13 <+tmortagne> it's exactly the same reason than html
10:13 <+tmortagne> you don'tt want to interpret wiki syntax
10:13 <+tmortagne> plus it's very usefull for debug
10:14 <vmassol> tmortagne: commons wiki created
10:14 <+tmortagne> vmassol: ok thanks
10:15 <+mflorea> tmortagne: I see, then it's confusing because someone reading the velocity macro docs doesn't know that it extends script macro so it doesn't know there are other valid parameters
10:16 <+tmortagne> mflorea: I know
10:16 <+tmortagne> i never said the documentation was right
10:16 <+mflorea> ok :)
10:16 <+tmortagne> it's older than script macro itself actually
10:17 <+tmortagne> fixed
10:17 <+mflorea> great, thanks!
10:20 <+mflorea> tmortagne: now, when I use {{velocity wiki="false"}} why am I getting new lines transformed into BRs?
10:21 <+tmortagne> mflorea: it's not a velocity macro thing
10:21 <+tmortagne> you have a new line so html writer convert it to BR
10:21 <+tmortagne> otherwise you will not have a new line
10:21 <+tmortagne> html/xhtml
10:22 <+mflorea> I see
10:22 <+tmortagne> when you use wiki=false you produce plain text
10:32 <+mflorea> tmortagne: would you agree that {{velocity wiki="false"}} can be replaced by {{velocity}}{{{verbatim}}}{{/velocity}} when the output of the velocity macro is not intended to be transformed to HTML? The best option would be to save the page with syntax plain/1.0 but it doesn't appear by default in the list of available syntaxes. Btw, I'm referring to the XWiki.LiveTableResults page.
10:34 <+tmortagne> it's not exactly the same thing since verbatim block produce <pre> (this thing should not even exist if you ask me...) but visually yes it's pretty much the same thing,making plain/1/0 syntax appear is just a configuration
10:34 <+tmortagne> and we should use it a lot more than now
10:35 <+tmortagne> actually you could not have velocity
10:35 <+tmortagne> with plain/1.0 syntax
10:36 <+tmortagne> if you really need velocity in your use case
10:36 <+mflorea> yes, it's needed
10:36 <+tmortagne> but you can use context instead
10:36 <+tmortagne> well when syntax is implemented in context macro actually
10:36 <+mflorea> tmortagne: my issue is that LIveTableResults fails the webstandards validation test because it contains multiple consecute BRs which are generated from multiple new lines. Using verbatim fixes this
10:37 <+tmortagne> anyway ussing wiki=false is a lot better than {{velocity}}{{{verbatim}}}{{/velocity}}
10:37 <+tmortagne> hmm
10:37 <+mflorea> ok, but I don't want new lines to be transformed into BRs
10:38 <+tmortagne> an dyou sure you need several new lines ?
10:39 <+mflorea> they are generated somehow :) of course I could try to make them disappear
10:40 <+mflorea> they are generated by empty lines inside the velocity code, so they are used for code formatting, separating different sections of code
10:41 <+tmortagne> you can use ## to remove them
10:41 <+mflorea> yes
10:41 <+tmortagne> and still see a separation
10:56 <evalica> has joined #xwiki
10:56 <Enygma`> has joined #xwiki
11:04 <vmassol> mflorea: ok enterprise moved to commons pom. so all should be ready for the release
11:04 <vmassol> I'll still need to move other top level projects to the commons pom but that's not on the path of the XE 3.0M3 release
11:05 <+mflorea> vmassol: ok, I'll start writing the release plan and I'll probably start the release after lunch
11:06 <vmassol> mflorea: do we have an ETA for the user status feature from sergiu?
11:06 <+mflorea> no :(
11:09 <vmassol> mflorea: we'll need to update a few things in the release plan since there's now both commons and rendering to release too
11:10 <+mflorea> yes
11:10 <vmassol> actually: commons pom, commons tool, commons core, rendering
11:10 <vmassol> (in that order)
11:10 <vmassol> with the issue of the circular dep between commons pom and commons tools
11:10 <+mflorea> yep, I'll write the plan and ask you to review it
11:10 <vmassol> ok
11:10 <vmassol> thanks
11:12 <vmassol> I can't get the jira issue calendar to work anymore...
11:13 <vmassol> tmortagne: I'm not sure in which category to put the XPOM jira project… (I haven't created it yet)
11:13 <vmassol> initially I wanted a XWiki Commons category
11:14 <vmassol> to put the 4 jira projects in it (2 tools, commons core and commons pom)
11:14 <vmassol> if I do this then commons isn't shown as a top level project
11:14 <+tmortagne> why ?
11:15 <vmassol> one jira project goes in one category
11:15 <+tmortagne> sure but maybe the current top level project categroy is a XWiki top level category one
11:15 <+tmortagne> haveing a separated category makes it even more separated from XWiki
11:15 <+tmortagne> i would also put rendering in it
11:16 <vmassol> right top level means projects here:
11:16 <vmassol>
11:16 <vmassol> s/right/right now/
11:16 <vmassol> but there's no notion of group project in jira
11:16 <vmassol> "I would also put rendering in it". In what?
11:17 <+tmortagne> in the commons category
11:17 <+tmortagne> that would be a category with all the rool you can use outside of xwiki
11:17 <+tmortagne> s/root/tools/
11:17 <gsauthier> has quit
11:18 <gsauthier> has joined #xwiki
11:19 <vmassol> well how would you name it?
11:19 <vmassol> and how would you name the top level categrory?
11:21 <+tmortagne> we already said that rendering was a big commons project with its own life so it could be the commons category you wanted
11:21 <+tmortagne> for the top level one we can simply at "XWiki" in the name
11:23 <+tmortagne> between making commons separated from the rest of XWiki and showing it as a top level project the more important and to separate it IMO
11:27 <+jvelociter> mflorea: sorry, just read your comment
11:28 <+jvelociter> is Ciprian around ? he made the image, I've just committed it
11:28 <+mflorea> he should be around
11:28 <+jvelociter> vmassol: yes webapp is 2.6.2 IIRC
11:28 <vmassol> ok ftm I'll create a XWiki Commons category, seems to be the best compromise I can see. ok tmortagne? the rule is if a top level project has several jira projects it can have a category
11:28 <vmassol> jvelociter: it says 2.6 in the footer
11:28 <+jvelociter> but wikis ahave not been updated, they are still in 2.6 snapshot
11:29 <vmassol> ah
11:29 <+jvelociter> vmassol: Hum I think I know
11:29 <vmassol> still version comes from the war
11:29 <+jvelociter> there is a line in the upgrade guide that says to copy WEB-INF/classes
11:29 <+jvelociter> it could be that
11:29 <vmassol> normally, unless overriden
11:30 <+jvelociter> cp -r xwiki/WEB-INF/classes
11:30 <+tmortagne> vmassol: ok
11:33 <+jvelociter> I think we've overriden in WEB-INF/classes to hide the fact we were running a SNAPSHOT
11:40 <vmassol> jvelociter: could you fix this?
11:49 <arkub> has quit
11:50 <arkub> has joined #xwiki
11:52 <+jvelociter> fixed
11:52 <+jvelociter> it was hardcoded in XWiki.XWikiPreferences in fact
11:53 <+jvelociter> hum BTW that version comment message is off
11:53 <+jvelociter> I haven't entered anyrhing
11:58 <jstoldt|Notebook> has joined #xwiki
11:59 <jstoldt|Notebook> hello
11:59 <jstoldt|Notebook> vmassol: could you point me to the file that takes care of parameters for images?
12:03 <Stulle|Workstati> has joined #xwiki
12:04 <Stulle|Workstati> sorry, seems like the HSDAP network coverage is horrible here...
12:05 <Stulle|Workstati> has quit
12:05 <jstoldt|Notebook> has quit
12:05 <jstoldt|Notebook> has joined #xwiki
12:06 <jstoldt|Notebook> meh...
12:07 <mflorea> has quit
12:12 <jstoldt|Notebook> is now known as <jstoldt>
12:13 <jstoldt> is now known as <jstoldt|Notebook>
12:13 <jvdrean> has joined #xwiki
12:16 <vmassol> jstoldt|Notebook: image parsing?
12:16 <vmassol> not sure I understand what you mean
12:17 <vmassol> actually it's more rendering
12:17 <vmassol> XHTML rendering probably?
12:17 <vmassol> each renderer honors some params
12:17 <jstoldt|Notebook> well, i was going to document the image syntax
12:18 <jstoldt|Notebook> i know some parameters seem to be XWiki specific
12:18 <jstoldt|Notebook> like keepRatio
12:18 <jstoldt|Notebook> (or what it was called...)
12:19 <jstoldt|Notebook> so i wonder where can i read about the possible parameters and what they'll do
12:19 <vmassol> yes one minute
12:20 <jstoldt|Notebook> thanks
12:24 <vmassol> jstoldt|Notebook: DefaultXHTMLImageRenderer
12:25 <jstoldt|Notebook> thanks, will try to find it ;)
12:25 <vmassol> it calls XWikiWikiModel.getImageURL()
12:25 <vmassol> mf
12:25 <vmassol> s/mf//
12:26 <jstoldt|Notebook> okay. this is the new Renderer top level project? or still in core?
12:30 <vmassol> DefaultXHTMLImageRenderer in top level, XWikiWikiModel.getImageURL in core
12:30 <vmassol> :)
12:30 <vmassol> s/core/platform core/
12:30 <vmassol> got to go, lunch time, bbl
12:30 <jstoldt|Notebook> okay
12:30 <jstoldt|Notebook> have a good one
12:32 <abusenius> has joined #xwiki
12:54 <jstoldt|Notebook> can anyone give me a hint where onImage from the renderer is called?
13:04 <jstoldt|Notebook> changing trains. later
13:08 <jstoldt|Notebook> has quit
13:19 <mflorea> has joined #xwiki
13:25 <jstoldt|Notebook> has joined #xwiki
13:27 <+mflorea> vmassol: we get java.lang.IllegalStateException: basedir <> does not exist
13:27 <+mflorea> in both platform-web and enterprise, is this related to you last commit?
13:28 <vmassol> mflorea: yep seen it, don't know yet why.
13:28 <vmassol> going to rebuild the whole thing
13:28 <vmassol> (locally)
13:28 <+mflorea> ok
13:46 <jstoldt|Notebook> has quit
13:47 <vmassol> mflorea: it doesn't reproduce locally
13:47 <vmassol> does it fail for you too?
13:48 <vmassol> building platform/web
13:48 <+mflorea> I haven't checked
13:50 <DrLou> has joined #xwiki
13:50 <jstoldt|Notebook> has joined #xwiki
13:56 <jstoldt|Notebook> sorry to bother you again but could somebody point me to where onImage is caled?
13:58 <jstoldt|Notebook> XHTMLImageRenderer#onImage << that one i mean
14:01 <vmassol> jstoldt|Notebook: sure checking
14:01 <jstoldt|Notebook> thanks
14:01 <vmassol> well the top level is XHTMLREnderer for sure
14:01 <vmassol> which chains listeners
14:01 <vmassol> and calls XHTMLChainingRenderer
14:02 <vmassol> then onImage of XHMTLChaningRenderer calls:
14:02 <vmassol>         this.imageRenderer.onImage(reference, isFreeStandingURI, parameters);
14:02 <jstoldt|Notebook> i see, will go on searching
14:02 <jstoldt|Notebook> has quit
14:02 <vmassol> where imageRendere is an instance of XHTMLImageRenderer
14:02 <vmassol> which is implemented by DefaultXHTMLImageRenderer
14:03 <jstoldt|Notebook> has joined #xwiki
14:03 <vmassol> jstoldt|Notebook: was saying:
14:03 <vmassol> where imageRendere is an instance of XHTMLImageRenderer
14:03 <vmassol> which is implemented by DefaultXHTMLImageRenderer
14:03 <jstoldt|Notebook> sorry, the train is going in through no-mans land... i'll be connected every once in a while...
14:03 <vmassol> and DefaultXHTMLImageRenderer calls:
14:04 <vmassol>                 imageURL = this.wikiModel.getImageURL(reference, parameters);
14:04 <vmassol> this.wikiModel is implemented by XWikiWikiModel
14:04 <jstoldt|Notebook> i see
14:04 <vmassol> which calls getImageURLQueryString
14:04 <vmassol> which uses :
14:04 <vmassol>         String width = StringUtils.chomp(getImageDimension(WIDTH, imageParameters), PIXELS);
14:04 <vmassol>         String height = StringUtils.chomp(getImageDimension(HEIGHT, imageParameters), PIXELS);
14:05 <vmassol>         String style = imageParameters.get("style");
14:05 <jstoldt|Notebook> ah, this is what i've been searching for
14:05 <jstoldt|Notebook> thanks
14:07 <jstoldt|Notebook> i figure i was trying to go the wrong way... i was trying to get to the level where the syntax is read and parsed to the rendering
14:07 <jstoldt|Notebook> still need to learn a lot, i figure
14:08 <vmassol> parser —> transformations —> renderers
14:08 <vmassol> right now we're not very clean in that we don't have well-defined supported params
14:09 <vmassol> we have an issue for that but we haven't standardized it yet
14:09 <vmassol> (jira issue that is)
14:09 <vmassol> so it's up to the renderers to decide what they handle ATM
14:10 <vmassol> xwiki committers: would be great to verify you can build commons/rendering/platform after all the changes I've done
14:12 <jstoldt|Notebook> okay
14:12 <jstoldt|Notebook> thanks for that information
14:24 <jstoldt|Notebook> wow, Java is weird... .append().append().aappend()... O_O
14:37 <jstoldt|Notebook> is it correct to be speaking about CSS properties? or is there a better word for that?
14:38 <vmassol> seems ok
14:39 <jstoldt|Notebook> ok
14:39 <vmassol> evalica: I'd need your help for the new and subwikis (for the logos)
14:40 <vmassol> logos and colors
14:44 <+evalica> k
14:44 <vmassol> thanks
14:48 <venkatesh> has quit
14:49 <sdumitriu> has joined #xwiki
15:14 <jstoldt|Notebook> hmmm am i missing something or is it rather futile to define the image height in percentage?
15:16 <+tmortagne> jstoldt|Notebook: indeed that's not supported (yet ?)
15:16 <+tmortagne> but it's always useful for the browser
15:16 <+tmortagne> even if it's not resized server side
15:17 <jstoldt|Notebook> yeah, i keep reading this code but it seems that it really the height parameter/style isn't passed unless height is in pixel...
15:18 <+tmortagne> yes it's not given to the URL generation code but you still have it in the <img> element
15:20 <+tmortagne> it's supposed to be the same thing for width btw, percent is simply not supported server side
15:20 <jstoldt|Notebook> oh, so getImageURL is doing backend transformation of the image?
15:20 <+tmortagne> yep
15:20 <+tmortagne> to reduce since of the sent files
15:21 <+tmortagne> *size
15:21 <+tmortagne> well not getImageURL exactly
15:21 <+tmortagne> but it indicate in the URL what's need for the image to be reesized when the browser ask for it
15:21 <jstoldt|Notebook> it actually is that way... this got me wondering just now
15:23 <jstoldt|Notebook> yeah
15:49 <sburjan> has quit
16:02 <jstoldt|Notebook> has quit
16:25 <+cjdelisle> Hi folks. What do you guys think of removing "HTTP Meta Info" from XWikiPreferences class?
16:26 <+cjdelisle> If anyone is using it already, they will still have it because they will keep their old class when upgrading.
16:27 <+cjdelisle> But it's really bad, it depends on rendering 1.0 system and it is not quite 1.0 rendering and definitely not 2.0 rendering.
16:30 <+jvdrean> Hi cjdelisle, I've seen it used quite frequently, to include analytics js snippet, to set some velocity vars, etc
16:31 <+jvdrean> even if those already using it would not be affected it's useful
16:34 <+cjdelisle> It would be easy to add it back in if desired. I really don't like it because it uses rendering1 (and there's no way to work around that) and it introduces security problems.
16:40 <+mflorea> vmassol tmortagne: can you please review the release plan? Thanks
16:40 <+tmortagne> mflorea: ok looking
16:41 <+tmortagne> mflorea: don't you need to release xwiki-commons-license-resources before tools ?
16:42 <+tmortagne> nvm
16:42 <+mflorea> you mean the child before the parent?
16:42 <+tmortagne> mixing things
16:42 <+tmortagne> i don't see xwiki-rendering in your plan
16:43 <+mflorea> ah, forgot about it :)
16:43 <+mflorea> let me add it
16:43 <+tmortagne> should be just after xwiki-commons-core i think
16:43 <vmassol> mflorea: sdumitriu is proposing to commit the user status today and do himself the release tonight for 3.0M3
16:43 <vmassol> if you're ok what we could do is release commons and rendering before that
16:44 <vmassol> ie now
16:44 <vmassol> sdumitriu: still ok with that?
16:44 <+mflorea> fine with me
16:45 <@sdumitriu> Yes
16:49 <+tmortagne> vmassol: did you upgraded dependencies in XE/XEM already ?
16:49 <vmassol> XE yes
16:49 <vmassol> XEM no
16:49 <vmassol> if by dep you mean dep on the top level pom
16:50 <+tmortagne> i mean dep on everything that changed like commons-test
16:50 <+tmortagne> for integration tests for example
16:50 <vmassol> hmmm haven't seen this one checking
16:50 <+tmortagne> (looks like it's not the case but asking in case you are on it)
16:50 <+mflorea> sdumitriu: I'll start now and release up to xwiki-core, ok with the release plan for this?
16:51 <vmassol> mflorea: don't release platform/core
16:51 <+mflorea> sure, excluding
16:51 <vmassol> sergiu will need to commit in it
16:51 <+mflorea> I mean
16:51 <vmassol> 1) commons-pom
16:51 <vmassol> 2) commons tools
16:51 <vmassol> 3) comomns core
16:51 <vmassol> 4) rendering
16:51 <+mflorea> vmassol: see the release plan, so you're saying I should change it?
16:52 <vmassol> let me check it, haven't read it yet
16:52 <+mflorea> I'm interested in what is before xwiki-core
16:52 <vmassol> it's ordered?
16:52 <+mflorea> yes
16:52 <vmassol> k
16:52 <vmassol> yes sounds good
16:53 <vmassol> all before xwiki-core, excluding
16:53 <+mflorea> yep
16:53 <+mflorea> starting now
16:53 <vmassol> do you know how to release commons pom?
16:53 <vmassol> it references commons tools so you need to trick it
16:54 <+mflorea> hmm, wdym by trick?
16:54 <vmassol> ie locally set version to final version for tools, build locally, then update to final version in commons pom
16:54 <vmassol> and then really release commons tools
16:54 <vmassol> at least that's what tmortagne explained to me
16:54 <vmassol> ;)
16:54 <+mflorea> ok, I'll do so
16:54 <+tmortagne> mflorea: root pom depends on tools
16:54 <vmassol> we have a issue right now, cyclic dep, not sure how we should cleanly solve it
16:55 <+mflorea> ok, I'll build tools locally with stable version before releasing commons pom
16:55 <+evalica> vmassol: I don't know what that message with rights for XWiki.XWikiguest is about - I just changed the current color theme for the space
16:56 <vmassol> evalica: seems we have buggy messages, jvelociter reported something this morning too
16:56 <+evalica> k thanks
16:57 <vmassol> btw tmortagne are you ok with the versions I have set for commons?
16:57 <vmassol> I've left pom at 40-SNAPSHOT
16:57 <vmassol> and left the tools at their previous versions too
16:57 <+tmortagne> yep sure
16:58 <vmassol> hmmm
16:58 <vmassol> commons tools top level pom should be 1 probaby
16:58 <vmassol> I see it's 30
16:58 <vmassol> mflorea: wdyt?
16:58 <vmassol> that was a mistake (copied from platform tools pom)
16:59 <+mflorea> vmassol: I'm ok with starting from 1 since it's a new module
16:59 <+tmortagne> yep this pom did not existed before so it should be 1
16:59 <vmassol> ok fixing
17:00 <+mflorea> updating the release plan
17:02 <vmassol> done
17:04 <@sdumitriu> vmassol: Can you give me rights on nexus? I started to release the polls application but didn't have the rights to publish the xar
17:05 <@sdumitriu> (contrib release)
17:05 <+mflorea> guys, I don't see commons on husdonagent (from where I'm going to release) so I'm going to checkout the source in ~/releases/trunks/commons
17:05 <vmassol> mflorea: I added commons to hudson
17:05 <vmassol> yesterday I think
17:06 <+tmortagne> vmassol: why did you added <commons.tool.license.version>1.2-SNAPSHOT</commons.tool.license.version> in XE pom ? it's already in the root pom
17:06 <@sdumitriu> vmassol: that's about a svn checkout on the hudsonagent machine from where we perform releases
17:06 <vmassol> tmortagne: hmmm ok fixing
17:06 <+mflorea> yep, it's different
17:06 <+mflorea> I'll checkout
17:07 <evalica> has quit
17:07 <+tmortagne> vmassol: but we should probably have a <commons.core.version> at least of the commons-test
17:07 <vmassol> tmortagne: done
17:07 <vmassol> check latest commit
17:07 <vmassol> :)
17:08 <+tmortagne> ok
17:08 <+tmortagne> updating XEM
17:08 <vmassol> ok I'll leave XEM to you...
17:08 <vmassol> you either need to have XE top level pom as parent
17:08 <vmassol> or redefine the DB profiles/config
17:08 <+tmortagne> yep seen that
17:09 <+tmortagne> maybe be need a distribution root pom
17:09 <+tmortagne> for all distributions like XE and XEM
17:09 <vmassol> future solution will be to use maven 3.1 mixins
17:09 <+tmortagne> future solution will be to get rid of XEM ;)
17:09 <vmassol> (
17:09 <vmassol> hehe
17:10 <+tmortagne> yes i'm waiting actively for mixins to drastically reduce xem-web-debug pom
17:10 <Enygma`> has quit
17:10 <@sdumitriu> vmassol: Did you see my message about nexus?
17:11 <vmassol> sdumitriu: yes sorry, that thread was blocked
17:11 <vmassol> checking now
17:12 <vmassol> sdumitriu: you don't seem to have a user defined on nexus
17:12 <vmassol> can you confirm?
17:12 <@sdumitriu> +1
17:12 <vmassol> I'm creating one
17:23 <vmassol> tmortagne: do you think it's ok not to move more macros to the rendering project right now? Should we move more after the 3.0M3 release or should we wait for 3.1M1?
17:23 <vmassol> right now there are only 2 macros moved (toc, html)
17:23 <vmassol> I haven't checked but there are more that canbe moved easily: id for ex
17:23 <+tmortagne> it's ok for 3.0M3 i think
17:23 <+tmortagne> ye sthere are a lot more
17:24 <+tmortagne> since most of them has been designed to work outside of XWiki
17:24 <vmassol> tmortagne: do you think we should move before 3.0 final?
17:24 <vmassol> well depends, there are lots that cannot be moved
17:24 <vmassol> all the script ones for ex
17:24 <+tmortagne> why ?
17:24 <vmassol> (not without a refactoring first)
17:24 <vmassol> because they use DAB
17:24 <+tmortagne> there is not much XWiki in it
17:24 <vmassol> for programming rights for ex
17:24 <+tmortagne> not really no
17:25 <+tmortagne> it's not with cancellable events now
17:25 <+tmortagne> *done
17:25 <+tmortagne> s/not/done/
17:25 <vmassol> ah ok didn't know that
17:25 <+tmortagne> done by abusenius
17:25 <vmassol> hmm the dep is still there
17:26 <+tmortagne> he did that mainly for checkstyle reason at first but make it nicer ;)
17:26 <vmassol> trying to remove it
17:26 <+tmortagne> he probably implemented the event in the scrript macro itself
17:26 <vmassol> just to see if it compiles
17:26 <+tmortagne> but it's easy to move it somehwre eles
17:27 <+mflorea> vmassol: I'm getting svn: Commit failed (details follow):
17:27 <+mflorea> svn: Server sent unexpected return value (403 Forbidden) in response to CHECKOUT request for '/svnroot/xwiki/!svn/ver/35161/commons/xwiki-commons-pom/trunk/pom.xml'
17:27 <+mflorea> do I need special commit rights for commons or rendering?
17:27 <vmassol> mflorea: I'm adding you
17:27 <+mflorea> ok, thanks
17:28 <vmassol> done
17:29 <+mflorea> hmm, same
17:31 <vmassol> mflorea?
17:31 <vmassol> (username)
17:31 <+mflorea> yes
17:31 <@sdumitriu> vmassol: Add me as well
17:31 <+mflorea> sdumitriu says it may be the cache, I'll wait a few minutes
17:33 <vmassol> sdumitriu: done
17:33 <+tmortagne> vmassol: shouldn't we put jmock version in root pom like we have junit one since pretty much all the project use jmock as well for testing ?
17:33 <+mflorea> works now
17:33 <vmassol> tmortagne: yes probably, I just didn't take the time to do it and verify it all works
17:33 <vmassol> actualyl I'm not completely sure
17:34 <vmassol> but I guess a project that needs a different version can override in case it's needed
17:34 <vmassol> script macro builds withtout dep on bridge
17:34 <vmassol> :)
17:34 <+tmortagne> ok the it has been moved
17:34 <+tmortagne> cool
17:35 <+tmortagne> that wold have been a shame to not put all the script macros in rendering ;)
17:35 <+tmortagne> not 100% sure for the velocity one
17:35 <+tmortagne> since it's a bit special
17:35 <vmassol> yeah we would have refactored anyay
17:35 <+mflorea> guys, are you ok with xwiki-commons-40 for the tag label, or should I use xwiki-commons-pom-40?
17:35 <vmassol> needs to move classloader in commons though
17:36 <+tmortagne> yep
17:38 <+tmortagne> we could find a way to make include macro a bit less dependent on wiki concept, like some API to get the XDOM of a target resource whatever this resource it and do all the context jingling in events like we do for script macros
17:38 <vmassol> we can also have 2 include macros
17:38 <vmassol> a generic one with less featrures
17:39 <+tmortagne> yep
17:39 <vmassol> and a xwiki one that extends it
17:39 <vmassol> tmortagne: didn't see your message re the macro move. Should we do it before 3.0 final?
17:39 <vmassol> or wait for 3.1
17:39 <vmassol> I'm not sure
17:39 <+tmortagne> to come back to your initial question about 3.0 i'm not sure, it's not critical technically since the important thing are API and syntaxes but would be nice
17:39 <vmassol> yes it would be nice I agree
17:39 <vmassol> it doesn't seem too risky
17:40 <+tmortagne> nop
17:40 <vmassol> classloader is not very easy to move
17:40 <+tmortagne> the bigger rendering is for the first announcement the better it is I guess
17:40 <vmassol> needs to be split in 2
17:40 <+tmortagne> same thing for commons
17:41 <+tmortagne> what is the wiki part in classloader ?
17:41 <vmassol> I'm checking
17:41 <+tmortagne> i use only the generic part with extension manager AFAIK
17:42 <vmassol> ah AttachmentURLConnection
17:42 <vmassol> uses AttachmentReference
17:42 <vmassol> to resolve jars="…." attachments refs
17:43 <+tmortagne> ok that could probably me moved as it is then
17:43 <vmassol> yes
17:44 <vmassol> xwiki-classloader-attachmentjar or something like this
17:44 <+tmortagne> yep
17:45 <+tmortagne> it also highlight the fact that anyone can easily add more jar handlers for macros
17:45 <vmassol> yep
18:17 <+mflorea> vmassol: xwiki-commons-velocity, script, management and properties have the wrong parent. It should be xwiki-commons-core right?
18:18 <+tmortagne> mflorea: yep
18:18 <vmassol> mflorea: checking
18:18 <vmassol> hmm right
18:18 <+mflorea> I'll fix it then
18:18 <vmassol> fixing
18:19 <vmassol> you fix or I fix?
18:19 <+mflorea> I can fix it :)
18:19 <vmassol> ok
18:31 <vmassol> mflorea: 3 checkstyle errors
18:31 <vmassol> you fixing them?
18:31 <+mflorea> let me build
18:34 <+mflorea> I can fix them
18:34 <vmassol> k
18:35 <rrodriguez> has quit
19:01 <vmassol> mflorea: have you updated the top level commons pom too?
19:01 <vmassol> the trunks one
19:02 <+mflorea> no, updating now
19:17 <+mflorea> guys, the parent for xwiki-tools is wrong I think
19:17 <+mflorea>
19:18 <vmassol> indeed
19:18 <+mflorea> I released it with 39 (the previous xwiki pom)
19:18 <vmassol> trying a quick change
19:21 <arkub> has quit
19:21 <vmassol> mflorea: what do you want to do?
19:22 <vmassol> I can commit against the issue for moving to top level project
19:22 <vmassol> or I create a new issue
19:22 <+mflorea> I think you can commit against the existing issue, but the questions is if I need to re-release xwiki-tools pom or not?
19:23 <+mflorea> I think I have, to include the new parent
19:24 <vmassol> It's better but not 100% mandatory
19:24 <vmassol> depends on the energy you have
19:24 <vmassol> :)
19:24 <vmassol> let me commit first
19:24 <+mflorea> I still have :)
19:24 <+mflorea> energy
19:25 <vmassol> done
19:31 <vmassol> got to go, bb in 1h30mn
20:05 <jstoldt|Notebook> has joined #xwiki
20:06 <+cjdelisle> !help
20:06 <jbrBridge> !who - shows who is on the other channel
20:06 <jbrBridge> !shutdown - shutdown bridge (will probably attempt to rejoin after a few seconds)
20:06 <+cjdelisle> !shutdown
20:12 <jstoldt|Notebook> i want to get a development environment to view the XWiki src... should i get eclipse and intelliJ? or just one?
20:12 <+mflorea> tmortagne: right now rendering depends on xwiki-commons and assumes the version is $project.versions This is a PITA because I have to edit a lot of poms to resolve the snapshots. I'm going to add a property xwiki.commons.version WDYT?
20:13 <+tmortagne> mflorea: yes vmassol probably forgot about that
20:13 <+mflorea> ok, adding the property
20:14 <+tmortagne> jstoldt|Notebook: see
20:14 <+tmortagne> make me think i need to update it a bit since it's more simple than before now
20:16 <jstoldt|Notebook> :) so i should go with eclipse... next question, which windows distribution of eclipse should i get? i am a bit overwhelmed by all the nice abreviations ;)
20:17 <+tmortagne> jstoldt|Notebook: you can use what you want, i'm using Eclipse and i wrote a tutorial to have this easy to debug Eclipse project but you can do that with intelliJ too (some of us use it)
20:17 <+tmortagne> jstoldt|Notebook: take the 2EE one
20:17 <+tmortagne> J2EE
20:18 <jstoldt|Notebook> okay, well, i think i'll go with eclipse
20:18 <jstoldt|Notebook> and hope i can make this work on win 7
20:21 <+tmortagne> jstoldt|Notebook: i think i used to have some issue with maven/WTP on win7 (it was not deploying all the jars) but it's maybe fixed now
20:21 <+tmortagne> i can assure you that it's working well on Ubuntu ;)
20:21 <jstoldt|Notebook> well, i don't actually want to compile and stuff for now
20:21 <jstoldt|Notebook> i just want a nicer way to browse the code
20:21 <+tmortagne> ok
20:22 <jstoldt|Notebook> than doing it web based
20:22 <+tmortagne> than you don't really need to follow this tutorial
20:22 <+tmortagne> just install m2eclipse
20:22 <+tmortagne> that will allow you to easily import maven project into Eclipse
20:22 <jstoldt|Notebook> great
20:23 <+tmortagne> but to just read code it's possible IntelliJ is better here sincce it properly handler maven submodule
20:23 <+tmortagne> in Eclipse you have to import all modules as separated eclipse projects
20:24 <+tmortagne> it's taking care properly of the dependencies between the project but you loose the maven project tree visually
20:24 <jstoldt|Notebook> is that only for toplevel projects or for all?
20:25 <+tmortagne> every single maven pom/module will create an Eclipse project and all that at the same level
20:26 <+tmortagne> so it's not the best unless you know well the organization already
20:26 <jstoldt|Notebook> sorry for my ignorance, i am used to Visual Studio and C++ which is really comfortable
20:26 <+tmortagne> well Eclipse for java is a lot better than Visual Studio with c++
20:26 <+tmortagne> a looot
20:26 <jstoldt|Notebook> okay, i think i know what you are getting at... let me try to see what this means for me
20:27 <+tmortagne> mayb it will be ok for you anyway
20:27 <jstoldt|Notebook> i'll give it a shot
20:27 <+tmortagne> note that with the name we give to our maven prooject it's kind of organized anyway
20:27 <jstoldt|Notebook> worst case scenario, i shoot somebody in anger ;)
20:27 <+tmortagne> :)
20:29 <jstoldt|Notebook> well, i figure anything will be better than keep surfing the SVN ;)
20:29 <+tmortagne> sure
20:30 <+cjdelisle> if you want to read svn on the browser, I have a greasemonkey script for firefox which will so syntax highlighting on the text.
20:30 <+cjdelisle> it's nice when reading stuff in third party libraries (apache commons)
20:33 <jstoldt|Notebook> n'ah, not a firefox fan :-P
20:33 <jstoldt|Notebook> i'll go long ways to avoid FF ;)
20:34 <+cjdelisle> chrome user?
20:34 <jstoldt|Notebook> Opera
20:34 <+tmortagne> cjdelisle: seems nice, could you send it to me ?
20:34 <jstoldt|Notebook> really don't like Google either
20:34 <+cjdelisle> I'll attach it.
20:35 <+tmortagne> jstoldt|Notebook: so you prefer the close source one ? ;)
20:35 <jstoldt|Notebook> well, usually quite the opposite, actually, but what i like most about Opera is that it's ready to use without any attachments needed for my purposes
20:35 <jstoldt|Notebook> and it sticks to the standards
20:36 <+cjdelisle> hehe and if the website doesn't then it won't show it to you.
20:37 <jstoldt|Notebook> true but at that point i just go about blaming website vendors for not sticking to the standard and browser vendors for creating buggy implementations to which website vendors create hacks
20:37 <jstoldt|Notebook> ;)
20:37 <+cjdelisle> indeed it is their fault but that doesn't get you the page.
20:39 <+cjdelisle>
20:39 <jstoldt|Notebook> yeah...
20:39 <+cjdelisle> It's google's thing i just added an event listener to the top which tinkers with pages when it detects they're not html
20:42 <+tmortagne> cjdelisle: thanks
20:42 <+cjdelisle> sure thing
20:48 <jstoldt|Notebook> i think needs some update, too...
20:55 <jstoldt|Notebook> hmmm should i get XWiki Eclipse or is that horribly outdated and of no use anymore, anyway?
20:55 <mflorea> has quit
20:57 <+tmortagne> jstoldt|Notebook: not horribly but a bit outdated, most of the thing should work
20:57 <+tmortagne> it's just that there is bugs not fixed since a long time
20:57 <jstoldt|Notebook> i see
20:58 <+tmortagne> is a bit outdated since it need the new commons and rendering
20:59 <+tmortagne> but all the rest is still true
20:59 <evalica> has joined #xwiki
21:00 <jstoldt|Notebook> i know, just wanted to point it out
21:14 <tmortagne> has quit
22:48 <vmassol> has quit

Get Connected