Wiki source code of IRC Archive for channel #xwiki
Last modified by Vincent Massol on 2012/10/18 19:18
Show last authors
author | version | line-number | content |
---|---|---|---|
1 | 01:13 <npm> has joined #xwiki | ||
2 | 01:17 <npm__> has quit | ||
3 | 01:55 <florinciu1> has quit | ||
4 | 03:03 <abusenius> has quit | ||
5 | 03:03 <abusenius> has joined #xwiki | ||
6 | 03:17 <abusenius> has quit | ||
7 | 03:17 <abusenius> has joined #xwiki | ||
8 | 03:37 <abusenius> has quit | ||
9 | 04:26 <DrLou> has quit | ||
10 | 05:47 <venkatesh> has joined #xwiki | ||
11 | 06:18 <sdumitriu> has quit | ||
12 | 07:35 <rrodriguez> has quit | ||
13 | 07:51 <vmassol> has joined #xwiki | ||
14 | 07:52 <mflorea> has joined #xwiki | ||
15 | 07:55 <gsauthier> has quit | ||
16 | 07:55 <gsauthier> has joined #xwiki | ||
17 | 08:25 <tmortagne> has joined #xwiki | ||
18 | 09:00 <sburjan> has joined #xwiki | ||
19 | 09:07 <jstoldt> has quit | ||
20 | 09:19 <vmassol> good morning | ||
21 | 09:20 <vmassol> mflorea: re the release I still need to move the enterprise/ build to use the commons pom. I believe this is the last step for the commons/rendering move | ||
22 | 09:20 <vmassol> I'm working on this now, should be pretty quick | ||
23 | 09:21 <+mflorea> vmassol: ok, we still have failing test. what worries me is that we have many flickering tests in ui-tests.. | ||
24 | 09:26 <rrodriguez> has joined #xwiki | ||
25 | 09:45 <+mflorea> jvelociter: have you seen this http://hudson.xwiki.org/view/Functional%20Tests/job/xwiki-product-enterprise-tests/org.xwiki.enterprise$xwiki-enterprise-test-webstandards/428/testReport/org.xwiki.test.webstandards.framework/DefaultValidationTest/Validating_XHTML_validity_for__space_Sandbox__page_WebHome_executed_with_credentials_Admin_admin/ ? | ||
26 | 09:45 <+mflorea> it complains about the search suggest icon. | ||
27 | 10:07 <arkub> has joined #xwiki | ||
28 | 10:08 <vmassol> jvelociter: xwiki.org is in 2.6? | ||
29 | 10:09 <vmassol> I thought you said you updated it to 2.6.2 | ||
30 | 10:09 <vmassol> ? | ||
31 | 10:11 <+tmortagne> vmassol: what's weird is that import page indicate 2.6.2 and footer 2.6 | ||
32 | 10:11 <vmassol> yep | ||
33 | 10:11 <vmassol> hence my question to jvelociter | ||
34 | 10:11 <+mflorea> tmortagne: as stated here http://extensions.xwiki.org/xwiki/bin/view/Extension/Velocity+Macro velocity macro has only 2 parameters, output and filter. Is that right? I don't understand why {{velocity wiki="false"}} has a different output than {{velocity}}. AFAIK "wiki" is a parameter for the html macro, so IMO it should either be ignored or documented. | ||
35 | 10:11 <+tmortagne> and theversion numvber is supposed to come from the same place in both | ||
36 | 10:12 <+tmortagne> mflorea: no it's not right, it also have everything from http://extensions.xwiki.org/xwiki/bin/view/Extension/Script+Macro except language | ||
37 | 10:13 <+sburjan> good morning | ||
38 | 10:13 <+tmortagne> mflorea: i don't see wht wiki parameter is not valid | ||
39 | 10:13 <+tmortagne> it's exactly the same reason than html | ||
40 | 10:13 <+tmortagne> you don'tt want to interpret wiki syntax | ||
41 | 10:13 <+tmortagne> plus it's very usefull for debug | ||
42 | 10:14 <vmassol> tmortagne: commons wiki created | ||
43 | 10:14 <+tmortagne> vmassol: ok thanks | ||
44 | 10:15 <+mflorea> tmortagne: I see, then it's confusing because someone reading the velocity macro docs doesn't know that it extends script macro so it doesn't know there are other valid parameters | ||
45 | 10:16 <+tmortagne> mflorea: I know | ||
46 | 10:16 <+tmortagne> i never said the documentation was right | ||
47 | 10:16 <+mflorea> ok :) | ||
48 | 10:16 <+tmortagne> it's older than script macro itself actually | ||
49 | 10:17 <+tmortagne> fixed | ||
50 | 10:17 <+mflorea> great, thanks! | ||
51 | 10:20 <+mflorea> tmortagne: now, when I use {{velocity wiki="false"}} why am I getting new lines transformed into BRs? | ||
52 | 10:21 <+tmortagne> mflorea: it's not a velocity macro thing | ||
53 | 10:21 <+tmortagne> you have a new line so html writer convert it to BR | ||
54 | 10:21 <+tmortagne> otherwise you will not have a new line | ||
55 | 10:21 <+tmortagne> html/xhtml | ||
56 | 10:22 <+mflorea> I see | ||
57 | 10:22 <+tmortagne> when you use wiki=false you produce plain text | ||
58 | 10:32 <+mflorea> tmortagne: would you agree that {{velocity wiki="false"}} can be replaced by {{velocity}}{{{verbatim}}}{{/velocity}} when the output of the velocity macro is not intended to be transformed to HTML? The best option would be to save the page with syntax plain/1.0 but it doesn't appear by default in the list of available syntaxes. Btw, I'm referring to the XWiki.LiveTableResults page. | ||
59 | 10:34 <+tmortagne> it's not exactly the same thing since verbatim block produce <pre> (this thing should not even exist if you ask me...) but visually yes it's pretty much the same thing,making plain/1/0 syntax appear is just a configuration | ||
60 | 10:34 <+tmortagne> and we should use it a lot more than now | ||
61 | 10:35 <+tmortagne> actually you could not have velocity | ||
62 | 10:35 <+tmortagne> with plain/1.0 syntax | ||
63 | 10:36 <+tmortagne> if you really need velocity in your use case | ||
64 | 10:36 <+mflorea> yes, it's needed | ||
65 | 10:36 <+tmortagne> but you can use context instead | ||
66 | 10:36 <+tmortagne> well when syntax is implemented in context macro actually | ||
67 | 10:36 <+mflorea> tmortagne: my issue is that LIveTableResults fails the webstandards validation test because it contains multiple consecute BRs which are generated from multiple new lines. Using verbatim fixes this | ||
68 | 10:37 <+tmortagne> anyway ussing wiki=false is a lot better than {{velocity}}{{{verbatim}}}{{/velocity}} | ||
69 | 10:37 <+tmortagne> hmm | ||
70 | 10:37 <+mflorea> ok, but I don't want new lines to be transformed into BRs | ||
71 | 10:38 <+tmortagne> an dyou sure you need several new lines ? | ||
72 | 10:39 <+mflorea> they are generated somehow :) of course I could try to make them disappear | ||
73 | 10:40 <+mflorea> they are generated by empty lines inside the velocity code, so they are used for code formatting, separating different sections of code | ||
74 | 10:41 <+tmortagne> you can use ## to remove them | ||
75 | 10:41 <+mflorea> yes | ||
76 | 10:41 <+tmortagne> and still see a separation | ||
77 | 10:56 <evalica> has joined #xwiki | ||
78 | 10:56 <Enygma`> has joined #xwiki | ||
79 | 11:04 <vmassol> mflorea: ok enterprise moved to commons pom. so all should be ready for the release | ||
80 | 11:04 <vmassol> I'll still need to move other top level projects to the commons pom but that's not on the path of the XE 3.0M3 release | ||
81 | 11:05 <+mflorea> vmassol: ok, I'll start writing the release plan and I'll probably start the release after lunch | ||
82 | 11:06 <vmassol> mflorea: do we have an ETA for the user status feature from sergiu? | ||
83 | 11:06 <+mflorea> no :( | ||
84 | 11:09 <vmassol> mflorea: we'll need to update a few things in the release plan since there's now both commons and rendering to release too | ||
85 | 11:10 <+mflorea> yes | ||
86 | 11:10 <vmassol> actually: commons pom, commons tool, commons core, rendering | ||
87 | 11:10 <vmassol> (in that order) | ||
88 | 11:10 <vmassol> with the issue of the circular dep between commons pom and commons tools | ||
89 | 11:10 <+mflorea> yep, I'll write the plan and ask you to review it | ||
90 | 11:10 <vmassol> ok | ||
91 | 11:10 <vmassol> thanks | ||
92 | 11:12 <vmassol> I can't get the jira issue calendar to work anymore... | ||
93 | 11:13 <vmassol> tmortagne: I'm not sure in which category to put the XPOM jira project… (I haven't created it yet) | ||
94 | 11:13 <vmassol> initially I wanted a XWiki Commons category | ||
95 | 11:14 <vmassol> to put the 4 jira projects in it (2 tools, commons core and commons pom) | ||
96 | 11:14 <vmassol> if I do this then commons isn't shown as a top level project | ||
97 | 11:14 <+tmortagne> why ? | ||
98 | 11:15 <vmassol> one jira project goes in one category | ||
99 | 11:15 <+tmortagne> sure but maybe the current top level project categroy is a XWiki top level category one | ||
100 | 11:15 <+tmortagne> haveing a separated category makes it even more separated from XWiki | ||
101 | 11:15 <+tmortagne> i would also put rendering in it | ||
102 | 11:16 <vmassol> right top level means projects here: | ||
103 | 11:16 <vmassol> http://svn.xwiki.org/svnroot/xwiki/ | ||
104 | 11:16 <vmassol> s/right/right now/ | ||
105 | 11:16 <vmassol> but there's no notion of group project in jira | ||
106 | 11:16 <vmassol> "I would also put rendering in it". In what? | ||
107 | 11:17 <+tmortagne> in the commons category | ||
108 | 11:17 <+tmortagne> that would be a category with all the rool you can use outside of xwiki | ||
109 | 11:17 <+tmortagne> s/root/tools/ | ||
110 | 11:17 <gsauthier> has quit | ||
111 | 11:18 <gsauthier> has joined #xwiki | ||
112 | 11:19 <vmassol> well how would you name it? | ||
113 | 11:19 <vmassol> and how would you name the top level categrory? | ||
114 | 11:21 <+tmortagne> we already said that rendering was a big commons project with its own life so it could be the commons category you wanted | ||
115 | 11:21 <+tmortagne> for the top level one we can simply at "XWiki" in the name | ||
116 | 11:23 <+tmortagne> between making commons separated from the rest of XWiki and showing it as a top level project the more important and to separate it IMO | ||
117 | 11:27 <+jvelociter> mflorea: sorry, just read your comment | ||
118 | 11:28 <+jvelociter> is Ciprian around ? he made the image, I've just committed it | ||
119 | 11:28 <+mflorea> he should be around | ||
120 | 11:28 <+jvelociter> vmassol: yes xwiki.org webapp is 2.6.2 IIRC | ||
121 | 11:28 <vmassol> ok ftm I'll create a XWiki Commons category, seems to be the best compromise I can see. ok tmortagne? the rule is if a top level project has several jira projects it can have a category | ||
122 | 11:28 <vmassol> jvelociter: it says 2.6 in the footer | ||
123 | 11:28 <+jvelociter> but wikis ahave not been updated, they are still in 2.6 snapshot | ||
124 | 11:29 <vmassol> ah | ||
125 | 11:29 <+jvelociter> vmassol: Hum I think I know | ||
126 | 11:29 <vmassol> still version comes from the war | ||
127 | 11:29 <+jvelociter> there is a line in the upgrade guide that says to copy WEB-INF/classes | ||
128 | 11:29 <+jvelociter> it could be that | ||
129 | 11:29 <vmassol> normally, unless overriden | ||
130 | 11:30 <+jvelociter> cp -r xwiki/WEB-INF/classes xwiki.new/WEB-INF/ | ||
131 | 11:30 <+tmortagne> vmassol: ok | ||
132 | 11:33 <+jvelociter> I think we've overriden version.properties in WEB-INF/classes to hide the fact we were running a SNAPSHOT | ||
133 | 11:40 <vmassol> jvelociter: could you fix this? | ||
134 | 11:49 <arkub> has quit | ||
135 | 11:50 <arkub> has joined #xwiki | ||
136 | 11:52 <+jvelociter> fixed | ||
137 | 11:52 <+jvelociter> it was hardcoded in XWiki.XWikiPreferences in fact | ||
138 | 11:53 <+jvelociter> hum BTW that version comment message is off | ||
139 | 11:53 <+jvelociter> I haven't entered anyrhing | ||
140 | 11:58 <jstoldt|Notebook> has joined #xwiki | ||
141 | 11:59 <jstoldt|Notebook> hello | ||
142 | 11:59 <jstoldt|Notebook> vmassol: could you point me to the file that takes care of parameters for images? | ||
143 | 12:03 <Stulle|Workstati> has joined #xwiki | ||
144 | 12:04 <Stulle|Workstati> sorry, seems like the HSDAP network coverage is horrible here... | ||
145 | 12:05 <Stulle|Workstati> has quit | ||
146 | 12:05 <jstoldt|Notebook> has quit | ||
147 | 12:05 <jstoldt|Notebook> has joined #xwiki | ||
148 | 12:06 <jstoldt|Notebook> meh... | ||
149 | 12:07 <mflorea> has quit | ||
150 | 12:12 <jstoldt|Notebook> is now known as <jstoldt> | ||
151 | 12:13 <jstoldt> is now known as <jstoldt|Notebook> | ||
152 | 12:13 <jvdrean> has joined #xwiki | ||
153 | 12:16 <vmassol> jstoldt|Notebook: image parsing? | ||
154 | 12:16 <vmassol> not sure I understand what you mean | ||
155 | 12:17 <vmassol> actually it's more rendering | ||
156 | 12:17 <vmassol> XHTML rendering probably? | ||
157 | 12:17 <vmassol> each renderer honors some params | ||
158 | 12:17 <jstoldt|Notebook> well, i was going to document the image syntax | ||
159 | 12:18 <jstoldt|Notebook> i know some parameters seem to be XWiki specific | ||
160 | 12:18 <jstoldt|Notebook> like keepRatio | ||
161 | 12:18 <jstoldt|Notebook> (or what it was called...) | ||
162 | 12:19 <jstoldt|Notebook> so i wonder where can i read about the possible parameters and what they'll do | ||
163 | 12:19 <vmassol> yes one minute | ||
164 | 12:20 <jstoldt|Notebook> thanks | ||
165 | 12:24 <vmassol> jstoldt|Notebook: DefaultXHTMLImageRenderer | ||
166 | 12:25 <jstoldt|Notebook> thanks, will try to find it ;) | ||
167 | 12:25 <vmassol> it calls XWikiWikiModel.getImageURL() | ||
168 | 12:25 <vmassol> mf | ||
169 | 12:25 <vmassol> s/mf// | ||
170 | 12:26 <jstoldt|Notebook> okay. this is the new Renderer top level project? or still in core? | ||
171 | 12:30 <vmassol> DefaultXHTMLImageRenderer in top level, XWikiWikiModel.getImageURL in core | ||
172 | 12:30 <vmassol> :) | ||
173 | 12:30 <vmassol> s/core/platform core/ | ||
174 | 12:30 <vmassol> got to go, lunch time, bbl | ||
175 | 12:30 <jstoldt|Notebook> okay | ||
176 | 12:30 <jstoldt|Notebook> have a good one | ||
177 | 12:32 <abusenius> has joined #xwiki | ||
178 | 12:54 <jstoldt|Notebook> can anyone give me a hint where onImage from the renderer is called? | ||
179 | 13:04 <jstoldt|Notebook> changing trains. later | ||
180 | 13:08 <jstoldt|Notebook> has quit | ||
181 | 13:19 <mflorea> has joined #xwiki | ||
182 | 13:25 <jstoldt|Notebook> has joined #xwiki | ||
183 | 13:27 <+mflorea> vmassol: we get java.lang.IllegalStateException: basedir <http://hudson.xwiki.org/job/xwiki-platform-web/ws/trunk/standard/target/maven-shared-archive-resources/META-INF> does not exist | ||
184 | 13:27 <+mflorea> in both platform-web and enterprise, is this related to you last commit? | ||
185 | 13:28 <vmassol> mflorea: yep seen it, don't know yet why. | ||
186 | 13:28 <vmassol> going to rebuild the whole thing | ||
187 | 13:28 <vmassol> (locally) | ||
188 | 13:28 <+mflorea> ok | ||
189 | 13:46 <jstoldt|Notebook> has quit | ||
190 | 13:47 <vmassol> mflorea: it doesn't reproduce locally | ||
191 | 13:47 <vmassol> does it fail for you too? | ||
192 | 13:48 <vmassol> building platform/web | ||
193 | 13:48 <+mflorea> I haven't checked | ||
194 | 13:50 <DrLou> has joined #xwiki | ||
195 | 13:50 <jstoldt|Notebook> has joined #xwiki | ||
196 | 13:56 <jstoldt|Notebook> sorry to bother you again but could somebody point me to where onImage is caled? | ||
197 | 13:58 <jstoldt|Notebook> XHTMLImageRenderer#onImage << that one i mean | ||
198 | 14:01 <vmassol> jstoldt|Notebook: sure checking | ||
199 | 14:01 <jstoldt|Notebook> thanks | ||
200 | 14:01 <vmassol> well the top level is XHTMLREnderer for sure | ||
201 | 14:01 <vmassol> which chains listeners | ||
202 | 14:01 <vmassol> and calls XHTMLChainingRenderer | ||
203 | 14:02 <vmassol> then onImage of XHMTLChaningRenderer calls: | ||
204 | 14:02 <vmassol> this.imageRenderer.onImage(reference, isFreeStandingURI, parameters); | ||
205 | 14:02 <jstoldt|Notebook> i see, will go on searching | ||
206 | 14:02 <jstoldt|Notebook> has quit | ||
207 | 14:02 <vmassol> where imageRendere is an instance of XHTMLImageRenderer | ||
208 | 14:02 <vmassol> which is implemented by DefaultXHTMLImageRenderer | ||
209 | 14:03 <jstoldt|Notebook> has joined #xwiki | ||
210 | 14:03 <vmassol> jstoldt|Notebook: was saying: | ||
211 | 14:03 <vmassol> where imageRendere is an instance of XHTMLImageRenderer | ||
212 | 14:03 <vmassol> which is implemented by DefaultXHTMLImageRenderer | ||
213 | 14:03 <jstoldt|Notebook> sorry, the train is going in through no-mans land... i'll be connected every once in a while... | ||
214 | 14:03 <vmassol> and DefaultXHTMLImageRenderer calls: | ||
215 | 14:04 <vmassol> imageURL = this.wikiModel.getImageURL(reference, parameters); | ||
216 | 14:04 <vmassol> this.wikiModel is implemented by XWikiWikiModel | ||
217 | 14:04 <jstoldt|Notebook> i see | ||
218 | 14:04 <vmassol> which calls getImageURLQueryString | ||
219 | 14:04 <vmassol> which uses : | ||
220 | 14:04 <vmassol> String width = StringUtils.chomp(getImageDimension(WIDTH, imageParameters), PIXELS); | ||
221 | 14:04 <vmassol> String height = StringUtils.chomp(getImageDimension(HEIGHT, imageParameters), PIXELS); | ||
222 | 14:05 <vmassol> String style = imageParameters.get("style"); | ||
223 | 14:05 <jstoldt|Notebook> ah, this is what i've been searching for | ||
224 | 14:05 <jstoldt|Notebook> thanks | ||
225 | 14:07 <jstoldt|Notebook> i figure i was trying to go the wrong way... i was trying to get to the level where the syntax is read and parsed to the rendering | ||
226 | 14:07 <jstoldt|Notebook> still need to learn a lot, i figure | ||
227 | 14:08 <vmassol> parser —> transformations —> renderers | ||
228 | 14:08 <vmassol> right now we're not very clean in that we don't have well-defined supported params | ||
229 | 14:09 <vmassol> we have an issue for that but we haven't standardized it yet | ||
230 | 14:09 <vmassol> (jira issue that is) | ||
231 | 14:09 <vmassol> so it's up to the renderers to decide what they handle ATM | ||
232 | 14:10 <vmassol> xwiki committers: would be great to verify you can build commons/rendering/platform after all the changes I've done | ||
233 | 14:12 <jstoldt|Notebook> okay | ||
234 | 14:12 <jstoldt|Notebook> thanks for that information | ||
235 | 14:24 <jstoldt|Notebook> wow, Java is weird... .append().append().aappend()... O_O | ||
236 | 14:37 <jstoldt|Notebook> is it correct to be speaking about CSS properties? or is there a better word for that? | ||
237 | 14:38 <vmassol> seems ok | ||
238 | 14:39 <jstoldt|Notebook> ok | ||
239 | 14:39 <vmassol> evalica: I'd need your help for the new commons.xwiki.org and rendering.xwiki.org subwikis (for the logos) | ||
240 | 14:40 <vmassol> logos and colors | ||
241 | 14:44 <+evalica> k | ||
242 | 14:44 <vmassol> thanks | ||
243 | 14:48 <venkatesh> has quit | ||
244 | 14:49 <sdumitriu> has joined #xwiki | ||
245 | 15:14 <jstoldt|Notebook> hmmm am i missing something or is it rather futile to define the image height in percentage? | ||
246 | 15:16 <+tmortagne> jstoldt|Notebook: indeed that's not supported (yet ?) | ||
247 | 15:16 <+tmortagne> but it's always useful for the browser | ||
248 | 15:16 <+tmortagne> even if it's not resized server side | ||
249 | 15:17 <jstoldt|Notebook> yeah, i keep reading this code but it seems that it really the height parameter/style isn't passed unless height is in pixel... | ||
250 | 15:18 <+tmortagne> yes it's not given to the URL generation code but you still have it in the <img> element | ||
251 | 15:20 <+tmortagne> it's supposed to be the same thing for width btw, percent is simply not supported server side | ||
252 | 15:20 <jstoldt|Notebook> oh, so getImageURL is doing backend transformation of the image? | ||
253 | 15:20 <+tmortagne> yep | ||
254 | 15:20 <+tmortagne> to reduce since of the sent files | ||
255 | 15:21 <+tmortagne> *size | ||
256 | 15:21 <+tmortagne> well not getImageURL exactly | ||
257 | 15:21 <+tmortagne> but it indicate in the URL what's need for the image to be reesized when the browser ask for it | ||
258 | 15:21 <jstoldt|Notebook> it actually is that way... this got me wondering just now | ||
259 | 15:23 <jstoldt|Notebook> yeah | ||
260 | 15:49 <sburjan> has quit | ||
261 | 16:02 <jstoldt|Notebook> has quit | ||
262 | 16:25 <+cjdelisle> Hi folks. What do you guys think of removing "HTTP Meta Info" from XWikiPreferences class? | ||
263 | 16:26 <+cjdelisle> If anyone is using it already, they will still have it because they will keep their old class when upgrading. | ||
264 | 16:27 <+cjdelisle> But it's really bad, it depends on rendering 1.0 system and it is not quite 1.0 rendering and definitely not 2.0 rendering. | ||
265 | 16:30 <+jvdrean> Hi cjdelisle, I've seen it used quite frequently, to include analytics js snippet, to set some velocity vars, etc | ||
266 | 16:31 <+jvdrean> even if those already using it would not be affected it's useful | ||
267 | 16:34 <+cjdelisle> It would be easy to add it back in if desired. I really don't like it because it uses rendering1 (and there's no way to work around that) and it introduces security problems. | ||
268 | 16:40 <+mflorea> vmassol tmortagne: can you please review the release plan? Thanks | ||
269 | 16:40 <+tmortagne> mflorea: ok looking | ||
270 | 16:41 <+tmortagne> mflorea: don't you need to release xwiki-commons-license-resources before tools ? | ||
271 | 16:42 <+tmortagne> nvm | ||
272 | 16:42 <+mflorea> you mean the child before the parent? | ||
273 | 16:42 <+tmortagne> mixing things | ||
274 | 16:42 <+tmortagne> i don't see xwiki-rendering in your plan | ||
275 | 16:43 <+mflorea> ah, forgot about it :) | ||
276 | 16:43 <+mflorea> let me add it | ||
277 | 16:43 <+tmortagne> should be just after xwiki-commons-core i think | ||
278 | 16:43 <vmassol> mflorea: sdumitriu is proposing to commit the user status today and do himself the release tonight for 3.0M3 | ||
279 | 16:43 <vmassol> if you're ok what we could do is release commons and rendering before that | ||
280 | 16:44 <vmassol> ie now | ||
281 | 16:44 <vmassol> sdumitriu: still ok with that? | ||
282 | 16:44 <+mflorea> fine with me | ||
283 | 16:45 <@sdumitriu> Yes | ||
284 | 16:49 <+tmortagne> vmassol: did you upgraded dependencies in XE/XEM already ? | ||
285 | 16:49 <vmassol> XE yes | ||
286 | 16:49 <vmassol> XEM no | ||
287 | 16:49 <vmassol> if by dep you mean dep on the top level pom | ||
288 | 16:50 <+tmortagne> i mean dep on everything that changed like commons-test | ||
289 | 16:50 <+tmortagne> for integration tests for example | ||
290 | 16:50 <vmassol> hmmm haven't seen this one checking | ||
291 | 16:50 <+tmortagne> (looks like it's not the case but asking in case you are on it) | ||
292 | 16:50 <+mflorea> sdumitriu: I'll start now and release up to xwiki-core, ok with the release plan for this? | ||
293 | 16:51 <vmassol> mflorea: don't release platform/core | ||
294 | 16:51 <+mflorea> sure, excluding | ||
295 | 16:51 <vmassol> sergiu will need to commit in it | ||
296 | 16:51 <+mflorea> I mean | ||
297 | 16:51 <vmassol> 1) commons-pom | ||
298 | 16:51 <vmassol> 2) commons tools | ||
299 | 16:51 <vmassol> 3) comomns core | ||
300 | 16:51 <vmassol> 4) rendering | ||
301 | 16:51 <+mflorea> vmassol: see the release plan, so you're saying I should change it? | ||
302 | 16:52 <vmassol> let me check it, haven't read it yet | ||
303 | 16:52 <+mflorea> I'm interested in what is before xwiki-core | ||
304 | 16:52 <vmassol> it's ordered? | ||
305 | 16:52 <+mflorea> yes | ||
306 | 16:52 <vmassol> k | ||
307 | 16:52 <vmassol> yes sounds good | ||
308 | 16:53 <vmassol> all before xwiki-core, excluding | ||
309 | 16:53 <+mflorea> yep | ||
310 | 16:53 <+mflorea> starting now | ||
311 | 16:53 <vmassol> do you know how to release commons pom? | ||
312 | 16:53 <vmassol> it references commons tools so you need to trick it | ||
313 | 16:54 <+mflorea> hmm, wdym by trick? | ||
314 | 16:54 <vmassol> ie locally set version to final version for tools, build locally, then update to final version in commons pom | ||
315 | 16:54 <vmassol> and then really release commons tools | ||
316 | 16:54 <vmassol> at least that's what tmortagne explained to me | ||
317 | 16:54 <vmassol> ;) | ||
318 | 16:54 <+mflorea> ok, I'll do so | ||
319 | 16:54 <+tmortagne> mflorea: root pom depends on tools | ||
320 | 16:54 <vmassol> we have a issue right now, cyclic dep, not sure how we should cleanly solve it | ||
321 | 16:55 <+mflorea> ok, I'll build tools locally with stable version before releasing commons pom | ||
322 | 16:55 <+evalica> vmassol: I don't know what that message with rights for XWiki.XWikiguest is about - I just changed the current color theme for the space | ||
323 | 16:56 <vmassol> evalica: seems we have buggy messages, jvelociter reported something this morning too | ||
324 | 16:56 <+evalica> k thanks | ||
325 | 16:57 <vmassol> btw tmortagne are you ok with the versions I have set for commons? | ||
326 | 16:57 <vmassol> I've left pom at 40-SNAPSHOT | ||
327 | 16:57 <vmassol> and left the tools at their previous versions too | ||
328 | 16:57 <+tmortagne> yep sure | ||
329 | 16:58 <vmassol> hmmm | ||
330 | 16:58 <vmassol> commons tools top level pom should be 1 probaby | ||
331 | 16:58 <vmassol> I see it's 30 | ||
332 | 16:58 <vmassol> mflorea: wdyt? | ||
333 | 16:58 <vmassol> that was a mistake (copied from platform tools pom) | ||
334 | 16:59 <+mflorea> vmassol: I'm ok with starting from 1 since it's a new module | ||
335 | 16:59 <+tmortagne> yep this pom did not existed before so it should be 1 | ||
336 | 16:59 <vmassol> ok fixing | ||
337 | 17:00 <+mflorea> updating the release plan | ||
338 | 17:02 <vmassol> done | ||
339 | 17:04 <@sdumitriu> vmassol: Can you give me rights on nexus? I started to release the polls application but didn't have the rights to publish the xar | ||
340 | 17:05 <@sdumitriu> (contrib release) | ||
341 | 17:05 <+mflorea> guys, I don't see commons on husdonagent (from where I'm going to release) so I'm going to checkout the source in ~/releases/trunks/commons | ||
342 | 17:05 <vmassol> mflorea: I added commons to hudson | ||
343 | 17:05 <vmassol> yesterday I think | ||
344 | 17:06 <+tmortagne> vmassol: why did you added <commons.tool.license.version>1.2-SNAPSHOT</commons.tool.license.version> in XE pom ? it's already in the root pom | ||
345 | 17:06 <@sdumitriu> vmassol: that's about a svn checkout on the hudsonagent machine from where we perform releases | ||
346 | 17:06 <vmassol> tmortagne: hmmm ok fixing | ||
347 | 17:06 <+mflorea> yep, it's different | ||
348 | 17:06 <+mflorea> I'll checkout | ||
349 | 17:07 <evalica> has quit | ||
350 | 17:07 <+tmortagne> vmassol: but we should probably have a <commons.core.version> at least of the commons-test | ||
351 | 17:07 <vmassol> tmortagne: done | ||
352 | 17:07 <vmassol> check latest commit | ||
353 | 17:07 <vmassol> :) | ||
354 | 17:08 <+tmortagne> ok | ||
355 | 17:08 <+tmortagne> updating XEM | ||
356 | 17:08 <vmassol> ok I'll leave XEM to you... | ||
357 | 17:08 <vmassol> you either need to have XE top level pom as parent | ||
358 | 17:08 <vmassol> or redefine the DB profiles/config | ||
359 | 17:08 <+tmortagne> yep seen that | ||
360 | 17:09 <+tmortagne> maybe be need a distribution root pom | ||
361 | 17:09 <+tmortagne> for all distributions like XE and XEM | ||
362 | 17:09 <vmassol> future solution will be to use maven 3.1 mixins | ||
363 | 17:09 <+tmortagne> future solution will be to get rid of XEM ;) | ||
364 | 17:09 <vmassol> (http://jaxenter.com/maven-3-0-the-future-of-maven-10580.html) | ||
365 | 17:09 <vmassol> hehe | ||
366 | 17:10 <+tmortagne> yes i'm waiting actively for mixins to drastically reduce xem-web-debug pom | ||
367 | 17:10 <Enygma`> has quit | ||
368 | 17:10 <@sdumitriu> vmassol: Did you see my message about nexus? | ||
369 | 17:11 <vmassol> sdumitriu: yes sorry, that thread was blocked | ||
370 | 17:11 <vmassol> checking now | ||
371 | 17:12 <vmassol> sdumitriu: you don't seem to have a user defined on nexus | ||
372 | 17:12 <vmassol> can you confirm? | ||
373 | 17:12 <@sdumitriu> +1 | ||
374 | 17:12 <vmassol> I'm creating one | ||
375 | 17:23 <vmassol> tmortagne: do you think it's ok not to move more macros to the rendering project right now? Should we move more after the 3.0M3 release or should we wait for 3.1M1? | ||
376 | 17:23 <vmassol> right now there are only 2 macros moved (toc, html) | ||
377 | 17:23 <vmassol> I haven't checked but there are more that canbe moved easily: id for ex | ||
378 | 17:23 <+tmortagne> it's ok for 3.0M3 i think | ||
379 | 17:23 <+tmortagne> ye sthere are a lot more | ||
380 | 17:24 <+tmortagne> since most of them has been designed to work outside of XWiki | ||
381 | 17:24 <vmassol> tmortagne: do you think we should move before 3.0 final? | ||
382 | 17:24 <vmassol> well depends, there are lots that cannot be moved | ||
383 | 17:24 <vmassol> all the script ones for ex | ||
384 | 17:24 <+tmortagne> why ? | ||
385 | 17:24 <vmassol> (not without a refactoring first) | ||
386 | 17:24 <vmassol> because they use DAB | ||
387 | 17:24 <+tmortagne> there is not much XWiki in it | ||
388 | 17:24 <vmassol> for programming rights for ex | ||
389 | 17:24 <+tmortagne> not really no | ||
390 | 17:25 <+tmortagne> it's not with cancellable events now | ||
391 | 17:25 <+tmortagne> *done | ||
392 | 17:25 <+tmortagne> s/not/done/ | ||
393 | 17:25 <vmassol> ah ok didn't know that | ||
394 | 17:25 <+tmortagne> done by abusenius | ||
395 | 17:25 <vmassol> hmm the dep is still there | ||
396 | 17:26 <+tmortagne> he did that mainly for checkstyle reason at first but make it nicer ;) | ||
397 | 17:26 <vmassol> trying to remove it | ||
398 | 17:26 <+tmortagne> he probably implemented the event in the scrript macro itself | ||
399 | 17:26 <vmassol> just to see if it compiles | ||
400 | 17:26 <+tmortagne> but it's easy to move it somehwre eles | ||
401 | 17:27 <+mflorea> vmassol: I'm getting svn: Commit failed (details follow): | ||
402 | 17:27 <+mflorea> svn: Server sent unexpected return value (403 Forbidden) in response to CHECKOUT request for '/svnroot/xwiki/!svn/ver/35161/commons/xwiki-commons-pom/trunk/pom.xml' | ||
403 | 17:27 <+mflorea> do I need special commit rights for commons or rendering? | ||
404 | 17:27 <vmassol> mflorea: I'm adding you | ||
405 | 17:27 <+mflorea> ok, thanks | ||
406 | 17:28 <vmassol> done | ||
407 | 17:29 <+mflorea> hmm, same | ||
408 | 17:31 <vmassol> mflorea? | ||
409 | 17:31 <vmassol> (username) | ||
410 | 17:31 <+mflorea> yes | ||
411 | 17:31 <@sdumitriu> vmassol: Add me as well | ||
412 | 17:31 <+mflorea> sdumitriu says it may be the cache, I'll wait a few minutes | ||
413 | 17:33 <vmassol> sdumitriu: done | ||
414 | 17:33 <+tmortagne> vmassol: shouldn't we put jmock version in root pom like we have junit one since pretty much all the project use jmock as well for testing ? | ||
415 | 17:33 <+mflorea> works now | ||
416 | 17:33 <vmassol> tmortagne: yes probably, I just didn't take the time to do it and verify it all works | ||
417 | 17:33 <vmassol> actualyl I'm not completely sure | ||
418 | 17:34 <vmassol> but I guess a project that needs a different version can override in case it's needed | ||
419 | 17:34 <vmassol> script macro builds withtout dep on bridge | ||
420 | 17:34 <vmassol> :) | ||
421 | 17:34 <+tmortagne> ok the it has been moved | ||
422 | 17:34 <+tmortagne> cool | ||
423 | 17:35 <+tmortagne> that wold have been a shame to not put all the script macros in rendering ;) | ||
424 | 17:35 <+tmortagne> not 100% sure for the velocity one | ||
425 | 17:35 <+tmortagne> since it's a bit special | ||
426 | 17:35 <vmassol> yeah we would have refactored anyay | ||
427 | 17:35 <+mflorea> guys, are you ok with xwiki-commons-40 for the tag label, or should I use xwiki-commons-pom-40? | ||
428 | 17:35 <vmassol> needs to move classloader in commons though | ||
429 | 17:36 <+tmortagne> yep | ||
430 | 17:38 <+tmortagne> we could find a way to make include macro a bit less dependent on wiki concept, like some API to get the XDOM of a target resource whatever this resource it and do all the context jingling in events like we do for script macros | ||
431 | 17:38 <vmassol> we can also have 2 include macros | ||
432 | 17:38 <vmassol> a generic one with less featrures | ||
433 | 17:39 <+tmortagne> yep | ||
434 | 17:39 <vmassol> and a xwiki one that extends it | ||
435 | 17:39 <vmassol> tmortagne: didn't see your message re the macro move. Should we do it before 3.0 final? | ||
436 | 17:39 <vmassol> or wait for 3.1 | ||
437 | 17:39 <vmassol> I'm not sure | ||
438 | 17:39 <+tmortagne> to come back to your initial question about 3.0 i'm not sure, it's not critical technically since the important thing are API and syntaxes but would be nice | ||
439 | 17:39 <vmassol> yes it would be nice I agree | ||
440 | 17:39 <vmassol> it doesn't seem too risky | ||
441 | 17:40 <+tmortagne> nop | ||
442 | 17:40 <vmassol> classloader is not very easy to move | ||
443 | 17:40 <+tmortagne> the bigger rendering is for the first announcement the better it is I guess | ||
444 | 17:40 <vmassol> needs to be split in 2 | ||
445 | 17:40 <+tmortagne> same thing for commons | ||
446 | 17:41 <+tmortagne> what is the wiki part in classloader ? | ||
447 | 17:41 <vmassol> I'm checking | ||
448 | 17:41 <+tmortagne> i use only the generic part with extension manager AFAIK | ||
449 | 17:42 <vmassol> ah AttachmentURLConnection | ||
450 | 17:42 <vmassol> uses AttachmentReference | ||
451 | 17:42 <vmassol> to resolve jars="…." attachments refs | ||
452 | 17:43 <+tmortagne> ok that could probably me moved as it is then | ||
453 | 17:43 <vmassol> yes | ||
454 | 17:44 <vmassol> xwiki-classloader-attachmentjar or something like this | ||
455 | 17:44 <+tmortagne> yep | ||
456 | 17:45 <+tmortagne> it also highlight the fact that anyone can easily add more jar handlers for macros | ||
457 | 17:45 <vmassol> yep | ||
458 | 18:17 <+mflorea> vmassol: xwiki-commons-velocity, script, management and properties have the wrong parent. It should be xwiki-commons-core right? | ||
459 | 18:18 <+tmortagne> mflorea: yep | ||
460 | 18:18 <vmassol> mflorea: checking | ||
461 | 18:18 <vmassol> hmm right | ||
462 | 18:18 <+mflorea> I'll fix it then | ||
463 | 18:18 <vmassol> fixing | ||
464 | 18:19 <vmassol> you fix or I fix? | ||
465 | 18:19 <+mflorea> I can fix it :) | ||
466 | 18:19 <vmassol> ok | ||
467 | 18:31 <vmassol> mflorea: 3 checkstyle errors | ||
468 | 18:31 <vmassol> you fixing them? | ||
469 | 18:31 <+mflorea> let me build | ||
470 | 18:34 <+mflorea> I can fix them | ||
471 | 18:34 <vmassol> k | ||
472 | 18:35 <rrodriguez> has quit | ||
473 | 19:01 <vmassol> mflorea: have you updated the top level commons pom too? | ||
474 | 19:01 <vmassol> the trunks one | ||
475 | 19:02 <+mflorea> no, updating now | ||
476 | 19:17 <+mflorea> guys, the parent for xwiki-tools is wrong I think | ||
477 | 19:17 <+mflorea> http://svn.xwiki.org/svnroot/xwiki/platform/xwiki-tools/trunk/pom.xml | ||
478 | 19:18 <vmassol> indeed | ||
479 | 19:18 <+mflorea> I released it with 39 (the previous xwiki pom) | ||
480 | 19:18 <vmassol> trying a quick change | ||
481 | 19:21 <arkub> has quit | ||
482 | 19:21 <vmassol> mflorea: what do you want to do? | ||
483 | 19:22 <vmassol> I can commit against the issue for moving to top level project | ||
484 | 19:22 <vmassol> or I create a new issue | ||
485 | 19:22 <+mflorea> I think you can commit against the existing issue, but the questions is if I need to re-release xwiki-tools pom or not? | ||
486 | 19:23 <+mflorea> I think I have, to include the new parent | ||
487 | 19:24 <vmassol> It's better but not 100% mandatory | ||
488 | 19:24 <vmassol> depends on the energy you have | ||
489 | 19:24 <vmassol> :) | ||
490 | 19:24 <vmassol> let me commit first | ||
491 | 19:24 <+mflorea> I still have :) | ||
492 | 19:24 <+mflorea> energy | ||
493 | 19:25 <vmassol> done | ||
494 | 19:31 <vmassol> got to go, bb in 1h30mn | ||
495 | 20:05 <jstoldt|Notebook> has joined #xwiki | ||
496 | 20:06 <+cjdelisle> !help | ||
497 | 20:06 <jbrBridge> !who - shows who is on the other channel | ||
498 | 20:06 <jbrBridge> !shutdown - shutdown bridge (will probably attempt to rejoin after a few seconds) | ||
499 | 20:06 <+cjdelisle> !shutdown | ||
500 | 20:12 <jstoldt|Notebook> i want to get a development environment to view the XWiki src... should i get eclipse and intelliJ? or just one? | ||
501 | 20:12 <+mflorea> tmortagne: right now rendering depends on xwiki-commons and assumes the version is $project.versions This is a PITA because I have to edit a lot of poms to resolve the snapshots. I'm going to add a property xwiki.commons.version WDYT? | ||
502 | 20:13 <+tmortagne> mflorea: yes vmassol probably forgot about that | ||
503 | 20:13 <+mflorea> ok, adding the property | ||
504 | 20:14 <+tmortagne> jstoldt|Notebook: see http://dev.xwiki.org/xwiki/bin/view/Community/DebugXEWithEclipse | ||
505 | 20:14 <+tmortagne> make me think i need to update it a bit since it's more simple than before now | ||
506 | 20:16 <jstoldt|Notebook> :) so i should go with eclipse... next question, which windows distribution of eclipse should i get? i am a bit overwhelmed by all the nice abreviations ;) | ||
507 | 20:17 <+tmortagne> jstoldt|Notebook: you can use what you want, i'm using Eclipse and i wrote a tutorial to have this easy to debug Eclipse project but you can do that with intelliJ too (some of us use it) | ||
508 | 20:17 <+tmortagne> jstoldt|Notebook: take the 2EE one | ||
509 | 20:17 <+tmortagne> J2EE | ||
510 | 20:18 <jstoldt|Notebook> okay, well, i think i'll go with eclipse | ||
511 | 20:18 <jstoldt|Notebook> and hope i can make this work on win 7 | ||
512 | 20:21 <+tmortagne> jstoldt|Notebook: i think i used to have some issue with maven/WTP on win7 (it was not deploying all the jars) but it's maybe fixed now | ||
513 | 20:21 <+tmortagne> i can assure you that it's working well on Ubuntu ;) | ||
514 | 20:21 <jstoldt|Notebook> well, i don't actually want to compile and stuff for now | ||
515 | 20:21 <jstoldt|Notebook> i just want a nicer way to browse the code | ||
516 | 20:21 <+tmortagne> ok | ||
517 | 20:22 <jstoldt|Notebook> than doing it web based | ||
518 | 20:22 <+tmortagne> than you don't really need to follow this tutorial | ||
519 | 20:22 <+tmortagne> just install m2eclipse | ||
520 | 20:22 <+tmortagne> that will allow you to easily import maven project into Eclipse | ||
521 | 20:22 <jstoldt|Notebook> great | ||
522 | 20:23 <+tmortagne> but to just read code it's possible IntelliJ is better here sincce it properly handler maven submodule | ||
523 | 20:23 <+tmortagne> in Eclipse you have to import all modules as separated eclipse projects | ||
524 | 20:24 <+tmortagne> it's taking care properly of the dependencies between the project but you loose the maven project tree visually | ||
525 | 20:24 <jstoldt|Notebook> is that only for toplevel projects or for all? | ||
526 | 20:25 <+tmortagne> every single maven pom/module will create an Eclipse project and all that at the same level | ||
527 | 20:26 <+tmortagne> so it's not the best unless you know well the organization already | ||
528 | 20:26 <jstoldt|Notebook> sorry for my ignorance, i am used to Visual Studio and C++ which is really comfortable | ||
529 | 20:26 <+tmortagne> well Eclipse for java is a lot better than Visual Studio with c++ | ||
530 | 20:26 <+tmortagne> a looot | ||
531 | 20:26 <jstoldt|Notebook> okay, i think i know what you are getting at... let me try to see what this means for me | ||
532 | 20:27 <+tmortagne> mayb it will be ok for you anyway | ||
533 | 20:27 <jstoldt|Notebook> i'll give it a shot | ||
534 | 20:27 <+tmortagne> note that with the name we give to our maven prooject it's kind of organized anyway | ||
535 | 20:27 <jstoldt|Notebook> worst case scenario, i shoot somebody in anger ;) | ||
536 | 20:27 <+tmortagne> :) | ||
537 | 20:29 <jstoldt|Notebook> well, i figure anything will be better than keep surfing the SVN ;) | ||
538 | 20:29 <+tmortagne> sure | ||
539 | 20:30 <+cjdelisle> if you want to read svn on the browser, I have a greasemonkey script for firefox which will so syntax highlighting on the text. | ||
540 | 20:30 <+cjdelisle> it's nice when reading stuff in third party libraries (apache commons) | ||
541 | 20:33 <jstoldt|Notebook> n'ah, not a firefox fan :-P | ||
542 | 20:33 <jstoldt|Notebook> i'll go long ways to avoid FF ;) | ||
543 | 20:34 <+cjdelisle> chrome user? | ||
544 | 20:34 <jstoldt|Notebook> Opera | ||
545 | 20:34 <+tmortagne> cjdelisle: seems nice, could you send it to me ? | ||
546 | 20:34 <jstoldt|Notebook> really don't like Google either | ||
547 | 20:34 <+cjdelisle> I'll attach it. | ||
548 | 20:35 <+tmortagne> jstoldt|Notebook: so you prefer the close source one ? ;) | ||
549 | 20:35 <jstoldt|Notebook> well, usually quite the opposite, actually, but what i like most about Opera is that it's ready to use without any attachments needed for my purposes | ||
550 | 20:35 <jstoldt|Notebook> and it sticks to the standards | ||
551 | 20:36 <+cjdelisle> hehe and if the website doesn't then it won't show it to you. | ||
552 | 20:37 <jstoldt|Notebook> true but at that point i just go about blaming website vendors for not sticking to the standard and browser vendors for creating buggy implementations to which website vendors create hacks | ||
553 | 20:37 <jstoldt|Notebook> ;) | ||
554 | 20:37 <+cjdelisle> indeed it is their fault but that doesn't get you the page. | ||
555 | 20:39 <+cjdelisle> http://www.xwiki.org/xwiki/bin/download/XWiki/Caleb_James_DeLisle/prettify.user.js | ||
556 | 20:39 <jstoldt|Notebook> yeah... | ||
557 | 20:39 <+cjdelisle> It's google's thing i just added an event listener to the top which tinkers with pages when it detects they're not html | ||
558 | 20:42 <+tmortagne> cjdelisle: thanks | ||
559 | 20:42 <+cjdelisle> sure thing | ||
560 | 20:48 <jstoldt|Notebook> i think http://dev.xwiki.org/xwiki/bin/view/Community/SourceRepository needs some update, too... | ||
561 | 20:55 <jstoldt|Notebook> hmmm should i get XWiki Eclipse or is that horribly outdated and of no use anymore, anyway? | ||
562 | 20:55 <mflorea> has quit | ||
563 | 20:57 <+tmortagne> jstoldt|Notebook: not horribly but a bit outdated, most of the thing should work | ||
564 | 20:57 <+tmortagne> it's just that there is bugs not fixed since a long time | ||
565 | 20:57 <jstoldt|Notebook> i see | ||
566 | 20:58 <+tmortagne> http://dev.xwiki.org/xwiki/bin/view/Community/SourceRepository is a bit outdated since it need the new commons and rendering | ||
567 | 20:59 <+tmortagne> but all the rest is still true | ||
568 | 20:59 <evalica> has joined #xwiki | ||
569 | 21:00 <jstoldt|Notebook> i know, just wanted to point it out | ||
570 | 21:14 <tmortagne> has quit | ||
571 | 22:48 <vmassol> has quit |