IRC Archive for channel #xwiki on 01 July 2014

Last modified by Vincent Massol on 2014/07/01 23:12

<Denis> has quit
01:18 <nickless> has quit
04:30 <Denis> has joined #xwiki
06:02 <Denis> has quit
06:11 <sburjan> has quit
06:11 <lynxt> has quit
06:11 <sdumitriu> has quit
06:22 <sburjan> has joined #xwiki
07:13 <msmeria> has joined #xwiki
08:10 <vmassol> has joined #xwiki
08:30 <gdelhumeau> has joined #xwiki
08:36 <evalica> has joined #xwiki
08:37 <Enygma`> has joined #xwiki
09:00 <cjd> has joined #xwiki
09:16 <mflorea> has joined #xwiki
09:27 <lucaa> has joined #xwiki
09:35 <tmortagne> has joined #xwiki
09:40 <lucaa> has quit
09:46 <Lyes> has joined #xwiki
09:56 <lucaa> has joined #xwiki
09:59 <vmassol> good morning
09:59 <vmassol> I'm trying to cherry-pick this old commit onto the 5.4.x branch: https://github.com/xwiki/xwiki-enterprise/commit/b3da56779c19f81c03d445bca89a313c1abf668e
09:59 <vmassol> but I get: "fatal: bad object b3da56779c19f81c03d445bca89a313c1abf668e"
09:59 <vmassol> if some git guru can help that would be nice :)
09:59 <vmassol> I googled a bit but couldn't find anything conclusive
10:01 <vmassol> (and I did a got pull on master)
10:01 <cjd> if you do a fresh clone, does it repeat itself?
10:01 <cjd> something to try while waiting for sdumitriu1 to wake up
10:02 <vmassol> no idea, I would prefer to avoid cloning again platform if I can avoid it ;)
10:02 <vmassol> (especially since I have lots of stashes in my working  copy)
10:02 <vmassol> can someone try it locally?
10:02 <vmassol> git cherry-pick b3da56779c19f81c03d445bca89a313c1abf668e
10:02 <vmassol> on branch:
10:03 <vmassol> stable-5.4.x
10:06 <tmortagne> vmassol: worked
10:06 <vmassol> strange
10:06 <vmassol> could you push it then? :)
10:06 <vmassol> I'll handle the jira issue
10:06 <tmortagne> (I did  git cherry-pick -x b3da56779c19f81c03d445bca89a313c1abf668e but I doubt that's the reason)
10:06 <tmortagne> sure
10:07 <vmassol> wait let me try
10:07 <tmortagne> -x just add a reference to the original commit that's all
10:07 <vmassol> same...
10:07 <vmassol> ok go
10:07 <cjd> you beat me to it.. /me pulling trunk
10:07 <tmortagne> done
10:07 <vmassol> thanks
10:11 <tmortagne> vmassol: by the way "Rule violated for bundle XWiki Platform - WYSIWYG Editor - Server Side: instructions covered ratio is 0.18, but expected minimum is 0.19"
10:11 <vmassol> arg :)
10:11 <vmassol> checking thanks
10:12 <tmortagne> ha and "org.sonar.api.utils.SonarException: License for plugin devcockpit is expired"
10:12 <tmortagne> that's what makes sonar builds fail on jenkins
10:35 <vmassol> tmortagne: shouldn't we see perf improvement on the graph of http://ci.xwiki.org/view/All/job/xwiki-enterprise-test-jmeter/lastBuild/performance/ ?
10:35 <vmassol> it seems flat at best
10:36 <vmassol> (possibly increasing a bit)
10:36 <tmortagne> vmassol: if you are referring to macro transformation improvement I doubt it's noticeable in the kind of pages we have in XE
10:37 <vmassol> I'm referring to all the work you've done recently
10:37 <vmassol> not just macro tx
10:37 <vmassol> I was expecting to see some improvements even if small
10:37 <vmassol> said differently, how do we know how much we're improving?
10:38 <vmassol> (with all your perrf-related improvements)
10:38 <vmassol> *perf
10:39 <vmassol> the point of this project/graph was to have a baseline to be able to compare to
10:40 <vmassol> I'm not yet sure how to use that baseline
10:40 <vmassol> is it recorded somewhere?
10:40 <tmortagne> the most visible things I have done recently were on memory and on initialization
10:40 <vmassol> shouldn't we take snaphosts regularly to compare?
10:40 <tmortagne> so not very visible in that report
10:43 <tmortagne> also worked on improving background tasks helpers to improve speed perception in our various tools but not very visible in this pure /view/ report
10:43 <tmortagne> I'm concentrating fully on various thing called at each request right now
10:44 <tmortagne> so I hope to really start improving that report
10:44 <vmassol> ok good
10:44 <tmortagne> "shouldn't we take snaphosts regularly to compare?" I don't understand, this is exactly what this report is
10:46 <tmortagne> you have the last snapshot in the table but the graph is an average of all snapshots
10:46 <tmortagne> (and you can access each snapshot)
10:46 <vmassol> nothing is lost?
10:46 <vmassol> we keep data forever?
10:47 <vmassol> if I want to compare now with the status on, say, 1st of april 2014, can I do it?
10:47 <tmortagne> right now the job is configured to keep 1000 builds
10:48 <tmortagne> I doubt this job existed in 1st of April
10:49 <tmortagne> it on the principal yes you can access any of the past 1000 report (and we could put more than 1000)
10:50 <vmassol> just make sure we don't loose our initial base line data
10:50 <vmassol> IMO it's interesting to compare at each release
10:50 <vmassol> so one saved snapshot at all final releases would be good
10:50 <vmassol> 5.4, 6.0, 6.1, etc
10:54 <tmortagne> 1000 is a lot of snapshot already since it means 1000 days, it was usually not built much more than once a day and is now only built once a day unless to force a build
10:55 <tmortagne> s/to/you/
10:56 <vmassol> btw it's quite slow and i'm sure it's because we keep a lot of old builds
10:57 <vmassol> at some point it may become really too slow
10:57 <tmortagne> what is slow ?
10:58 <tmortagne> accessing the snapshot itself is instant for me, the graph image on http://ci.xwiki.org/view/All/job/xwiki-enterprise-test-jmeter/lastBuild/performance/ at each request it seems so this part is slow yes
10:59 <tmortagne> the images on http://ci.xwiki.org/view/All/job/xwiki-enterprise-test-jmeter/ seems to have some caching since they are quicker to display
11:01 <vmassol> yes the image is slow to display
11:34 <lucaa> has quit
11:48 <lucaa> has joined #xwiki
12:07 <gdelhumeau> has quit
13:17 <vmassol> has quit
13:18 <Denis1> has joined #xwiki
14:10 <sdumitriu1> vmassol1: The git error is weird, looks like your git repo might be broken (bad disk?)
14:11 <sdumitriu1> Although I would expect it to fail more often
14:11 <vmassol1> hope not
14:11 <vmassol1> :)
14:11 <vmassol1> rest is working fine
14:11 <sdumitriu1> Try "git show b3da56779c19f81c03d445bca89a313c1abf668e"
14:11 <vmassol1> I tried that
14:11 <vmassol1> it shows the same error
14:11 <vmassol1> is now known as <vmassol>
14:12 <cjd> man git-fsck  ?
14:12 <cjd> that just randomly came to mind
14:14 <sdumitriu1> vmassol: Weird, I get the same...
14:15 <sdumitriu1> So it looks like it is a missing commit
14:15 <vmassol> sdumitriu1: it worked for tmortagne
14:15 <tmortagne> yep no problem for me
14:15 <sdumitriu1> Wait, I was in the wrong repo
14:16 <tmortagne> and vmassol copy pasted the link to the original commit so it exist on github
14:16 <sdumitriu1> Yep, it's there in enterprise
14:16 <vmassol> ahhhhhh
14:16 <vmassol> stupid me
14:16 <vmassol> I was in platform
14:16 <vmassol> .....
14:17 <tmortagne> :)
14:17 <tmortagne> not very nice error reporting
14:21 <vmassol> tmortagne: we still cannot reference an exisiting translation key inside a translation value?
14:22 <vmassol> something like:
14:22 <vmassol> [email protected]
14:22 <vmassol> ?
14:22 <tmortagne> there is no new syntax no
14:22 <vmassol> ok too bad
14:22 <vmassol> that would have saved a lot of unnecessary translations
14:24 <tmortagne> you could also use the same translation key in several places...
14:24 <vmassol> I cannot here
14:24 <vmassol> it's a livetable
14:24 <vmassol> the prefix is fixed
14:25 <tmortagne> you choose the prefix in the livetable configuration
14:25 <vmassol> I have 5 columns, 4 are the same as another LT and one is specific to my use case
14:25 <vmassol> I know how LT translations works tmortagne ;)
14:26 <tmortagne> this is not really "a lot of unnecessary translations"
14:26 <vmassol> sdumitriu, mflorea: do we have doc on how to use a computed field?
14:26 <vmassol> tmortagne: it's 4 x number of laguages
14:27 <vmassol> so it's a lot of *unnecessary* translations
14:27 <vmassol> when we release my stuff there won't be transaltions available in all languages when it should have them, unless I spend substantial times doing lots of copy pastes
14:27 <mflorea> vmassol: I don't think there is any besides the release notes
14:28 <vmassol> :(
14:28 <mflorea> did you find the release notes?
14:28 <vmassol> I checked the RN and they don't say much
14:28 <mflorea> ok
14:28 <cjd> trandlations.properties --> translations.js    turing complete data representation ftw xD
14:28 <vmassol> http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWikiEnterprise42M2#HComputedclassfields ?
14:28 <mflorea> yes
14:28 <vmassol> there's a script property
14:28 <vmassol> should I put wiki syntax in there?
14:28 <vmassol> ie {{velocity}}...
14:28 <vmassol> ?
14:29 <mflorea> yes
14:29 <vmassol> should I handle both view and edit?
14:29 <vmassol> (modes)
14:29 <vmassol> like the custom display
14:29 <vmassol> ?
14:29 <cjd> foo={{velocity}}$msg.get('foo'){{/velocity}}
14:29 <mflorea> yep
14:29 <vmassol> what's the diff with custol display?
14:29 <vmassol> *custom
14:29 <mflorea> checkout what AWM generates when you add the Content or Title field to an app
14:30 <vmassol> it would be nice to doc this....
14:30 <vmassol> we let this through in our doc process and it's not nice :)
14:31 <tmortagne> vmassol: http://l10n.xwiki.org/xwiki/bin/view/L10N/Refactoring#HCopyakey
14:31 <tmortagne> it should not be that much copy/pasting
14:31 <vmassol> mflorea: ok I've checked AWM
14:31 <vmassol> it doesn't use the script field!
14:31 <vmassol> it uses only custom display
14:32 <mflorea> ok
14:32 <vmassol> so I'm a bit lost as to the usage of the script field
14:32 <vmassol> it seems not needed
14:32 <mflorea> it is
14:32 <mflorea> if you call display then the custom display is evaluated, but if you call getValue then the output of the script is evaluate
14:32 <mflorea> I think
14:32 <mflorea> to be double checked :)
14:33 <vmassol> I see
14:33 <mflorea> so script --> the value, custom display --> how the value is displayed
14:33 <vmassol> hard to guess without doc ...
14:33 <mflorea> :)
14:33 <vmassol> wow http://localhost:8080/xwiki/bin/edit/AppWithinMinutes/Content?editor=wiki is pretty complex ;)
14:34 <vmassol> hmm too bad I cannot reuse it…
14:34 <vmassol> I mean call it
14:34 <vmassol> include it
14:34 <vmassol> I could but then if AWM is removed my app doesn't work anymore
14:34 <vmassol> I think we need this somewhere where it can be reused
14:35 <vmassol> it's too complex
14:35 <vmassol> including niceties like:
14:35 <vmassol>       ## The tool bar may have an entry to insert an HTML macro. Make sure it doesn't break the HTML macro we are currently in.
14:35 <vmassol> ;)
14:36 <vmassol> mflorea: btw this means AWM doesn't generate a valid class? :)
14:36 <cjd> they were reusing simpleedittoolbar.vm :)
14:36 <vmassol> since the script field is empty
14:36 <vmassol> so if you call getValue on the property you may get some wrong result
14:38 <OSIMasson> has quit
14:41 <mflorea> vmassol: re missing script tag, you're probably right, shouldn't be empty, my focus was the functional part, it seems no one called getValue so far
14:41 <vmassol> yeah
14:42 <mflorea> re content displayer, yes would be nice to have it reusable, but I'm not sure where it would be put, we need a new app
14:42 <vmassol> or some way in the oldcore to handle content editable as a peoprety
14:43 <vmassol> *property
14:43 <vmassol> hmm getValue doesn't for me ddebugging
14:51 <vmassol> hmm
14:51 <vmassol> {
14:52 <vmassol> I think getValue() doesn't work for a computed property
14:52 <mflorea> ok, it seems I don't know that much :)
14:53 <mflorea> I guess display() returns the output of script if there's not custom display
14:53 <vmassol> display works
14:53 <vmassol> it calles getScript()
14:53 <vmassol> *calls
14:53 <mflorea> in this case the script and custom display are doing the same thing
14:53 <vmassol> so far yes
14:54 <mflorea> just that I wouldn't put code for edit mode in script
14:54 <vmassol> getScript can also be called but you'll then need to evaluate it yourself...
14:54 <mflorea> even if getValue doesn't work, I think it's better to keep the value in script and dislay logic (view/edit) in custom display
14:54 <vmassol> yes it's what it's for
14:55 <mflorea> this way it's easier to see the value, otherwise you need to visually 'parse' the display code
14:55 <mflorea> when you look at the xclass
14:57 <mflorea> btw http://jira.xwiki.org/browse/XWIKI-8095
14:57 <vmassol> ahaha
14:57 <vmassol> "hmm I'm not sure it's correct to put N/A for the documentation field. IMO this needs to be documented in the Developer Guide somewhere."
14:57 <vmassol> so I had caught it!
14:57 <vmassol> sdumitriu: anything to say for your defence? ;)
14:58 <vmassol> *defense
14:58 <vmassol> the doc says:
14:58 <vmassol> " • Computed pseudofield (new in 4.2M3)"
14:58 <vmassol> missing a bit of information ;)
15:05 <vmassol> tmortagne: I'll let you do http://l10n.xwiki.org/xwiki/bin/view/L10N/Refactoring#HCopyakey if it's easy, ok? :)
15:06 <tmortagne> you just need to indicate source and target key and it copied all translations
15:06 <vmassol> "just"
15:06 <tmortagne> copies
15:06 <vmassol> you mean just 4 times?
15:06 <vmassol> ok that's not too bad then
15:06 <vmassol> even though it's still a lot of dup
15:06 <tmortagne> it's not the same translation resource ?
15:06 <vmassol> and when someone changes a key I'm 100% sure they won't change the other plazces
15:07 <msmeria> has quit
15:08 <vmassol> this copy tool is nice and is better than nothing for sure… thanks for pointing it out
15:11 <vmassol> mflorea: any idea how I could display the title entered by the user in wiki mode for ex?
15:11 <mflorea> wdym by 'display'? I guess you're not talking about $doc.plainTitle
15:12 <vmassol> mflorea: this is what I have so far:
15:12 <vmassol> https://gist.githubusercontent.com/vmassol/da345772633c23d71ab9/raw/970f6dd173274d3ad53e72a152e6a11ef024feb1/gistfile1.txt
15:12 <vmassol> this works fine for the content
15:12 <vmassol> ah wait
15:13 <vmassol> again just me being stupid I think
15:13 <vmassol> (I didn't sleep much yesterday ;))
15:13 <mflorea> :)
15:27 <vmassol> hmm not easy
15:41 <vmassol> actually it is
15:58 <Denis1> has quit
15:59 <evalica> has quit
15:59 <Enygma`> has quit
16:04 <tmortagne> anyone knows where wiki module API is documented on extensions.xwiki.org ? can't find anything else that the UI, I'm sure I'm not searching properly but I was expecting to find it in "Wiki Module" page like for all other modules
16:06 <tmortagne> vmassol: any idea ?
16:06 <vmassol> I think guillaume has not added it, I pinged him  few times about it...
16:06 <tmortagne> ok
16:55 <vmassol> guys, is it normal that if I use some velocity script in a wiki page in edit mode to set some xproperty, it's not saved when the page is saved?
16:59 <vmassol> tmortagne, mflorea, any idea about that? I wanted to change the doc and let the user decide whether to click save or cancel
16:59 <vmassol> anyway I can do something else
17:00 <tmortagne> you sure it's not saved ?
17:00 <vmassol> yes
17:00 <vmassol> when I check in object mode afterwards, it's the same value as before the edit
17:00 <tmortagne> IMO there is no reason, you are using Document#save() .
17:01 <tmortagne> ?
17:01 <mflorea> vmassol: I don't understand. You have an input with the proper name and it isn't saved?
17:01 <vmassol> my point was to not have to call save()
17:01 <vmassol> mflorea: I change an xproperty in edit mode in velocity
17:01 <vmassol> and I wanted to let the user click "save" or "cancel" button
17:02 <vmassol> and I was expecting that when he clicks "save" that my change would be persisted
17:02 <mflorea> I don't understand what you mean by 'change'
17:02 <vmassol> $object.set('propkey', value)
17:02 <mflorea> the only thing that is saved is what is submitted
17:02 <tmortagne> vmassol: you are talking about two totally different request here
17:02 <vmassol> ok
17:02 <tmortagne> whatever you do during the edit display is not going to be part of the form sent by save button
17:02 <mflorea> how could that work? the save action only takes into account what is being submitted. You changes are lost ofc
17:03 <tmortagne> what you can so is add some hidden inputs I guess
17:03 <mflorea> you need a hidden input most probably
17:03 <vmassol> we could make that wiork
17:03 <mflorea> yep
17:03 <vmassol> if we wanted
17:03 <tmortagne> but it works only with object that already exist
17:03 <tmortagne> which is a pity, I have the same issue with XWiki Repository
17:05 <tmortagne> basically we need XWIKI-10252
17:05 <tmortagne> then you can add as many object as you want as hidden inputs
17:09 <vmassol> cool it all works now :)
17:10 <vmassol> now I need to test migrations, I'm a bit worried by that
17:12 <mflorea> has quit
17:38 <tmortagne> vmassol: did you saw my message about sonar devcockpit plugin ?
17:38 <vmassol> nope
17:39 <tmortagne> "org.sonar.api.utils.SonarException: License for plugin devcockpit is expired"
17:39 <tmortagne> that's what make all our sonar builds fail
17:39 <vmassol> ok I'll ask for a license renewal
17:40 <vmassol> they all expire today apparently
17:40 <vmassol> we use 3 plugins with a license
17:43 <vmassol> mail sent
17:44 <woshilapin> has quit
17:46 <tmortagne> ok cool
17:49 <vmassol> [fun] https://twitter.com/izs/status/483992648672227328/photo/1 ;)
17:51 <vmassol> tmortagne: FYI I just rebuilt only enterprise and I got:  https://gist.githubusercontent.com/vmassol/be202386a2ac4c031658/raw/79a214936feb594eeb72870523d0c2bef910601e/gistfile1.txt
17:52 <vmassol> (maybe it's CI who hasn't build stuff in the right order)
17:52 <tmortagne> all I can confirm is that this method exist
17:52 <tmortagne> did you built with -U ?
17:52 <tmortagne> if you built today already Maven won't re'download the snapshots
17:53 <tmortagne> re-download
17:53 <vmassol> yes likely
17:57 <vmassol> tmortagne: if I build enterprise master and then replace jetty/hsqldb's data/ dir by one from a previous version and start XE shouldn't I get the DW?
18:02 <tmortagne> if it's not the same version yes you should get the DW
18:03 <vmassol> then I don't understand why I don't get it :)
18:03 <tmortagne> since that's like upgrading the war
18:03 <vmassol> I'm logged in as admin
18:05 <tmortagne> you can check what you have in the distribution status or try accessing directly /distribution/ action to see what you get
18:05 <vmassol> k, I'm rebuilding with -U ATM to be sure I have a working XE
18:06 <mflorea> has joined #xwiki
18:08 <vmassol> tmortagne: you didn't voice any opinion on the thread related to http://jira.xwiki.org/browse/XWIKI-10586
18:08 <vmassol> I hope you're ok with it :)
18:08 <vmassol> (since I finished implementing a first version, worst case, I'll put it as an extension on e.x.o anyway)
18:11 <tmortagne> vmassol: did not spend much time analyzing it but I don't have strong opinion on it
18:13 <vmassol> I think we could also move the welcome pages to this app
18:13 <vmassol> hmm maybe not
18:13 <vmassol> forget that
18:13 <vmassol> the welcome pages are linked to the dashboard app
18:15 <tmortagne> vmassol: could this be used for spaces hope pages too ?
18:16 <vmassol> yes it could
18:16 <tmortagne> s/hope/home/
18:16 <vmassol> the only thing to take into account is the default title
18:16 <vmassol> right now I've hardcoded it to the translation key for the main home page
18:17 <vmassol> the rest should work fine for any page actually
18:17 <vmassol> so to activate it you just need an xobject of type HomePageClass
18:18 <tmortagne> thinking about this since when you create a new space you have a Dashboard similar to wiki home page proposed
18:18 <tmortagne> so pretty much the same issues I guess
18:18 <vmassol> if we generify it,  it could be called an Include Application I guess
18:19 <vmassol> since it allows selecting a page to include (and optionally specifying your own content)
18:21 <tmortagne> hmm this look a lot like what XWiki.DocumentSheetBinding is doing
18:23 <tmortagne> it's
18:23 <tmortagne> it's XWiki.DocumentSheetBinding plus custom content
18:24 <vmassol> tmortagne: I've added some screenshot of what I have so far on 6
18:24 <vmassol> 6
18:24 <vmassol> grr
18:25 <vmassol> http://jira.xwiki.org/browse/XWIKI-10586
18:32 <vmassol> tmortagne: I get the DW now with my new build with -U
18:33 <tmortagne> vmassol: ok, it's probably because DW use the new method then
18:33 <tmortagne> I guess it's simply crashed
18:33 <vmassol> yes probably
18:35 <vmassol> tmortagne: just seen your reply. Where would you store the page to include?
18:36 <tmortagne> vmassol: not sure I understand the question, the goal of DocumentSheetBinding is to indicate a page to display instead of the document content, you can call that include but it's the same thing
18:36 <tmortagne> DocumentSheetBinding has a sheet property
18:36 <tmortagne> that's the only property actually
18:36 <vmassol> the user chooses the page to include
18:36 <tmortagne> yes
18:36 <vmassol> this needs to be stored somewhere
18:37 <vmassol> I store it in an xobject
18:37 <tmortagne> the page to include is the sheet
18:37 <vmassol> for ex the user wants the home page to be Blog.WebHome
18:38 <vmassol> I don't see how I can implement it without a new xclass
18:38 <vmassol> and storing the page to include in the home page content wouldn't work for the user (too technical)
18:39 <tmortagne> vmassol: I really don't understand, DocumentSheetBinding is a class which indicate which page to execute instead of the document content
18:40 <tmortagne> so looks like it's doing the same thing as your class, except for the optional part
18:40 <vmassol> ah I think I understand
18:40 <vmassol> it's not exactly a sheet
18:41 <vmassol> (semantically)
18:41 <vmassol> but yes it would work
18:45 <tmortagne> is the target page supposed to be executed in its own context or in the context of the current page ?
18:51 <Lyes> has quit
18:51 <vmassol> tmortagne: I include with context=new
18:51 <tmortagne> so it's not an include
18:51 <tmortagne> it's a display
18:51 <vmassol> indeed it's a display
18:54 <tmortagne> so that would be the difference with DocumentSheetBinding that would justify a new class
18:55 <vmassol> indeed
18:55 <tmortagne> but since it's just about displaying a page, a name more generic than HomePage.HomePageClass could be nice :)
18:56 <vmassol> yes it's about changing the default edition of a page to also allow displaying the content of another page…
18:57 <vmassol> I've thought about it and HomePage app isn't that bad
18:57 <vmassol> since this is useful especially for home pages
18:57 <tmortagne> but make the feature a lot less generic since it imply it's only for home pages
18:58 <vmassol> that's not that bad
18:58 <vmassol> it's like DocumentSheetBinding which is supposed to be used for sheets
18:58 <vmassol> but your proposal uses it not as sheet but as the page to include
18:58 <vmassol> maybe a bad comparison
18:58 <vmassol> ;)
18:58 <vmassol> but you see what I mean hopefully
18:59 <vmassol> anyway I'm open for a better name, but I dont like too much Display App, Redirect App
18:59 <tmortagne> you can use DocumentSheetBinding in any document and it does a bit more than include since it also takes the title form the target page
18:59 <tmortagne> s/form/from/
18:59 <tmortagne> it's not a redirect so not redirect
18:59 <vmassol> technically no
19:00 <vmassol> but from the user pov it can be
19:00 <tmortagne> if display is not a proper name then it's not the right name for the display macro :)
19:00 <vmassol> it's a technical name
19:00 <vmassol> technical concept
19:00 <vmassol> which is fine for a macro
19:00 <mflorea> has quit
19:00 <vmassol> but Display app doesn't mean anything
19:00 <vmassol> it means an app that displays something
19:01 <tmortagne> "display" is that than technical, you want to display some page
19:01 <vmassol> that's very generic
19:01 <vmassol> way too generic
19:01 <vmassol> almost all apps do display something
19:01 <tmortagne> I'm talking about the class, I don't really see why this require a new app
19:02 <vmassol> Page Chooser Application
19:02 <vmassol> because this is something optional
19:02 <vmassol> I don't want this in an existing module
19:03 <vmassol> Page Display Choose Application but it starts to be too complex
19:03 <vmassol> personally I like Home Page application the best so far
19:03 <vmassol> right now the app contains 5 pages fyi
19:04 <tmortagne> limiting this feature only to home pages would be a pity IMO...
19:04 <vmassol> it's the use case that we wish to implement
19:04 <vmassol> we'll have wording for that
19:04 <vmassol> if we use a too geenric wording
19:04 <vmassol> we'll loose the reason we are creating this
19:05 <vmassol> what we are doing here is the opposite of genericity
19:05 <vmassol> we're creating something tailored for the home page
19:05 <vmassol> now that devs could tune it to reuse it for other use cases is fine with me
19:05 <cjd> has quit
19:06 <tmortagne> "Default Page Application" it display a default page in case you don't have custom content
19:06 <vmassol> that's better than the other proposals indeed
19:07 <tmortagne> you get the generic part at least and does not sounds too technical
19:08 <vmassol> but again we would need to ensure the wording works fine
19:08 <vmassol> (ie not too generic)
19:08 <vmassol> that could work I think
19:08 <tmortagne> it's not more generic than the feature itself I think
19:10 <tmortagne> I have to go, sorry for waking up after the battle (fortunately I did not had strong opinion :D)
19:10 <vmassol> it's ok you said +1 for the concept ;)
19:10 <vmassol> changing the name is an impl detail that's not too hard
19:11 <vmassol> you hsould propose "Default Page App" to see how others react to it
19:11 <vmassol> we still need to find a way to define the default title
19:11 <tmortagne> yep I writing an answer to me right now
19:11 <vmassol> but that could be a property in the xclass
19:12 <tmortagne> the default title could be the target page title
19:12 <vmassol> right now that would mean "Dashboard"
19:12 <vmassol> instead of "Wiki Home"
19:12 <OSIMasson> has joined #xwiki
19:13 <tmortagne> but we would but a custom title in the wiki home page
19:13 <tmortagne> s/but/put/
19:13 <vmassol> no
19:13 <vmassol> :)
19:13 <vmassol> that would fail one of my use case
19:13 <vmassol> which is to not have anything technical
19:13 <vmassol> :)
19:13 <tmortagne> title concept is technical ?
19:13 <vmassol> seeing $services.localization.render(…) is technical
19:14 <vmassol> :)
19:14 <vmassol> (you forgot translations)
19:14 <tmortagne> only the wiki home page know it's about wiki home page so I don't really see how it would not be a custom title
19:14 <vmassol> as I said
19:15 <vmassol> this could be in the xclass
19:15 <vmassol> simple user would not see the xobjects
19:15 <vmassol> but he would see the title
19:15 <tmortagne> how is it not a custom title ?
19:16 <vmassol> you lost me here...
19:16 <vmassol> "but we would but a custom title in the wiki home page" WDYM?
19:17 <vmassol> (show me an example of such a custom title)
19:17 <tmortagne> yes in the wiki home page, I did not say where in the wiki home page
19:17 <vmassol> ok then if you agree it cannot go in the title field
19:17 <tmortagne> all I'm saying is that only this page knows what it's about so I don't see how it could be somwhere else
19:17 <vmassol> then we agree it would have to go in the xobject
19:19 <tmortagne> I'm not sure what xobject bring exactly, the user should not see the title field either in inline edit mode
19:19 <vmassol> btw
19:20 <vmassol> he doesn't see it
19:20 <vmassol> s/btw//
19:20 <vmassol> it hides the default title value from the user
19:20 <vmassol> (simple user)
19:22 <vmassol> btw it's not exactly the same thing for a space
19:23 <vmassol> it's actually very different
19:23 <tmortagne> it's not very clear what you want exactly, if the goal is to protect default title from user editing the title field then OK but it sound a bit more meaningful than just "hiding some technical title"
19:23 <vmassol> going to reploy to your mail
19:24 <tmortagne> have to go, will read that later
19:24 <tmortagne> bye
19:24 <vmassol> bye and htnaks
19:24 <tmortagne> has quit
19:51 <lucaa1> has joined #xwiki
19:53 <lucaa> has quit
20:02 <nickless> has joined #xwiki
20:29 <lucaa1> has quit
21:33 <lucaa> has joined #xwiki
21:50 <vmassol> has quit
21:50 <vmassol> has joined #xwiki
21:53 <vmassol1> has joined #xwiki
21:53 <vmassol> has quit
21:54 <vmassol1> has quit
21:56 <vmassol> has joined #xwiki
21:57 <OSIMasson> has quit
22:57 <vmassol> has quit
23:12 <Denis> has joined #xwiki
Tags:
   

Get Connected