IRC Archive for channel #xwiki on 23 September 2015

Last modified by Vincent Massol on 2015/09/23 23:58

<ansuz> has quit
00:09 <ansuz> has joined #xwiki
00:59 <Slashman> has joined #xwiki
01:25 <Slashman> has quit
03:48 <cjd_> has joined #xwiki
03:51 <cjd> has quit
05:26 <Ramona1> has joined #xwiki
05:45 <mflorea> has joined #xwiki
05:54 <Ramona1> has quit
06:01 <Denis1> has joined #xwiki
06:03 <Denis> has quit
07:00 <Ramona1> has joined #xwiki
07:01 <Ramona1> has quit
07:43 <mflorea> has quit
08:22 <vmassol> has joined #xwiki
08:31 <Ramona2> has joined #xwiki
08:32 <cjd_> has quit
08:40 <msmeria> has joined #xwiki
08:41 <gsmeria> has joined #xwiki
08:42 <KermitTheFragger> has joined #xwiki
09:01 <woshilapin> has joined #xwiki
09:03 <tmortagne> has joined #xwiki
09:15 <cjd> has joined #xwiki
09:23 <mflorea> has joined #xwiki
09:40 <vmassol> tmortagne: seems we have an export bug/limitation
09:40 <vmassol> http://localhost:8080/xwiki/bin/export/Sandbox/WebHome?format=xar&pages=Main.WebHome&history=true fails but if I add the name parameter it works. We could make it work without having to specify a name and use some default (like the current page name for example). WDYT?
09:40 <vmassol> checking the dco now
09:40 <vmassol> *doc
09:41 <vmassol> indeed the doc doesn't say that name is mandatory
09:41 <vmassol> actually doc doesn't even document the name parameter :)
09:41 <Trefex> has joined #xwiki
09:41 <vmassol> checking code now
09:43 <vmassol> hmmm
09:43 <vmassol> it should work with a default name of "export" from what I see in the code
09:43 <vmassol> (or "backup")
09:43 <vmassol> debugging now
09:44 <tmortagne> no name is supposed to mean the whole wiki AFAIK
09:44 <vmassol> I'm not saying no pages
09:44 <tmortagne> foget that I tough you were talking about page parameter
09:45 <tmortagne> no name should work, it's probably very minor
09:45 <vmassol> indeed
09:45 <vmassol> the code returns "export" :)
09:45 <vmassol> and stops
09:45 <tmortagne> since the name we pass by default is the page reference we should simply use that by default IMO
09:45 <tmortagne> (and probably stop passing it in the UI)
09:45 <vmassol> we should change return "export"; by name = "export"
09:46 <vmassol> and that should work fine
09:47 <vmassol> I have a meeting in 15 minutes now so I can either work on this around 14:00 or you could do it if you want
09:47 <vmassol> (note that I haven't reproduced amrita's issue)
09:48 <vmassol> FTR the problem is on
10:00 <vmassol> tmortagne: I've created I'll handle it later in the afternoon
10:01 <tmortagne> vmassol: ok
10:01 <gdelhumeau> has joined #xwiki
10:02 <tmortagne> vmassol: it was probably made like this on purpose given the code but I really don't see the point
10:02 <vmassol> I've checked the history
10:02 <vmassol> it was done by ludo a very long time ago
10:02 <vmassol> and I think he just made a mistake
10:02 <vmassol> anyway
10:02 <vmassol> been like this for very long now and it's easyt o fix
10:06 <ol-ow2> has joined #xwiki
10:08 <ldubost> has joined #xwiki
10:32 <mflorea> tmortagne: I checked a bit the 2 failing repository tests to see if they are still caused by my Solr changes and this time it seems the problem is that TestUtils#getInputStream returns null. I can access those pages outside the tests. I see you claimed these tests.
10:33 <tmortagne> I claimed them before seeing the issue with solr actually
10:33 <mflorea> ok, I can continue the investigation if you're busy with something else
10:34 <tmortagne> no I will get back to it, if it's not solr then it's probably my rest test toolkit refactoring
10:34 <tmortagne> I'm done with the perf report anyway
10:34 <mflorea> ok, good, I'll check the other failing tests then
10:37 <tmortagne> mflorea: it's only failing on master, right ?
10:37 <mflorea> yes
10:37 <tmortagne> ok
10:37 <tmortagne> so it cannot really be anything else than the TestUtils refctaoring I guess
10:41 <Slashman> has joined #xwiki
11:23 <ldubost> has quit
11:25 <ldubost> has joined #xwiki
11:31 <tmortagne> cjd: looks like you are missing a <developpers> section in
11:32 <tmortagne> right now the extension ends up with xwiki-commons developpers section (i.e. XWiki Dev Team)
11:33 <cjd> that's a bit of an unfortunatel default ?  Do you suppose you could write the patch ?
11:34 <tmortagne> cjd: it's not a default, this is the right information for xwiki-commons
11:34 <tmortagne> you have to override it
11:42 <cjd> Are you patching that ?  I have to fix something else so I will have to release
11:42 <gsmeria> has quit
11:45 <ldubost2> has joined #xwiki
11:46 <ldubost> has quit
11:46 <ldubost2> is now known as <ldubost>
11:46 <jvipa5g> has joined #xwiki
11:47 <jvipa5g> hi! as I can enable LDAP authentication on a standalone installation?
11:53 <jvipa5g> hi! as I can enable LDAP authentication on a standalone installation?
11:58 <gsmeria> has joined #xwiki
12:16 <tmortagne> jvipa5g: LDAP authenticator is included in the default XWiki Enterprise if that's the question
12:43 <jvipa5g> exit
12:43 <jvipa5g> has quit
13:10 <ldubost> has quit
13:11 <ldubost> has joined #xwiki
13:14 <ldubost> has quit
13:34 <vmassol> ok coming to get some news on the 7.2 release
13:35 <vmassol> how are we on the CI? I see plenty of failing tests
13:35 <vmassol> where can I help?
13:35 <tmortagne> vmassol: there is not plenty for 7.2
13:36 <vmassol> tmortagne: is it normal that the jmeter job is failing (didn't check yet)?
13:36 <tmortagne> I'm looking at it
13:36 <tmortagne> it's failing since the move as far as I can see
13:37 <tmortagne> but when debugging it does not seems related to the environment
13:37 <tmortagne> anyway I think I found a fix, currently running locally to check
13:37 <vmassol> ok
13:37 <vmassol> 5 tests failing for master, 4 for 7.2
13:37 <vmassol> checking sonar job
13:38 <vmassol> 12 failing ofr 6.4.x
13:38 <vmassol> (not counting platform ยง`.4)
13:38 <vmassol> *6.4
13:59 <ldubost> has joined #xwiki
13:59 <ldubost> has quit
14:01 <ldubost> has joined #xwiki
14:17 <vmassol> gdelhumeau: hi, I rmemeber seeing some comments from you saying that some feature was going to be more costly in perf now that we display titles, do you remember?
14:17 <gdelhumeau> displaying titles in the livetable maybe?
14:17 <vmassol> ah yes I think that's it
14:18 <vmassol> has this been done already btw?
14:18 <gdelhumeau> in the children/siblings views
14:19 <gdelhumeau> note: not in the Document Inde
14:19 <vmassol> so AllDocs doesn't display NS info nicely ATM?
14:19 <vmassol> do we have a jira issue?
14:19 <vmassol> (couldn't find one-
14:19 <vmassol> )
14:20 <vmassol> (it also means some discrepancies between livetabls)
14:21 <vmassol> and displaying of "WebHome" in the UI :)
14:22 <vmassol>
14:22 <gdelhumeau> we had XWIKI-12218 which was close
14:22 <vmassol> Location also displays the . apparently
14:22 <vmassol> (just checked)
14:23 <gdelhumeau> but it seems no proper jira issue
14:23 <vmassol> I wonder if we couldn't use the breadcrumb display (or something like this) instead of the dot notation
14:23 <vmassol> note that it would be less nice when copy pasting reference ;)
14:24 <vmassol> (but that could be solved in a different way)
14:24 <vmassol> and breadcrumb is probably too expensive in a LT
14:24 <vmassol> but a view like the breadcrulmb could work
14:24 <vmassol> anyway creating a jira issue for 7.3
14:34 <vmassol> gdelhumeau: I've created XWIKI-12608
14:34 <gdelhumeau> thx
14:56 <Ramona2> has quit
15:13 <ldubost> has quit
15:30 <gsmeria> has left #xwiki
15:33 <vmassol> mflorea: addFilter('hidden') is deprecated now, no? 'hidden/document' should be used instead, right?
15:33 <mflorea> yep
15:33 <vmassol> ok I'll fix the usages then
15:33 <vmassol> (seems you left them as is)
15:33 <mflorea> tmortagne added hidden/document and hidden/space
15:33 <mflorea> where?
15:33 <vmassol> ah ok thought it was you
15:33 <vmassol> in wiki pages
15:34 <mflorea> ah
15:35 <mflorea> I remember I fixed it in the document tree
15:35 <vmassol> yep seen that
15:36 <tmortagne> vmassol: did not really tough much about whether "hidden" should be deprecated or not, just made sure a hidden/document version more consistent with hidden/space exist
15:36 <vmassol> tmortagne: but do yu agree that having 2 is not the best option and that we should keep only 1?
15:37 <vmassol> (and deprecate the other one)
15:38 <vmassol> if we agree I can take care of it
15:38 <vmassol> I've done the changes locally already
15:38 <tmortagne> actually what I did is more or less a quick fix from my point of view. Ideally at some point I believe we should have a "hidden" filter that hide everything with the concept or hidden whatever (probably trough some extension point)
15:38 <ldubost> has joined #xwiki
15:39 <vmassol> BTW what is a 'hidden' space?
15:39 <vmassol> (how do you make a space hidden?)
15:39 <tmortagne> same as before, just a shortcut in space table
15:40 <vmassol> before you had to set all the docs as hidden inside a space to make it hidden, no?
15:40 <tmortagne> it's still the case
15:40 <tmortagne> nobody is supposed to touch space table
15:40 <Trefex> has quit
15:40 <tmortagne> right now space table and dynamically generated based on modification on document table
15:40 <Trefex1> has joined #xwiki
15:40 <vmassol> ok so this field is acting as a cache
15:40 <tmortagne> like the whole table yes :)
15:41 <vmassol> when a new not hidden doc is added in a hidden space, the hidden field is reset to fasle
15:41 <vmassol> correct?
15:42 <tmortagne> yes and for all the space parents
15:42 <vmassol> k thanks
16:14 <xwikibot> has joined #xwiki
16:14 <ldubost2> has joined #xwiki
16:15 <ldubost> has quit
16:26 <msmeria> has quit
17:10 <mflorea> has quit
17:13 <vmassol> gdelhumeau: re the release and XWIKI-12570
17:14 <vmassol> I see that XWIKI-12570 is marked as a rgeression, do we know when it was introduced?
17:14 <gdelhumeau> no, and it's difficult to reproduce
17:16 <gdelhumeau> but as a security issue, it's critical
17:17 <vmassol> ok so we need Denis1's input on your last comments before we can start the release
17:18 <tmortagne> vmassol: it's probably like since since we move to the new security module
17:18 <tmortagne> s/move/moved/
17:19 <vmassol> tmortagne: ok so we could consider that it's critical but that we could release 7.2 without it, right?
17:19 <vmassol> (I've pinged Denis on skype, asking him to comment on gdelhumeau's comment)
17:19 <tmortagne> unless the race condition that "exploit" it happen more often now
17:20 <tmortagne> we since we don't know for sure what really cause it...
17:20 <gdelhumeau> I'm already talking to Denis1, but he is off for now
17:20 <vmassol> ok
17:36 <ol-ow2> has quit
18:14 <ldubost> has quit
18:19 <KermitTheFragger> has quit
18:39 <Trefex1> has quit
18:55 <vmassol> has quit
18:55 <vmassol> has joined #xwiki
19:00 <vmassol> has quit
19:00 <vmassol> has joined #xwiki
20:03 <gdelhumeau> has quit
20:07 <ldubost> has joined #xwiki
20:15 <cjd> has quit
20:26 <Ramona1> has joined #xwiki
20:36 <Slashman> has quit
20:39 <ldubost> has quit
20:39 <Slashman> has joined #xwiki
20:45 <Slashman> has quit
20:56 <vmassol> has quit
20:57 <vmassol> has joined #xwiki
20:58 <vmassol> has quit
21:05 <cjd> has joined #xwiki
21:49 <sdumitriu> has quit
21:51 <Ramona1> has quit
22:04 <sdumitriu> has joined #xwiki
22:49 <mflorea> has joined #xwiki
22:54 <woshilapin> has quit
23:00 <mflorea> has quit
23:58 <tmortagne> has quit

Get Connected