Wiki source code of IRC Archive for channel #xwiki on 05 July 2016
Last modified by Vincent Massol on 2016/07/05 23:52
Show last authors
author | version | line-number | content |
---|---|---|---|
1 | <mflorea> has joined #xwiki | ||
2 | 07:39 <msmeria> has joined #xwiki | ||
3 | 08:19 <Aranjedeath> has quit | ||
4 | 08:32 <vmassol> has joined #xwiki | ||
5 | 08:33 <KermitTheFragger> has joined #xwiki | ||
6 | 08:48 <vmassol> sonar licenses updated! | ||
7 | 09:00 <tmortagne> has joined #xwiki | ||
8 | 09:23 <mflorea> has quit | ||
9 | 09:27 <vmassol> one less job failing :) | ||
10 | 09:29 <vmassol> haha found something for the stackoverflow issue of the quality job, trying it.... | ||
11 | 09:33 <vmassol> done, we'll see during the next job runs if it works or not | ||
12 | 09:33 <vmassol> (FYI see the "notes" on http://ci.xwiki.org/ where I explained what I added) | ||
13 | 09:33 <vmassol> (the XX:ThreadStackSize thing) | ||
14 | 09:35 <vmassol> fixing quality job on 7.4.X branch: [WARNING] Rule violated for bundle XWiki Platform - Legacy - Model: instructions covered ratio is 0.34, but expected minimum is 1.00 | ||
15 | 09:40 <acotiuga> has joined #xwiki | ||
16 | 09:43 <vmassol> guys rest tests are still failing on master: http://ci.xwiki.org/job/xwiki-enterprise-test-rest/lastCompletedBuild/testReport/ | ||
17 | 09:44 <vmassol> there's also some NPE in the logs | ||
18 | 09:44 <vmassol> for ex http://ci.xwiki.org/job/xwiki-enterprise-test-rest/lastCompletedBuild/org.xwiki.enterprise$xwiki-enterprise-test-rest/testReport/org.xwiki.test.rest/WikisResourceTest/testSolrSearch/ | ||
19 | 09:56 <mflorea> has joined #xwiki | ||
20 | 09:57 <vmassol> tmortagne: good morning, I'll need your help to fix the javadoc ^^^^^ (not urgent) | ||
21 | 09:58 <vmassol> (I made some progress on the javadoc job for platform but I'm stuck on those right now and it's bit difficult for me to fix them) | ||
22 | 10:01 <Enygma`> has joined #xwiki | ||
23 | 10:02 <evalica> has joined #xwiki | ||
24 | 10:06 <tmortagne> vmassol: E is the type of the entity (BaseClass, BaseObject, XWikiDocument, etc.) | ||
25 | 10:07 <edvorg> has joined #xwiki | ||
26 | 10:08 <gdelhumeau> has joined #xwiki | ||
27 | 10:10 <vmassol> Enygma`: ^^^^ :) We need to do something about this and have the style we want by default IMO | ||
28 | 10:10 <Slashman> has joined #xwiki | ||
29 | 10:13 <Enygma`> vmassol: you mean about the image macro? | ||
30 | 10:14 <vmassol> yeah | ||
31 | 10:14 <vmassol> this has been tickling me for a long time now | ||
32 | 10:15 <Enygma`> we can control the styling from the sheet | ||
33 | 10:16 <Enygma`> but the autolink (when the image is resized) needs to come from rendering | ||
34 | 10:16 <vmassol> there are 2 aspects: 1) having a solution for xwiki.org and 2) having a solution for the product | ||
35 | 10:16 <vmassol> I think I have a jira issue for the product somewhere | ||
36 | 10:17 <vmassol> we have something a bit similar here: http://jira.xwiki.org/browse/XWIKI-7603# | ||
37 | 10:18 <vmassol> actually XWIKI-7602 | ||
38 | 10:18 <vmassol> closing 7603 as dup | ||
39 | 10:20 <Enygma`> vmassol: what does captioning have to do with image boarder and autolink? | ||
40 | 10:21 <Enygma`> (which are the current 2 features and reasons why we use the image macro on xwiki.org) | ||
41 | 10:21 <vmassol> Enygma`: basically the person who created this issue wanted the same look at wikipedia | ||
42 | 10:21 <vmassol> and this includes border | ||
43 | 10:22 <vmassol> and the solution to also add caption is most likely similar to the one to add border | ||
44 | 10:22 <vmassol> either a macro or some parameters | ||
45 | 10:22 <vmassol> note that the issue with parameter is that it's too complex and lengthy to use | ||
46 | 10:22 <vmassol> (lenghty and complex) | ||
47 | 10:23 <vmassol> for xwiki.org for ex we want it by default | ||
48 | 10:23 <Enygma`> [[image:test.png|caption="My caption"]] | ||
49 | 10:23 <vmassol> so it could be the notion of default parameters configured in the admin for ex | ||
50 | 10:23 <Enygma`> or "title" | ||
51 | 10:23 <vmassol> or macro | ||
52 | 10:24 <Enygma`> I don`t really see this as something coming from a macro | ||
53 | 10:24 <vmassol> basically there are 3 characteristics we would need: caption, border and resize | ||
54 | 10:25 <vmassol> could be a style parameter maybe | ||
55 | 10:25 <tmortagne> depends what is the goal, there is a looot more stuff in mediawiki images :) | ||
56 | 10:25 <vmassol> [[image:test.png|style=small]] which would do both border + resize to a fixed small size | ||
57 | 10:26 <vmassol> with a confiurable style in the admin | ||
58 | 10:26 <vmassol> on xwiki.org we hve defined 3-4 styles | ||
59 | 10:26 <vmassol> 4 | ||
60 | 10:26 <vmassol> http://dev.xwiki.org/xwiki/bin/view/Community/DocGuide#HScreenshots2FImages | ||
61 | 10:26 <Enygma`> we can already control the size through the width & height parameters (that also accept percentages) | ||
62 | 10:27 <vmassol> yes but odon't understand | ||
63 | 10:27 <Enygma`> we just need to add a title and a link parameter | ||
64 | 10:27 <vmassol> the goal is to be 1) simple and 2) consistent throughout the site | ||
65 | 10:27 <vmassol> if you leave it to the user you get 1000 different styles | ||
66 | 10:27 <Enygma`> if you add a macro, nobody will use it | ||
67 | 10:28 <Enygma`> they will use the standard, documented syntax | ||
68 | 10:28 <Enygma`> as best as they can | ||
69 | 10:28 <vmassol> if you offer 3 parameters to use it's going to be even worse | ||
70 | 10:28 <vmassol> :) | ||
71 | 10:28 <Enygma`> we just need good defaults | ||
72 | 10:28 <vmassol> nobody will us ethe | ||
73 | 10:28 <vmassol> *use them | ||
74 | 10:28 <vmassol> or they'll use them with wrong values | ||
75 | 10:28 <Enygma`> link can be default | ||
76 | 10:29 <vmassol> that's why I was mentioning defaults but you can't have defaults | ||
77 | 10:29 <Enygma`> I`m primarily interested in a solution for the product here | ||
78 | 10:29 <vmassol> because as mentioned already we have 4 valid styles for xwiki.org | ||
79 | 10:29 <vmassol> and you can imagine that by default we may not want all images to have the same size | ||
80 | 10:29 <vmassol> border could be a default | ||
81 | 10:30 <vmassol> linking too could be a default (when the image is resized) | ||
82 | 10:30 <Enygma`> linking should be done always (IMO, not just when resized) | ||
83 | 10:30 <vmassol> why would you want to click on an image? | ||
84 | 10:30 <vmassol> (when it displays the same thing) | ||
85 | 10:30 <vmassol> your browser already has an action to open the image | ||
86 | 10:31 <Enygma`> I want all images to be clickable so that they can be opened in a new tab and easily referenced | ||
87 | 10:31 <Enygma`> I don`t want it to open it in the current tab | ||
88 | 10:31 <vmassol> your browser already has an action to get the link to an image | ||
89 | 10:31 <vmassol> the only reason I see for the linking is when the image is resized | ||
90 | 10:32 <vmassol> or when there's a link to another place ofc | ||
91 | 10:32 <Enygma`> I like to keep it simple | ||
92 | 10:32 <Enygma`> I find it more flexible that way | ||
93 | 10:32 <vmassol> [[[[image:…]]>>...]] | ||
94 | 10:32 <vmassol> in this case we don't want the autolink btw ;) | ||
95 | 10:33 <Enygma`> yes, we also introduce this confusion | ||
96 | 10:33 <Enygma`> users might expect to go somewhere | ||
97 | 10:37 <evalica> vmassol: what's up with http://dev.xwiki.org/xwiki/bin/view/Community/HallOfFame ? I don't appear in any of the categories and also the colors are off + there are very few contributors. Clemens also is missing, etc. | ||
98 | 10:42 <tmortagne> HallOfFame is outdated since a long time | ||
99 | 10:42 <vmassol> yes there are issues with the version there I think. I had been working on the next version in github but it's not been fully finished/deployed AFAIR | ||
100 | 10:42 <vmassol> could be something to do during a hackathon for example ;) | ||
101 | 10:43 <vmassol> I'll update the page with a wanring for now | ||
102 | 10:43 <vmassol> I think it can be fixed easily by deleting the scm data in the perm dir to recreate them | ||
103 | 10:43 <vmassol> but would need some time for this | ||
104 | 10:48 <gdelhumeau> Hello. Please hold your commits | ||
105 | 10:48 <gdelhumeau> I need to know if the build is stable | ||
106 | 10:50 <gdelhumeau> acotiuga: are you finxing http://ci.xwiki.org/job/xwiki-enterprise-test-selenium/ ? | ||
107 | 10:50 <evalica> gdelhumeau: no - we need help | ||
108 | 10:50 <acotiuga> no | ||
109 | 10:50 <gdelhumeau> I've just seen your message on skype | ||
110 | 11:17 <msmeria1> has joined #xwiki | ||
111 | 11:20 <msmeria> has quit | ||
112 | 11:22 <msmeria> has joined #xwiki | ||
113 | 11:25 <msmeria1> has quit | ||
114 | 11:26 <msmeria1> has joined #xwiki | ||
115 | 11:28 <msmeria> has quit | ||
116 | 12:04 <gdelhumeau> mflorea: are you ready to commit XWIKI-13528 | ||
117 | 12:05 <mflorea> gdelhumeau: not yet :( I still need a few hours | ||
118 | 12:06 <gdelhumeau> could it break any test? | ||
119 | 12:06 <vmassol> yes | ||
120 | 12:06 <vmassol> :) | ||
121 | 12:06 <gdelhumeau> by principle :p | ||
122 | 12:07 <gdelhumeau> then I won't be able to fix them (if it is needed) and to release | ||
123 | 12:07 <gdelhumeau> so either I release early this afternoon, either someone else do it afterwards | ||
124 | 12:08 <vmassol> IMO it's going to be too late to reelase today if we wait for it | ||
125 | 12:08 <vmassol> because we'll need the full build to pass | ||
126 | 12:08 <vmassol> so we need to decide what to do | ||
127 | 12:09 <vmassol> I think it would be a pity to not have it for RC | ||
128 | 12:09 <vmassol> so I'd be in favor of postponing the release to tomorrow if we can't achieve it today | ||
129 | 12:09 <vmassol> we just need to find a RM | ||
130 | 12:09 <vmassol> but we need to not postpone more than tomorrow | ||
131 | 12:09 <vmassol> as we're risking to endanger the final reelase date | ||
132 | 12:10 <vmassol> next RM on http://dev.xwiki.org/xwiki/bin/view/ReleasePlans/ is Caty and then Marius | ||
133 | 12:10 <mflorea> I will do the release as I'm the one delaying it | ||
134 | 12:10 <vmassol> ok cool | ||
135 | 12:10 <vmassol> so if we succeed today, GD does it and if not Marius | ||
136 | 12:10 <vmassol> ok? | ||
137 | 12:10 <mflorea> yes | ||
138 | 12:11 <Signum> Is there a way to use XWiki like a database? Confluence offers a way to add fields to each page (e.g. in a table) and then display a list of pages and selected fields from subpages. I'd like to create an inventory of stuff and put each item on a page. | ||
139 | 12:12 <Signum> Similar to the "References" project. But I'd like to avoid coding. Just use what's available in xwiki. | ||
140 | 12:12 <gdelhumeau> Signum: it's the main advantage of XWiki actually :) | ||
141 | 12:13 <gdelhumeau> you should try http://extensions.xwiki.org/xwiki/bin/view/Extension/App+Within+Minutes+Application | ||
142 | 12:13 <Signum> gdelhumeau: Uh, nice. How come I missed that? Thanks. | ||
143 | 12:14 <vmassol> for a general concept see also http://platform.xwiki.org/xwiki/bin/view/Main/SecondGenerationWiki | ||
144 | 12:22 <M-jsimard> has quit | ||
145 | 12:22 <blabla2[m]> has quit | ||
146 | 12:22 <M-vmassol> has quit | ||
147 | 12:22 <M-mouhb1> has quit | ||
148 | 12:22 <M-cjd> has quit | ||
149 | 12:22 <Chris[m]1> has quit | ||
150 | 12:32 <edvorg> has quit | ||
151 | 12:38 <edvorg> has joined #xwiki | ||
152 | 12:44 <Chris[m]> has joined #xwiki | ||
153 | 13:18 <M-cjd> has joined #xwiki | ||
154 | 13:18 <M-jsimard> has joined #xwiki | ||
155 | 13:18 <M-yflory> has joined #xwiki | ||
156 | 13:18 <M-mouhb> has joined #xwiki | ||
157 | 13:18 <blabla2[m]> has joined #xwiki | ||
158 | 13:19 <M-vmassol> has joined #xwiki | ||
159 | 13:26 <gdelhumeau> http://ci.xwiki.org/job/xwiki-platform_javadoc/ is broken | ||
160 | 13:27 <vmassol> gdelhumeau: that'es normal | ||
161 | 13:27 <vmassol> it's a work in progress | ||
162 | 13:36 <tmortagne> gdelhumeau: always been broken :) | ||
163 | 13:36 <vmassol> btw tmortagne did you see my message of this morning on irc about it? | ||
164 | 13:37 <tmortagne> vmassol: I answered you | ||
165 | 13:37 <vmassol> haha | ||
166 | 13:37 <tmortagne> don't have new bugs to fix right now for MediaWiki so I will take care of it | ||
167 | 13:38 <vmassol> so I missed the answer :) | ||
168 | 13:38 <vmassol> ok cool thx | ||
169 | 13:55 <mflorea> vmassol: I have a bit of a problem. I need to commit the configuration for the default WYSIWYG editor. It should be either in xwiki.properties or XWikiPreferences but since the value is going to be ckeditor it can't be committed in platform, which is not aware of the CKEditor (as we decided to have he dep in XE). | ||
170 | 13:55 <mflorea> so it needs to be committed on XE, but this would mean overwriting xwiki.properties or XWikiPreferences in XE | ||
171 | 13:57 <vmassol> since we have default values for all properties | ||
172 | 13:58 <vmassol> this is just about documenting the properties for the user | ||
173 | 13:58 <vmassol> so indeed we would need overwriting in XE | ||
174 | 13:58 <mflorea> it doesn't apply in this case, because the platform code that defines the configuration option doesn't know about ckeditor | ||
175 | 13:58 <vmassol> I don't remember exazctly where we generate the file | ||
176 | 13:58 <vmassol> but we have an extra config property | ||
177 | 13:59 <vmassol> $!xwikiPropertiesAdditionalProperties | ||
178 | 13:59 <vmassol> (in the build) | ||
179 | 13:59 <mflorea> indeed | ||
180 | 13:59 <mflorea> we use it for tests | ||
181 | 13:59 <vmassol> got to go now (eval meeting), bb later but maybe others (thomas?) can help? | ||
182 | 14:13 <acotiuga> has quit | ||
183 | 14:13 <tmortagne> mflorea: for me it's just about documenting this property and make the value configurable at build time like we do for several already (like we should probably do for all actually at some point) | ||
184 | 14:13 <acotiuga> has joined #xwiki | ||
185 | 14:51 <mflorea> tmortagne: but ckeditor should be the default editor in 8.2 and for this it needs to be explicitly configured. Having "ckeditor" as the default value doesn't work because the configuration source is in platform, which doesn't know about ckeditor. So XE must configure ckeditor explicitly | ||
186 | 14:52 <tmortagne> mflorea: and that's exactly what I said | ||
187 | 14:52 <tmortagne> XE would set it at build time | ||
188 | 14:52 <tmortagne> same as various other properties | ||
189 | 14:52 <mflorea> ok, good | ||
190 | 14:52 <tmortagne> but it should be an actual property, documented and with a placeholder | ||
191 | 14:52 <tmortagne> XE should not use $!xwikiPropertiesAdditionalProperties | ||
192 | 14:53 <mflorea> you mean a POM property? | ||
193 | 14:54 <tmortagne> I means same as https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.properties.vm#L87 | ||
194 | 14:54 <mflorea> ok | ||
195 | 14:54 <tmortagne> and then in XE you set a Maven property which is then used at platform level to generate the xwiki.properties file | ||
196 | 14:54 <mflorea> thanks, I'll do the same | ||
197 | 14:56 <ClemensR> has joined #xwiki | ||
198 | 14:56 <gdelhumeau> we were supposed to not commit | ||
199 | 14:59 <ClemensR> edvorg: you got mail ;) | ||
200 | 15:01 <gdelhumeau> mflorea: so you will commit it today? | ||
201 | 15:03 <mflorea> I'm trying, but I can't tell for sure | ||
202 | 15:10 <lucaa> has joined #xwiki | ||
203 | 15:10 <lucaa> hello xwikiers | ||
204 | 15:10 <lucaa> I have made a fix for the issue http://jira.xwiki.org/browse/XWIKI-13544 | ||
205 | 15:11 <lucaa> and I would like to also put it on some older versions (I would need it on the stable-7.4.x for example) | ||
206 | 15:11 <lucaa> but I don't know exactly what is the rule, what other branch I should merge it on, besides master and this stable-7.4 | ||
207 | 15:12 <lucaa> any of the 8.x branches? | ||
208 | 15:12 <lucaa> from what I understand from here http://www.xwiki.org/xwiki/bin/view/Download/ , I guess this would be 8.1 as well | ||
209 | 15:12 <lucaa> please confirm | ||
210 | 15:13 <msmeria1> has quit | ||
211 | 15:15 <gdelhumeau> stable-8.1.x and stable-7.4.x | ||
212 | 15:15 <gdelhumeau> but please don't commit anymore on master | ||
213 | 15:15 <gdelhumeau> we are supposed to release | ||
214 | 15:22 <lucaa> oh, sorry for this | ||
215 | 15:22 <lucaa> I already committed :( | ||
216 | 15:29 <tmortagne> lucaa: no need to cherry pick in stable-8.1.x since we are not going to release a 8.1.1 given the release date of 8.2 final | ||
217 | 15:30 <tmortagne> (but yes usually you would put it in 8.1.x and 7.4.x) | ||
218 | 15:30 <lucaa> well, I guess, but since I don';t know the release plan I'm putting everywhere :) | ||
219 | 15:31 <tmortagne> as you want | ||
220 | 15:34 <lucaa> gdelhumeau: I closed XWIKI-13544 since I just pushed all the fixes for it, and I marked it resolved in 8.2-rc-1 , as I assume this is what is being released and I also assumed my commit on master was included in the release | ||
221 | 15:34 <lucaa> lemme know if it's not the case, I will change the fix version | ||
222 | 15:35 <gdelhumeau> that's ok | ||
223 | 16:58 <boubou> has quit | ||
224 | 16:59 <woshilapin> has quit | ||
225 | 17:00 <woshilapin> has joined #xwiki | ||
226 | 17:09 <acotiuga> has quit | ||
227 | 17:28 <ClemensR> has left #xwiki | ||
228 | 17:38 <boubou> has joined #xwiki | ||
229 | 17:39 <vmassol> I'm curious aobut "Various tools and helpers for teams of people" :) | ||
230 | 17:43 <mflorea> has quit | ||
231 | 17:49 <gdelhumeau> platform still not built :( | ||
232 | 17:49 <gdelhumeau> on ci | ||
233 | 17:54 <tmortagne> vmassol: you will have to wait longer than I tough, github commit application is totally unusable | ||
234 | 17:57 <vmassol> so it's something about saving wiki pages to SCM | ||
235 | 17:57 <vmassol> (SCM = github) | ||
236 | 17:59 <tmortagne> no | ||
237 | 17:59 <tmortagne> I wanted to use github application to commit it | ||
238 | 17:59 <vmassol> ah | ||
239 | 18:00 <vmassol> you're adventurous :) | ||
240 | 18:03 <evalica> has quit | ||
241 | 18:11 <Enygma`> has quit | ||
242 | 18:15 <KermitTheFragger> has quit | ||
243 | 19:15 <Pbas> has quit | ||
244 | 19:24 <tmortagne> has quit | ||
245 | 19:31 <Slashman> has quit | ||
246 | 19:48 <lucaa> has quit | ||
247 | 20:11 <tmortagne> has joined #xwiki | ||
248 | 20:35 <boubou> [14:32:53] <boubou> :( | ||
249 | 20:35 <boubou> [14:34:28] <boubou> http://pastebin.com/5vEYQXTF | ||
250 | 20:36 <boubou> what can cause that ? | ||
251 | 20:55 <Pbas> has joined #xwiki | ||
252 | 20:57 <tmortagne> has quit | ||
253 | 21:16 <Denis> has quit | ||
254 | 21:17 <gdelhumeau> has quit | ||
255 | 21:18 <vmassol> has quit | ||
256 | 21:20 <tmortagne> has joined #xwiki | ||
257 | 21:25 <tmortagne> has quit | ||
258 | 22:57 <lkrejci> has joined #xwiki | ||
259 | 23:22 <lkrejci> has quit | ||
260 | 23:22 <lkrejci> has joined #xwiki | ||
261 | 23:33 <lucaa> has joined #xwiki | ||
262 | 23:52 <lkrejci> has quit | ||
263 | 23:52 <lkrejci> has joined #xwiki |