Wiki source code of IRC Archive for channel #xwiki on 25 August 2016
Last modified by Vincent Massol on 2016/08/25 23:04
Show last authors
| author | version | line-number | content |
|---|---|---|---|
| 1 | <M-cjd> has quit | ||
| 2 | 02:58 <M-cjd> has joined #xwiki | ||
| 3 | 03:22 <jonesmeier> has quit | ||
| 4 | 03:24 <jonesmeier> has joined #xwiki | ||
| 5 | 06:51 <Denis1> has joined #xwiki | ||
| 6 | 06:51 <DarkKnightCZ> has joined #xwiki | ||
| 7 | 06:53 <Denis> has quit | ||
| 8 | 07:03 <DarkKnightCZ> has quit | ||
| 9 | 07:03 <DarkKnightCZ1> has joined #xwiki | ||
| 10 | 07:19 <DarkKnightCZ1> has quit | ||
| 11 | 07:25 <DarkKnightCZ> has joined #xwiki | ||
| 12 | 08:03 <msmeria> has joined #xwiki | ||
| 13 | 08:04 <DarkKnightCZ> has quit | ||
| 14 | 08:09 <DarkKnightCZ> has joined #xwiki | ||
| 15 | 08:25 <vmassol> has joined #xwiki | ||
| 16 | 08:36 <ix3[m]> has joined #xwiki | ||
| 17 | 08:37 <ix3[m]> has left #xwiki | ||
| 18 | 08:48 <acotiuga> has joined #xwiki | ||
| 19 | 08:49 <Denis> has joined #xwiki | ||
| 20 | 08:50 <Denis1> has quit | ||
| 21 | 09:08 <DarkKnightCZ> Hi, has anybody experienced issue with spaces in page name on Tomcat > 7.0.62 ? Apparently there is some behaviour change between 7.0.62.0 and 7.0.70 which results in the impossiblity to edit pages with spaces in them (it results in creation of page with + signs in xwiki) | ||
| 22 | 09:16 <DarkKnightCZ> vmassol: hello, I've found today (since i've done yesterday upgrade to 8.2.1) that XWIKI-13651 also affects this version, so I'm actually wondering if its caused by XWIKI-12544 or not | ||
| 23 | 09:21 <DarkKnightCZ> hmm, so it looks like it's combination of two issues | ||
| 24 | 09:22 <DarkKnightCZ> sometimes it fails with "Cannot read property 'observe' of undefined" and sometimes it tries to load that tree.js file but in edit mode that results in Locked response code when two people on wiki are trying to edit at the same time | ||
| 25 | 09:32 <mflorea> has joined #xwiki | ||
| 26 | 09:38 <vmassol> DarkKnightCZ: hi | ||
| 27 | 09:39 <vmassol> if you're using 8.3M1 you should be fine regarding the tree.js issue since it's been fixed | ||
| 28 | 09:39 <vmassol> and the export of children is part of 8.3M1 so there's no reason for you to have the problem normally | ||
| 29 | 09:39 <DarkKnightCZ> vmassol: it's 8.2.1 | ||
| 30 | 09:39 <vmassol> so you don't have XWIKI-12544 for sure in that version | ||
| 31 | 09:40 <vmassol> AFAIU XWIKI-13651 was vaused by XWIKI-125444 yes | ||
| 32 | 09:40 <vmassol> regarding tomcat there's no known issue with spaces | ||
| 33 | 09:40 <DarkKnightCZ> yup, looks that way although it looks similar | ||
| 34 | 09:41 <vmassol> but there are general encoding issues | ||
| 35 | 09:41 <vmassol> in some version | ||
| 36 | 09:41 <vmassol> as we indicate | ||
| 37 | 09:41 <vmassol> see http://platform.xwiki.org/xwiki/bin/view/AdminGuide/InstallationTomcat | ||
| 38 | 09:41 <vmassol> (the red box :)) | ||
| 39 | 09:41 <vmassol> I'm sure you're hitting those | ||
| 40 | 09:42 <DarkKnightCZ> aaah, yes, thats it :) | ||
| 41 | 09:42 <DarkKnightCZ> I will try to reproduce the CKEditor issue on clean installation and report a bug then :) | ||
| 42 | 09:43 <vmassol> ok | ||
| 43 | 09:47 <vmassol> thanks Alex | ||
| 44 | 09:48 <vmassol> maybe you could also add the missing WebHome in the examples (haven't checked but that's a guess) | ||
| 45 | 09:48 <vmassol> because it seems the tutorial is not valid | ||
| 46 | 09:48 <vmassol> anymore | ||
| 47 | 09:49 <vmassol> yes for example $xwiki.jsx.use("XWiki.SkinExt") is not going to work by default | ||
| 48 | 09:49 <vmassol> since by default pages are created non terminal | ||
| 49 | 09:49 <vmassol> or we should indictae to create a page as a terminal page and point to the doc for that | ||
| 50 | 09:50 <vmassol> btw just realized were missing documentation for terminal pages at http://platform.xwiki.org/xwiki/bin/view/Features/DocumentLifecycle#HCreate, adding that | ||
| 51 | 09:54 <DarkKnightCZ> has quit | ||
| 52 | 09:55 <DarkKnightCZ> has joined #xwiki | ||
| 53 | 09:58 <acotiuga> added the missing WebHome on SkinExtensionTutorial | ||
| 54 | 10:01 <vmassol> it could be better to create a terminal page though since I'm not sure why a ssx page would have children but ok... | ||
| 55 | 10:01 <vmassol> at least it makes it simpler for the non advanced user | ||
| 56 | 10:02 <vmassol> (although it's an advanced concept) | ||
| 57 | 10:03 <vmassol> it's not easy | ||
| 58 | 10:07 <gdelhumeau> has joined #xwiki | ||
| 59 | 10:16 <vmassol> FTR I've updated http://platform.xwiki.org/xwiki/bin/view/Features/DocumentLifecycle We forgot to udpate it when we introduced the terminal page checkbox in the create page dialog and when we introduced the new templates recently... | ||
| 60 | 10:16 <vmassol> I think we need to be more careful about documentation in the future | ||
| 61 | 10:16 <vmassol> lots of users are complaning that the doc is obsolete, and they're right | ||
| 62 | 10:17 <vmassol> gdelhumeau: hi | ||
| 63 | 10:17 <vmassol> gdelhumeau: could you update http://platform.xwiki.org/xwiki/bin/view/Features/DocumentLifecycle#HExport please? | ||
| 64 | 10:17 <gdelhumeau> ok | ||
| 65 | 10:18 <vmassol> gdelhumeau: maybe we could link to http://platform.xwiki.org/xwiki/bin/view/Features/Exports | ||
| 66 | 10:18 <vmassol> the link is there already | ||
| 67 | 10:18 <vmassol> maybe we could just link to it without adding the screenshots | ||
| 68 | 10:18 <vmassol> however on http://platform.xwiki.org/xwiki/bin/view/Features/Exports we need to show a better screenshot too | ||
| 69 | 10:19 <vmassol> with the children selection feature | ||
| 70 | 10:19 <vmassol> wait | ||
| 71 | 10:19 <vmassol> the children selection is only implemented for XAR? | ||
| 72 | 10:19 <vmassol> not for HTML for example? | ||
| 73 | 10:20 <vmassol> it's there for html | ||
| 74 | 10:20 <vmassol> so it's only for HTML and XAR | ||
| 75 | 10:20 <vmassol> so it's ok | ||
| 76 | 10:20 <vmassol> :) | ||
| 77 | 10:20 <vmassol> I thought we were supporting multiple pages for PDF too | ||
| 78 | 10:20 <vmassol> but maybe you just didn't implement it | ||
| 79 | 10:20 <vmassol> ? | ||
| 80 | 10:29 <vmassol> guys, what do you think about introducing a UserReferenceSerializer to generate a user string. I'd like to remove some code duplication and improve the display when the guest user is not allowed to do somehting. For example if you have an include or display macro, we generate an exception with "[Current user [null] doesn't have view rights on document [lescastcodeurs:CKEditor.VelocityMacros]]". Would be nicer to say "Guest user [Guest] | ||
| 81 | 10:37 <vmassol> mflorea, gdelhumeau, thomas (not here): wdyt? | ||
| 82 | 10:37 <vmassol> FTR here's the code in the include macro: https://github.com/xwiki/xwiki-platform/blob/79bc1823e5bb75ce54ed771f646b61b8b294f544/xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacro.java#L150-L150 | ||
| 83 | 10:38 <vmassol> (the same exist for the display maro) | ||
| 84 | 10:38 <vmassol> *macro | ||
| 85 | 10:41 <mflorea> vmassol: you mean a UserReferenceSerializer that generates "Guest" for null reference? I'm not that sure about this, because we won't have a resolver that generates null reference from "Guest" | ||
| 86 | 10:41 <vmassol> yes but seralizer do not mean you can go back to parse them | ||
| 87 | 10:41 <vmassol> IMO | ||
| 88 | 10:41 <vmassol> it's just a representation | ||
| 89 | 10:42 <vmassol> and this serializer woud generate a printable representation | ||
| 90 | 10:42 <vmassol> (a pretty print representation if you prefer) | ||
| 91 | 10:42 <vmassol> input: document reference, output: pretty print representation of the current user | ||
| 92 | 10:43 <vmassol> ex: "Vincent Massol (xwiki:Vincent.Massol)" | ||
| 93 | 10:43 <vmassol> ex2: "Guest" | ||
| 94 | 10:44 <vmassol> I wouldn't mind using another terminology such as Displayer but we don't have a generic component interface for that | ||
| 95 | 10:44 <vmassol> in any case it's still possible to write a resolver to resolver it back into a DocumentReference | ||
| 96 | 10:44 <vmassol> (should it be needed) | ||
| 97 | 10:51 <vmassol> mflorea: I was just hit by http://jira.xwiki.org/browse/XWIKI-13653 | ||
| 98 | 10:51 <vmassol> (not me but a user of a wiki I've set up: lescastcodeurs.myxwiki.org) | ||
| 99 | 10:51 <vmassol> I could go back to GWT but would be nice to use CK | ||
| 100 | 10:56 <mflorea> well, CK is a XAR extension, this will happen with any XAR extension. i.e. imagine that you install an application and you give view rights only to the application home page. If the home page includes other pages (from some code space for instance) it won't work correctly | ||
| 101 | 10:57 <vmassol> I understand the problem mariu | ||
| 102 | 10:57 <vmassol> marius | ||
| 103 | 10:57 <vmassol> I'm not talking about all use cases, just this one which is a major one | ||
| 104 | 10:57 <vmassol> (and a regression) | ||
| 105 | 10:59 <mflorea> we need "include as author" | ||
| 106 | 10:59 <evalica> has joined #xwiki | ||
| 107 | 10:59 <vmassol> for the general use case maybe we need a marker at page level to tell that a page should be viewable independently of permissions, or something like this | ||
| 108 | 10:59 <Enygma`> has joined #xwiki | ||
| 109 | 10:59 <vmassol> or what you say yes | ||
| 110 | 10:59 <vmassol> (even better) | ||
| 111 | 10:59 <mflorea> include with the rights of the content author | ||
| 112 | 11:00 <vmassol> we have something similar in a few places already | ||
| 113 | 11:00 <vmassol> like SUExecutor | ||
| 114 | 11:00 <mflorea> the downside is that it will require PR and it will cause issue on subwikis | ||
| 115 | 11:01 <vmassol> why require PR? | ||
| 116 | 11:01 <vmassol> if we consider that a page is safe, we could allow it to be viewed always no? | ||
| 117 | 11:02 <vmassol> btw on my screenshot we can see that the skin is not being displayed fine either which is a similar issue | ||
| 118 | 11:03 <vmassol> (but at least some skin is displayed so it's less criticial) | ||
| 119 | 11:05 <mflorea> actually no, it doesn't require PR, it will just perform the include with the rights of the content author | ||
| 120 | 11:05 <vmassol> yes | ||
| 121 | 11:18 <gdelhumeau> vmassol: http://platform.xwiki.org/xwiki/bin/view/Features/DocumentLifecycle#HExport updated | ||
| 122 | 11:19 <vmassol> thx | ||
| 123 | 11:20 <vmassol> ahah you found a clever way ;) | ||
| 124 | 11:21 <gdelhumeau> thanks :) | ||
| 125 | 11:37 <edvorg> has joined #xwiki | ||
| 126 | 11:49 <xwikibot> has joined #xwiki | ||
| 127 | 12:11 <vmassol1> has joined #xwiki | ||
| 128 | 12:13 <vmassol> has quit | ||
| 129 | 12:55 <ClemensR> has joined #xwiki | ||
| 130 | 15:06 <DarkKnightCZ> has quit | ||
| 131 | 15:13 <jonesmeier> has quit | ||
| 132 | 15:42 <DarkKnightCZ> has joined #xwiki | ||
| 133 | 15:43 <vmassol1> ah reminder to try to favor one the issues listed on http://www.xwiki.org/xwiki/bin/view/Roadmaps/ for BFDs | ||
| 134 | 15:43 <vmassol1> (I had also forgotten which is why I'm sending this reminder ;)) | ||
| 135 | 15:43 <vmassol1> is now known as <vmassol> | ||
| 136 | 15:43 <vmassol> they're not easy though… | ||
| 137 | 15:44 <vmassol> I've jsut reviewed them and they look too complex for me at least | ||
| 138 | 15:44 <vmassol> (to achieve in 1 one day) | ||
| 139 | 15:49 <DarkKnightCZ> has quit | ||
| 140 | 16:04 <DarkKnightCZ> has joined #xwiki | ||
| 141 | 16:11 <DarkKnightCZ> has quit | ||
| 142 | 16:12 <msmeria> has quit | ||
| 143 | 17:16 <acotiuga> has quit | ||
| 144 | 17:22 <ClemensR> has quit | ||
| 145 | 17:33 <acotiuga> has joined #xwiki | ||
| 146 | 17:45 <DarkKnightCZ> has joined #xwiki | ||
| 147 | 17:46 <Aranjedeath> has joined #xwiki | ||
| 148 | 17:47 <mflorea> has quit | ||
| 149 | 17:53 <DarkKnightCZ> has quit | ||
| 150 | 18:27 <gdelhumeau> has quit | ||
| 151 | 18:37 <edvorg> has quit | ||
| 152 | 18:40 <hakin> has quit | ||
| 153 | 18:51 <acotiuga> has left #xwiki | ||
| 154 | 20:25 <edvorg> has joined #xwiki | ||
| 155 | 20:47 <vmassol> has quit | ||
| 156 | 20:48 <mflorea> has joined #xwiki | ||
| 157 | 21:35 <DarkKnightCZ> has joined #xwiki | ||
| 158 | 21:40 <mflorea> has quit | ||
| 159 | 21:52 <mflorea> has joined #xwiki | ||
| 160 | 22:08 <mflorea> has quit | ||
| 161 | 22:27 <edvorg> has quit | ||
| 162 | 23:04 <DarkKnightCZ> has quit |
