Code Style

The XWiki project is following a specific coding style. We're using Checkstyle (checkstyle.xml) to ensure compliance of the code. Our build (the Maven2 one) is configured to fail on violations. However the decision to follow this code style and enforce it was only decided recently and the code base has not all been moved to this new code style. Hence:

  • We're only enforcing the code style in the code that have been moved to the new code style. The checked files are defined in xwiki/core/pom.xml (bottom of file).
  • We're asking new code to follow the new style and then once a Java file is compliant, to edit xwiki/core/pom.xml and add it there so that we cannot regress...

For examples of "clean" classes see the following classes and their unit tests:

Coding style topics:

Invalid macro parameters used for the "toc" macro. Cause: [Failed to validate bean: [must be greater than or equal to 1]]. Click on this message for details.

Configuring your IDE to use the XWiki code style

Eclipse 3.x

Download codestyle-eclipse.xml.

After this, select Window > Preferences, and open up the configuration for Java > Code Style > Code Formatter. Click on the button labeled Import... and select the file you downloaded. Give the style a name, and click OK.

IntelliJ IDEA 4.5+

Download codestyle-idea.xml.

Close IntelliJ IDEA. Place the file in your IntelliJ IDEA user configuration directory. For example for Windows Vista users of IntelliJ IDEA v6.x, it's in C:
Users
username
.IntelliJIdea60
config
codestyles
. Then open IntelliJ IDEA again, select File > Project Settings > Project Code Style, select Use per-project code style scheme, click on Import... and select XWiki.

Package names

All code that is not moved to the new XWiki Architecture based on components should use com.xpn.xwiki. New architecture code should use org.xwiki.

Interface best practices

Do not use 'public' in interfaces

Public is always implied in interfaces. Do not write:

public interface Page
{
   public String getParentSpaceKey();
}

But instead, write

public interface Page
{
    String getParentSpaceKey();
}

Javadoc Best Practices

We are following the Sun Javadoc coding conventions. Please make sure you're familiar with them when you write javadoc.

Write useful comments

Do not repeat name of method or any useless information. For example, if you have:

/**
 * @return the id
 */

public String getId()
{
   return this.id;
}

Instead, write:

/**
 * @return the attachment id (the id is the filename of the XWikiAttachment object used to construct this Attachment object)
 */

public String getId()
{
   return this.id;
}

Do not duplicate Javadoc

If you inherit from an interface then you shouldn't copy the Javadoc from the interface. Instead you should reference it. For example if getSomething() is the implementation a method defined in an inherited Something interface, you shouldn't write:

/**
 * Do something blah blah.
 */

public void doSomething()
{
[...]

Instead, write the following:

/**
 * {@inheritDoc}
 *
 * <p>Optionally add here javadoc additional to the one inherited from the parent javadoc.</p>
 *
 * @see Something#doSomething()
 */
public void doSomething()
{
[...]

Do not duplicate method comments with parameters comments

Instead of writing:

/**
 * Returns the key of the space to which this page belongs to.
 *
 * @return - Parent space's key as String.
 */

public String getParentSpaceKey();

Write:

/**
 * @return the key of the space to which this page belongs to. For example "Main".
 */

public String getParentSpaceKey();
Tags:
Created by VincentMassol on 2007/02/06 15:27
   

Get Connected