IRC Archive for channel #xwiki

lucaa joined #xwiki at 00:02
jvdrean joined #xwiki at 00:46
jvdrean left at 00:48 (Client Quit
jvelociter left at 00:59 (Quit: jvelociter
nickless left at 03:41 (Ping timeout: 276 seconds
sdumitriu left at 04:34 (Ping timeout: 276 seconds
slhommed joined #xwiki at 05:51
slhommed - (05:51): hi all
slhommed - (05:52): anyone here know of a plugin or module, etc. to enable chat with other logged in users?
slhommed - (05:52): if not, at least a way to display logged in users
slhommed left at 06:46 (Quit: Leaving
mflorea joined #xwiki at 07:03
florinciu joined #xwiki at 07:35
vmassol joined #xwiki at 07:57
plunden1 joined #xwiki at 08:08
mariusbutuc joined #xwiki at 08:13
florinciu left at 08:20 (Quit: Leaving.
Denis joined #xwiki at 08:48
mariusbutuc left at 08:56 (Ping timeout: 265 seconds
mariusbutuc joined #xwiki at 08:57
Enygma` joined #xwiki at 09:00
lucaa left #xwiki at 09:05
evalica joined #xwiki at 09:16
lucaa joined #xwiki at 09:36
mariusbutuc left #xwiki at 09:39
KermitTheFragger joined #xwiki at 09:57
Enygma` left at 10:06 (Quit: Leaving.
Enygma` joined #xwiki at 10:10
glerouge joined #xwiki at 10:11
tmortagne joined #xwiki at 10:13
arkub joined #xwiki at 10:22
anamarias joined #xwiki at 10:38
jvdrean joined #xwiki at 10:43
jvelociter joined #xwiki at 11:02
anamarias left at 11:09 (Ping timeout: 264 seconds
florinciu joined #xwiki at 11:42
mflorea left at 11:53 (Quit: Leaving.
nickless joined #xwiki at 12:09
temporalfox left at 12:17 (Quit: temporalfox
florinciu left at 12:22 (Read error: Connection reset by peer
florinciu joined #xwiki at 12:25
gvallarelli joined #xwiki at 12:29
gvallarelli - (12:29): Hi
sdumitriu joined #xwiki at 12:35
nickless left at 12:36 (Ping timeout: 260 seconds
CalebJamesDeLisl - (12:41): hmm, I just segfaulted jetty.
CalebJamesDeLisl - (12:41): By creating a user and loading a page.
CalebJamesDeLisl - (12:42): Ok, who's using com.sun.misc.Unsafe? ;)
sdumitriu - (12:47): Sun JRE
sdumitriu - (12:47): Segfaults are usually bugs in the JVM
CalebJamesDeLisl - (12:48): JavaThread "http://localhost:8081/xwikiTrunk/bin/download/XWiki/XWikiUserSheet/noavatar.png?width=120"
CalebJamesDeLisl - (12:48): I know stack overflowing the GC will lead to a spectacular blowup, maybe I'll do that and compare the dumps.
CalebJamesDeLisl - (12:52): It was libxcb.so so looks like it's X11 that bombed out.
arkub left at 13:19 (Ping timeout: 258 seconds
CalebJamesDeLisl - (13:42): Should I have a vote to include xwiki-invitation in XE before getting a jira project?
bougie - (13:45): how can desactivate the registration ?
vmassol - (13:45): CalebJamesDeLisl: to include xwiki-invitation in the platform yes, including it in XE is another matter
florinciu left at 13:46 (Read error: Connection reset by peer
bougie - (13:46): or redirect the register/xwiki/Register to another page
vmassol - (13:46): bougie: remove the register right to guests/users
CalebJamesDeLisl - (13:46): I meant in platform/applications but do I need to have the vote before the jira project?
vmassol - (13:47): yes
vmassol - (13:47): (since jira reflects that)
CalebJamesDeLisl - (13:47): Ok, I'll just put it in the sandbox without issue tracking until I have the vote.
CalebJamesDeLisl - (13:48): (I want something in the sandbox so we know what we're voting on.)
vmassol - (13:48): k
vmassol - (13:51): guys we're already late by 2 days for the 2.3RC2 (or final) release so we need to plan it
vmassol - (13:51): is there anyimportant bug fix that someone is working on that needs to go in?
vmassol - (13:51): (or any blocker that anyone knows about?)
mflorea joined #xwiki at 13:52
vmassol - (13:52): mflorea: hi. There's one failing test for 2.3 release: http://hudson.xwiki.org/view/Functional%20Tests/job/xwiki-product-enterprise-tests-2.3/com.xpn.xwiki.products$xwiki-enterprise-test-wysiwyg/16/testReport/com.xpn.xwiki.it.selenium/TabsTest/testSwitchToSourceBeforeWysiwygLoad/
mflorea - (13:53): vmassol: flickering..
vmassol - (13:53): oops, got to go, I have a meeting I had forgotten. Please let me know if you're working on stuff for RC2/final in the meantime
mflorea - (13:54): I'm working on adding support for special characters in page name
mflorea - (13:54): in the WYSIWYG editor
Denis left at 14:15 (Quit: Leaving.
florinciu joined #xwiki at 14:37
tmortagne - (14:42): vmassol: there is a right issue reported by José (http://jira.xwiki.org/jira/browse/XWIKI-5128) and Ludo but i i don't think it's a regression so it's not blocker
Enygma` left at 14:44 (Quit: Leaving.
tmortagne - (14:47): i just had an issue on trunk, i tried to create a user and it did not worked but I did not get any error, the user is just not here
tmortagne - (14:48): sending this warning before looking more in case someone already knows what is the issue
tmortagne - (14:49): i get an error when looking with firebug:
tmortagne - (14:50): registry is undefined
tmortagne - (14:50): var respondersForEvent  = registry.get(eventName);
lucaa left at 14:51 (Quit: Leaving.
lucaa joined #xwiki at 14:51
lucaa left at 14:57 (Quit: Leaving.
lucaa joined #xwiki at 14:57
vmassol - (15:01): back
vmassol - (15:04): strange I was pretty sure we had some tests for this
tmortagne - (15:05): it's not the first time i see this "registry is undefined" but i don't remember what was the cause last time
tmortagne - (15:06): it's probably on my side only
tmortagne - (15:07): hmm i have the user after a restart of XWiki actually
tmortagne - (15:07): but i still have the error
tmortagne - (15:07): just by going to http://127.0.0.1:8080/xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Users#|t=userstable&p=1&wiki=local
tmortagne - (15:07): don't even need to try to create a user
arkub joined #xwiki at 15:09
tmortagne - (15:09): note that i have this error only on the user list page and not on the group list page
tmortagne - (15:11): i remember, last time I had this it was because some js files were not loaded because a subwiki was loading skin files on main wiki so the user did not had the right to get the skin resources
tmortagne - (15:12): but here i'm user standard Admin user on a fresh wiki
florinciu left at 15:16 (Quit: Leaving.
CalebJamesDeLisl - (15:17): registry.get(eventName);  Seem to remember that one... is the error inside prototype?
tmortagne - (15:17): CalebJamesDeLisl: i don't know
CalebJamesDeLisl - (15:18): You can set firebug to break on error, I found that very helpful.
tmortagne - (15:18): i'm updating an retesting with very last xar build
CalebJamesDeLisl - (15:19): Another thing, I noticed the class editor has a bad html macro but my copy is old.
plunden1 left #xwiki at 15:20
CalebJamesDeLisl - (15:21): I don't know if this was fixed http://127.0.0.1:8081/xwikiTrunk/bin/view/XWiki/XWikiRights it's ClassSheet
tmortagne - (15:24): another firebug error: when it finish importing i get
tmortagne - (15:24): this.url.match is not a function
tmortagne - (15:24):     var m  = this.url.match(/^\s*https?:\/\/[^\/]*/);
tmortagne - (15:24): and it says it's in prototype.js  (line 1517)
tmortagne - (15:24): did we upgraded prototype or something ?
tmortagne - (15:24): rerstesting user list
tmortagne - (15:25): still get the error
CalebJamesDeLisl - (15:25): I know there are a lot of js issues (especially if you turn on strict checking in about:config)
tmortagne - (15:25): it says it's in prototype.js  (line 4440)
CalebJamesDeLisl - (15:25): Can you look up the stack?
tmortagne - (15:26): CalebJamesDeLisl: how do i do that ?
tmortagne - (15:26): hmm wait
CalebJamesDeLisl - (15:27): You have to turn on the script section of firebug
tmortagne - (15:27): the ajax request just before the error
tmortagne - (15:27): ha no nothing
CalebJamesDeLisl - (15:27): attempting to repeat:  in users->add user?
tmortagne - (15:28): script tab seems on, i go there whet i click on " prototype.js  (line 4440)"
tmortagne - (15:28): CalebJamesDeLisl: no need
tmortagne - (15:28): just going to the page
tmortagne - (15:29): i get the error just by loading user list admin page
tmortagne - (15:29): it's working now
tmortagne - (15:30): i mean i dont get the error anymore when i go to the page
tmortagne - (15:30): looks like it's kind of random
tmortagne - (15:30): restarting
tmortagne - (15:31): even after restarting i don't get the error anymore, trying to create a user then
tmortagne - (15:32): ha this time i get something real
tmortagne - (15:32): but it's redirecting before i could see it
tmortagne - (15:32): trying to copy it fast
tmortagne - (15:33): note that i got an error but this timee it worked
tmortagne - (15:33): looks like there is something ugly somewhere
CalebJamesDeLisl - (15:33): XWikiUserSheet.
CalebJamesDeLisl - (15:33): Looked up the stack, that's what's causing the call.
CalebJamesDeLisl - (15:34): To get a stack trace you have to go in console and in the upper left corner there is a pause button and click that.
CalebJamesDeLisl - (15:34): It breaks on error and you get to look at the stack, and the heap.
tmortagne - (15:35): CalebJamesDeLisl: i can't get the error anymore, now i just have a different error (a 400 bad request on some ajax call)  i don't have time to look before it's redirect
tmortagne - (15:36): http://127.0.0.1:8080/xwiki/bin/register/XWiki/XWikiPreferences?xpage=registeruser?ajax=1
tmortagne - (15:36): got it this time
CalebJamesDeLisl - (15:36): You can use the net section of firebug for that. Click persist and you can still see the requests.
tmortagne - (15:36): this return a "400 bad request"
tmortagne - (15:37): to reproduce just try to create a user from the admin user section
tmortagne - (15:37): but again it''s working well, i did created thee user
tmortagne - (15:37): i can't reproduce the first issue i had where user did not shows up in the list
CalebJamesDeLisl - (15:38): Hmm, no 400 here. but for me the link is bin/view/XWiki/XWikiPreferences?xpage=registeruser
tmortagne - (15:40): i have many
tmortagne - (15:40): 2010-04-21 15:39:43,605 [http://127.0.0.1:8080/xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Users] ERROR web.XWikiAction                 - Connection aborted
tmortagne - (15:40): in the log
tmortagne - (15:40): looks like it's related
CalebJamesDeLisl - (15:43): I'm still just getting the first issue. I'll have to look at it later.
tmortagne - (15:45): CalebJamesDeLisl: Persist doe snot seems to help for the redirect, i still loose previous logs
CalebJamesDeLisl - (15:46): It hides them under a collapse menu, make sure it's not doing that.
tmortagne - (15:46): ok
tmortagne - (15:48): found it so it's always the same thing, just before doing the redirect there is a
tmortagne - (15:48): http://127.0.0.1:8080/xwiki/bin/register/XWiki/XWikiPreferences?xpage=registeruser?ajax=1      400 Bad Request
tmortagne - (15:48): a POST
tmortagne - (15:49): hmm
tmortagne - (15:49): i'm looking at the "Post" tag in the details of the request
tmortagne - (15:49): i see
tmortagne - (15:49): xwikiname   qq
tmortagne - (15:49): among other things
CalebJamesDeLisl - (15:50): xwikiname=qq ?!
CalebJamesDeLisl - (15:50): that your test name?
tmortagne - (15:50): ha i know i thing that's how the user name is called in this request
tmortagne - (15:50): yep
tmortagne - (15:51): i tought i was the wiki name when seeing "xwikiname"
tmortagne - (15:51): very bad parameter name...
tmortagne - (15:52): to be more precise in the Net section i get
tmortagne - (15:53): http://127.0.0.1:8080/xwiki/bin/register/XWiki/XWikiPreferences?xpage=registeruser?ajax=1    400 Bad Request
tmortagne - (15:53): just before the redirect and then
tmortagne - (15:53): http://127.0.0.1:8080/xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Users    Aborted
tmortagne - (15:53): just after the redirect
tmortagne - (15:53): only thing in red in the list
tmortagne - (15:54): (first one is a POST and second one a GET and seems to be the target of the redirect)
tmortagne - (15:54): i don't have the second one in the Console, just in Net
tmortagne - (15:55): and i think the second one is directly related to
tmortagne - (15:55): 2010-04-21 15:46:48,172 [http://127.0.0.1:8080/xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Users] ERROR web.XWikiAction                 - Connection aborted
tmortagne - (15:55): either the server or the client close the connection before it's finished for some reason
tmortagne - (15:55): looks more like the client
CalebJamesDeLisl - (15:56): Yup repeated.
CalebJamesDeLisl - (15:56): Looks like the fragile lightbox has been broken. I don't see any livevalidation in the fields.
CalebJamesDeLisl - (15:58): Wait a second!  There are supposed to be stars next to the fields indicating they are mandatory. Has it been completely reverted?!
tmortagne - (16:00): CalebJamesDeLisl: something else i did not noticed previously, i created a user with a password shorter than 6 chars and it worked
tmortagne - (16:00): so yes it seems there is old code used here
CalebJamesDeLisl - (16:01): That's what i'd say. Should have removed that template when I had the chance ;)
CalebJamesDeLisl - (16:02): Yea, user sheet has been reverted.
CalebJamesDeLisl - (16:04): r27393. you broke it ;)
CalebJamesDeLisl - (16:06): Looks like it was just a bad merge.
CalebJamesDeLisl - (16:07): Or not, svn doesn't allow that.
tmortagne - (16:07): on which page ?
CalebJamesDeLisl - (16:09): XWikiUsersSheet lines 111 and 112
tmortagne - (16:09): you mean AdminUserSheet ? there is no modification on XWikiUserSheet on r27393
tmortagne - (16:10): i don't understand why i changed "registerinline" for "registeruser", probably a copy past from older branch yes
tmortagne - (16:10): it was not on purpose for sure
vmassol - (16:10): guys please make sure to add a functional test
vmassol - (16:11): so does it mean registration has no functional test?
vmassol - (16:11): (make sure you add it before you fix the pb ;))
tmortagne - (16:11): CalebJamesDeLisl: are you taking care of that ?
CalebJamesDeLisl - (16:12): I wasn't but I can if you want.
tmortagne - (16:12): i'm working on an important right bug right now
CalebJamesDeLisl - (16:12): Ok, I'll do it.
tmortagne - (16:12): thanks
gvallarelli left at 16:12 (Ping timeout: 252 seconds
CalebJamesDeLisl - (16:13): Good luck in the /user/impl
CalebJamesDeLisl - (16:13): My conclusion when I read it was I would never ever touch anything.
tmortagne - (16:13): yea i'm starting to know it pretty well :)
tmortagne - (16:13): (but my eyes still hurt ;))
CalebJamesDeLisl - (16:13): I know how you feel.
jvdrean - (16:23): Nice, chuck norris on xwiki.org (page deleted)
vmassol - (16:51): CalebJamesDeLisl: you closed without a functional test. I think it would be worth to add some func tests. Do you already have some for the new registration features?
CalebJamesDeLisl - (16:51): I do have some tests of the existing registration page. There is also a test to make sure the user is registered.
vmassol - (16:52): so add some test so that next time it's caught?
CalebJamesDeLisl - (16:52): I have been avoiding functional tests because I am going to have to spend a few days with selenium2 before I can make any sense of it.
CalebJamesDeLisl - (16:52): I know it's no excuse but that is the real reason.
vmassol - (16:52): ok… It hink you shoudl start by this actually then :)
vmassol - (16:53): I can help if you have questions
CalebJamesDeLisl - (16:53): Thanks. Is there a lot of build up? It seems like to rest one thing one has to define a bunch of classes.
CalebJamesDeLisl - (16:53): s/rest/test/
vmassol - (16:54): CalebJamesDeLisl: not too much since it's quite new
vmassol - (16:54): but it's easy to add where required
vmassol - (16:54): the strategy is page objects indeed
vmassol - (16:55): so that other tests can then build up on yours
vmassol - (16:55): that prevents duplication
CalebJamesDeLisl - (16:55): Ok, I'm going to post the invitation code to sandbox and then I will get started right away.
vmassol - (16:55): great
vmassol - (16:55): cool to get someone else to look at it
vmassol - (16:55): so far only jerome and I have looked at it
vmassol - (16:56): we need to all know it so that new tests are built on selenium2 instead of seleinum2
CalebJamesDeLisl - (16:56): I am anxious about writing the right inferstructure classes.
CalebJamesDeLisl - (16:56): I don't know how the test might be used in the future.
CalebJamesDeLisl - (16:57): I've learned that success is nothing but failure and stubbornness and I have both in spades.
vmassol - (17:00): we all have, that's how we progress :)
mariusbutuc joined #xwiki at 17:17
CalebJamesDeLisl - (17:19): Hmm. am I not allowed to commit to sandbox?
vmassol - (17:19): your user need to be added to the committer group on sandbox.xwiki.org
vmassol - (17:19): I can do that
vmassol - (17:20): contrib.xwiki.org
CalebJamesDeLisl - (17:20): Thanks.
vmassol - (17:20): what user? (you have 2)
vmassol - (17:21): ah no
vmassol - (17:21): 3
vmassol - (17:21): ok found it
vmassol - (17:22): CalebJamesDeLisl: can you try now?
CalebJamesDeLisl - (17:22): Hmm, nope. Did you chose cjdelisle?
vmassol - (17:22): yes
vmassol - (17:23): ok i know
vmassol - (17:24): CalebJamesDeLisl: can you try again?
CalebJamesDeLisl - (17:24): Nope.
vmassol - (17:26): you sure you have done a proper checkout?
vmassol - (17:27): (don't know if it matters)
vmassol - (17:27): with https
CalebJamesDeLisl - (17:27): I checked out with https.
vmassol - (17:27): then I don't know what the problem is
CalebJamesDeLisl - (17:27): What is the file that should be returning my name?
vmassol - (17:27): I don't really know how the code works for authentication against the svn
vmassol - (17:28): I don't know
vmassol - (17:28): there's a script somewhere indeed
CalebJamesDeLisl - (17:28): I saw it once when there was an update of xwiki.org and the bot was running.
vmassol - (17:29): ok found it
vmassol - (17:29): http://www.xwiki.org/xwiki/bin/view/XWiki/GetCommitters
vmassol - (17:30): you're there: http://www.xwiki.org/xwiki/bin/view/XWiki/GetCommitters?project=contrib
vmassol - (17:30): missing xwiki: prefix
vmassol - (17:30): no
vmassol - (17:30): that's what i thought initially
vmassol - (17:30): but I've tried with both
CalebJamesDeLisl - (17:31): And now it works.
temporalfox joined #xwiki at 17:31
CalebJamesDeLisl - (17:31): Funny those things.
vmassol - (17:31): I put back the value I put in my first try… strange
CalebJamesDeLisl - (17:32): Cache?
mariusbutuc left #xwiki at 17:44
evalica left at 17:54 (Quit: Leaving.
lucaa left at 17:56 (Quit: Leaving.
lucaa joined #xwiki at 17:56
CalebJamesDeLisl - (18:20): So looking at these tests it looks like I need to add a page element like "class LightBox<? extends BasePage>" then I need to make sure the things in the page still work in the lightbox.
CalebJamesDeLisl - (18:23): Of course if then a page is made where things are pointed to with full xpath like /html/body/.... then that would obviously break.
vmassol - (18:24): lightbox sounds too generic to me
vmassol - (18:24): RegisterUserLightBox maybe? (or RegisterUserLightBoxPage)
CalebJamesDeLisl - (18:26): Ok, so then each test gets it's own element? ;)
vmassol - (18:26): the goal of the Page object is to provide actions done on that page
vmassol - (18:26): so that the tests can use a high level DSL and not do any tech stuff
vmassol - (18:27): for example for a user reg lightbox page, you'd have a registerUser() method probably
vmassol - (18:27): wihch would fill all the fields
vmassol - (18:27): and then press the add button
CalebJamesDeLisl - (18:27): I have been largely doing that in selenium1 tests with all of the helper methods.
vmassol - (18:27): the test would use that page  and then assert the result
vmassol - (18:28): the result would need a user admin page
vmassol - (18:28): with a hasUser() method
vmassol - (18:28): which would be used in the test assert
CalebJamesDeLisl - (18:28): Would you say it's a best practice to keep xpaths out of the test class?
vmassol - (18:28): in selenium1 there was a bit or reuse but it was way less organized
vmassol - (18:28): it was all in a flat space
vmassol - (18:29): yes definitely
vmassol - (18:29): there should definitely be no xpath or no technical name in the test
vmassol - (18:29): tech name := id, class, etc
CalebJamesDeLisl - (18:29): Hmm, that will slow things down in cases where there is no reuse.
vmassol - (18:30): yes it'll slow down by something like 1-5 minutes
vmassol - (18:30): it's worth it
vmassol - (18:30): IMO
vmassol - (18:30): much better than trying to second guess the reuse
nickless joined #xwiki at 18:30
vmassol - (18:30): which inevitably fail to work
vmassol - (18:30): since people take the shortcut and then no reuse
vmassol - (18:31): which is what we had in selenium1
CalebJamesDeLisl - (18:31): I'm not making a judgment at this point on it. It's always hard to read the future.
vmassol - (18:31): I added method initially for the reuse as new methodes were required people didn't no refactor
vmassol - (18:31): s/as/but as/
vmassol - (18:32): I find the page object a better pattern
vmassol - (18:32): I discovered it on the selenium best practice page
vmassol - (18:32): s/selenium/selenium2/
vmassol - (18:32): didn't knowit before
CalebJamesDeLisl - (18:33): Yes the lack of name spacing and all of the globals was an eyesore but "it's just a test" was what I understood to be the rationale.
vmassol - (18:33): one thing missing in our fwk for selenium2 is the notion of skin, we'll need to add that at one point
CalebJamesDeLisl - (18:34): Anyway. I have to have some idea of how this stuff might be reused before I go and code nice clean code which is not reusable because it's too specialized.
vmassol - (18:34): IMO jsut add a registerUser method, should be enough for now
vmassol - (18:35): + the isUserAvailable() for the other Page object
vmassol - (18:35): do you need more right now?
CalebJamesDeLisl - (18:35): Seems like the page in the lightbox should be an extension of the page outside of the lightbox.
vmassol - (18:36): could be indeed
CalebJamesDeLisl - (18:36): Create a register page, add fields, logic to fill them in etc. Then create a class for in lightbox and start over. Sounds wrong.
vmassol - (18:36): you wouldn't create a register page
vmassol - (18:36): you would do this:
vmassol - (18:37): on the user page, you'd have a getRegistrationPage()
vmassol - (18:37): but I agree that it's better
vmassol - (18:37): to directly have a registerUser() method in the user page
vmassol - (18:37): that method would click on register, fill the fields and press save
vmassol - (18:37): hmm we need also a way to test the cancel
vmassol - (18:38): (the cross at the top right)
CalebJamesDeLisl - (18:38): In the user page? Don't you need registration before you have access to the user?
vmassol - (18:38): cancelling the registration lightbox
vmassol - (18:38): so maybe 2 classes are good after all
CalebJamesDeLisl - (18:39): Yes. The upper right hand X is intrinsic to the lightbox, the fields and buttons are intrinsic to the register page, how do we reuse both?
vmassol - (18:39): by having a lightbox page
vmassol - (18:40): extended by the register user lightbox "age"
vmassol - (18:40): s/age/page/
CalebJamesDeLisl - (18:40): LightBoxRegister extends Register?
vmassol - (18:40): err?
vmassol - (18:40): what is Register?
CalebJamesDeLisl - (18:40): RegisterPage
CalebJamesDeLisl - (18:41): public class RegisterPageInLightBox extends RegisterPage?
vmassol - (18:41): I don't think so
vmassol - (18:41): actually I'm against it
vmassol - (18:41): it's wrong
vmassol - (18:41): for ex, the register page has a register button
CalebJamesDeLisl - (18:41): You lose the X from the lightbox.
vmassol - (18:41): this would mean the register lightbox page would also have a register button
vmassol - (18:41): which is not hte case
vmassol - (18:42): the register lightbox page is NOT a register page
vmassol - (18:42): I don't understand your problem actually
CalebJamesDeLisl - (18:42): Actually it is. There are some hacks to recognize the lightbox and behave differently.
vmassol - (18:43): where is the delete user in the user reg lightbox?
vmassol - (18:43): where is the register user in the user reg lightbox?
vmassol - (18:43): where are the menus int he suer reg ligthbox ?
vmassol - (18:43): so it's not a reg page
CalebJamesDeLisl - (18:43): The user reg lightbox is view/XWiki/Registration
vmassol - (18:44): it doesn't matter what it is technically
vmassol - (18:44): it's from a user pob
vmassol - (18:44): pov
vmassol - (18:44): when I have:
vmassol - (18:45): UserRegistrationLightBox urlb =....
vmassol - (18:45): then
vmassol - (18:45): I shouldn't be able to write:
vmassol - (18:45): urlb.deleteUser()
vmassol - (18:45): or urlb.deletePage()
vmassol - (18:45): FTM I can imagine 2 versb on urlb
CalebJamesDeLisl - (18:46): You can do that from /register/XWiki/Register?
vmassol - (18:46): urlb.registerUser(….)
vmassol - (18:46): and
vmassol - (18:46): urlb.cancel()
vmassol - (18:46): ah you're talking about something else I think
vmassol - (18:46): are you talking about the reg page that is not in the admin ?
vmassol - (18:47): (I was only talking about the page in the admin + its lightbox)
CalebJamesDeLisl - (18:47): It's also in the admin section.
CalebJamesDeLisl - (18:47): Admin->Users->Add user
vmassol - (18:47): name mixup
CalebJamesDeLisl - (18:47): Livetable? I mess that up all the time.
vmassol - (18:48): is it the same code used in both places?
CalebJamesDeLisl - (18:48): Yup.
vmassol - (18:48): ok then we can have an additional class
vmassol - (18:49): for sharing that UI
vmassol - (18:49): let's call it RegistrationElement for now
CalebJamesDeLisl - (18:49): Can you explain what it provides?
vmassol - (18:49): so UserRegistrationLightBox extends RegElement
vmassol - (18:49): the filling of the fields
vmassol - (18:49): and maybe (if it's shared) the submit button
vmassol - (18:50): then RegistrationPage exteds RegElement
CalebJamesDeLisl - (18:50): No the submit button is the "detect the lightbox" hack I referred to.
vmassol - (18:50): ok then it's not common
vmassol - (18:50): IMO
vmassol - (18:51): all this shows a UI issue BTW
mflorea left at 18:51 (Quit: Leaving.
CalebJamesDeLisl - (18:51): I agree having to detect the lightbox is wrong.
vmassol - (18:51): hmm actually we should differentiate user addition from registration in term of wording, at least for now
CalebJamesDeLisl - (18:52): Wording in the tests?
vmassol - (18:52): actually I think that difference is also in the UI
vmassol - (18:52): if I remember well
CalebJamesDeLisl - (18:53): Are you referring to registeruser.vm vs. registerinline.vm?
vmassol - (18:53): I have no idea what these are
vmassol - (18:54): http://myxwiki.org/xwiki/bin/admin/XWiki/XWikiPreferences?editor=globaladmin&section=Users#|t=userstable&p=1&wiki=local
vmassol - (18:54): indeed the button is 'add user'
vmassol - (18:54): while http://myxwiki.org/xwiki/bin/register/XWiki/Register is about registration
vmassol - (18:54): so we should keep this wording difference in the tests IMO
CalebJamesDeLisl - (18:55): Even though it's internally the same thing?
CalebJamesDeLisl - (18:55): copy-paste code reuse ;)
vmassol - (18:55): Im' not sure what we are talking about
vmassol - (18:55): we've already talked about the code reuse
vmassol - (18:55): anyway
vmassol - (18:55): the best is that you do it
vmassol - (18:56): we can talk after based on something tangible maybe
glerouge left at 18:56 (Quit: Leaving.
jvdrean left at 18:56 (Quit: Leaving.
vmassol - (18:56): it's taking lot of time here for something that would be expressed in 30 seconds verbally I believe ;)
CalebJamesDeLisl - (18:57): Perhaps so. I will hack something together and you can see what you think.
vmassol - (18:57): great
gvallarelli joined #xwiki at 18:58
gvallarelli - (18:58): Hi
CalebJamesDeLisl - (18:58): Actually I'm going to take a break and go try pulling off a gear for the garden tractor. See ya later.
vmassol - (18:58): hehe see ya
vmassol - (18:59): I'll go and d some cement to set up a fence in the garden too ;)
vmassol - (18:59): s/d/do/
vmassol - (19:00): tmortagne: you're sure of yourself for 2.2 for the hasAccessLevel? Isn't it risky? (unless you're ok to do a 2.2.6 if it's not working ;))
tmortagne - (19:01): vmassol: the next release is already 2.2.6 in 2.2 branch
vmassol - (19:01): ah right
vmassol - (19:01): then 2.2.7
vmassol - (19:02): I think it's good to have it in 2.2.6 if you're confident about the fix and if we're all ok to do a 2.2.7 should there be a pb
tmortagne - (19:02): and yes i don't think it's risky (it's even a potential security risk to keep 2.2 the way it is currently)
vmassol - (19:02): ok
tmortagne - (19:03): and anyway yes i'm ok with a 2.2.7
tmortagne - (19:03): one more one less...
vmassol - (19:03): :)
tmortagne - (19:03): (i'm currently adding some more unit test, good thing is that this test commes with lot's of multiwiki unit tests)
tmortagne - (19:03): at last
vmassol - (19:04): cool
KermitTheFragger left at 19:10 (Quit: Leaving
lucaa left at 19:28 (Quit: Leaving.
arkub left at 19:40 (Ping timeout: 258 seconds
florinciu joined #xwiki at 19:43
florinciu left at 19:45 (Read error: Connection reset by peer
mflorea joined #xwiki at 19:50
jfx joined #xwiki at 19:53
jfx left #xwiki at 19:53
gvallarelli - (20:09): got to go goodbye
gvallarelli - (20:09): and good work
gvallarelli left #xwiki at 20:09
npm left at 20:13 (Quit: Leaving.
npm joined #xwiki at 20:18
jvdrean joined #xwiki at 21:06
florinciu joined #xwiki at 21:49
jvdrean left at 22:12 (Quit: Leaving.
jvdrean joined #xwiki at 23:00
tmortagne left at 23:00 (Quit: Leaving.
tmortagne joined #xwiki at 23:04
tmortagne left at 23:04 (Client Quit
vmassol left at 23:09 (Quit: Leaving.
mflorea left at 23:19 (Remote host closed the connection
mflorea joined #xwiki at 23:19
florinciu left at 23:47 (Read error: Connection reset by peer
florinciu joined #xwiki at 23:49