IRC Archive for channel #xwiki on 18 January 2012

00:00 <vmassol> has quit
00:54 <rrodriguez> has quit
02:25 <tekzilla> has quit
02:27 <tekzilla> has joined #xwiki
05:00 <DrLou> has quit
05:14 <CIA-121> Sergiu Dumitriu master * r12db777 / xwiki-platform-core/xwiki-platform-annotations/xwiki-platform-annotation-ui/src/main/resources/AnnotationCode/Style.xml : XWIKI-7391: Add border or shadows to annotation modal window ...
05:48 <CIA-121> Sergiu Dumitriu master * r8a0b055 / xwiki-enterprise-ui/src/main/resources/Main/Activity.xml : [misc] Hide the message stream form also when using the /edit/ action, not just the deprecated /inline/ one. - http://git.io/mIh4Cw
06:00 <Denis1> has joined #xwiki
06:02 <Denis> has quit
07:38 <vmassol> has joined #xwiki
07:41 <sdumitriu> has quit
07:59 <mflorea> has joined #xwiki
08:23 <vmassol> has quit
08:53 <tmortagne> has joined #xwiki
08:54 <CIA-121> Marius Dumitru Florea master * r5ebe7d9 / (2 files): [misc] Extend the WYSIWYG Editor page objects to be able to move a test for Selenium 1 to Selenium 2. - http://git.io/YOITeA
08:54 <CIA-121> Marius Dumitru Florea master * r77a77a1 / (3 files in 2 dirs): Fix failing WYSIWYG tests (+ moved one of them to ui-tests). - http://git.io/4gPypQ
09:18 <jvelo> has joined #xwiki
09:35 <sburjan> has joined #xwiki
09:48 <jvdrean> has quit
09:52 <vmassol> has joined #xwiki
09:55 <Denis1> is now known as <Denis>
09:56 <+sburjan> seems that ui-tests are stuck on jenkins
10:03 <vmassol> has quit
10:13 <gdelhumeau> has joined #xwiki
10:37 <evalica> has joined #xwiki
10:56 <Enygma`> has joined #xwiki
11:14 <jvdrean> has joined #xwiki
11:32 <evalica> has quit
11:33 <Enygma`> has quit
12:16 <mflorea> has quit
12:20 <CIA-121> tmortagne master * r8bcbae0 / (6 files in 6 dirs): XWIKI-7384: Provide UI to import and synchronize an external extension ...
12:20 <CIA-121> tmortagne master * rb7ab43d / xwiki-platform-core/pom.xml : XWIKI-7407: Upgrade to Restlet 2.0.11 - http://git.io/2M1_gw
12:41 <vmassol> has joined #xwiki
12:50 <CIA-121> tmortagne master * rec2810e / xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java : XWIKI-7410: "Can't find any begin event corresponding to [class ...
12:52 <mflorea> has joined #xwiki
12:58 <silviar> has joined #xwiki
13:14 <+mflorea> tmortagne: platform build fails due to a compilation failure on xwiki-platform-extension-repository-xwiki-server-api http://ci.xwiki.org/job/xwiki-platform/1371/consoleText
13:16 <+mflorea> cannot find symbol AbstractXHTMLLinkTypeRenderer
13:18 <evalica> has joined #xwiki
13:24 <+tmortagne> mflorea: that's weird, this is not new, it's part of rendering
13:24 <+tmortagne> checking something
13:25 <+mflorea> the last 3 failures are all strange..
13:25 <+mflorea> plarform failures
13:25 <+mflorea> platform
13:28 <+tmortagne> mflorea: trying with html syntax module as direct dependency, it's cleaner anyway since it directly use it it should directly depends on it
13:29 <+mflorea> ok
13:30 <CIA-121> tmortagne master * r2d08842 / xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-repositories/xwiki-platform-extension-repository-xwiki/xwiki-platform-extension-repository-xwiki-server-api/pom.xml : Put xhtml syntax module as direct dependency - http://git.io/hKEWog
13:30 <+tmortagne> lets see
13:31 <sburjan> has quit
13:33 <sburjan> has joined #xwiki
13:34 <CIA-121> tmortagne master * r8890c08 / (7 files): Apply codestyle - http://git.io/rH7UzA
13:34 <Enygma`> has joined #xwiki
13:42 <CIA-121> Marius Dumitru Florea master * r7ea7b85 / (4 files in 2 dirs): Extend the WYSIWYG editor page objects to be able to move the tests that require windows focus from wysiwyg-tests to ui-tests. - http://git.io/lVSpCQ
13:42 <CIA-121> Marius Dumitru Florea master * rcc94626 / (5 files in 3 dirs): Move tests that require window focus to ui-tests. - http://git.io/XgIciw
14:12 <jvelo> has quit
14:40 <+tmortagne> mflorea: looks like test-ui always get stuck
14:41 <+mflorea> yes, I'll take care of it asap
14:53 <vmassol> hi guys, just back from my morning meeting…
14:53 <vmassol> so what's up? how is the release doing? :)
14:53 <vmassol> (have we been able to start it already?)
14:57 <CIA-121> Marius Dumitru Florea master * r3cf8296 / xwiki-enterprise-test/xwiki-enterprise-test-wysiwyg/src/test/it/org/xwiki/test/wysiwyg/SubmitTest.java : XE-947: WYSWYG SubmitTest#testShortcutsForSaveAndView() and SubmitTest#testShortcutsForSaveAndContinue() fail erroniously. ...
14:58 <+mflorea> nop, I'm looking at the ui-tests
14:58 <vmassol> mflorea: you've been able to track down the hanging?
14:58 <+mflorea> not yet
15:01 <+mflorea> yeah, found it!!!
15:01 <+mflorea> we get a popup "To display this page, Firefox must send information that will repeat any action (such as a search or order confirmation) that was performed earlier."
15:01 <vmassol> ahah
15:02 <+mflorea> how can we fix this?
15:02 <vmassol> indeed I should have thought about this...
15:02 <vmassol> (I got ot locally when I upgraded at some point)
15:02 <vmassol> let's google to find how to avoid it
15:02 <vmassol> there might be some startup mapram
15:02 <vmassol> *param
15:03 <vmassol> In the URL window of firefox type about:config
15:03 <vmassol> Change this setting in firefox
15:03 <vmassol> browser.sessionstore.postdata;
15:03 <vmassol> Change from a 0 to 1
15:04 <vmassol> but that needs to start it
15:04 <vmassol> visually
15:04 <+mflorea> but why do we get this in the first place? do we refresh the page after a post?
15:05 <vmassol> reading http://support.mozilla.org/en-US/questions/695164
15:05 <+mflorea> I'm looking at testRedirectBackAfterLogin
15:06 <vmassol> or
15:06 <vmassol> Tools,Options, Advance,
15:06 <vmassol> uncheck "Tell me when a Website asks to store ...
15:07 <vmassol> more info about the param here: http://kb.mozillazine.org/Browser.sessionstore.postdata
15:08 <vmassol> actually
15:08 <vmassol> we could possibly set some param in java
15:09 <vmassol> checking
15:09 <vmassol> maybe it's possible to set the prop in a profile: http://code.google.com/p/selenium/wiki/FirefoxDriver
15:09 <vmassol> something similar to:
15:10 <vmassol> firefoxProfile.setPreference("extensions.firebug.currentVersion", "1.8.1"); // Avoid startup screen
15:12 <+mflorea> ok, but maybe we can fix the test. I'm looking at the LoginTest and for instance I see that testLoginWithInvalidUsername fails when run separately. There might be other mistakes too.
15:12 <vmassol> yep seem it' possible, see http://rostislav-matl.blogspot.com/2011/09/setting-firefox-preferences-via.html
15:13 <vmassol> mflorea: sure we could try making the test work without doing a back()
15:13 <vmassol> apparently it fails when: it's doing a back() and the previous URL was sending post data
15:13 <vmassol> right?
15:14 <+mflorea> could be, yes
15:14 <vmassol> at least we could easily try: http://rostislav-matl.blogspot.com/2011/09/setting-firefox-preferences-via.html
15:14 <+mflorea> but I'm trying to see if this is a problem with a particular test or it's something related to the order in which tests are run
15:14 <vmassol> (with the "browser.sessionstore.postdata" prop)
15:14 <vmassol> ok
15:46 <lucaa> has joined #xwiki
15:54 <+mflorea> ok, I understood the problem. recacheSecretToken is called before each test, and it navigates back after the token is cached. As a consequence, if you have a test that leaves the browser in a "POST-form-submitted" state (like testLoginWithInvalidCredentials which just POSTs invalid credentials) then the next test will face the "resubmit POST data" popup.
15:56 <vmassol> makes sense
15:59 <+mflorea> so I see three options: (1) don't go back in recacheSecretToken (I have to see where it is used) (2) make a GET request in tearDown (in LoginTest at least) or (3) configure the FF profile.
16:00 <+mflorea> re (3) I'm wondering if could miss some bugs if we prevent the "resend POST data" popup
16:02 <+mflorea> or, instead of using the Back button, I could save the current URL before caching the csrf token and GET the URL after
16:04 <DrLou_> has joined #xwiki
16:06 <+mflorea> I'll try this last approach
16:13 <vmassol> I agree that if we can avoid (3) it's better
16:23 <CIA-121> Marius Dumitru Florea master * r2a8b016 / xwiki-platform-core/xwiki-platform-test/src/main/java/org/xwiki/test/ui/TestUtils.java : Fix the functional UI tests hanging issue. - http://git.io/ULQsnQ
16:24 <sburjan`> has quit
16:24 <sburjan`> has joined #xwiki
16:55 <sdumitriu> has joined #xwiki
16:58 <+sburjan> sdumitriu: Nice work on Annotations Modal ! :)
17:02 <+evalica> I don't like the blue shadow
17:03 <@sdumitriu> Yep, seen the comment evalica
17:04 <@sdumitriu> sburjan: You didn't tell me yesterday, is the 3.3.1 build good?
17:16 <vmassol> mflorea: btw how did you find about the FF popup blocking the test?
17:16 <+mflorea> vmassol: I run all LoginTests
17:17 <vmassol> locally?
17:17 <+mflorea> yes
17:17 <vmassol> ok so it wasn't an issue of the agent
17:17 <+mflorea> it didn't reproduce when I run each test individually
17:17 <+mflorea> yep
17:17 <vmassol> so we were right that it could be caused by other tests running before the hanging test
17:18 <+mflorea> yep
17:18 <vmassol> ok
17:18 <vmassol> cool that it's not related to the agent
17:18 <vmassol> so the tests should be all ok now?
17:19 <vmassol> sdumitriu: hi
17:19 <vmassol> could you fix the extensions test?
17:19 <vmassol> (there should be only 1, thomas fixed the XR test AFAIK)
17:25 <+sburjan> sdumitriu: yes, I also tested it on Oracle
17:25 <+sburjan> only issues I found were reported but only fixed in 3.4
17:29 <rrodriguez> has joined #xwiki
17:44 <vmassol> snif… we still have 12 failures in ui tests
17:44 <vmassol> http://ci.xwiki.org/job/xwiki-enterprise-test-ui/org.xwiki.enterprise$xwiki-enterprise-test-ui/903/testReport/
17:44 <vmassol> (snif being French and meaning *sob*)
17:46 <vmassol> mflorea: I reported this on the webdriver mailing list: "Element cannot be scrolled into view"
17:46 <vmassol> it started appearing in 2.16.0
17:46 <vmassol> which is why I didn't upgrade to 2.16.0 earlier (remember now :))
17:46 <+mflorea> I'll check if there is any workaround
17:46 <vmassol> s/2.16/2.15/
17:46 <vmassol> https://groups.google.com/forum/#!topic/webdriver/R2jwSWrIK44
17:46 <vmassol> ah seems the thread has grown now
17:47 <vmassol> " Unfortunately this hasn't been fixed in 2.17, but will
17:47 <vmassol> hopefully be in 2.18 which should be out soon."
17:47 <sburjan> has quit
17:47 <vmassol> https://code.google.com/p/selenium/issues/detail?id=3075
17:48 <vmassol> btw 2.17 is out apparenty: http://code.google.com/p/selenium/source/browse/trunk/java/CHANGELOG
17:49 <vmassol> "FIXED: 3154, 3144: Issues launching Firefox 9 due to modal dialog" interesting
17:49 <vmassol> (probably not the problem we had though)
17:56 <abusenius> has joined #xwiki
17:58 <CIA-121> tmortagne master * rf38f323 / xwiki-enterprise-installers/xwiki-enterprise-installer-debian/xwiki-enterprise-installer-debian-tomcat/xwiki-enterprise-installer-debian-tomcat-pgsql/pom.xml : XE-1092: PosgreSQL debian package has the wrong driver set in hibernate ...
18:05 <silviar> has quit
18:05 <tmortagne> has quit
18:11 <CIA-121> tmortagne master * rf5925ce / xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-repositories/xwiki-platform-extension-repository-xwiki/xwiki-platform-extension-repository-xwiki-server-api/src/main/java/org/xwiki/extension/repository/xwiki/internal/resources/ExtensionRESTResource.java : Remove unneeded imports - http://git.io/j-sYpQ
18:53 <abusenius> has quit
19:00 <abusenius> has joined #xwiki
19:03 <gdelhumeau> has quit
19:03 <vmassol> has quit
19:12 <mflorea> has quit
19:45 <mflorea> has joined #xwiki
20:09 <evalica> has quit
20:23 <sburjan`> has quit
20:24 <lucaa> has quit
20:25 <vmassol> has joined #xwiki
20:48 <Enygma`> has quit
21:56 <xwikibot> has joined #xwiki
22:10 <rrodriguez> has quit
22:29 <CIA-121> Marius Dumitru Florea master * ree32659 / xwiki-platform-core/xwiki-platform-test/src/main/java/org/xwiki/test/ui/po/BasePage.java : Fix some of the functional UI tests that are failing because of the changes made for XWIKI-6018 (and possibly also because of the Selenium upgrade). - http://git.io/3GdbiQ
22:46 <abusenius> has quit
23:05 <vmassol> has quit