IRC Archive for channel #xwiki on 22 May 2012

Last modified by Vincent Massol on 2012/10/18 19:22

00:03 <sburjan_> has joined #xwiki
00:06 <jvdrean> has quit
00:07 <sburjan`> has quit
00:07 <sburjan_> is now known as <sburjan`>
00:08 <polx_> has joined #xwiki
00:12 <polx> has quit
00:12 <polx_> is now known as <polx>
00:40 <polx> has quit
00:59 <ssavi> has joined #xwiki
01:01 <sburjan`> has quit
01:02 <sburjan`> has joined #xwiki
02:15 <qwebirc16628> has joined #xwiki
02:16 <slugz> has joined #xwiki
02:17 <qwebirc16628> hey guys, i was just trying to view the hsql db in DBEdit, I cant seem to access the DB apparently i need to update the JDBC Driver to the latest one? But I believe it already is at the latest driver, is this a bug?
02:18 <qwebirc16628> im on an OSX
02:22 <@sdumitriu> Hi qwebirc16628
02:22 <qwebirc16628> Hello
02:22 <qwebirc16628> Any ideas? :)
02:22 <@sdumitriu> Nope...
02:23 <@sdumitriu> Can you be more specific about the failure?
02:23 <qwebirc16628> ill just go get the exact error.. one momento.
02:24 <qwebirc16628> No suitable driver for URL "my db"
02:24 <@sdumitriu> Hm... Looks like configuration error
02:24 <qwebirc16628> java.lang.Exception: No suitable driver for URL "/Applications/XWiki Enterprise/data/xwiki_db" 	at dbedit.ConnectionData.connect(ConnectionData.java:115) 	at dbedit.actions.ConnectAction.performThreaded(ConnectAction.java:56) 	at dbedit.actions.CustomAction$1.execute(CustomAction.java:43) 	at dbedit.ThreadedAction.run(ThreadedAction.java:48) 	at java.lang.Thread.run(Thread.java:680) Caused by: java.sql.SQLException: No suitable
02:24 <@sdumitriu> What exactly did you use as the connection string?
02:24 <qwebirc16628> Thats the rest of the error
02:25 <qwebirc16628> name of my connection, user as sa and the url to the db name
02:25 <@sdumitriu> Try using this: jdbc:hsqldb:file:/Applications/XWiki Enterprise/data/xwiki_db
02:26 <qwebirc16628> yah thats what i have.. i just shortened it for the example
02:27 <qwebirc16628> this is what i have in the url: /Applications/XWiki Enterprise/data/xwiki_db
02:27 <@sdumitriu> Including the jdbc:hsqldb:file: prefix, right?
02:28 <qwebirc16628> does the prefix go at the end?
02:28 <qwebirc16628> xwiki_db.something?
02:30 <@sdumitriu> Wait
02:30 <@sdumitriu> So, I downloaded DBEdit myself
02:30 <qwebirc16628> okay
02:30 <@sdumitriu> Pressed on Add connection
02:30 <qwebirc16628> yes
02:30 <@sdumitriu> Chose hsqldb
02:31 <qwebirc16628> yes
02:31 <@sdumitriu> And it asked me for a file location
02:31 <@sdumitriu> And here I used the path to a database on my disk
02:31 <qwebirc16628> does this have to go at the beginning: jdbc:hsqldb:file:/
02:32 <@sdumitriu> Then it displays a more complex Connection dialog, with 4 inputs
02:32 <@sdumitriu> Name: xwiki_db
02:32 <@sdumitriu> URL: jdbc:hsqldb:/home/sgm/Downloads/xwiki-enterprise-jetty-hsqldb-4.1-milestone-1/database/xwiki_db
02:32 <@sdumitriu> User: sa
02:32 <@sdumitriu> Password: <empty>
02:33 <qwebirc16628> yes
02:33 <@sdumitriu> I can try to connect to it, but it says "wrong database file version"
02:34 <qwebirc16628> hmmm
02:36 <@sdumitriu> Then I closed the application, removed the hsqldb.jar file from there, and copied over a hsqldb-2.2.8.jar from my XWiki instance (from WEB-INF/lib)
02:36 <@sdumitriu> And now it works
02:37 <qwebirc16628> okay, so thats the solution, aWesome.. ill give it a go :-)
02:41 <@sdumitriu> Also, make sure that the database is indeed in the "data" directory, and not "database"
02:41 <@sdumitriu> Usually it's "database" in a default installation, so it should be "data" only if you explicitly moved it
02:42 <qwebirc16628> okay next error... Database lock acquisition failure: lockFile: org.hsqldb.. etc
02:42 <qwebirc16628> would this is a permision thing on osx?
02:42 <@sdumitriu> Probably not, is XWiki already running?
02:42 <qwebirc16628> No
02:43 <@sdumitriu> Hm...
02:43 <qwebirc16628> ill close everything down and try again, one moment
02:43 <@sdumitriu> Can you check if there's a xwiki_db.lock file in that directory?
02:43 <@sdumitriu> If yes, just delete it
02:43 <qwebirc16628> which directory?
02:43 <@sdumitriu> The one with the database
02:44 <qwebirc16628> this is in the main root folder: xwiki.lck
02:44 <qwebirc16628> database folder looks fine
02:47 <qwebirc16628> looks like it connected, i can use the browser schema, but no table information is loading...
02:56 <qwebirc16628> yah def looks like its connecting, but when i click on details in the browser scheme like SYSTEM_USERS, i dont get any results..
02:56 <qwebirc16628> do you get any default tables that load up?
02:59 <qwebirc16628> okay, looks like its pretty manual, im used to Navicat where things are little more automated
02:59 <qwebirc16628> so i just need to select what i want and then run a query and all good
03:04 <qwebirc16628> Thanks @sdumitriu. Its been a BIG HELP :D
03:04 <@sdumitriu> You're welcome
03:10 <qwebirc16628> has quit
03:21 <npm> sdumitriu: I'm still seeing http://jira.xwiki.org/browse/XWIKI-6180 in 3.5 virtual wiki (see scrollback) should I reopen that bug, or what? --- macros in root-wiki disappear after restart if "global" work (after restart) when set to work on current wiki
03:22 <npm> um... that last part didn't survive editing
03:22 <npm> i meant: when macro scope set to global, it becomes undefined next restart
03:22 <npm> when set to wiki-only it works as expected
03:23 <@sdumitriu> Is that a multiwiki environment?
03:23 <npm> yes
03:23 <npm> it worked fine when virtual=0
03:24 <npm> then i converted to multiwiki and noticed it failing
03:24 <@sdumitriu> Hm...
03:24 <@sdumitriu> I'd say open a new issue
03:24 <@sdumitriu> Ah, one more q
03:24 <npm> ok
03:24 <npm> sure
03:25 <@sdumitriu> Is the macro defined in the main wiki or in a subwiki?
03:25 <npm> main wiki
03:25 <npm> i had http://www.nielsmayer.com setup as solo wiki
03:25 <npm> then added a second wiki
03:26 <@sdumitriu> Does the macro stop working everywhere, or just in the non-main wikis?
03:26 <npm> i didn't check the other wiki because i was acutally only using on main
03:26 <npm> so the issue is actually solved for me (working on next)
03:26 <npm> but was curious if known bug fixed in 3.5.1
03:27 <npm> also having issue changing Lucene search in main wiki to only index the main wiki
03:27 <npm> it hangs forever... till i delete lucene files and restart, then it goes back to reindexing all subwikis, which i don't want
03:29 <npm> sdumitriu: one more thing that's relevant (but a hunch on my part)
03:29 <npm> it has to do w/ the macro being groovy
03:30 <npm> and perhaps no other groovy being loaded after tomcat restart
03:30 <npm> yes
03:31 <npm> oops never mind the "yes"
03:31 <npm> there's also "com.mysql.jdbc.exceptions.jdbc4.MySQLSyntaxErrorException: Incorrect database name 'Sandbox.Google Talk'" showing up in logs
03:32 <@sdumitriu> Probably a malformed link to a document containing : in its name
03:33 <npm> apparently because I once had a document named "Google Talk: ...."
03:33 <npm> odd thing is I renamed document, deleted the orig from trashbin, and still get same error
03:34 <npm> will try hand editing out the name from activitystream_events db directly
03:35 <npm> neways i'm tracking that down before i declare another bug :-)
03:35 <npm> although giving such errors on a document with a colon in the title is a bug too i guess.
03:36 <npm> and also seems a potential route to sql injection (??) if you can erroneously switch databases like that
03:37 <npm> going to dinner will file the  http://jira.xwiki.org/browse/XWIKI-6180 'ish bug later
03:49 <CIA-74> Sergiu Dumitriu master * r114d9ad https://github.com/xwiki/xwiki-rendering/commit/114d9ade972caa5220fd4c709a8e6f9f121419de / (4 files): XRENDERING-206: [[path:]] and [[attach:]] links are incorrectly marked as external links - http://git.io/BbgdEA
03:50 <sdumitriu> has quit
03:51 <qwebirc59671> has joined #xwiki
03:52 <qwebirc59671> Hey guys, just wondering whether im connecting ot the right xwiki data... my schema shows INFORMATION_SCHEMA, PUBLIC and SYSTEM_LOBS,.. its pretty abstract
03:53 <qwebirc59671> Looking at this page, it looks more readable and friendly.. http://platform.xwiki.org/xwiki/bin/view/DevGuide/DatabaseSchema
04:18 <qwebirc59671> has quit
05:54 <npm> looks like 3.5 doesn't like long comments: "Caused by: com.mysql.jdbc.MysqlDataTruncation: Data truncation: Data too long for column 'XWR_COMMENT' at row 1
05:55 <npm> the comment: "renamed document to eliminate weird bug that happens with ':' in document name, here making same change to title for consistency w/ url -- the ':' in name seems to be mistaken for space. Also deleted all associated activity stream entries for the old document name with the ':' in name."
06:29 <polx> has joined #xwiki
07:01 <slugz> has quit
07:03 <Denis2> has joined #xwiki
07:05 <Denis> has quit
08:01 <vmassol> has joined #xwiki
08:07 <CIA-74> Vincent Massol master * r3bd0af8 https://github.com/xwiki/xwiki-platform/commit/3bd0af8a400690c50f1dbebf40802fd82d57ac1b / xwiki-platform-core/pom.xml : Add more CLIRR excludes and explanations. Would be nice if the Release Manager ...
08:07 <CIA-74> Vincent Massol master * r3c2173d https://github.com/xwiki/xwiki-platform/commit/3c2173d35493c782aecc6b70abb46b1d9e844ac1 / xwiki-platform-core/pom.xml : Add end of exclude block - http://git.io/SoWwhw
08:07 <CIA-74> Vincent Massol master * r00a1d6f https://github.com/xwiki/xwiki-platform/commit/00a1d6ff4028dba437089e6440192cde50fb5db1 / xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-script/src/test/java/org/xwiki/component/internal/script/ComponentScriptServiceTest.java : Use AssertNull instead (suggested by Sergiu Dumitriu) - http://git.io/qol8Zg
08:12 <rrodriguez> has quit
08:22 <ssavi> has quit
08:23 <ssavi> has joined #xwiki
08:53 <mflorea> has joined #xwiki
09:12 <tmortagne> has joined #xwiki
09:21 <jvdrean> has joined #xwiki
09:26 <sburjan> has joined #xwiki
09:38 <CIA-74> tmortagne stable-3.5.x * r5d469e3 https://github.com/xwiki/xwiki-platform/commit/5d469e34fb9bc59b4f975a83701c6eb048b20a67 / xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.cfg.vm : XWIKI-7843: Wrong documentation of some field of LDAP in xwiki.cfg - http://git.io/UPbfSQ
09:39 <CIA-74> tmortagne master * r4429b4e https://github.com/xwiki/xwiki-platform/commit/4429b4edddac8b9b6ee2b723a352f3cb3fab7148 / xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.cfg.vm : XWIKI-7843: Wrong documentation of some field of LDAP in xwiki.cfg - http://git.io/q3STXg
09:39 <CIA-74> tmortagne stable-4.0.x * r9df5b07 https://github.com/xwiki/xwiki-platform/commit/9df5b07d06b48bd7cd439ec2a60064428aada4a2 / xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.cfg.vm : XWIKI-7843: Wrong documentation of some field of LDAP in xwiki.cfg - http://git.io/fdDoCg
09:42 <jvdrean> has quit
10:17 <mflorea> has quit
10:28 <mflorea> has joined #xwiki
10:29 <ssavi> has quit
10:33 <ssavi> has joined #xwiki
10:42 <jvdrean> has joined #xwiki
11:16 <jvelo> has quit
11:22 <ssavi> has quit
11:38 <jvdrean1> has joined #xwiki
11:40 <jvelo> has joined #xwiki
11:42 <jvdrean> has quit
12:08 <tmortagne> has quit
12:13 <Denis2> is now known as <Denis>
12:17 <Enygma`> has joined #xwiki
12:17 <evalica> has joined #xwiki
12:43 <CIA-74> Ecaterina Moraru (Valica) master * rd52a6ef https://github.com/xwiki/xwiki-platform/commit/d52a6efeb6379158b021042128796df2ca702506 / (2 files in 2 dirs): Merge pull request #47 from jssolichin/master - http://git.io/f4ji-A
12:43 <CIA-74> Jonathan Solichin master * ra396fc7 https://github.com/xwiki/xwiki-platform/commit/a396fc785d1494dc391dad7c54f515095788d45f / (2 files in 2 dirs): Simplified the 'Tags' section initial text to conform with other initial/empty states Revised - http://git.io/6KfgNQ
12:51 <tmortagne> has joined #xwiki
12:57 <mflorea> has quit
13:21 <+sburjan> vmassol: were you able to download the ISO yesterday ?
13:21 <vmassol> sburjan: yep, still downloading
13:21 <vmassol> 3 hours more
13:22 <+sburjan> since yesterday ? so slow ?
13:22 <vmassol> I had to restart it, it was stalled
13:22 <+sburjan> ok
13:27 <+sburjan> vmassol: I could help you by investigatin a little bit the UAC behavior towards our package
13:27 <vmassol> I understand UAC. I'm now looking how to get PROGRAMDATA dir
13:28 <vmassol> if you know how to do that it would help
13:29 <vmassol> my guess is that we'll need to differentiate windows versions
13:29 <vmassol> in XP it doesn't exist AFAIK
13:29 <+sburjan> or if it does, it's not the same
13:30 <vmassol> not the same is not a problem at all
13:30 <vmassol> but it doesn't exist on XP
13:30 <+sburjan> my question is: do you want to install in multiple directories or you want everything in one ?
13:30 <vmassol> multiple
13:31 <+sburjan> I'm trying to imagine a scenario with multiple directories, idea is that afaik database dir cannot be set apart from jetty
13:31 <vmassol> wrong
13:31 <vmassol> :)
13:31 <+sburjan> okay, that's a step forward :)
13:31 <+sburjan> at least for me
13:32 <+sburjan> http://ss64.com/nt/syntax-variables.html
13:32 <+sburjan> I'm looking at this
13:32 <vmassol> http://technet.microsoft.com/en-us/library/dd560744%28WS.10%29.aspx
13:34 <vmassol> but %ProgramData% isn't set on XP
13:34 <vmassol> I've tried it
13:34 <vmassol> ah yes it says N/A in your doc
13:34 <vmassol> (had missed it)
13:34 <vmassol> anyway we 'll just need several profiles
13:36 <+sburjan> seems that %ALLUSERSPROFILE% exists in XP, whith its equivalent in Windows 7 being %ProgramData%
13:36 <vmassol> yes
13:39 <+sburjan> and for windows 8 we'll need another profile too it seems
13:50 <mflorea> has joined #xwiki
13:51 <+sburjan> now the quetion is if that the installer is used only to test, or we want something more with it .. because if we only want it for testing purposes, we can install it in C:\XWiki
13:51 <vmassol> test?
13:52 <vmassol> hmm
13:52 <+sburjan> well can be the installer used in production ? with hetty and hsqldb ?
13:52 <vmassol> you mean the standalone distribution
13:52 <vmassol> indeed we've said it's not configured for production
13:52 <vmassol> but i don't think it's a reason for putting stuff in the wrong place
13:52 <+sburjan> yes, something like "minimal wiki", "playground wiki"
13:53 <+sburjan> yes, true
13:53 <vmassol> I remember that I was hating software that installed in C:\ when I was a windows user
13:53 <vmassol> ;)
13:53 <+sburjan> I'm 100% the impact of a product starts with a good installer
13:53 <vmassol> yes
13:53 <vmassol> steve jobs believed in this too ;)
13:53 <vmassol> (reading his biography...)
13:54 <+sburjan> and yes, putting stuff in C:| could bother/annoy users since WIndows has paths specially for apps to store their data
13:54 <+sburjan> and users expecting a seamless integration
13:55 <+sburjan> bbl
13:55 <slugz> has joined #xwiki
14:15 <evalica1> has joined #xwiki
14:15 <evalica> has quit
14:15 <evalica1> is now known as <evalica>
14:49 <sdumitriu> has joined #xwiki
15:29 <polx> has quit
15:30 <polx> has joined #xwiki
15:30 <tmortagne> has quit
15:32 <tmortagne> has joined #xwiki
15:43 <CIA-74> Sorin Burjan master * rc07a47b https://github.com/xwiki/xwiki-enterprise/commit/c07a47b7ab23b286d8b70a290893beac20811f4c / (3 files in 3 dirs): XE-1175: Exclude failing Selenium 2 tests on IE8 from running - http://git.io/QZRMvQ
15:43 <CIA-74> Sorin Burjan master * r9f8fd40 https://github.com/xwiki/xwiki-enterprise/commit/9f8fd40c4bf458f9f6138b57d6aca943bffdc0bc / xwiki-enterprise-test/xwiki-enterprise-test-ui/src/test/it/org/xwiki/test/ui/LoginTest.java : XE-1175: Exclude failing Selenium 2 tests on IE8 from running - http://git.io/OxN7LQ
15:43 <CIA-74> Sergiu Dumitriu master * redee1b2 https://github.com/xwiki/xwiki-enterprise/commit/edee1b290f11e8515bf6cf30aec5d67ff1836d2b / (2 files in 2 dirs): Merge pull request #21 from sorinello/XE-1175 - http://git.io/WxuJhw
15:48 <+sburjan> sdumitriu: thanks for the merge !
15:49 <@sdumitriu> sburjan: Don't forget to create the two issues about the two ignored tests
15:49 <+sburjan> sdumitriu: I'll update the existing issue which lists all of the ignored tests
15:50 <@sdumitriu> sburjan: Or that, yes
15:57 <+sburjan> sdumitriu: done
15:58 <+sburjan> I have started a job, don't know if t he changes are already built
16:07 <+sburjan> any idea why this fails even if 0 tests failed ? http://ci.xwiki.org/computer/agent-7/
16:08 <vmassol> sburjan: http://ci.xwiki.org/job/xwiki-enterprise-test-ui-IE8/19/console
16:08 <vmassol> "Caused by: com.jcraft.jsch.JSchException: reject HostKey: maven.xwiki.org"
16:08 <vmassol> this agent's key is missing from maven.xwiki.org
16:09 <vmassol> I'm not sure if we wish to deploy artifacts built on this agent though....
16:09 <+sburjan> we don't
16:09 <vmassol> then we must not use the deploy goal
16:09 <vmassol> instead we need to use the install goal
16:09 <+sburjan> ok, let me try to update the job
16:10 <vmassol> it's a job specific to that agent?
16:10 <vmassol> answer: yes
16:10 <+sburjan> yes it is
16:10 <+sburjan> only bound to that agent
16:10 <vmassol> done
16:11 <vmassol> you can trigger a new build if you want
16:11 <+sburjan> ok, let me manually start a build
16:11 <+sburjan> yepp, e-mail notifs are disabled, so I won;t geenrate noise
16:11 <vmassol> cool
16:21 <+sburjan> http://ci.xwiki.org/job/xwiki-enterprise-test-ui-IE8/20/ and success :D
16:21 <+sburjan> finally I see one of my dreams achieved
16:23 <+sburjan> thanks vmassol !
16:23 <vmassol> cool
16:23 <vmassol> :)
16:23 <+sburjan> IE9 is next :D
16:32 <CIA-74> Sergiu Dumitriu master * rcd54f71 https://github.com/xwiki/xwiki-platform/commit/cd54f71367ed8efbe81c6e1d052c15724be0905e / xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java : XWIKI-7846: The email field is not obfuscated as it should be - http://git.io/03muWw
16:32 <CIA-74> Sergiu Dumitriu stable-4.0.x * r5060ccb https://github.com/xwiki/xwiki-platform/commit/5060ccb6321a562169734e3459e3b02ef00256ab / xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java : XWIKI-7846: The email field is not obfuscated as it should be - http://git.io/YVhizw
16:39 <vmassol> we need someone to upgrade myxwiki.org to 4.1-SNAPSHOT…
16:39 <vmassol> IMO we need to make it part of the release process and script it
16:40 <vmassol> otherwise we don't get the benefit of having it as a real life test platform
16:41 <vmassol> (I'll do the myxwiki upgrade next week if nobody beats me to it but would be nice if someone beats me; ))
17:00 <slugz> has quit
17:08 <sburjan> has quit
17:22 <@cjd> re "[VOTE] Stop bundling legacy .jar files in enterprise and manager." how do you imagine this being rectified?
17:22 <@cjd> because if it just quietly downloads and installs the jars with old extensions then we're no better off than shipping them anyway.
17:24 <@cjd> it seems like extension authors should be using a compatibility matrix to show where their extensions do and don't work.
17:24 <+tmortagne> vmassol: why SHAPSHOT ? isn't it supposed to be the milestone releases
17:24 <+tmortagne> ?
17:25 <vmassol> tmortagne: sure we can do that too. We  could use snapshot when we know it's stable enough and we want to test a given feature not released yet. I agree that milestones/rcs is better in general
17:46 <polx> has quit
18:12 <ssavi> has joined #xwiki
18:14 <evalica> has quit
18:18 <Enygma`> has quit
18:22 <tmortagne> has quit
18:47 <CIA-74> Marius Dumitru Florea master * ra355e2b https://github.com/xwiki/xwiki-platform/commit/a355e2b4088e6bb2ec00d820ed7c4af517e1bfa4 / (3 files in 3 dirs): XWIKI-7649: Introduce document merge conflict resolution UI - http://git.io/1iF5nQ
18:57 <CIA-74> Jean-Vincent Drean master * r1f4be6e https://github.com/xwiki/xwiki-platform/commit/1f4be6ee087ce86a7ede31ac6018fff8ee8f95b6 / (5 files in 4 dirs): XWIKI-7847 : Allow to set the timezone in the wiki preferences and the user profile - http://git.io/7t6Wmw
18:59 <mflorea> has quit
19:01 <jvdrean1> has quit
19:27 <polx> has joined #xwiki
19:44 <abusenius> has joined #xwiki
20:03 <CIA-74> Caleb James DeLisle XWIKI-7748 * r83056dd https://github.com/xwiki/xwiki-commons/commit/83056dd644121761ce1de31b4036e0bf924b7624 / (51 files in 35 dirs): Merged in the trunk. (+24 more commits...) - http://git.io/h8fdQQ
20:13 <polx> has quit
20:13 <polx> has joined #xwiki
20:15 <ssavi> has quit
20:22 <CIA-74> Caleb James DeLisle XWIKI-7748 * r8872395 https://github.com/xwiki/xwiki-commons/commit/8872395772051ff3324c58e2854b8374b6068226 / (5 files in 3 dirs): XWIKI-7748 move EnvironmentConfiguration into /internal/ - http://git.io/YD_VNA
20:59 <rrodriguez> has joined #xwiki
21:05 <vmassol> cjd: I don't like this change too much because 1) you've just broken backward compat and 2) I had done this on purpose so the least would be to discuss it
21:06 <vmassol> in any case we've agreed that we need a VOTE before breaking backward dep
21:06 <vmassol> unless I've misunderstood something and nothing is broken :)
21:06 <@cjd> You're talking about EnvironmentConfiguration?
21:06 <vmassol> yup
21:06 <vmassol> checking somrthing
21:06 <polx_> has joined #xwiki
21:07 <@cjd> Well, why is it in public space? That looked like a mistake to me.
21:07 <vmassol> I'm checking
21:07 <vmassol> if I'm not mistaking this for another class I wrote
21:07 <vmassol> no that's the one
21:08 <vmassol> I'm sure I could be convinced but that's not the problem for me
21:08 <vmassol> the problem is that I don't see how this doesn't break backward compat but you haven't added a clirr exclude
21:08 <vmassol> ?
21:08 <vmassol> and adding a clirr exclude requires a vote
21:08 <@cjd> I'm pretty sure I did.
21:08 <polx> has quit
21:08 <polx_> is now known as <polx>
21:08 <vmassol> maybe in another commit, let me check other mails
21:09 <@cjd> Check the comparison
21:09 <vmassol> indeed found another mail
21:09 <@cjd> https://github.com/xwiki/xwiki-commons/compare/XWIKI-7748
21:09 <vmassol> hmm we don't get diffs
21:09 <vmassol> checking github
21:09 <vmassol> what?
21:09 <vmassol> seems they've removed it
21:10 <vmassol> cjd: I don't see a vote email
21:10 <@cjd> perhaps because it's committed against a branch?
21:10 <vmassol> this is in a branch?
21:10 <@cjd> mhm
21:11 <vmassol> indeed
21:11 <vmassol> ahhhhh
21:11 <vmassol> I always make the mistake
21:11 <@cjd> I'd like to merge it asap
21:11 <vmassol> I hate how github reports this
21:11 <vmassol> I always think it's master
21:11 <@cjd> https://github.com/xwiki/xwiki-commons/compare/XWIKI-7748 <-- this is the diff
21:11 <rrodriguez> has quit
21:13 <vmassol> I'd like to review it but I won't have the time since I'm travelling starting tomorrow till end of week… so I'll trust the others to review it :)
21:13 <vmassol> what's improtznt for me
21:13 <vmassol> if our new rule re backawrd compat
21:13 <vmassol> ie that we don't take it lightly
21:13 <vmassol> and only add clirr excludes with votes and common agreement
21:14 <vmassol> except for young apis but we haven't concluded on that thread yet
21:14 <@cjd> Well that brings up an interesting point because as far as I can see, the new rule has not gone into effect.
21:14 <vmassol> environment could be considered a young apis, depending on how we define it
21:14 <vmassol> it IS in effect
21:14 <@cjd> We agreed not to ship legacy code as part of that.
21:14 <vmassol> not really
21:15 <vmassol> at least that's not what I agreed
21:15 <vmassol> what I agreed is
21:15 <vmassol> to offer the ability to download a distribution without legacy code
21:15 <vmassol> that does't mean not shipping a distribution with legacy code
21:15 <vmassol> we haven't agreed on details yet
21:15 <vmassol> but I'm not talking about this
21:16 <vmassol> I'm talking about our deprecation/legacy policy
21:16 <vmassol> not distribution
21:16 <rrodriguez> has joined #xwiki
21:16 <@cjd> ok
21:16 <@cjd> I'd like to clear something up on that point too. I'm not sure how to approach the question about extensions.
21:16 <vmassol> re distribution I'm really worried
21:17 <vmassol> our extensions are already not in a good shape
21:17 <vmassol> it would be 10 times worse
21:17 <vmassol> so we need to find a solution
21:17 <vmassol> I don't have the solution right now
21:17 <vmassol> (you asked earlier)
21:18 <vmassol> someone's got to propose something
21:18 <@cjd> If we *want* to move away from bundling legacy then I want to help. If we want to punt the issue and accept that nothing will ever leave the code once it enters, I'm not going to bring a war against that community standard.
21:18 <vmassol> well for me
21:18 <vmassol> not bundling legacy is reallly  not improtant at all
21:18 <vmassol> what's important
21:18 <@cjd> It's not an easy question to answer.
21:18 <vmassol> is for users
21:18 <vmassol> to be able to clearly see when they use depredcated stuff in wiki pages
21:18 <vmassol> got to go
21:19 <vmassol> has quit
21:29 <CIA-74> Sergiu Dumitriu master * r6bddc7e https://github.com/xwiki/xwiki-rendering/commit/6bddc7e3ed4563ef354ed8ea47dff927691ba2ab / xwiki-rendering-syntaxes/xwiki-rendering-syntax-xhtml/src/main/resources/META-INF/components.txt : [misc] List components in alphabetical order - http://git.io/Pv73kA
21:29 <CIA-74> Sergiu Dumitriu master * r5f23ff2 https://github.com/xwiki/xwiki-rendering/commit/5f23ff247730e79d04d7afb4ceef87eae858d40b / xwiki-rendering-syntaxes/xwiki-rendering-syntax-xhtml/src/main/resources/META-INF/components.txt : XRENDERING-206: [[path:]] and [[attach:]] links are incorrectly marked as external links - http://git.io/wwJ8QA
21:40 <ssavi> has joined #xwiki
21:51 <polx> has quit
21:51 <polx> has joined #xwiki
21:52 <ssavi> has quit
21:54 <vmassol> has joined #xwiki
21:58 <vmassol> has quit
22:17 <jvdrean> has joined #xwiki
22:48 <abusenius> has quit
22:59 <jvdrean> has quit
23:26 <ssavi> has joined #xwiki

Get Connected