IRC Archive for channel #xwiki on 23 September 2013
Last modified by Vincent Massol on 2013/09/23 22:59
<abusenius> has quit
00:36 <polx> has quit
02:28 <sburjan`> has quit
02:28 <bouquetf> has quit
02:28 <lynxt> has quit
02:28 <Denis> has quit
02:28 <kstuart> has quit
02:28 <sdumitriu> has quit
02:29 <xwikibot> has joined #xwiki
02:29 <ekarlso> has joined #xwiki
04:30 <Denis> has joined #xwiki
05:51 <Denis> has quit
06:32 <polx> has joined #xwiki
06:34 <polx> has quit
07:50 <polx> has joined #xwiki
07:52 <vmassol> has joined #xwiki
08:02 <mflorea> has joined #xwiki
08:18 <tmortagne> has joined #xwiki
08:36 <Denis> has joined #xwiki
08:40 <polx> has quit
08:44 <sburjan> has joined #xwiki
08:44 <msmeria> has joined #xwiki
08:45 <polx> has joined #xwiki
08:48 <vmassol> cjd: good morning
08:51 <vmassol> tmortagne: I have a very very basic markdown renderer started here (I started it for Emmanuel Bernard at some point to give him a skeleton since he was interested in working on this - but he's no longer). I wonder if I should commit the little I've done or if it needs to be complete before committing it: https://github.com/xwiki/xwiki-rendering/compare/markdown-renderer
08:51 <vmassol> (good morning too btw! :))
08:52 <vmassol> (it could be labelled "alpha" if we wanted to commit it)
08:52 <tmortagne> vmassol: +1 for commit with experimental or alpha or something like that like we did for xwiki/2.1 before we declare it stable
08:53 <vmassol> ok I'll push something for 5.3M1 then
08:53 <vmassol> after we create the RC1 brnach for 5.2
08:53 <vmassol> thanks
08:54 <vmassol> ah jakub has also started doing that, cool
09:01 <UCC> has joined #xwiki
09:03 <vmassol> tmortagne: you really deleted " remotes/origin/feature-resource-and-wiki-modules"?
09:03 <vmassol> that's my branch and it's needed ….
09:04 <vmassol> see XWIKI-9236
09:04 <tmortagne> where do you see me removing this branch ?
09:04 <tmortagne> I did not touched it
09:04 <vmassol> you said "deleted" in your last email
09:05 <vmassol> maybe you replied to the wrong line then?
09:05 <vmassol> (which would be great! :))
09:05 <tmortagne> was feature-restimportxar
09:05 <vmassol> ok pfew :)
09:06 <tmortagne> I checked all the empty branches (branches with no diff with master)
09:06 <vmassol> yep
09:08 <evalica> has joined #xwiki
09:24 <vmassol> sburjan/msmeria: good morning
09:24 <vmassol> any blocker for the RC1 release of today?
09:24 <vmassol> committers: anything remaining from any of you for RC1?
09:24 <sburjan> vmassol: anything I know about is the issue GD reported abut the Upgrade All Wikis
09:25 <sburjan> besides that, I did not found anything
09:25 <vmassol> hm indeed, he's probably not fixed it, I think he wanted to disable the upgrade all wikis but I didn't follow this thread
09:25 <vmassol> I think thomas said +1, who's supposed to do that?
09:26 <vmassol> (the disabling)
09:27 <vmassol> GD probably if he knows enough about the DW, maybe mflorea can help?
09:27 <tmortagne> vmassol: no idea what is supposed to disable but Guillaume need to validate the proposal first (plus I'm the only one who voted)
09:27 <tmortagne> s/what/who/
09:27 <vmassol> yes would be good to have mflorea's opinion at least
09:27 <tmortagne> I know how to diabled it don't worry about that
09:27 <tmortagne> disable
09:27 <vmassol> ok
09:27 <tmortagne> it's more on my side than on UI side
09:28 <vmassol> ok so we just need some more opinions and that's all?
09:28 <vmassol> ah GD needs to answer you say, ok
09:28 <tmortagne> just need to say "this proposal pass" I guess yes
09:28 <vmassol> ok let's wait for him
09:29 <tmortagne> anyway disabling it locally waiting for him
09:29 <vmassol> ok :)
09:29 <vmassol> btw
09:29 <vmassol> I have one problem with activeinstalls
09:29 <vmassol> (a small one)
09:29 <vmassol> if you go to http://activeinstalls.xwiki.org/
09:29 <vmassol> you'll see there are some 1.0-SNAPSHOT versions
09:29 <vmassol> these are sent by sergiu and fabio
09:30 <vmassol> because they built a product based on XE
09:30 <vmassol> the problem is that we don't send a product name along with the version
09:30 <tmortagne> you should IMO
09:30 <vmassol> I'm wondering what we could send
09:30 <vmassol> yes we should
09:30 <tmortagne> send the while distribution id
09:30 <vmassol> do we have that info somewhere?
09:30 <vmassol> ah
09:30 <tmortagne> ExtensionId
09:30 <vmassol> ok good, you think they have differentone?
09:30 <tmortagne> you are extracting the version from it I guess
09:30 <tmortagne> but you also have the id
09:30 <vmassol> yes
09:31 <vmassol> ok
09:31 <vmassol> but will it be different for them?
09:31 <tmortagne> EM is looking at the pom.xml so yes it should unless they do very weird stuff
09:32 <vmassol> ok, I'll work on sending that now and commit before RC1 if you give me 1 hour
09:32 <tmortagne> bu at least for Fabio I know he is doing it properly since he asked me
09:32 <tmortagne> I'm not release manager so on my side you have all the time you want :)
09:32 <vmassol> :)
09:44 <vmassol> found a potential bug
09:45 <vmassol> I've just built XE from sources
09:45 <vmassol> and when I start it for the first time I get
09:45 <vmassol> https://www.evernote.com/shard/s119/sh/f283dec5-9b90-4240-b8cd-83c37612fb92/52a43c9c27680df8f374ad7d4e07ab3d
09:45 <vmassol> the AS is supposed to be empty
09:46 <vmassol> anyone has any idea why there's this entry in the AS?
09:46 <tmortagne> this is a generated class
09:46 <vmassol> yes but not the only one right?
09:46 <vmassol> yet only this one appears
09:46 <tmortagne> it's not a class actually
09:46 <tmortagne> a template
09:46 <tmortagne> maybe the other are hidden and not this one for some reason
09:46 <vmassol> good idea
09:46 <vmassol> checking
09:47 <tmortagne> but not sure why only now
09:47 <vmassol> indeed it's not hidden, checking code
09:47 <tmortagne> actually it used to be generated but I'm not sure it's still true after Edy's refactorings
09:47 <vmassol> it's generated
09:47 <vmassol> (can't find it in our sources)
09:48 <mflorea> vmassol: on my side I just need to finish http://jira.xwiki.org/browse/XWIKI-8535 . I'll reply to GD's mail.
09:48 <vmassol> mflorea: ok thanks
09:48 <tmortagne> looks like the sheet is in the XAR and the template is generated
09:48 <vmassol> searhcing where
09:48 <vmassol> if you know where, let me know ;)
09:48 <tmortagne> wiki-manager
09:50 <tmortagne> actually the the real code is in appmanager
09:50 <tmortagne> AbstractXClassManager#checkClassTemplateDocument
09:50 <vmassol> hmm I thought I had done fixes in there already
09:50 <tmortagne> it's not set hidden by default but it never did
09:50 <vmassol> maybe I missed this one
09:51 <vmassol> wow: doc.setSyntax(Syntax.XWIKI_1_0);
09:51 <vmassol> nice....
09:51 <tmortagne> yes it's not recent code
09:51 <vmassol> tmortagne: you want to fix the hidden or should I do it?
09:51 <tmortagne> you can do it
09:51 <tmortagne> continue working of DW
09:51 <vmassol> ok
09:53 <sdumitriu> has quit
09:58 <sdumitriu> has joined #xwiki
09:59 <vmassol> ok fixed and tested
09:59 <vmassol> ouch big buf
09:59 <vmassol> bug
10:00 <vmassol> sburjan/msmeria: could you try this on latest:
10:00 <vmassol> - log in as Admin
10:00 <vmassol> - go to Admin user profile
10:00 <vmassol> - change hidden docs settings to use and save
10:00 <vmassol> this leads me to http://localhost:8080/xwiki/XWiki/Admin?category=preferences which shows an empty page for an unknown reason ATM
10:00 <vmassol> missing bin/view
10:01 <vmassol> yes looks like a bug regression
10:01 <msmeria> vmassol: I can test it now
10:02 <tmortagne> vmassol: make sure you clean your browser cache, maybe some change in some JS
10:02 <vmassol> tmortagne: you're right
10:02 <vmassol> it was my cache
10:02 <vmassol> pfew :)
10:03 <vmassol> didn't think the cache could cause the url change
10:03 <tmortagne> still it's a pity we kind of break every browser when we change something
10:03 <fmancinelli> has joined #xwiki
10:04 <tmortagne> vmassol: you closed XWIKI-9487 but seems you did not pushed
10:04 <vmassol> indeed
10:05 <vmassol> thanks
10:05 <vmassol> hmm we also need to hide http://localhost:8080/xwiki/bin/view/XWiki/XWikiServerWorkspacetemplate
10:05 <vmassol> oops
10:05 <vmassol> bad paste
10:06 <vmassol> I meant XWikiServerWorkspacetemplate
10:06 <vmassol> checking where it's created
10:06 <gdelhumeau> has joined #xwiki
10:07 <tmortagne> vmassol: it's XWikiServerClassTemplate in your screenshot
10:08 <vmassol> tmortagne: that's another one :)
10:08 <vmassol> (that you get when you first create a wiki)
10:08 <tmortagne> well what you fixed in XWIKI-9487 is XWikiServerClassTemplate
10:09 <vmassol> I know
10:09 <vmassol> this is a different issue
10:09 <tmortagne> not sure what paste you are reffering to then
10:12 <vmassol> I can find the method getWikiDescriptorToSave
10:13 <vmassol> now trying to find where the xwikiserver doc is saved
10:13 <vmassol> found it
10:16 <msmeria> vmassol: after saving it redirects me to http://localhost:8080/xwiki/bin/XWiki/Admin?category=preferences, but if I hover over Profile and click on preferences the address is http://localhost:8080/xwiki/bin/view/XWiki/Admin?category=preferences. Both links point to the same thing, but I think "view" should also be included in the first one
10:20 <vmassol> gdelhumeau: good morning
10:20 <vmassol> see irc logs from this morning, we talked about you :)
10:21 <vmassol> msmeria: have you cleared your cache?
10:21 <gdelhumeau> hi vmassol
10:21 <gdelhumeau> Ok I check
10:22 <tmortagne> gdelhumeau: see your Skype ;)
10:22 <msmeria> vmassol: I didn't. Let me retest it
10:24 <vmassol> msmeria/sburjan: you should report this kind of bug too (ie when you think a page is visible - ie non hidden - when it should be)
10:25 <sburjan> and how do we know which page should hedden and which not ?
10:25 <vmassol> you're a user
10:25 <vmassol> so it's easy
10:26 <vmassol> do what I did: put yourself in the shoes of a basic user (ie hidden docs off, simple user)
10:26 <vmassol> and if you something weird, you report it
10:26 <vmassol> *see
10:26 <vmassol> pretty easy :)
10:26 <vmassol> what I mean is you should report usability bugs
10:26 <vmassol> s/you/that you/
10:27 <msmeria> vmassol: I retested after I cleared my cahce and I have the same behaviour
10:27 <vmassol> msmeria: ok, strange, probably missing a "view" somewhere then
10:27 <vmassol> this seems to indicate the url is manually crafted somewhere
10:28 <vmassol> or using a "" action...
10:34 <vmassol> gdelhumeau: I still get the DW wizard when creating a wiki is that normal?
10:34 <vmassol> (build from 30 mn ago)
10:35 <gdelhumeau> did you change the extension repository in xwiki.properties?
10:35 <vmassol> no
10:35 <vmassol> I need the snapshot repo?
10:35 <vmassol> i thought it wasn't the problme
10:35 <gdelhumeau> I personnaly use my own maven repo
10:36 <gdelhumeau> and you need to set it before creating the wiki template
10:36 <gdelhumeau> extension.repositories=local:maven:file://${sys:user.home}/.m2/repository
10:36 <vmassol> I know how to set that ;)
10:37 <vmassol> that's not the issue
10:38 <vmassol> ok works if use the snapshot repo, good
10:39 <vmassol> gdelhumeau: one problem: on a wiki the Panels space shouldn't be shown
10:39 <vmassol> (it contains non hidden doc, webpreferences to be precise)
10:41 <vmassol> there's also a XWikiComments page created not hidden in the XWiki space that I don't see in the main wiki
10:42 <gdelhumeau> I'm looking
10:43 <gdelhumeau> I have reproduced the Panel issue, but not the XWiki one. When I am logged as Admin, I always see the XWiki spaces, on the main wiki & on other wikis
10:45 <vmassol> of course
10:45 <vmassol> :)
10:45 <vmassol> "there's also a XWikiComments page created not hidden in the XWiki space that I don't see in the main wiki"
10:45 <vmassol> I haven't researched it, I don't know what this page is
10:46 <vmassol> but it's not on the main wiki
10:46 <vmassol> (at least not visible)
10:46 <gdelhumeau> ok
10:57 <alexdb> has joined #xwiki
11:05 <alexdb> has left #xwiki
11:33 <Slashman> has joined #xwiki
11:55 <mflorea> vmassol: for the DW issue (upgrade all wikis mode) I talked with tmortagne and we'd like to add a new step that is triggered only when you select the Upgrade All Wikis mode, and that displays the list of UI extension (XARs) installed on all wikis so that the user (global admin) can upgrade the wikis. I think we'll need one more day for this, so we either postpone the release for tomorrow or do this for 5.2 final. I prefer to postpone.
11:56 <vmassol> mflorea: postpone by the RC by one day seems better indeed. If we can keep the 5.2 final date FTM it's better. Thomas might need one or 2 more days if that's all he needs to have a first version of the new import though, he'll let us know
11:56 <vmassol> in short: sounds good to me
11:57 <mflorea> ok
11:59 <vmassol> gdelhumeau: it might be necessary to update the translations on l10n too before the final 5.2 release
11:59 <gdelhumeau> ok
11:59 <vmassol> when you switch to French the translations are about "espace de travail"
12:00 <vmassol> which AFAIU is not correct right?
12:01 <gdelhumeau> yes
12:04 <vmassol> gdelhumeau: btw regarding your last commit
12:04 <vmassol> did you deprecate the translation key too?
12:04 <vmassol> if not, you should
12:05 <gdelhumeau> ok
12:33 <xwikibot> has joined #xwiki
12:43 <sburjan> vmassol: ctrl+g works for me. on which browser are you on ?
12:44 <vmassol> chrome but the problem doesn't seem to be the browser
12:44 <vmassol> the url is wrong
12:44 <vmassol> http://localhost:8080/xwiki/bin/view/Main/$response.encodeURL(restURL)?q=sandbox
12:44 <vmassol> some recent commit must have caused this
12:45 <sburjan> vmassol: I don't know how to see the URL. But on Chrome it never worked, because in Chrome ctrl+g is actually the search function
12:45 <vmassol> jumptopage.js
12:45 <vmassol> script: "$response.encodeURL(restURL)",
12:46 <vmassol> seems Ic aused it
12:46 <vmassol> somehow
12:46 <vmassol> maybe $response is not defined in js
12:48 <sburjan> it's odd, I don't see jumptopage.js in my Firebug
12:48 <vmassol> which means we don't have any func test for jumptopage
12:49 <sburjan> but strangely, I don';t see it in Firebug, but it seems to be working for me :)
12:49 <vmassol> either you don't have the correct version or you have a cache
12:50 <sburjan> I cleared my cache. and I am on the latest snapshot from xwiki.org
12:56 <sburjan> vmassol: I am looking in the generated HTML (ctrl+u), and I don't see any jumptopage.js, I must be missing something
13:08 <mflorea> vmassol: I'll fix the search suggest, re subwiki
13:09 <mflorea> has quit
13:16 <vmassol> mf
13:16 <vmassol> s/mf//
13:52 <vmassol> any JS expert here?
13:52 <vmassol> I need a trick to be able to put a string in a string in velocity inside a js file without yuicompressor choking on it :)
13:52 <vmassol> script: "$response.encodeURL($restURL)",
13:53 <vmassol> more precisely:
13:53 <vmassol> new XWiki.widgets.Suggest(this.input, {
13:53 <vmassol> #set ($restURL = "${request.contextPath}/rest/wikis/${xcontext.database}/search?scope=name&number=10&")
13:53 <vmassol> I cannot use a js comment since minification will remove it
13:54 <vmassol> so I need some noop js operation that allows to put the following in it: irc://irc.freenode.net:6667/#set ($restURL = "${request.contextPath}/rest/wikis/${xcontext.database}/search?scope=name&number=10&")
13:54 <vmassol> (bad paste)
13:58 <vmassol> got it!
13:59 <vmassol> :)
14:04 <chalx> has joined #xwiki
14:08 <chalx1> has joined #xwiki
14:08 <chalx> has quit
14:09 <vmassol> ok jump to page fixed
14:10 <mflorea> has joined #xwiki
14:16 <sburjan> vmassol: what was the issue ? I am still unable to find the js from Firebug :)
14:17 <vmassol> checl the commit
14:18 <gdelhumeau> how do we deprecate a translation key?
14:37 <tmortagne> gdelhumeau: you have some documentation at the beginning of ApplicationResources.properties
14:37 <gdelhumeau> ok
14:41 <vmassol> guys I'm fixing vnc on all agents
14:41 <vmassol> there might be some false positives for a bit
14:49 <gdelhumeau> tmortagne: should I create a deprecated section (with #@deprecatedstart) on a translation which is a wiki document ? (not in ApplicationResources.properties)
14:51 <tmortagne> gdelhumeau: yes would be better to follow ApplicationResources.properties, l10n wiki works the same for both
14:52 <tmortagne> you can also add the ApplicationResources.properties header to your content
14:52 <gdelhumeau> nice, ok
14:54 <tmortagne> gdelhumeau: is this key older than 5.2 ?
14:58 <vmassol> ok all done
14:59 <gdelhumeau> yes
15:12 <fmancinelli> Hi guys, do you know if the Job Module serializes requests to the same job type? E.g., jobManager.executeJob("A", req1); jobManager.executeJob("A", req2); jobManager.executeJob("B", req3); will execute A,req1 and B,req3 in parallel and put A,req2 in wait until A,req1 is done?
15:13 <tmortagne> fmancinelli: there is no parallel execution yet
15:14 <tmortagne> everything that go trough JobManager is executed on the same background thread one by one right now
15:14 <tmortagne> (see http://jira.xwiki.org/browse/XCOMMONS-400)
15:15 <tmortagne> now for the serialization itself I'm not sure I understand what you ask exactly
15:15 <tmortagne> a job status is serializer when it's done runnning
15:15 <tmortagne> s/serializer/serialized/
15:17 <fmancinelli> serialized in the sense that no two jobs of the *same* type can be executed concurrently. So if you ask to execute 3 requests of a job type A, these requests will be serialized in the sense that the second will start when the first is done, and the third will start when the second is done. A request for a job of another type can, in case, be executed in parallel
15:19 <fmancinelli> anyway http://jira.xwiki.org/browse/XCOMMONS-400 is even more strict, in the sense that there is only one job executing at a given time :)
15:19 <tmortagne> fmancinelli: I can assure you it's impossible to execute jobs in parallel for now in job module, same type or not
15:20 <tmortagne> yes even when you use executeJob
15:20 <tmortagne> executeJob actually call addJob and wait for it to be done
15:22 <tmortagne> fmancinelli: note that before XCOMMONS-400 I would like to evaluate XCOMMONS-443, it may completely remove this module or a big part of it
15:23 <tmortagne> so if you feel like experimenting stuff you can look at it ;)
15:23 <Inge-> hm. it seems to me that the code rendering macro is quite a bit faster now than it used to be.
15:23 <Inge-> (i.e. 5.1 vs 3.4 or so)
15:24 <fmancinelli> has quit
15:25 <tmortagne> Inge-: we upgraded Jythong since 3.4 so might be it
15:25 <tmortagne> Jython
15:25 <tmortagne> and they were indeed supposed to work on speed but I did not really done much testing
15:25 <Inge-> rightbut
15:26 <Inge-> any change for caching it automatically?
15:26 <Inge-> or does that still require wrapping it in a cache macro?
15:26 <tmortagne> XWIKI-8456 is still open
15:26 <fmancinelli> has joined #xwiki
15:27 <tmortagne> ha something else, highligting used to be done 1 thread at a time
15:27 <tmortagne> it's not true anymore
15:27 <Inge-> yeah I just tested that
15:27 <Inge-> that helps quite a lot
15:27 <fmancinelli> sorry I crashed
15:28 <tmortagne> when there is a lot of users yes
15:28 <tmortagne> Inge-: if you fill like working on XWIKI-8456 I can give you some pointers
15:28 <Inge-> well, if the rendering took 50 seconds, and everything else was waiting for it ... you didn't need very many users
15:28 <tmortagne> 50s is really a lot
15:29 <Inge-> a 200 line bit of code took a long time in 3.4
15:29 <tmortagne> it took like 10s the first time it's used to initialize Jython but then I never saw it take 50s
15:29 <Inge-> now it was down to around 10s
15:30 <Inge-> and after wrapping in macro, it is <1sec
15:30 <Inge-> i.e. caching macro
15:30 <tmortagne> probably Jython for this one then
15:30 <tmortagne> what syntax was it ?
15:30 <Inge-> C#
15:30 <tmortagne> ok
15:41 <vmassol> gtg, bb in 1 hour
16:29 <msmeria> has quit
16:53 <gdelhumeau> enterprise build is broken
16:55 <sburjan> gdelhumeau: I am still getting DW wizard after creating a workspace (today's snapshot)
16:59 <gdelhumeau> sburjan: did you changed the extension repository in xwiki.properties ?
16:59 <sburjan> gdelhumeau: nope. do I need to activate the snapshot repository ?
17:00 <gdelhumeau> Yes, before creating the wiki template
17:00 <gdelhumeau> (you can delete "workspacetemplate" with the Wiki Manager UI)
17:05 <polx_> has joined #xwiki
17:07 <polx> has quit
17:08 <chalx1> has quit
17:09 <polx_> has quit
17:27 <sdumitriu> Quick question, should we allow spaces in usernames? Right now the authenticator removes all spaces from the passed username
17:28 <polx> has joined #xwiki
17:32 <UCC> has quit
17:33 <vmassol> sdumitriu: we need to decide globally what we wish to allow for usernames (dots, etc). I think this warrants some discussion on the list. Ideally we should support everything IMO
17:34 <vmassol> the real question is more: what needs to be fixed to achieve this
17:34 <sdumitriu> Mainly XWikiAuthServiceImpl
17:35 <sdumitriu> (I have a version that supports dots, trying to push it to the platform)
17:39 <chalx> has joined #xwiki
17:40 <UCC> has joined #xwiki
17:46 <vmassol> sdumitriu: not now please, we need to release 5.2RC1 and final :)
17:46 <gdelhumeau> *.WebPreferences should be hidden by default, don't you think?
17:46 <vmassol> yes
17:46 <vmassol> it's supposed to be like this already
17:46 <vmassol> (gdelhumeau)
17:50 <polx> has quit
17:51 <chalx> has quit
17:51 <sburjan> has quit
17:59 <gdelhumeau> it seems there is a problem in jenkis: http://ci.xwiki.org/job/xwiki-enterprise-test-webstandards/2742/console
17:59 <tmortagne> sdumitriu: authenticator is easy to fix but the main issue come from the groups and rights objects
18:01 <mflorea> has quit
18:02 <gdelhumeau> sburjan`: when I create a new user and I go to his profile, all fields display $escapetool.xml($doc.getValue($sectionProperty))
18:03 <gdelhumeau> sburjan`: can you confirm?
18:03 <vmassol> gdelhumeau: confirmed
18:03 <vmassol> ouch
18:04 <gdelhumeau> ok, I report it
18:04 <gdelhumeau> I handle it
18:04 <vmassol> I think Edy fixed something
18:04 <vmassol> in the user profile
18:04 <vmassol> to prevent XSS injection
18:04 <vmassol> he did this a few days ago, could be related
18:04 <vmassol> should be easy to fix
18:08 <gdelhumeau> When I save the page, it is fixed -_-
18:11 <gdelhumeau> fixed
18:12 <vmassol> what was the problem?
18:14 <gdelhumeau> https://github.com/xwiki/xwiki-platform/pull/176
18:14 <vmassol> why do you create a new issue?
18:15 <vmassol> also I'm not sure about the fix
18:16 <vmassol> XWIKI-8592
18:16 <gdelhumeau> because I needed a Jira issue to do my commit
18:16 <vmassol> yes and?
18:16 <gdelhumeau> there is already one?
18:16 <vmassol> the quesiton still stands
18:16 <vmassol> :)
18:16 <vmassol> ofc there is one
18:16 <vmassol> because it's a regression
18:16 <vmassol> so someone broke it
18:16 <vmassol> and that person had an issue
18:16 <vmassol> the only question is
18:16 <vmassol> when was it
18:16 <vmassol> did you check that?
18:17 <vmassol> the answer is 5.2RC1
18:17 <vmassol> so your issue cannot set a corredct affects
18:17 <Denis> has quit
18:17 <vmassol> becuase you'll have:
18:17 <vmassol> affects 5.2RC1
18:17 <vmassol> fix for 5.2 RC1
18:17 <vmassol> that doesn't make any sense for users
18:17 <vmassol> why report an issue that is not released
18:17 <vmassol> when it's fixed before the release
18:17 <vmassol> ?
18:17 <vmassol> :)
18:18 <vmassol> btw this is explained on http://dev.xwiki.org/xwiki/bin/view/Community/DevelopmentPractices
18:19 <vmassol> my second point was about the fix itself
18:19 <vmassol> I think the issue is that $doc.getValue() returns null
18:20 <gdelhumeau> it's because there is no value
18:20 <vmassol> it's because of null
18:20 <vmassol> so I was wondering if we shoudl do: $!doc.getValue() instead
18:20 <vmassol> which makes more sense to me
18:20 <vmassol> than $!escapetool.xml()
18:21 <vmassol> but I'm not 100% sure
18:21 <vmassol> :)
18:22 <vmassol> anyway could you redo your PR and I'll apply it
18:22 <vmassol> (with XWIKI-8592)
18:22 <vmassol> it exists but it's a security issue
18:22 <gdelhumeau> vmassol: If I do $escapetool.xml($!doc.getValue()) it still don't work
18:22 <vmassol> so not public
18:23 <vmassol> can you try:
18:23 <vmassol> $!{doc.getValue()}
18:23 <vmassol> ?
18:23 <vmassol> otherwise the ! might apply to doc only
18:23 <polx> has joined #xwiki
18:23 <gdelhumeau> not better
18:23 <vmassol> then I don't understand the issue
18:23 <vmassol> unless there's a bug in escapetool
18:23 <vmassol> $escapetool.xml("") should return ""
18:24 <vmassol> ok I'm not understanding something clearly
18:25 <gdelhumeau> $escapetool.xml('') returns ''
18:25 <vmassol> yes just tested
18:25 <gdelhumeau> $escapetool.xml($util.null) returns null
18:26 <gdelhumeau> $!{doc.getValue($sectionProperty)} returns ''
18:26 <gdelhumeau> but $escapetool.xml($!{doc.getValue($sectionProperty)}) returns null
18:26 <gdelhumeau> I don't understand why
18:26 <vmassol> ok so we're 2
18:26 <vmassol> :)
18:27 <vmassol> anyway if your solution works go for it
18:27 <vmassol> would still be interesting to understand why it doesn't wokr....
18:28 <gdelhumeau> I delete my JIRA ?
18:28 <vmassol> you can close it as invalid
18:28 <gdelhumeau> ok
18:29 <vmassol> affects = 5.2RC1 and no fix for
18:32 <gdelhumeau> the PR has been updated
18:33 <fmancinelli> has quit
18:43 <sdumitriu1> has joined #xwiki
18:49 <gdelhumeau> has quit
18:50 <tmortagne> has quit
19:11 <evalica> has quit
19:27 <Slashman> has quit
19:45 <cjd> vmassol: good afternoon, any branches of mine on the central repo you can trash, they're going to take significant work to get up to date and I still have local copies
19:55 <abusenius> has joined #xwiki
20:45 <Denis> has joined #xwiki
21:12 <UCC> has quit
21:41 <fmancinelli> has joined #xwiki
21:53 <polx_> has joined #xwiki
21:57 <polx> has quit
21:57 <polx_> is now known as <polx>
22:04 <vmassol> has quit
22:08 <fmancinelli> has quit
22:59 <UCC> has joined #xwiki
