Show last authors
1 00:16 <cjd> has quit
2 00:18 <ssavi> has joined #xwiki
3 00:26 <vmassol> has quit
4 00:37 <polx> has quit
5 00:39 <evalica> has quit
6 00:47 <jvdrean> has quit
7 02:00 <mflorea> has quit
8 02:09 <mflorea> has joined #xwiki
9 02:37 <mflorea> has quit
10 02:39 <tekzilla> has quit
11 02:40 <tekzilla> has joined #xwiki
12 03:11 <jvdrean> has joined #xwiki
13 05:04 <ssavi> has quit
14 05:07 <ssavi> has joined #xwiki
15 07:21 <irssi_> has joined #xwiki
16 07:21 <irssi_> is now known as <cjd>
17 07:28 <polx> has joined #xwiki
18 07:44 <vmassol> has joined #xwiki
19 08:07 <evalica> has joined #xwiki
20 08:29 <vmassol> good morning
21 08:30 <vmassol> we need to release 4.1.3 today
22 08:30 <vmassol> we don't have any blocker open AFAIK
23 08:31 <vmassol> AndreasJonsson: good morning
24 08:31 <vmassol> I've noticed 2 issues in the chart macro
25 08:31 <vmassol> 1) ChartMacroParameters (public) uses internal DataSource
26 08:31 <vmassol> 2) The DataSource interface (internal) not nice, since one need to call method before another one!!
27 08:32 <vmassol> are you planning to fix this?
28 08:32 <CIA-114> Vincent Massol master * rc5124f6 https://github.com/xwiki/xwiki-platform/commit/c5124f673db30629191cdb223bca0776f1e13468 / (47 files in 12 dirs): [Misc] Move Chart macro sources under one package (was under 2 different packages) - http://git.io/sg2kkw
29 08:32 <CIA-114> Vincent Massol master * rb874daf https://github.com/xwiki/xwiki-platform/commit/b874dafc7d187e9d825409806a5afb78b08bbe96 / xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/TempResourceAction.java : [Misc] Added javadoc - http://git.io/vYfgIQ
30 08:35 <evalica> has quit
31 08:53 <tmortagne> has joined #xwiki
32 09:11 <CIA-114> tmortagne master * ra49cc4a https://github.com/xwiki/xwiki-platform/commit/a49cc4adb0ef2b6a78c6c77ee716ba98c567bcbd / xwiki-platform-core/pom.xml : XWIKI-8011: When saving a wiki macro document the author of the macro should be used to check right instead of the current user - http://git.io/NPd7lg
33 09:14 <vmassol> AndreasJonsson: ping
34 09:18 <sburjan> has joined #xwiki
35 09:36 <CIA-114> tmortagne master * rcf55726 https://github.com/xwiki/xwiki-platform/commit/cf557260538378b70165e9f9a3968320fc37cc82 / xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/main/java/org/xwiki/rendering/internal/macro/chart/source/LocaleConfiguration.java : Fix header - http://git.io/Jp97hQ
36 11:16 <tmortagne> has quit
37 11:16 <tmortagne1> has joined #xwiki
38 12:11 <CIA-114> tmortagne feature-extensiondistribution * r74cd304 https://github.com/xwiki/xwiki-commons/commit/74cd3042f1611b1cc59287045bb65e432ce76383 / (3 files in 3 dirs): XCOMMONS-202: Find a way to have the war in the core extension list (+9 more commits...) - http://git.io/An6fHg
39 12:12 <Enygma`> has joined #xwiki
40 12:18 <evalica> has joined #xwiki
41 12:37 <ssavi> has quit
42 13:27 <vmassol> hello
43 13:27 <vmassol> is there anyone who would have the time to perform the 4.1.3 release today?
44 13:30 <polx> has quit
45 13:31 <vmassol> it's important we release it asap
46 14:39 <CIA-114> Vincent Massol master * r8e3c406 https://github.com/xwiki/xwiki-commons/commit/8e3c4066aaa17b0906b8b7f737717314022af213 / (5 files): XCOMMONS-214: Make it easier to register mock components from within Test suites - http://git.io/Z_pSQA
47 14:40 <vmassol> devs, in case you haven't noticed it yet, this can be useful to you when writing integration tests: http://jira.xwiki.org/browse/XCOMMONS-214
48 14:50 <CIA-114> Vincent Massol master * r8188677 https://github.com/xwiki/xwiki-commons/commit/81886775689ee6ae60feefb2f9b35734f95093dd / xwiki-commons-core/xwiki-commons-test/src/main/java/org/xwiki/test/AbstractMockingComponentTestCase.java : XCOMMONS-214: Make it easier to register mock components from within Test suites - http://git.io/6d5DHQ
49 15:08 <vmassol> cjd: ping
50 15:08 <vmassol> cjd: I continue to find it very disturbing that getting the temporary directory requires the permanent directory… that's really wrong from my pov
51 15:09 <vmassol> we should be able to not have a perm directory at all in commons
52 15:09 <vmassol> as a consquence almost all our tests using the temp dir generate this:
53 15:10 <vmassol> 15:06:42.159 [main] WARN o.x.e.internal.StandardEnvironment - No permanent directory configured. Using temporary directory [/var/folders/v9/_395qc791vz23qdwyptvs06m0000gn/T/].
54 15:10 <vmassol> could you fix it?
55 15:10 <vmassol> I'm loathe to modify all our unit tests to set the perm dir when the test and the code under tests don't need it!
56 15:30 <+AndreasJonsson> vmassol: I plan to work a bit more on the ChartMacro, and I will take your comments into account.
57 15:30 <vmassol> AndreasJonsson: i'm about to commit stuff in a few minutes
58 15:30 <vmassol> I've fixed a few things
59 15:30 <+AndreasJonsson> No, problems.
60 15:30 <vmassol> re the image unique id I was wrong
61 15:31 <vmassol> there's no hashcode method in ChartMacroParameters
62 15:31 <vmassol> thus hashcode always return a different value
63 15:31 <vmassol> even for chart macros in the same page
64 15:31 <vmassol> and we cannot really cache the images for a longer duration
65 15:31 <vmassol> (since their behavior can be scripted)
66 15:47 <sburjan> has quit
67 15:51 <tmortagne1> has quit
68 15:52 <tmortagne> has joined #xwiki
69 16:11 <polx> has joined #xwiki
70 16:17 <CIA-114> Vincent Massol master * re19a83d https://github.com/xwiki/xwiki-platform/commit/e19a83dd75cf29980e878ee56b93b5f101e21256 / (28 files in 13 dirs): XWIKI-8012: Replace usage of Charting action in the Chart Macro by Temporary action - http://git.io/GUuIYQ
71 16:17 <CIA-114> Vincent Massol master * rbe1052f https://github.com/xwiki/xwiki-enterprise/commit/be1052fafa859cebe2b951f9027832aa5393180b / pom.xml : XWIKI-8012: Replace usage of Charting action in the Chart Macro by Temporary action - http://git.io/fOpURw
72 16:19 <vmassol> AndreasJonsson: done, would be good if you check what I've modified
73 16:23 <CIA-114> tmortagne master * r64c2869 https://github.com/xwiki/xwiki-enterprise/commit/64c28692275021aeb62077c9f6d20a5e14941b3c / xwiki-enterprise-database/pom.xml : Generate WikiMacro classes - http://git.io/EaFCZg
74 16:24 <CIA-114> Vincent Massol master * r41221d2 https://github.com/xwiki/xwiki-platform/commit/41221d22b0a5600e80d2ebe7fcd26c26b5dae232 / (2 files in 2 dirs): XWIKI-8012: Replace usage of Charting action in the Chart Macro by Temporary action - http://git.io/oCbzhg
75 16:35 <D-Spair> has joined #xwiki
76 16:36 <D-Spair> Hello all... I was looking through Google and XWiki.org to see if there is a known issue with the adding of tags on Google Chrome...
77 16:36 <D-Spair> I keep having the page freeze up on me and have to kill the browser tab.
78 16:36 <CIA-114> tmortagne feature-extensiondistribution * r4849f82 https://github.com/xwiki/xwiki-platform/commit/4849f824d4be19a31483e1fc57da420cef47e2cc / (7 files in 3 dirs): XWIKI-7896: Display a global install/upgrade wizard when starting an new version of an XWiki instance (+18 more commits...) - http://git.io/vfNK-A
79 16:36 <D-Spair> Anyone aware of this issue?
80 16:37 <vmassol> I've noticed this too a few months ago
81 16:37 <CIA-114> tmortagne master * re592202 https://github.com/xwiki/xwiki-platform/commit/e592202f6909f8db794f24ce2c4ae493daea2f73 / xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java : XWIKI-8013: ApplicationReadyEvent event is sent before XWikiStubContextProvider is initialized - http://git.io/bENq1w
82 16:37 <vmassol> but I haven't raised any issue about at the time and I don't recall any existing issue
83 16:38 <vmassol> feel free to create a jira issue with the max information to reproduce
84 16:38 <vmassol> (D-Spair)
85 16:38 <D-Spair> vmassol: OK, will do.
86 16:39 <+sburjan`> works for me on xwiki.org and Chrome 20
87 16:40 <vmassol> sburjan`: it was working for me too
88 16:40 <vmassol> but not all the time
89 16:40 <vmassol> it was under some conditions
90 16:41 <D-Spair> vmassol: What "component" should it be listed under? I'm pretty certain it's either a JavaScript error or an AJAX error.
91 16:41 <vmassol> D-Spair: web & templates
92 16:42 <vmassol> s/web & templates/web/
93 16:42 <D-Spair> vmassol: JIRA says that is not a valid "component".
94 16:42 <D-Spair> vmassol: "Web" turns up nothing in the form.
95 16:42 <vmassol> XWIKI project
96 16:43 <D-Spair> Gotcha, thanks!
97 16:44 <CIA-114> tmortagne master * r42f8574 https://github.com/xwiki/xwiki-commons/commit/42f8574bbefa853a819bc90ea331dfb9d1879c6c / (9 files in 7 dirs): Merge branch 'feature-extensiondistribution' (+6 more commits...) - http://git.io/6XiPSw
98 16:48 <D-Spair> http://jira.xwiki.org/browse/XWIKI-8015
99 16:49 <vmassol> thanks
100 16:52 <D-Spair> Thank you! I'd have to use something else for documentation if XWiki didn't exist, and I REALLY like xwiki.
101 16:54 <vmassol> D-Spair: cool :) Do we have a testimonial from you on http://www.xwiki.org/xwiki/bin/view/References/Testimonials ? ;)
102 16:54 <vmassol> actually I can reuse the one you've just sent ;)
103 16:55 <vmassol> done :)
104 16:56 <CIA-114> Vincent Massol master * ra13a207 https://github.com/xwiki/xwiki-commons/commit/a13a20765ff24b779ec2673df8eb95fdc47655dd / xwiki-commons-core/xwiki-commons-test/src/main/java/org/xwiki/test/MockingComponentManager.java : XCOMMONS-214: Make it easier to register mock components from within Test suites - http://git.io/POv_Cg
105 16:56 <CIA-114> Vincent Massol master * r0b3a4cb https://github.com/xwiki/xwiki-platform/commit/0b3a4cb0e30e11f619fd8f741319d8610610a5fa / xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/test/java/org/xwiki/rendering/macro/dashboard/IntegrationTest.java : XCOMMONS-214: Make it easier to register mock components from within Test suites - http://git.io/S3bTYg
106 16:57 <D-Spair> vmassol: I can do better than that little snippet... Gimme a few minutes.
107 16:58 <vmassol> hehe
108 17:00 <D-Spair> OK, there... That's a little better.
109 17:01 <vmassol> indeed nicer
110 17:01 <vmassol> fixing quote
111 17:24 <CIA-114> Vincent Massol master * r5fd745a https://github.com/xwiki/xwiki-platform/commit/5fd745ab1a0f8948a34cda891aaa06eba454dea4 / (11 files in 10 dirs): XCOMMONS-214: Make it easier to register mock components from within Test suites - http://git.io/0hhojQ
112 17:27 <Enygma`> has quit
113 17:28 <Enygma`> has joined #xwiki
114 17:34 <Enygma`> has quit
115 17:38 <Enygma`> has joined #xwiki
116 17:41 <@cjd> hi vmassol, I didn't realize the getting the permanent dir to get the temp dir bothered you, it is actually just for a tiny "safty feature" which Denis suggested to stop the admin if he configures the permanent directory to be inside of the delete-on-startup part of the temp dir.
117 17:41 <@cjd> It's quite trivial to fix just by removing that check and the check doesn't offer much since there are many many ways to break a system.
118 17:42 <vmassol> cjd: I don't know about you or others but I have a strong feeling there's a SOC issue here
119 17:42 <@cjd> SOC?
120 17:42 <vmassol> (it's more than feelings actually ;))
121 17:42 <vmassol> Separation Of Concern
122 17:43 <vmassol> http://en.wikipedia.org/wiki/Separation_of_concerns
123 17:43 <vmassol> it's a pompous way of saying that tmp dir and perm dir should be separate notions as much as possible
124 17:44 <vmassol> :)
125 17:44 <@cjd> yes, I don't really see a serious issue since they're both handled in the same module anyway but the warnings in tests are not that great and the offending code offers almost nothing.
126 17:44 <vmassol> if you agree, cool :)
127 17:45 <@cjd> So no big deal to change it at my end, it's actually just deleting 14 lines.
128 17:45 <vmassol> guys any idea with compilation fails here: http://ci.xwiki.org/job/xwiki-platform/2264/consoleFull
129 17:45 <vmassol> it builds fine locally
130 17:46 <vmassol> apparently it's the Map in allowing(mockSsfx).use(with("uicomponents/container/columns.css"), with(any(Map.class)));
131 17:47 <vmassol> why would unchecked conversion make the compiler fail now?
132 17:48 <vmassol> I guess I can use the annotation to remove the check but I don't understand why our compiler fails now
133 17:48 <Denis1> vmassol, cjd: what is offending ?
134 17:49 <@cjd> The check to see if the admin has put the permanent dir inside of the temp dir means loading the permanent dir when the temp dir is loaded.
135 17:49 <@cjd> This causes a warning in tests where the permanent dir is not set
136 17:49 <Denis1> is now known as <Denis>
137 17:50 <@cjd> I'm for axing the check since it offers basicly nothing in terms of safety, there are so many interesting ways for an admin to break their system, we're not really helping.
138 17:51 <vmassol> the main issue is that getting the temporary dir shouldn't ask for the perm dir to be set
139 17:51 <vmassol> that's plain wrong to me
140 17:52 <CIA-114> Vincent Massol master * rc9dec41 https://github.com/xwiki/xwiki-platform/commit/c9dec41d018c20816d973b65f2473a6bb0dbb4a8 / xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/test/java/org/xwiki/rendering/macro/dashboard/IntegrationTest.java : [Misc] Trying to stop compiler from complaining - http://git.io/1lSglQ
141 17:53 <+Denis> I agree, but what afraid me initially is that older configuration does not make a clear distinction between permanent and non-permanent stuff
142 17:54 <+Denis> since now permanent may contains really critical stuff like attachemment storage, what we should really prevent, is to have an issue that delete the permanent data while we were trying to clean the temporary one
143 17:57 <@cjd> Denis: if you set the temp dir and permanent dir to the same location, you won't have the problem
144 17:57 <@cjd> only if you set the permanent dir to /your/temp/dir/xwiki-temp/
145 17:57 <@cjd> xwiki-temp is a magic word for the subdirectory which is deleted on start
146 17:58 <CIA-114> Vincent Massol master * rec6492a https://github.com/xwiki/xwiki-platform/commit/ec6492a3179050de837f8b4f0066a2ce87218309 / (81 files in 9 dirs): XWIKI-8016: Remove the Chart plugin - http://git.io/bHpyxg
147 17:58 <+Denis> what happen for old configuration use work in xwiki.cfg, and nothing in xwiki.properties for example ?
148 17:59 <@cjd> it will make it's own decision which will be sane
149 17:59 <evalica1> has joined #xwiki
150 18:00 <Enygma`> has quit
151 18:01 <Enygma`> has joined #xwiki
152 18:01 <evalica> has quit
153 18:07 <+Denis> if we 100% sure all decision will be sane, I have nothing to add
154 18:09 <vmassol> Denis: the only thing I'm 100% sure off is that forcing to have a perm dir when getting the tmp dir is wrong… :)
155 18:09 <vmassol> bbiab
156 18:14 <+Denis> well, I have never request that
157 18:25 <CIA-114> tmortagne feature-extensiondistribution * r2cddf7b https://github.com/xwiki/xwiki-platform/commit/2cddf7b426463e8fbf28d988b28a7c4ec0b2b1a6 / (3 files in 2 dirs): XWIKI-7896: Display a global install/upgrade wizard when starting an new version of an XWiki instance - http://git.io/_nfmzA
158 18:25 <CIA-114> tmortagne master * r8278ec1 https://github.com/xwiki/xwiki-platform/commit/8278ec1c268d9afa28e84072ce9d5ca1f1ef6932 / xwiki-platform-core/pom.xml : XWIKI-8017: Upgrade to JGroups 3.1.0 - http://git.io/hws2nA
159 18:34 <+tmortagne> vmassol: another unchecked build failure on platform I cannot reproduce locally and it's not new code so something changed on agent-2 if not all jenkins
160 18:35 <+tmortagne> there is absolutely no reason for it to get an error instead of a warning
161 18:35 <+tmortagne> it's like java compiler had a weird setup on errors/warnings
162 18:36 <+tmortagne> yours was on agent-1 so I guess it's all jenkins for some reason
163 18:37 <vmassol> tmortagne: yeah it beats me too
164 18:38 <+tmortagne> what weird is that it build a lot of stuff before failing and I'm sure there is the exact same situation in the stuff it built before failing
165 18:39 <+tmortagne> it's not like it was something rare
166 18:41 <+tmortagne> I can see the same things but printed as warning in previous projects
167 18:41 <+tmortagne> in http://ci.xwiki.org/job/xwiki-platform/2264/consoleFull
168 18:41 <+tmortagne> (not the same classes but same use case)
169 18:45 <CIA-114> tmortagne master * r95b2f3f https://github.com/xwiki/xwiki-platform/commit/95b2f3f4844aad13fb1057e874d1a28f4add2250 / xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-script/src/main/java/org/xwiki/extension/script/internal/safe/SafeCoreExtensionRepository.java : XCOMMONS-202: Find a way to have the war in the core extension list - http://git.io/ud1ixw
170 18:48 <tmortagne> has quit
171 19:07 <jvdrean> has quit
172 19:18 <ries> has left #xwiki
173 19:55 <vmassol> guys do you see the image nicely or is it all pinky? http://www.xwiki.org/xwiki/bin/view/References/BestVentes#Attachments
174 19:55 <evalica1> it's pinky
175 19:55 <vmassol> strange because when I view the attachments it's ok
176 19:56 <evalica1> same
177 19:56 <vmassol> so it's the resize algo
178 19:56 <vmassol> which isn't performant on jpg maybe
179 19:57 <vmassol> trying png
180 19:57 <evalica1> I guess since removing ?width fixes it
181 19:58 <vmassol> but we don't want that :)
182 19:58 <vmassol> it's good for me now
183 19:59 <evalica1> yes - it's ok
184 20:11 <vmassol> has quit
185 20:25 <polx> Hello XWiki experts, could anyone suggest me a component that could be used to display "alerts" ?
186 20:25 <evalica1> what about the {{warning}} macro
187 20:25 <evalica1> ?
188 20:25 <polx> I'm thinking of alerts posted to a user's session in the background and displayed to the user anytime he is ready.
189 20:25 <evalica1> or notifications mechanism
190 20:26 <polx> As far as I could read the notifications mechanism is the WatchList... or have I badly read?
191 20:26 <polx> One use case could be the request to upgrade the profile in some way.
192 20:26 <polx> Another could be a request to join a network.
193 20:26 <evalica1> http://platform.xwiki.org/xwiki/bin/view/DevGuide/XWikiNotifications
194 20:28 <polx> Interesting.
195 20:29 <polx> But this is triggered by a javascript call, itself probably by rendering, correct?
196 20:29 <evalica1> don't know :) .. it's javascript all right, I don't think the rendering is involved
197 20:30 <polx> I meant... it's js so it's triggered by an in-page JS.
198 20:31 <evalica1> never used them … I know they exist. The notifications are bundled by default. They are used in the Save page mechanism, etc. I don't think is an in-page JS, maybe they are called from xwiki.js - but don't know for sure
199 20:31 <polx> Fine. Thanks.
200 20:32 <polx> I think the back-end is missing to me... when it is filed into the session... how are they prioritized to be displayed.
201 20:32 <evalica1> not in xwiki.js .. they have their on notifications.js
202 20:32 <evalica1> *own
203 20:36 <evalica1> has quit
204 21:14 <ssavi> has joined #xwiki
205 21:55 <abusenius> has joined #xwiki
206 23:26 <abusenius> has quit

Get Connected